GitLab

R=foolip@chromium.org

Bug: 626703, 716320
Change-Id: I41c76ac598f77d8f1c3633a22cde413f9aed6418
Reviewed-on: https://chromium-review.googlesource.com/1220108Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590557}

This CL removes "void GetFunctionLocation(...)".
Only InspectorDOMDebuggerAgent::BuildObjectForEventListener() used this
method to set some values and it was not useful.
"std::unique_ptr<SourceLocation> GetFunctionLocation(...)" will be
moved into another class in following CL as commented, so this CL
addresses void one first.

Bug: 872138
Change-Id: I6cbb771a11c50d70654eac2918d5246b6838adc4
Reviewed-on: https://chromium-review.googlesource.com/1219427Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#590556}

The node is needed for PaintArtifactCompositor to correctly set
backface visibility properties of cc layers.

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Bug: 879364
Change-Id: Idc8241988f1582a160f816371e137c4ce03f4aa2
Reviewed-on: https://chromium-review.googlesource.com/1217909
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590555}

https://webrtc.googlesource.com/src.git/+log/375d35e01b11..bfd412ef716c


git log 375d35e01b11..bfd412ef716c --date=short --no-merges --format='%ad %ae %s'
2018-09-11 benwright@webrtc.org Adds integration of the FrameEncryptor/FrameDecryptor into the MediaChannel.
2018-09-11 buildbot@webrtc.org Roll chromium_revision de648460..8952ae00 (589477:590303)
2018-09-11 artit@webrtc.org Excluded tests and test utils from code coverage by generate_coverage_command.py
2018-09-11 nisse@webrtc.org Use SdpVideoFormat in VideoReceiveStream::Decoder
2018-09-11 danilchap@webrtc.org Allow nullptr retransmition rate limiter
2018-09-11 kthelgason@webrtc.org Remove unused file.
2018-09-11 kthelgason@webrtc.org Remove RTCUIApplicationStatusObserver.
2018-09-11 perkj@webrtc.org Reland "Decrease complexity of RtpPacketHistory::GetBestFittingPacket.""
2018-09-11 ssilkin@webrtc.org Fix target frame rate of spatial layer.


Created with:
  gclient setdep -r src/third_party/webrtc@bfd412ef716c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:844647,chromium:None,chromium:None,chromium:882358
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2319c5745080bd3de25d4aabd7e9bc5f0f9cf214
Reviewed-on: https://chromium-review.googlesource.com/1220237Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590554}

This is a follow up CL of
https://chromium-review.googlesource.com/c/chromium/src/+/1194406

We should setup the keyboard observer before displaying the virtual
keyboard otherwise the observer won't see the change of the virtual
keyboard.

Bug: 871756
Change-Id: I6b13072ed06d9e10d188c553082b411f2bb09326
Reviewed-on: https://chromium-review.googlesource.com/1220560Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590553}

There is a call to ShowVirtualKeyboard in
DefaultKeyboardExtensionBrowserTest::GetKeyboardWebContents, which is
quite confusing, because the virtual keyboard should be showing up from
focus/clicking and not an explicit call.

I don't really know why that code is there (maybe it's to load the
extension). However, when --enable-virtual-keyboard flag is on, we
begin loading the extension anyway.

Bug: 849995
Change-Id: Icae6c405ccde304ece80456190802012e487ebc5
Reviewed-on: https://chromium-review.googlesource.com/1215432
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590552}

The ResourceResponse class has a default constructor and a constructor
taking a KURL with some optional parameters. Upon investigation, these
parameters are used exclusively in test code with the exception of
mime_type which is used twice in document_loader.cc. In most cases, the
constructors' optional parameters were used followed by setters to set
other parameters not provided by the constructor. We thought it would be
more descriptive and simpler to remove the optional parameters in favor
of using the already-defined setters.

Change-Id: Ifb26f75019a1901f83908be92639d44b4000edd1
Reviewed-on: https://chromium-review.googlesource.com/1220478
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590551}

The threshold is controlled using field trial.
Also, add few more histograms to track any regressions.

Change-Id: I7901f70196dd23de5eec6fc9574602c71fbe0235
Bug: 882913
Reviewed-on: https://chromium-review.googlesource.com/1214748
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590550}

Store TracingSamplerProfiler in ChromeMainDelegate and make sure
profiling starts early at startup if needed. Also make the observer
async and thread safe.

BUG=859260


Change-Id: Ic84a2bfbe832a81071b05e0cff8f77c0015a1576
Reviewed-on: https://chromium-review.googlesource.com/1197324
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590549}

This patch extracts the SuggestionsSource dependency out from
SignInPromo.java so that we can reuse the logic from SignInPromo.java.

Bug: 860043
Change-Id: I62e38c37727a3a14727fedc505bb1c7031365024
Reviewed-on: https://chromium-review.googlesource.com/1168116
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590548}

There is no logic change - this just move the code around for
optimization.

Android's VM does run-time verification for all the methods in a class
if any of the methods fails in AOT compilation time. Therefore,
splitting out failing methods into a separate class containing it there
help reduce the overall time taken in the run-time verification.

See https://chromium-review.googlesource.com/c/chromium/src/+/1175444/8

for the whole picture.

See crbug.com/838702 for more information about run-time verification
issue.

Bug: 868250
Change-Id: I2f878edb7eb2b45119b146231beeb868174d3f2e
Reviewed-on: https://chromium-review.googlesource.com/1187661
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590547}

Prior to this patch, any call to SetNeedsIntersectionObservation would
cause all IntersectionObservers in all documents in the frame tree to
be marked as needing an update, even when they were not actually dirty.
This patch avoids propagating the dirty bit all the way up the frame
tree, so that each IntersectionObservation runs only when necessary.

BUG=879798
R=chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a5e7b3b966441aca9193a97026ca89c66e039b1
Reviewed-on: https://chromium-review.googlesource.com/1212449
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590546}

This reverts commit 99391f02.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [PartitionAlloc] Don't poison memory on free.
> 
> It might? be the cause of a perf regression.
> 
> Bug: 882471,680657
> Change-Id: Iec34a348426ccfdf5864a3b2cbe0c377da20ac0e
> Reviewed-on: https://chromium-review.googlesource.com/1220468
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590508}

TBR=palmer@chromium.org,eae@chromium.org,haraken@chromium.org

Change-Id: I6c687b8cb2b8aa0bc3de682c1c39f430b1f6b05c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882471, 680657
Reviewed-on: https://chromium-review.googlesource.com/1220815Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590545}

Bug: None
Test: locally compile
Change-Id: I80d12ad3edd287aa9ad7932dea60a1a5f8608b1b
Reviewed-on: https://chromium-review.googlesource.com/1217721
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590544}

The primary purporse of this CL is just to add the board name to the
URL for the MultiDevice suite learn more link in the Unified Setup
WebUI. However, it also factors all the logic around providing the link
into a new function
chromeos::multidevice_setup::GetBoardSpecificLearnMoreUrl so that
future board specific changes can be implemented in one place and apply
to all uses of the link, in particular Settings UI and Setup Flow.

Screenshots:
Setup flow: screen/42uKYYxBp6d
Settings UI: screen/q7WBgweWCcr

Bug: 870108
Change-Id: I06e0914194c64fb52fb46ed85822d0372c102d4a
Reviewed-on: https://chromium-review.googlesource.com/1217720Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590543}

Since the LEFT swipe is the only gesture with multiple consumers, it's
unnecessary to have the rapid-event redirect logic in place for other
swipe gestures.

Bug: internal b/115367714
Test: Swipe up multiple times quickly, verify the event is handled by
      the default target each time.

Change-Id: I5053fdfbb4d193aba64a99dbb1de02935ab66fa6
Reviewed-on: https://chromium-review.googlesource.com/1220303Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590542}

Bug: 113734839
Test: "tell me a joke" reads the joke out through screen reader
Change-Id: I92832ff6e7eea298b59aec660763b0d1a4854eef
Reviewed-on: https://chromium-review.googlesource.com/1217751
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590541}

https://chromium.googlesource.com/catapult.git/+log/6333b6741efe..fc2514597ca6


git log 6333b6741efe..fc2514597ca6 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 bsheedy@chromium.org Add functional test quest args
2018-09-11 benjhayden@chromium.org Add more utility functions to v2spa.
2018-09-11 eakuefner@chromium.org Reland "[TBMv2] Support Chromium commit positions in legacy_json_converter"


Created with:
  gclient setdep -r src/third_party/catapult@fc2514597ca6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:881017,chromium:843643
TBR=sullivan@chromium.org

Change-Id: I3d8a43b120d45c76ddbac06cf2627853efb54bbb
Reviewed-on: https://chromium-review.googlesource.com/1220239Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590540}

As an example: P2PSocketTcpBase::DoRead already stops looping if result <= 0,
but a delayed read result handled by OnRead doesn't.
Earlier, the socket entered an ERROR state after OnError() was
called, which would stop reads from continuing.

This CL fixes that issue and similar issues when sending and when using UDP.

Bug: 881260
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If7cd62b36705f69cfd95a71908d610cc871561b0
Reviewed-on: https://chromium-review.googlesource.com/1219390Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590539}

If enable_video_with_mixed_audio is defined, unittests should not
include null_video source_set.

Bug: 80443515
Test: manual / CQ
Change-Id: I905edbdc019841f1d2dfe18169ef3ba0af92b270
Reviewed-on: https://chromium-review.googlesource.com/1220697Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sunil Kumar <skx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590538}

The function is called only on RootInlineBox, and makes sense only when
called on an entire line.

Hence, this patch moves it to RootInlineBox to reduce confusion.

Change-Id: I9a2f283de54a3cce0658b11245f24e14b91c5908
Reviewed-on: https://chromium-review.googlesource.com/1220705
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590537}

Make sure that FidoBleDiscovery stores list of all Cable devices it
found and never attempt to connect to Cable devices.

Bug: 880295
Change-Id: I3799103da15b9314a8f8bdb57e0f1d42f7a99a28
Reviewed-on: https://chromium-review.googlesource.com/1214182
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590536}

Falls back to sync if unified consent is not given, or hasn't been offered.

Also checks on offering search suggestions, since that seems logical.

Bug: 877850

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8daab9213c3a6b71b2bd8a1dd921973b51b7db8e
Reviewed-on: https://chromium-review.googlesource.com/1189702
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590535}

This also fixes bugs caused by revisions 489ad84c and e3e9da53, which moved functionality out of the code path.

Bug: 847237
Change-Id: Ib60046f52b19d510e1f838a9900c1074b62d8c68
Reviewed-on: https://chromium-review.googlesource.com/1217910Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590534}

Fix threading issue when adding and removing streams.

Change-Id: Ib2ff6ed87bc7d96a2d0956c604f741be38992c7c
Reviewed-on: https://chromium-review.googlesource.com/1220555Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Jimmy Tobin <jtobin@google.com>
Cr-Commit-Position: refs/heads/master@{#590533}

Design doc: go/switch-context-menu

Bug: 864796
Change-Id: I13f42784eabb54f1222a3e61c819e77cf9f17010
Reviewed-on: https://chromium-review.googlesource.com/1199817Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590532}

Windows 10 native notification seems to have memory leak issues on OS
builds older than 17134. See crbug.com/882622. This seems to be a Windows
issue which has been fixed in 17134.

Bug: 882622
Change-Id: Icb251eb9ebb88b19b20b8e09692d85f7fcec6b54
Reviewed-on: https://chromium-review.googlesource.com/1220569Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590531}

This copies behavior on chrome://settings pages where tapping
anywhere in the option box can change the state of the toggle,
or having keyboard focus on an toggle element and clicking 'enter'
changes the state.

Bug: 810333,810307
Change-Id: Ib6edc31fff72f2e32c5b9ce73264739a3d3194c1
Reviewed-on: https://chromium-review.googlesource.com/1214366Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590530}

Added UpdateShelfVisibility in ~TabletModeWindowDragDelegate to keep
shelf in correct state after drag a window from top.
Most of the cases shelf can achieve a correct state after drag except for
dragging a browser window from top. The problem is that we delete drag
details in EndingForDraggingWindow for app windows but we can't do the
same for browser window.
Then ShelfLayoutManager::IsDraggingWindowFromTopOrCaptionArea
will drop into wrong condition in this case, which will cause the shelf
into a wrong state at the end of drag.

Tried to UpdateShelfVisibility again in ~TabletModeWindowDragDelegate
when drag details has already been deleted for all the window drags.

Bug: 882962
Change-Id: I6915bcfd7ee1890d40ca5d422c913552a487daf1
Reviewed-on: https://chromium-review.googlesource.com/1219934Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590529}

BUG=875867

Change-Id: Ic70b274c96d000c2aa05fa2399475806bb3d640f
Reviewed-on: https://chromium-review.googlesource.com/1181524
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590528}

Also shorten the time to wait for stable offline to 20s.

Bug: 883020
Change-Id: If932810e0d4864fe00bd2fec980175086b43afbd
Reviewed-on: https://chromium-review.googlesource.com/1220049Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590527}

It is used in 4,300+ compilation units.
http://crrev.com/590155 increased its pre-processed size by 3.72MB, and
this CL fixes it.

Bug: 242216, 881537, 882997
Change-Id: If723b9d77dbd06fdde184498aa6ed7aa3e5e88e2
Reviewed-on: https://chromium-review.googlesource.com/1218388
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590526}

If the page exists in a maximized browser window before going to
tablet mode, the layout that results from going to tablet mode
does not change the size of the page viewport. Hence, the visual
properties of the renderer and the browser are not automatically
synchrnoized. But going to tablet mode enables the top-chrome
sliding feature (i.e. BrowserView::GetTopControlsHeight() now
returns a non-zero value).

This CL makees sure that we synchronize the visual properties
manually, so that the renderer can get the new top-controls
height whenever it changes.

BUG=867063
TEST=manual, added a browser test.

Change-Id: Ifbbc224e1de452b2582635ea8f9b4c3992a0dceb
Reviewed-on: https://chromium-review.googlesource.com/1217355Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590525}

Change-Id: If9f842fd326eedd659999531bc15293ee0137863
Reviewed-on: https://chromium-review.googlesource.com/1220043Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590524}

Modify ViewAccessibilityUtils::GetFocusedChildWidgetForAccessibility to
return any widget that is visible and focused.

Previously, this was limited to tab-modal dialogs. Other focused
widgets, like the Find bar, should be treated in the same way.

Bug: 869703
Change-Id: I720bdd1e9c8d665d839296aa9bfd4c9490805dbd
Reviewed-on: https://chromium-review.googlesource.com/1208810Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590523}

The ControllerDelegate was renamed to InputDelegate to reflect
that it handles more than just the controller raw input.

Bug: 875291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7415806cf7ba52a7e49899843dcf93079333c8d3
Reviewed-on: https://chromium-review.googlesource.com/1213874
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590522}

Based on https://codereview.chromium.org/2897463003/.

Test: Run update.py --force-local-build, remove https://cs.chromium.org/chromium/src/build/config/fuchsia/BUILD.gn?l=41 and referenced files, and rebuild some Fuchsia binaries
Test: Run package.py and verify the .a's are included.
Bug: 724204
Change-Id: If1492138829846a0f970d034f28a84d517554401
Reviewed-on: https://chromium-review.googlesource.com/1211879Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590521}

A code path enabled by the butter experiment was calling some
methods on the sync_service_. However, it can be null in
certain situations.

I updated the methods to handler the case where sync_service is null.

Bug: 883048
Change-Id: I64b4d52a5fc897381a99ad1502c0e6dbb937e447
Reviewed-on: https://chromium-review.googlesource.com/1220708
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590520}

Bug: 880737
Change-Id: I2c455762066d424a3cde4e91dc70eacfc1b4fb7c
Reviewed-on: https://chromium-review.googlesource.com/1217033Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590519}

This CL is adding events to help investigate crbug 882982.
We are observing strange interaction with the SamplerThread and the
Browser main thread.

We suspect the thread to be suspended for a longer period than expected.

This code is temporary to investigate sampler profiling issues.
Should be reverted in a few weeks.

R=wittman@chromium.org, ssid@chromium.org

Bug: 882982
Change-Id: I4aa1d733ea06100c64e884e014222b04d97b3492
Reviewed-on: https://chromium-review.googlesource.com/1220174Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590518}