GitLab

[Password Manager] Changes implementation of left elided origins on chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux Compilation bot (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). The bot complained on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction: user enters a query w/o any matching entries in search box (i.e. there will be no entries) and then removes the query. The algorithm falls into infinite loop, because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and updateListVisibility_ to update the list before we read entry.urlDiv.offsetWidth.

BUG=595662, 595276

Review URL: https://codereview.chromium.org/1823423002

Cr-Commit-Position: refs/heads/master@{#383927}

BUG=b:26933097

Review URL: https://codereview.chromium.org/1817093003

Cr-Commit-Position: refs/heads/master@{#383926}

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306

Review URL: https://codereview.chromium.org/1817873002

Cr-Commit-Position: refs/heads/master@{#383925}

BUG=b:27344858
TEST=Tested on minnie
R=tapted@chromium.org,jwd@chromium.org

Review URL: https://codereview.chromium.org/1818933002

Cr-Commit-Position: refs/heads/master@{#383924}

BUG=589353

Review URL: https://codereview.chromium.org/1846543002

Cr-Commit-Position: refs/heads/master@{#383923}

We were hiding when the label size reached 0.  That winds up hiding the
background when the icon has both the internal spacing and the trailing padding
adjacent to it before the background ends.  Instead, wait to hide the background
until the internal spacing portion of that is collapsed, so it's just
<leading padding><icon><trailing padding>.

This isn't very noticeable when the internal spacing is 2 px.  It will be more
noticeable when I later increase the spacing (which is how I saw this).

This allows moving label layout in IconLabelBubbleView() downward since we no
longer care about sizing the label to 0 early.  I think the code reads more
clearly that way.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1830343003

Cr-Commit-Position: refs/heads/master@{#383922}

The mac valgrind bot doesn't exist anymore, so no need for these
suppressions and exclusions.

BUG=593920

Review URL: https://codereview.chromium.org/1839303002

Cr-Commit-Position: refs/heads/master@{#383921}

These were overlooked in the previous CL which renamed
paintInvalidationContainer to ancestor in some places that the parameter
is not necessary a paintInvalidtionContainer.

Review URL: https://codereview.chromium.org/1841643004

Cr-Commit-Position: refs/heads/master@{#383920}

BUG=598888
TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably".

Review URL: https://codereview.chromium.org/1842993002

Cr-Commit-Position: refs/heads/master@{#383919}

When the first animation of a group of an animation finishes earlier
than the rest, it can cause the scrubber synchronisation to fail if it
has passed the end time.

BUG=598304

Review URL: https://codereview.chromium.org/1843603004

Cr-Commit-Position: refs/heads/master@{#383918}

All:

* Add/update/clarify comments.

ContentSettingImageView:

* This doesn't directly subclass views::View.  Move those overrides into the IconLabelBubbleView list and reorder the code to match.
* Nuke IsBubbleShowing() and just inline its trivial code into its lone caller.

IconLabelBubbleView:

* Rename GetBubbleOutPadding() to GetOuterPadding(), the class already has "bubble" in the name.
* Factor code into some helpers in preparation for adding more uses/complexity in the future.
* Functional change: Make the leading padding match the trailing padding for MD in all cases, not just when there's no image. This looks better to me, is simpler, and will be necessary for an upcoming change.
* Add missing const to unittest code.

layout_constants.*:

* Rename "padding" to "spacing" in a place where we're referring to the distance between objects instead of at the edge of an object.

BUG=586423
TEST=none

Review URL: https://codereview.chromium.org/1834933002

Cr-Commit-Position: refs/heads/master@{#383917}

This cl implements showing a warning bubble when an IME extension is calling chrome.input.ime.activate() API, according to the API proposal: https://goo.gl/IeN7xE.

The input.ime.activate() API will not respond util user finishes interacting with the bubble. Only when user presses the 'OK' button, the extension call be successfully activated and get an input.ime.onActivate() event.

If user checks the 'Never show this again.' check box when clicking 'OK' button, the extension could be directly activated next time if the API is called from a user action like clicking buttons.

This cl adds the following new classes:
ImeWarningBubble: The interface or the IME warning bubble.
ImeWarningBubbleView: The implementation for the IME warning bubble. Provides warning information to the user upon the activation of an IME extension.

BUG=517773
TEST=BrowserTest.ImeActivatedBubbleBrowserTest

Review URL: https://codereview.chromium.org/1724733002

Cr-Commit-Position: refs/heads/master@{#383916}

This CL makes FrameLoaderClientImpl cache user agent string instead of
BlinkPlatformImpl to avoid threading issue.

BUG=598479

Review URL: https://codereview.chromium.org/1839023002

Cr-Commit-Position: refs/heads/master@{#383915}

TBR=jyasskin@chromium.org
BUG=176621, 176616, 309477

Review URL: https://codereview.chromium.org/1847473002

Cr-Commit-Position: refs/heads/master@{#383914}

Reland of move libpeerconnection target from third_party/libjingle (patchset #1 id:1 of https://codereview.chromium.org/1834163002/ )

Reason for revert:
The config.h problem was addressed in https://codereview.webrtc.org/1820023004/ which was rolled in with https://codereview.chromium.org/1840133002/

Original issue's description:
> Revert of Remove libpeerconnection target from third_party/libjingle (patchset #4 id:60001 of https://codereview.chromium.org/1808233002/ )
>
> Reason for revert:
> Broke clang/win gn build (https://bugs.chromium.org/p/chromium/issues/detail?id=598316), as mentioned in the review thread in comment 24.
>
> Original issue's description:
> > Remove libpeerconnection target from third_party/libjingle
> >
> > All locations that depended on the target also depended on libjingle_webrtc,
> > which is where the sources of libpeerconnection were moved.
> >
> > BUG=webrtc:4256,481633
> >
> > Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f
> > Cr-Commit-Position: refs/heads/master@{#383468}
>
> TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,kjellander@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4256,481633
>
> Committed: https://crrev.com/8d484368f9d4013effeee0e078fbe7039254cd45
> Cr-Commit-Position: refs/heads/master@{#383490}

TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4256,481633

Review URL: https://codereview.chromium.org/1839063005

Cr-Commit-Position: refs/heads/master@{#383913}

Now we keep document in LocalDOMWindow, and do not have to keep it alive in hidden window object.

BUG=None

Review URL: https://codereview.chromium.org/1836193002

Cr-Commit-Position: refs/heads/master@{#383912}

--testActivateAndListChange: for inputMethodPrivate.onImeMenuListChanged
--testSetAndUpdateMenuItems: for inputMethodPrivate.onImeMenuItemsChanged
--testNotifyMenuItems: for inputMethodPrivate.notifyImeMenuItemActivated

BUG=570761
TEST=ExtensionInputMethodApiTest.ImeMenuAPITest

Review URL: https://codereview.chromium.org/1839923002

Cr-Commit-Position: refs/heads/master@{#383911}

Review URL: https://codereview.chromium.org/1841273002

Cr-Commit-Position: refs/heads/master@{#383910}

I want to use this bot as the default-on win/clang trybot, so that if I need
to modify it (change it to release, or make it use LLD, or make it build fewer
targets then "all"), I don't have to modify our existing FYI waterfall bots.

BUG=588518

Review URL: https://codereview.chromium.org/1838083003

Cr-Commit-Position: refs/heads/master@{#383909}

And see codereview/1810993003

BUG=565069, 568673

Review URL: https://codereview.chromium.org/1814503003

Cr-Commit-Position: refs/heads/master@{#383908}

This test has been disabled for a long time and from local tests seems
OK now.

TBR=jyasskin@chromium.org
BUG=309149

Review URL: https://codereview.chromium.org/1843043002

Cr-Commit-Position: refs/heads/master@{#383907}

Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
This might be breaking official build.

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231

Review URL: https://codereview.chromium.org/1842563008

Cr-Commit-Position: refs/heads/master@{#383906}

The test is failing there after a recent QUIC update.

TBR=jyasskin@chromium.org
BUG=598953

Review URL: https://codereview.chromium.org/1844733004

Cr-Commit-Position: refs/heads/master@{#383905}

Cr-Commit-Position: refs/heads/master@{#383904}

TBR=jyasskin@chromium.org
BUG=598950

Review URL: https://codereview.chromium.org/1840363002

Cr-Commit-Position: refs/heads/master@{#383903}

Replace two Plugins logging with VLOG(1). This has a slight change in that
it uses operator<< on Node.h as opposed to logging the address of the
HTML Plugin Element; I do think this is slightly more useful than the
previous log info.

BUG=596760

Review URL: https://codereview.chromium.org/1845533002

Cr-Commit-Position: refs/heads/master@{#383902}

https://chromium.googlesource.com/skia.git/+log/9b2ef62d4708..890579051d40

$ git log 9b2ef62d4..890579051 --date=short --no-merges --format='%ad %ae %s'
2016-03-29 djsollen Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/1842793002/ )
2016-03-29 herb Add repeatSpan and change interface name.
2016-03-29 robertphillips Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1847443002

Cr-Commit-Position: refs/heads/master@{#383901}

Manually recover the images from CL issue 561363002 and submit
those images to LayoutTests/fast/images/resources

TBR=msarett@chromium.org
BUG=598949
NOTRY=true

Review URL: https://codereview.chromium.org/1844833002

Cr-Commit-Position: refs/heads/master@{#383900}

The reply message of a Synchronous IPC was not tracked by existing
tracing points, so the IPC handlers of synchronous IPCs are missed in
the critical paths of other tasks.
This CL adds a flow from the reply to the waiting IPC caller. So that
the IPC handler is trackes as a preceding event of a followings on
chrome://tracing.

BUG=580902

Review URL: https://codereview.chromium.org/1840053002

Cr-Commit-Position: refs/heads/master@{#383899}

"BookmarkThumbnailWidget" is no longer an appropriate name since the widget no
longer shows thumbnails. This CL updates the name to simply "BookmarkWidget".

BUG=593587

Review URL: https://codereview.chromium.org/1840193002

Cr-Commit-Position: refs/heads/master@{#383898}

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524

Review URL: https://codereview.chromium.org/1839003002

Cr-Commit-Position: refs/heads/master@{#383897}

This is a reland of https://codereview.chromium.org/1836883002/

BUG=428729
TBR=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/1839083003

Cr-Commit-Position: refs/heads/master@{#383896}

custom theme.

BUG=596136

Review URL: https://codereview.chromium.org/1813393002

Cr-Commit-Position: refs/heads/master@{#383895}

This patch does two things:

1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.

2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.

All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.

Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.

BUG=596231

Review URL: https://codereview.chromium.org/1814423002

Cr-Commit-Position: refs/heads/master@{#383894}

ScopedLogger was removed in http://crrev.com/381906.

The original review is on http://crrev.com/1379443002.

Review URL: https://codereview.chromium.org/1840693002

Cr-Commit-Position: refs/heads/master@{#383893}

R=pfeldman@chromium.org
BUG=598885

Review URL: https://codereview.chromium.org/1837283002

Cr-Commit-Position: refs/heads/master@{#383892}

They eventually get valid pointers assigned, but this makes the code clearer
and prevents spurious warnings from editors (like Eclipse) that detect
constructors with uninitialized data.

BUG=none
TEST=existing ash tests

Review URL: https://codereview.chromium.org/1838343003

Cr-Commit-Position: refs/heads/master@{#383891}

BUG=122457
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1834223007

Cr-Commit-Position: refs/heads/master@{#383890}

This behavior was regressed back in http://crrev.com/1649533003.

BUG=598919
R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/1846433002

Cr-Commit-Position: refs/heads/master@{#383889}

These variables should be declared when target_cpu is "arm", so that
cross-compiles may use these arguments to determine how to build host
tools.

Related change in //v8:
  https://codereview.chromium.org/1839763003/

BUG=592660

Review URL: https://codereview.chromium.org/1842833003

Cr-Commit-Position: refs/heads/master@{#383888}