GitLab

As this object isn't passed around very much, just make it movable. The
majority of the time, RVO applies and there is no move anyway.

Also make some string constants actually constant.

Bug: 741626
Change-Id: If505ceda66b2cd1c5892ecc35448d90fccdaa829
Reviewed-on: https://chromium-review.googlesource.com/571625
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487380}

    
Move common function to a utility class which provides support for reading
files and converting Bitmaps to mojom.Bitmaps for testing.

Add instrumentation test for QR code detection on Android Platform, the
tested qr_code.png is QR code the value of it is https://chromium.org.

These new test end up being rolled up in chrome_public_test_apk.

BUG=722931

Change-Id: I1961efdb8263a26f2075fd567904bc17713270b3
Reviewed-on: https://chromium-review.googlesource.com/566541Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#487379}

This CL migrates ArcVoiceInteraction{Framework,ArcHome}Service classes.

BUG=672829
TEST=Ran try. Ran on DUT.

Change-Id: Id46d1b3ab424b340e1c28509f0d349f531de6db8
Reviewed-on: https://chromium-review.googlesource.com/572677
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487378}

This reverts commit f3a47f5b.

Reason for revert: landed a real fix https://chromium.googlesource.com/chromium/src/+/49b2e1c02da7073c6c86e7e591928fc58fd5de34

Original change's description:
> Don't hold weak ref to ComputedStyle in BoxPainter.
> 
> Currently we hold a const ref& to a ComputedStyle object in BoxPainter::
> PaintBoxDecorationBackgroundWithRect. However, this ref could be
> invalidated during theme painting, which would cause a dangling ref
> issue when we use the ref later on.
> 
> This patch removes the weak ref and instead uses StyleRef() to grab a
> fresh style ref each time.
> 
> Bug: 712933
> Change-Id: Id576005fe63ac3a014002ba5a68acbb6c88382b0
> Reviewed-on: https://chromium-review.googlesource.com/566198
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486266}

TBR=chrishtr@chromium.org,shend@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 712933
Change-Id: Idbd2a663be78d52a1481a3bb04cb708bb1df3b3b
Reviewed-on: https://chromium-review.googlesource.com/574948Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487377}

Bug: 
Change-Id: Ie8c6b1515cf8172e7d263285efd17d342f8c887d
Reviewed-on: https://chromium-review.googlesource.com/571381
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487376}

Removed in https://chromium-review.googlesource.com/c/572261/, however it appears it's still timing out on Win7.

TBR=jeffcarp@chromium.org

Bug: 626703
Change-Id: I06abc7a36886cc4af60065e64d35f8a7be03a1e4
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/575731Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487375}

[Demo videos]
- account with bookmarks:
https://drive.google.com/open?id=0B1O0Z7eoZMuGeTBjVXdla0RPeFE
- account with no bookmarks:
https://drive.google.com/open?id=0B1O0Z7eoZMuGR0pGb2tYUHcyOWM

TEST=Make sure it works when signed in user has no bookmarks or there is any sync error...

Bug: 696893
Change-Id: I30a29eed423253651ff2466943c8ecdd6974e0b0
Reviewed-on: https://chromium-review.googlesource.com/569538
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487374}

Revert "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager""

This reverts commit 9c083706.

Reason for revert: This seems to have broken tests, sorry: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/41713

Original change's description:
> Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"
> 
> This is a reland of a66ebc8a
> Original change's description:
> > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager
> > 
> > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
> > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.
> > 
> > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.
> > 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> > 
> > BUG=705029
> > 
> > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
> > Reviewed-on: https://chromium-review.googlesource.com/562604
> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: Yixin Wang <wangyix@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#486519}
> 
> Bug: 705029
> Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/571044
> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Yixin Wang <wangyix@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487342}

TBR=holte@chromium.org,zhongyi@chromium.org,wangyix@chromium.org

Change-Id: Ieee4be83dbc33044c1b36361aa9541240c32b95b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 705029
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/575311Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487373}

This cl is a resubmission of an earlier cl (crrev.com/c/549675), which
was reverted to fix a crash on one specific version of Google Pixel.
The difference between this cl and the previous cl is in the
implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand:
- The old version is a templated function that uses function callback
  and variable number of args.
- The new version uses a function pointer, which is simpler than a
  callback.

The original crash was not reproducible using the old patch. 
But it is probably better to use function pointers instead of 
a callback function with variable number of bugs. 

Have run this new patch on a pixel phone and there was not crash. 

Bug: 668012
Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4
Reviewed-on: https://chromium-review.googlesource.com/569505
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487372}

For regular apps we queue requests[1] to fetch the app from the store[2] (or
wherever the app set as its update_url) and then install that[3]. The only thing
we actually sync for them are settings[4][5]- the rest is downloaded.

For bookmark apps, we can't actually fetch them from the store so we sync all
the necessary data[6] and update the app manually[7].

Even after we manually update a Bookmark App[7] we don't return so we are trying
to fetch bookmark apps from the store. This patch immediately returns after
updating the app.

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=522
[2] https://cs.chromium.org/chromium/src/extensions/browser/updater/extension_downloader.cc?q=extension+downloader&sq=package:chromium&dr=CSs&l=525
[3] https://cs.chromium.org/chromium/src/chrome/browser/extensions/updater/extension_updater.cc?gsn=CheckForUpdatesSoon&l=433
[4] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=57
[5] https://cs.chromium.org/chromium/src/components/sync/protocol/extension_specifics.proto?dr&l=20
[6] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=82
[7] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=511

Bug: 745097
Change-Id: Ie5b60648738e5ad14076018999c2509bbe263979
Reviewed-on: https://chromium-review.googlesource.com/571520Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487371}

This CL consolidates individual "font-size:13px"s and "line-height:20px"s into a
global rule.

Bug: 741877
Change-Id: Ica1d1498f7f7c7ad11df8f522dd22984230c0f73
Reviewed-on: https://chromium-review.googlesource.com/574672Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487370}

We ensure the new zoom factor has been processed by the compositor,
using requestAnimationFrame and a finished promise.

BUG=743009

Change-Id: I5d6b97333d170ceaa6bcd29db3e84446ef59d18b
Reviewed-on: https://chromium-review.googlesource.com/575729Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487369}

This CL migrates ArcSettingsService.

BUG=672829
TEST=Ran try.

Change-Id: I5f75acf2d1ca539921eb6038be1399ef7c115c63
Reviewed-on: https://chromium-review.googlesource.com/572885
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487368}

This CL implements metrics for download service.

Bug: 736090
Change-Id: I7da7c02f2af9c0071b7c21519cc93e2fcc486687
Reviewed-on: https://chromium-review.googlesource.com/551108
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487367}

BUG=725605
TBR=jcivelli@chromium.org

Change-Id: I5106c8073e021929abc36797710a88e667949b23
Reviewed-on: https://chromium-review.googlesource.com/575651Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487366}

BUG=729713
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2939833002
Cr-Commit-Position: refs/heads/master@{#487365}

With the current memory limits, the compositor experiences frequent out
of memory issues when running on 4k monitors. This patch doubles the
memory allowed to use when the screen resolution is high enough
(>= 3500px by default).

R=ericrk@chromium.org, piman@chromium.org

Bug: 695427
Change-Id: I73884ae93d7ccd32fd76b8e40f3a596a02e4eaae
Reviewed-on: https://chromium-review.googlesource.com/575445Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487364}

TBR=dimu@chromium.org

Change-Id: Ia2d09762cfbb4f4e3f56ac7d1340dd267e7abc0b
Reviewed-on: https://chromium-review.googlesource.com/575570Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487363}

Bug: 740791
Change-Id: Iff7b6a0288d790ae35e93a1d2d5d572f759831d4
Reviewed-on: https://chromium-review.googlesource.com/574969Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487362}

This change is related to the TaskScheduler cleanup work.
PolicyWatcher::Create was tagged to have BrowserThread::FILE removed,
however it was only mentioned in the comments.  This comment could
have been removed, but I wanted to update the method names / params
to make the PolicyWatcher initialization mechanism more obvious.

This change splits the Create() method into two methods and updates
the callsites.  I wanted to keep a single, private Create method to
keep the per-OS creation logic intact.


Bug: 
Change-Id: Ie4b4788a4d313414819b31ab5e1fca77781d1df3
Reviewed-on: https://chromium-review.googlesource.com/572442Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487361}

Bug: 667560
Change-Id: I49f71a69de6b1fcb021f0782e5389e55ec776bf5
Reviewed-on: https://chromium-review.googlesource.com/575430
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487360}

This is a reland of 0cbeffae
Original change's description:
> Add 4 TestExpecations from WebKit Linux Trusty Leak
> 
> After landing the CL enabling WPT tests that don't necessarily
> correspond to real files (crrev.com/c/461722/), 4 Timeout 
> TestExpectations from that CL turned up as Failures on WebKit Linux 
> Trusty Leak. 
> 
> Bug: 703837
> TBR: qyearsley@chromium.org
> Change-Id: Ideb2d49c866f04d5105c0ad30446b6c92124f0f2
> Reviewed-on: https://chromium-review.googlesource.com/566019
> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485464}

TBR: qyearsley@chromium.org
Bug: 703837
Change-Id: I23f301716c62c67976b5ff9b4d26bfc80f57bc66
Reviewed-on: https://chromium-review.googlesource.com/575590Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487359}

utils.promise had a few different issues, and it's only used in tests.
Just remove it.

Bug: 745020
Change-Id: Ic6306103d5d17f5cceb371f4b1f8362e7234b27f
Reviewed-on: https://chromium-review.googlesource.com/575518Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487358}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b0acf6c12b29..44b022b2a095

$ git log b0acf6c12..44b022b2a --date=short --no-merges --format='%ad %ae %s'
2017-07-17 npward [devil] Attempt to get last data from closed command process.
2017-07-17 benjhayden Refactor HistogramGrouping.BY_NAME.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0fcddab29db3cfc765b24476378b722a9dcce65e
Reviewed-on: https://chromium-review.googlesource.com/575761
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487357}

As it so happens, const char* is only mostly const.

Change-Id: I240167c3fb0545356e15e341b73502770de10ed6
Reviewed-on: https://chromium-review.googlesource.com/575107Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487356}

Currently we are not using the 2x images in the 'change picture' UI.

Bug: 730031
Change-Id: Iad4963d421c568c3f23ab84f3c319d08ec8148e3
Reviewed-on: https://chromium-review.googlesource.com/574686Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487355}

Bug: 736925
Change-Id: Ib50980632c779f3ba9ffc01474f8a0009cc06763
Reviewed-on: https://chromium-review.googlesource.com/566159Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487354}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c2d2c94f..08a425b1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Id1a414cbf5143b9c0921260d3deebae6598a0fd8
Reviewed-on: https://chromium-review.googlesource.com/575528Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487353}

This patch adds _fromCache to HAR's entry field. This will be used to
restore chrome specific cache info.

R=caseq
BUG=374557

Change-Id: Ic5b6ae632323a12823652cd31d4ad820b3e32cc3
Reviewed-on: https://chromium-review.googlesource.com/557885
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487352}

Move HAR format to use issueTime rather than startTime for HAR's
startTime. This was an because HAR is not friendly to negative timings
(negative often means there is no data) and when importing HAR we need
to know when the time between when the issueTime (when the browser found
out about a request) and the startTime (when the request was
dispatched); we show this result as "Queued". The delta between when the
request was dispatched (startTime) and when the min(dnsStart,
connectStart, sendStart) is the "Blocking" or "Stalled" time. We were
showing only Blocked/Stalled for blocked because we we would be using
negative numbers to represent the "queued" time.

R=caseq
BUG=374557

Change-Id: I157518cdcf67009e26c81fee96c239d612eee28a
Reviewed-on: https://chromium-review.googlesource.com/558504
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487351}

Partially reverts r483795.

The previous behaviour created a bad condition where the Omnibox OnBlur
event needs to deselect the text inside but the deselection erroneously
fires an utterance (even though the text field is deselected).

      interactive_ui_tests --gtest_filter='*SpokenFeedbackTest.*'

Bug: 740430
Test: revert c603f3c7, then run
Change-Id: I9fc8fba2bc0ac29567d26cde5ba49a550a741fa9
Reviewed-on: https://chromium-review.googlesource.com/564869Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487350}

This patch moves:
  - build/scripts/make_cssom_types.py ->
    build/scripts/core/css/make_cssom_types.py

  - build/scripts/templates/CSSOMTypes.cpp.tmpl ->
    build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl

  - build/scripts/templates/CSSOMKeywords.cpp.tmpl ->
    build/scripts/core/css/templates/CSSOMKeywords.cpp.tmpl

We append 'build/scripts' to the system path in
make_cssom_types.py so that it can import modules such as
json5_generator.

We also add a new GN template "code_generator" to be used by
the new style generators. There are some additional changes
to make the linter happy.

This patch does not change behaviour.

Bug: 732657
Change-Id: I07bb1042cf548ef8795a04833f8224ad1ffe232c
Reviewed-on: https://chromium-review.googlesource.com/558587
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487349}

CHECK is failing because if the preview is a subset of the document and
is cancelled or fails after the subset is completed but while draft data
is still being generated, 2 messages are sent to the UI. Fix this issue
so that only 1 message is sent to the UI per preview request.

Bug: 740377
Change-Id: I751432f24e6283a55939a51cfe452f331da3f850
Reviewed-on: https://chromium-review.googlesource.com/571516
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487348}

Fuchsia doesn't support file locking, i.e. there is no
base::File::Lock(), so components/filesystem was failing to compile.
Added ifdefs so File::Lock() is not used on Fuchsia.

Bug: 737802, 744893
Change-Id: I825fba49b9c6247d1b4c75ca23fce4c150344db1
Reviewed-on: https://chromium-review.googlesource.com/575288
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487347}

This CL separates the single and plural messages for copying and deleting
items. This is necessary because mixing $1 style placeholders with
ICU style plural formatting was providing translators with a string that
excluded the placeholder. This then broke when the translated string
was fed into a build, because it was missing the placeholder.

Bug: 741195
Change-Id: Ib4bb619081282c9b497c7363c1a2b72252e3252f
Reviewed-on: https://chromium-review.googlesource.com/572478
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487346}

Includes changes to:
- Deprecate the MX_PORT_OPT_V2 option.
- Remove various empty header files previously provided to aid porting
  of Linux code (e.g. sys/syscalls.h).

Bug: 707030
Change-Id: Ibb56470f791036037be69a341ebb716825b16b40
Reviewed-on: https://chromium-review.googlesource.com/572883
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487345}

Reland of https://chromium-review.googlesource.com/c/573324 after
one-line compile fix.

We are inconsistent in our usage of this namespace. We mostly use it
for test support code, but not always. We sometimes wrap tests in it,
but not always.

After discussion with top-level ash OWNERS we're going to eliminate
the namespace entirely. This is more consistent with unittest.cc
files in the rest of Chrome.

TBR=reveman@chromium.org
TBR=derat@chromium.org

Bug: none
Test: compiles, ash_unittests, chrome unit_tests
Change-Id: I6afce9fb02614469e36a20cc1b0f53b1ddca551d
Reviewed-on: https://chromium-review.googlesource.com/575766Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487344}

BUG=667892

Change-Id: I25c809655f4be1f170bcd07e25574766348c2de8
Reviewed-on: https://chromium-review.googlesource.com/575670Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487343}

This is a reland of a66ebc8a
Original change's description:
> Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager
> 
> Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
> Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.
> 
> Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> 
> BUG=705029
> 
> Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
> Reviewed-on: https://chromium-review.googlesource.com/562604
> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Yixin Wang <wangyix@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486519}

Bug: 705029
Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/571044Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487342}

Change-Id: I5aa8186935e0739052c4804f514f022a72318a26
Reviewed-on: https://chromium-review.googlesource.com/575525Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487341}