GitLab

There's page sets that are flaky on Win7 GPU bots due to
the current 200mb buffer size being hit.

R=sullivan@chromium.org

Bug: 1046081
Change-Id: Ib2beacfaa68f5b5cb47065f72cbfd0ab23a1d46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023200
Auto-Submit: oysteine <oysteine@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735610}

Design doc : https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

BrowserThread counterpart to move away from post_task.h is @
https://chromium-review.googlesource.com/c/chromium/src/+/2014055

Bug: 1026641
Change-Id: I11c0633779cd2cfe75e29d3318b953c86e32bbec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977964
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735609}

We currently use 2 directories to include ARCore SDK:
- the arcore-android-sdk/ contains the github checkout - we need it to
  get arcore header file
- the arcore-android-sdk-client/ contains the SDK's .aar itself (included
  from CIPD)

When changing anything in those 2 directories, we should make sure that
android-pie-arm64-dbg builder is run.

try.star was edited manually, the other changes are due to running
`lucicfg generate "main.star"` in src/infra/config since presubmit was
complaining.

Change-Id: I9d23817407d2f5e82a50dc12f56d7a11e6c0d0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023514Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735608}

This might be subject to concurrent modification by script.
Contributed-by: Sergei Glazunov <glazunov@google.com>
Bug: 1045874
Change-Id: I27f75b8a4db924bb4fe471abca439cbbe7948c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023354
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735607}

It is no longer used and can be removed

Bug: 1045766
Change-Id: I6cabd73a87a178b7489e8b63e1c50baba5a0362c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021859Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735606}

This moves the recently created content::MessagePort concept
to blink. This is required because some intended downstream
clients of this class can not take a dependency on content, but
already have a dependency on a blink.

BUG=803242

Change-Id: I177bf5e3c53ca550783a0aa9f1f6207551d87e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023470Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735605}

On devices struggling to keep up with the video playback,
render interval might drift around its proper value.
Adjusting cadence to small changes causes more harm than good,
because it resets the cadence pattern.

This change increases tolerance to such drifts.

Bug: 1042111
Change-Id: I5fa8b7d35de65f9b77a81d4c6a2648b30210dd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021406Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735604}

With pointer-lock active, the client hides the mouse cursor. While this
is appropriate in some contexts (full-screen games or VMs, for example),
it is not uncommon for a cursor to be required in others. In particular,
a game might use a cursor while interacting with menus, and disable it
while playing the game.

Rather than requiring the user to toggle pointer-lock manually in this
case, the host can composite the cursor image into the desktop. This
will have no effect if the cursor is hidden, but allow applications to
be used normally (albeit with noticeably higher perceived latency) if
it is visible.

Note that this CL doesn't work correctly without
https://webrtc-review.googlesource.com/c/src/+/166545.

Bug: 1043325
Change-Id: Ice84f4770ad32233177ea910d6f364c78998f8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013526
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735603}

chrome/android/features/vr contains the bulk of the UI code for WebXr,
changes to this directory can cause some of the WebXr Daydream-only
tests to fail.

chrome/android/javatests/... contains the tests that are actually run
on this config (especially when scoped to Daydream only), that are
currently otherwise untested.

Change-Id: Ie9beebb0e677bc1be30d7c7d2fe7c822a1fbbe29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023866
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735602}

Add a browser test that exercises clicking on the three-dot menu in the
Extensions Menu to trigger the context menu for that extension. This
provides parity with the test coverage in the old UI (tested in
ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction).

Bug: 984654
Change-Id: I49eb542c0abc393af481e869b2159e4457ce1e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022976Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735601}

This CL:
* adds 3 grid-item-alignment-with-orthogonal-flows tests
to the WPT project, adapted from WebKit tests.
The corresponding outdated tests are being removed from the fast/
folder.

* adds the class .thirdRowFirstColumn to grid.css support file,
and removes it from the single test's <style> section, where the
class is used, to avoid duplicates.

Change-Id: I390a50ccfd53065b808449d6e748b22d5f88aee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022793
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#735600}

SplitSettingsSync will allow the user to opt-out of browser sync.
However, IdentityManager::GetPrimaryAccount() assumes the user has
consented to browser sync. Many call sites in Chrome OS use
PrimaryAccountAccessTokenFetcher to get access tokens for APIs
that are unrelated to sync. These sites will fail if the user does
not consent to sync because the primary account will be empty.

Add a mode to PrimaryAccountAccessTokenFetcher to work with the
"unconsented" primary account, which exists whether or not the user
has consented to sync. I initially tried to switch the call sites
to directly use AccessTokenFetcher, but some of them (cloud policy)
can start a fetch before the primary account is available. PAATF
supports this use case.

Migrate the following sites:
* TokenHandlerFetcher - for login
* UserCloudPolicyTokenForwarder - for policy fetch
* CryptAuthClientImpl - for "Better Together" multidevice features

TODO: Supervised users.

Bug: 1042400
Test: updated existing unit_tests
Test: login works with --use-unconsented-primary-account
Test: enroll device, sign in, chrome://policy shows policies applied
Change-Id: Ia5eec6442f371ce957e674f4b1f20961244b8e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021824
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735599}

TBR: rdevlin.cronin@chromium.org
Bug: 1042220
Change-Id: Ibbb2c19588c08a7001a6704064111cfc380a9bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023202Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735598}

Bug: 901465
Change-Id: Icdf67d1c56eb675707eec256c5bfb5ffd6b9a875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023231Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: (gone) Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735597}

Now that we are adding support for tab groups in the WebUI tab strip,
there isn't a need to have 2 separate models for the tab context menu.

Bug: 1027373
Change-Id: I41ede1f315c5fc7bbe70addc0f3d36e0db83f04f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013652Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735596}

ToolbarActionViewInteractiveUITests don't apply to the new
Extensions Menu UI. Instead, we have test coverage in
ExtensionsMenuViewBrowserTest and ExtensionsMenuViewInteractiveUITest.
Force ToolbarActionViewInteractiveUITests to run with the
extensions menu feature disabled.

Bug: 984654
Change-Id: Ib67f19741393f51d8700218b2899125fd3aa02cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023225Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735595}

This CL adds the loader and makes the server request but does not yet
parse the response. That will be done in the next CL.

Bug: b:148239201
Change-Id: I7f8582f3f0335ce5b3f193ff21791ca2a6ee7348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018387
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735594}

This is a reland of b7fceb80

Note: asvitkine@ removed a bunch of stale entries since this CL was
reverted due to command line overflow on Windows.

Original change's description:
> Reland "Adding a FTT config for PreconnectSameOriginDesktop"
>
> This is a reland of 4e23e8e8
>
> Patchset 1 is what previously landed. This caused flakes in other
> loading predictor browser tests, so I added the holdback to all
> of the tests. In a follow-up, I will make sure the tests check
> for preconnects on the appropriate URLs.
>
> See https://chromium-review.googlesource.com/c/chromium/src/+/2004181
> for revert rationale.
>
> Original change's description:
> > Adding a FTT config for PreconnectSameOriginDesktop
> >
> > This experiment is in canary/dev and should be moved to Beta.
> >
> > Bug: 1038774
> > Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684
> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> > Reviewed-by: Alex Ilin <alexilin@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#732219}
>
> Bug: 1038774
> Change-Id: Id7bd4bddf5b5812d02a8953d0733f8af73007fb6
>
> TBR=tbansal@chromium.org,alexilin@chromium.org
>
> Change-Id: Id7bd4bddf5b5812d02a8953d0733f8af73007fb6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004691
> Reviewed-by: Alex Ilin <alexilin@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732553}

Bug: 1038774
Change-Id: I778a90becf3ad30a1f3f18417f604ce07bf72058

TBR=tbansal@chromium.org,alexilin@chromium.org

Change-Id: I778a90becf3ad30a1f3f18417f604ce07bf72058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023352Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735593}

https://skia.googlesource.com/skia.git/+log/f68213fc4db3..3234ce1347c5

git log f68213fc4db3..3234ce1347c5 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 robertphillips@google.com Add SkImage::MakeRasterFromCompressed and make MakeFromCompressed fall back to decompression for unsupported compression types
2020-01-27 herb@google.com Swap dtor order of SkSTArenaAlloc and SkArenaAlloc v.2
2020-01-27 borenet@google.com [infra] Update infra dep
2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@3234ce1347c5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: Ib631475f6c6ec44d49c0eecc24a6da8640729103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023215Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735592}

We no longer require devs to have JDK8 on their path.

Bug: 1036426
Change-Id: I0dd9276d5c76bee714c2cd68d24b23feb93ed43f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020548
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735591}

If a reporting UploadEventsRequest contains too many events, the
reporting server will only upload the first N events, and the
UploadEventsResponse will contain a record of which events were accepted
and which were rejected. The retry logic ensures that in the case where
there were some temporarily rejected events, that job is retried until
all of the events are either accepted or permanently rejected.

This involved some refactoring of the
DeviceManagementService::JobConfiguration so that a job can take part in
the decision of whether it needs to be retried, and to allow a job to
make changes to itself before it is retried.

R=poromov@chromium.org
BUG=1039739

Change-Id: Ic947f678d63fbe644e6af3575c7bea1dd970caba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005898
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735590}

I got a frightening-looking "unable to find package info" warning
on my first attempt running Android tests. The docs
(//android/javatests/.../vr/README.md) mention that this warning
can occur on first run. This CL updates the warning message to
indicate that it can be noisy. (In the end, the tests ran with
no problem.)

Change-Id: Ia1311051614204a5179757de4207c81a6a3060d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023388
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735589}

When backdrop filter is applied, the backdrop_filter_quality should be taken into account. Effect like blur doesn't require to be performed on the original size, rather it can be applied on the downsized image which is scaled by the backdrop_filter_qualityi, and then re-scaled back to its desired size. This should improve the performance for ui with blur effect, such as the launcher.

Bug: 1014300
Change-Id: I5012e9f476707c25cdb4f66c0f256a1dca0ae3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892053Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735588}

Currently when a user is in WebXr on a Daydream device, when they press
the "App" button to end the session they are taken to the VR Browser,
even if that is not how their session was started. After this change,
when the user presses the "App" button they will be taken to Daydream
home to continue a VR experience, unless they initiated the Session from
the VR Browser (in which case they will be returned to the VR Browser).
If the user simply takes the device out of the Daydream View headset and
closes the window, they will be returned to 2D chrome.

As a result of this change, a few tests needed to be updated.

Fixed:1046056

Change-Id: I8d0e8466e09a13aecccb331b0bf9fc2f2ebbf177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020905Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735587}

This is a reland of 9da458ed

Reason for reland:
Speculatively fixed the cause of the breakage in http://aosp/1218898
and rolling forward.

$ git log 0dace75a3e64..376e6d205326dd7 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 primiano@google.com Fix chromium roll failure on tracing_integration_test
2020-01-27 treehugger-gerrit@google.com Merge "Move render stage debug markers into the gpu_slice_table"
2020-01-27 treehugger-gerrit@google.com Merge "perfetto-cmd: Reduce compression quality to 6"
2020-01-27 primiano@google.com Merge "ipc: PERFETTO_EXPORT ServicePoxy for chrome roll"
2020-01-27 hjd@google.com Merge "traced_probes: Mux atrace configs"
2020-01-27 hjd@google.com Merge "trace_procssor: Remove use of std::stoi"
2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto"
2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling"
2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack."
2020-01-27 primiano@google.com Speculatively fix chromium roll
2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer
2020-01-27 primiano@google.com Update GN and mass reformat gn files
2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service"
2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px"


Original change's description:
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> Bug: None
> Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55
> Tbr: perfetto-bugs@google.com
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Primiano Tucci <primiano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735490}

Bug: None
Change-Id: If64536466ef4364e259bfd540c9fe01f0effe8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023486
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Auto-Submit: Primiano Tucci <primiano@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735586}

Context:
ExpandablePaymentHandlerBrowserTest.CancelPayment test crashed flakily,
because on clocking the PH UI, the ChromeActivity sometimes has already
been released in PaymentRequestImpl#onPaymentHandlerUiClosed, causing a
null error when accessing it.

Change:
In PaymentRequestImpl#onPaymentHandlerUiClosed, do null-check for
ChromeActivity before use.

Bug: 1045274
Change-Id: I4bee115093405c3d69494c56f57cc4703abb7a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023190
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735585}

This file should be able to be reviewed by the WebGL owners.

Bug: none
Change-Id: Idbd75f6add17bdfa1f727eb99191c92bd04bc64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020808Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735584}

Roll src/third_party/glslang/src/ b0ada8035..07a55839e (15 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b0ada80356ca..07a55839eed5

$ git log b0ada8035..07a55839e --date=short --no-merges --format='%ad %ae %s'
2020-01-27 rharrison Use correct enum type in case statement
2020-01-27 cepheus Build: Fix more build warnings caused by PR #2038.
2020-01-26 cepheus Build warning: Fix #2062, missing enum value in a switch.
2020-01-08 sk Public: replaced tabs with spaces
2020-01-08 sk CInterface: replaced tabs with spaces
2019-12-30 sk CInterface: added static asserts to compare C/C++ enums
2019-12-30 sk Added LAST_ELEMENT_MARKER for every enum used in the C interface
2019-12-26 sk CInterface: replaced SH_ prefix with GLSLANG_
2019-12-25 sk CInterface: added glslang_program_SPIRV_get_ptr()
2019-12-25 sk CInterface: added files to CMakeLists.txt
2019-12-25 sk CInterface: added _BIT suffix to glslang_messages_t and glslang_reflection_options_t, fixed const-correctness
2019-12-25 sk CInterface: reformatted according to .clang-format rules
2019-12-24 sk Added original glslang_c_interface implementation by Viktor Latypov
2019-12-24 laddoc Add Tess machine dependent built-in variables initialization for GLES 3.2
2019-10-18 timo.suoranta Fixes for gcc 9 / -Werror=deprecated-copy

Roll src/third_party/shaderc/src/ a4f9acedf..0681dd61d (2 commits)

https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/a4f9acedf3c0..0681dd61d3b0

$ git log a4f9acedf..0681dd61d --date=short --no-merges --format='%ad %ae %s'
2020-01-27 rharrison Remove deprecated APIs (#974)
2020-01-24 dneto Handle new Glslang profile enum in switch (#973)

Created with:
  roll-dep src/third_party/glslang/src src/third_party/shaderc/src

BUG=chromium:1046013

Change-Id: I567f501b239b6359b7551c19c14163a559dc072b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023511
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735583}

Change-Id: I3ae08313a26f6e4e65a8d1c5e6a552e06a9e068d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023510
Auto-Submit: (gone) Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735582}

This is the equivalent fix to the below CL for NavigationResult:
https://chromium-review.googlesource.com/c/chromium/src/+/2021316

It fixes a regression and adds a test to verify the behavior.

Bug: 1043440
Change-Id: I4b9e682a9d04fd485aa1ebacd5e4ceae42729765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023360Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735581}

This change fixes some issues with using the keyboard to select values
in datetime-local input popups.  Previously, using the arrow keys to
navigate the calendar portion of the popup would move a highlight but
would not actually change the selected value until the user hits 'enter'.
Hitting 'enter' then closes the popup, and if the user had also wanted to
change the time then they must re-open the popup to do so.

With this change, using the arrow-keys in the date section of the control
now changes the selection instead of just moving the highlight, and
all changes are pushed to the in-page control, matching the preexisting
behavior of the time section of the popup.

This necessitated a change to how invalid values (defined by the
'step' attribute) are handled.  Before this change, the highlight
could be moved over invalid dates in order to navigate past them to other
valid dates.  With this change, the highlight is no longer used for
navigation so users need another way to navigate between valid sections.
To achieve this, the selection behavior is changed such that if a user
uses an arrow key to navigate towards an invalid section, the selection
will seek in that direction and land on the nearest valid date in that
direction.

This new selection model is applied to the refreshed versions of the
date and week controls as well, although they do not yet push the live
updates to the page.  A follow-up change will implement the live-update
and double-escape-key model for these controls.

Once the old form control implementations are deleted, the
CalendarPicker._highlight management should be removed entirely from the
JavaScript and just implemented as a :hover style, but that is infeasible
as long as we are maintaining the old controls.  Filed bug 1046054 to
track this work.

A small bug is fixed with this change: a "middle day" of the 14th
instead of 15th was being granted to March instead of February due to an
off-by-one error (months, confusingly, start at 0 while days start at 1).

Bug: 1041637
Change-Id: I08eb4c9462dec2adfb2f63968aca7cbaf056d90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015651
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735580}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1248b8ef4a7b..f437869d4107

git log 1248b8ef4a7b..f437869d4107 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 jbudorick@chromium.org gclient: allow clients to pass deps_file name as config kwarg.

Created with:
  gclient setdep -r src/third_party/depot_tools@f437869d4107

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1041701
Tbr: agable@chromium.org
Change-Id: Ib6c981d5198e90a26d79613ef624f93f67f01b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023184Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735579}

Since stash.py polls until results are available, the tests can time out
in a single threaded environment if the test page tries to fetch results
before the target page stashes them. This patch moves the polling to
stash.js instead, so that the target page is free to stash results.

Also adds a window.close() call on the target page after stashing
results, otherwise each test case leaves a leftover window which can
slow down the test environment.

Bug: https://github.com/web-platform-tests/wpt/issues/20269
Change-Id: Ia2df8f889596e91207aca92f6ecb290c9f96d201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018099
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735578}

When using SurfaceControl after surface has been returned we need to
wait until fence provided by system will be signaled. When using GL
for compositing, this is implemented as importing provided file
descriptor as egl fence and issue ServerWait().

GLRenderer does it when we get surface back. With SkiaRenderer it
happens on next BeginWrite for the SharedImage. Import is expensive
operation and BeginWrite is on critical path.

This CL moves import to EndOverlayAccess as we will do it anyway.
Then at BeginWrite time we only issue ServerWait().

In local tests with scrolling simple page it saves 200us in
DrawToSwapUs metric.

Change-Id: I6efb2783d0e287dc5e4fbb5707c507328e75a32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019607Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735577}

This reverts commit a3182e3f.

Reason for revert: crbug.com/1023913#c10, crbug.com/1046100

Original change's description:
> Reland "mac: roll to 10.15 SDK"
> 
> This is a reland of fd84ab8a
> 
> Original change's description:
> > mac: roll to 10.15 SDK
> >
> > This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the
> > 10.15 SDK.
> >
> > Bug: 1023913
> > Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Original-Commit-Position: refs/heads/master@{#725141}
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723
> > Cr-Commit-Position: refs/heads/master@{#730238}
> 
> Bug: 1023913
> Change-Id: Icb5ca715edd7972c8b3824aa58a8e2b8df25d15b
> Tbr: thakis@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022257
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735493}

TBR=ellyjones@chromium.org,thakis@chromium.org

Change-Id: I48247599e2c713951465dbb24c25efc822f0c433
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1023913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024027Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735576}

This reverts commit 4eb4df63.

Reason for revert: Caused crbug.com/1045433.

Original change's description:
> Fixes click on inline element embedded in anchor inside <summary> breaks anchor.
>
> Previous to this CL, clicking on an inline element embedded in an anchor placed
> inside a <summary> tag will expand the <details> section instead of navigating to
> the anchor's href. However, when the anchor is placed outside of <summary>,
> it behaves correctly.
>
> The error is caused by DOMActivate event generated by the inline element. As
> DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the
> <summary>, and is handled there. Once DOMActivate is handled, the original
> click event stops propagating and terminates. This behavior, however, differs
> from when the anchor tag is placed outside of the summary. DOMActivate isn't
> handled, and the original click event keeps bubbling up till it's handled by
> the anchor.
>
> DOMActivate event is deprecated:
> https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event.
> However, since blink still has code that depends on it, replacing it is outside
> of the scope for this fix. Instead, this fix is for the anchor element to
> handle the DOMActivate event as it bubbles up. The anchor event handler checks
> the underlying event of DOMActivate and handles it if it's a click.
>
> I also looked at an alternative fix by trying to prevent the DOMActivate event
> from bubbling up. But calling event.stopPropagation() doesn't work as the
> EventDispatcher::DispatchEventPostProcess doesn't check this status.
>
>
> Bug: 538283
> Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718552}

TBR=tkent@chromium.org,masonfreed@chromium.org,yuzhehan@chromium.org

Bug: 1045433
Change-Id: I14b369beb04171ef846cb3a79ebb3fe268cf5c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023267Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735575}

TBR=crouleau@chromium.org
NOTRY=true

Bug: 1046101
Change-Id: Ifb27532f7096ab1461a552b87a20e1f9379ddb10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023987Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735574}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a053d8d7edc..3c0615232489


Created with:
  gclient setdep -r src-internal@3c0615232489

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1023913,chromium:927262
Tbr: jbudorick@google.com
Change-Id: Ibc01eadb60795f7ac71b92a6e78393bddd7625a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023214Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735573}

In https://chromium-review.googlesource.com/c/chromium/src/+/1988376
I added a TODO (which was bad, and actually a note to myself).

With FlexNG enabled the lack of this behaviour triggers a lot failures:
https://test-results.appspot.com/data/layout_results/linux-rel/292399/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

This makes it so an element with layout containment doesn't provide
a baseline to its parent.

An alternate version of this patch would to add this logic into
NGBoxFragment::Baseline. However this would likely be slightly more
expensive as we invoke that function much more than creating a fragment.

Bug: 845235
Change-Id: I2faa5042881c14e1e90088ac0219a0aa556f2bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019103Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735572}

Bug: 1045669
Change-Id: Ib5d5afeb13b5ab50293a03dbeaafe388ff0a8522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018341
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735571}