- 20 Feb, 2020 40 commits
-
-
David Trainor authored
Stable rollout is happening now, so we need to extend these a few more months to make sure it goes smoothly (check for errors, evaluate adoption & success criteria, etc.). Bug: 1039340 Change-Id: Icbd4ee821a26bb240273ce5ba7b8bc7e6b705a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062637Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#743253}
-
Nate Fischer authored
This represents sample rate as a per mille (out of 1000) integer. This has the advantage that embedders can express sample rates precisely (ex. 100 vs. 0.1). It also simplifies test logic. Sampling is still determined by hashing client_id, so this should not have a significant impact on metrics volume. This may have a minor impact due to rounding differences. This does not change the rates themselves, only their representation. This also simplifies the AndroidMetricsServiceClient interface, removing some methods and un-exposing others from subclasses (removing the 'virtual' declaration). Bug: 1037951, 1042518 Test: run_components_unittests -f AndroidMetricsServiceClientTest.* Test: run_android_webview_unittests -f AwMetricsServiceClientTest.* Test: start up WebView lots of times, compiled with stable & beta Test: channel, and manually confirm rate we're in-sample Change-Id: Idd52235f231cd93d97901c5d09a08bf05e71cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053793 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743252}
-
Ken Rockot authored
Bug: 955171 Change-Id: I8d157312f8f063093d95e534868ffdfe27d34fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067458 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743251}
-
Stephen Chenney authored
Various Rendering Core histograms are set to expire soon. Extend them another year or 2 more milestones. Bug: 1053092,1043743,1043742 Change-Id: I6e34ae87ec4c76834d4ede35033e95a78b84aa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062289 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#743250}
-
Gavin Williams authored
Change-Id: Ia5d45b58f20535aad7d303db20de345be5daef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067277 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#743249}
-
Evan Stade authored
Perhaps "content-modal" dialog would be another way to decsribe them. These are used for javascript dialogs, except onBeforeUnload (as per shared logic). There are TODOs sprinkled throughout, including: - accessibility (such as that handled by Chrome's TabObscuringHandler) - Embedder APIs: - to tell the embedder that a tab modal is showing, so they can modify their UI (Chrome disables the app menu) - for an embedder to inform WebLayer of focus events, which is used for juggling z-order (important for accessibility) - for an embedder to allow WebLayer to handle system back (so the dialog dismisses on back, rather than the page navigating) Bug: 1045499, 1025256 Change-Id: I2e694f09bbab9302375925e9148aac18f2985b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052267Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#743248}
-
Findit authored
This reverts commit 38d5e420. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743212 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzhkNWU0MjBmZTcyYzBiYjY2YzlmNzY4N2Q0NWU5MzhjNzdlMDBkZgw Sample Failed Build: https://ci.chromium.org/b/8887906576420062352 Sample Failed Step: browser_tests Sample Flaky Test: MetricIntegrationTest.FirstInputDelay Original change's description: > Add FirstInputDelay integration test > > This CL adds a test for FID that tests equality between the JS value and > the value reported in UKM and in UMA. > > Change-Id: I00de8c947895700d86788ee4a95ea228458bb25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067077 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743212} Change-Id: I7eae1f24fb72da933586cb32b4b1cad24ade9844 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067353 Cr-Commit-Position: refs/heads/master@{#743247}
-
Bettina authored
Bug: 1054179 Fixes: 1054179 Change-Id: I890ab97f3390861e64196d6064450a5244cfdd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065332 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743246}
-
Peter Boström authored
This is explicitly done for the Extensions menu, but affect two pin icons in ash too. Bug: chromium:943702 Change-Id: I4a04afd6d41df4a9f0487dd0359539c69f7d5a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065910Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743245}
-
Bailey Berro authored
Bug: 1052967,1052915 Change-Id: If7907659f05d223318f23bc497ae81997758e0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063254 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#743244}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bcc5d9fec0a3..4ae2e9779046 $ git log bcc5d9fec..4ae2e9779 --date=short --no-merges --format='%ad %ae %s' 2020-02-20 thakis Remove optimize_no_wpo in ffmpeg. 2020-01-30 tmathmeyer Fix memory leak in mov_read_pssh Created with: roll-dep src/third_party/ffmpeg Bug: 1053958,598772,1018745 Change-Id: I7b382c4d0b5c01a8cc2bba59b65a0fd888dca382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067438 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743243}
-
Eric Roman authored
This matches the IDL from the spec, and resolves a bug whereby the Web Crypto API could be used from an insecure context. We were correctly blocking access to "self.crypto.subtle" from insecure contexts, however it was possible to access through its interface self.SubtleCrypto. Bug: 1038704 Change-Id: I425d602fda64c3f63ee87bcfed1711e508901c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057098 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#743242}
-
Karan Bhatia authored
This CL tries to deflake ChromeNavigationBrowserTest.RedirectErrorPageReloadToAboutBlank. The theory is that the extension web request listeners aren't getting set up by the time the page is reloaded, hence the redirect is not happening. Fix by waiting for an ack from the extension background page. BUG=981295 Change-Id: If1171578dcbf248b910cbb6f774491ccb348f2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056942Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743241}
-
Daniel Libby authored
We're planning on turning on the composited scrollbar scrolling feature relatively soon so we want these metrics to continue gathering data so that we can see how they are affected by the feature. I standardized all the Event.Latency.*Scrollbar.* metrics to expire after M85. Note that while we probably won't look at all of the submetrics as often as the higher level ones (e.g. TimeToScrollUpdateSwapBegin4) they are all logged together as part of the LatencyInfo pipeline, similar to other input modalities (i.e. Touch and Wheel). Bug: 1041524 Change-Id: I47f4ab08a111fc987ad1b26c51e36c09f7970b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066147 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#743240}
-
Matt Jones authored
This patch adds the optional ability for sheet contents to intercept the back button. This is useful in cases where the bottom sheet has an unusually large peek state and back would be used to dismiss the sheet rather than inadvertently navigate back on the underlying page. Bug: 1049942 Change-Id: I3d1ff85f122a96743ea33a71b784f49e36c6e9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062748 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#743239}
-
behdad authored
In a previous change(crrev.com/2055047) we stop using the confidence intervals as a result of high noise on them. But we need to use the CI for control test. This change adds the condition to use confidence interval only for the control test. This helps with not flagging flaky failures. TBR=crouleau@chromium.org Bug: chromium:1052054 Change-Id: Ibbacb64229d06fc8b896cce28eb07d41bed62885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065112 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#743238}
-
Robert Sesek authored
Bug: 710376 Change-Id: I77502444e8598321e069b651dd2eed759e397155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066066 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#743237}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/402a68bf7d41..793a4fe52960 git log 402a68bf7d41..793a4fe52960 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sadrul@chromium.org windows: Fix when there's no pillow. Created with: gclient setdep -r src/third_party/catapult@793a4fe52960 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1051202 Tbr: crouleau@google.com Change-Id: I26125851e6abbba875b4804d24378588e7501bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743236}
-
Xianzhu Wang authored
A composited animation may make a layer overlap with another layer that didn't overlap earlier. When testing overlap, we need to expand the visual rect of the animating layer. Bug: 1026653 Change-Id: If38e7d621a21434143447ea7903da2de9691d070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057868Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743235}
-
Akihiro Ota authored
This change updates the hint delay whenever the speech rate is changed. We use an inverse relationship so that a faster speech rate correlates to a shorter delay. Bug: 1050833 Change-Id: Ifa42199dc2fe100153f25f517000d56076e09bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052554 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743234}
-
Fredrik Söderquist authored
Bug: 109224 Change-Id: I67ef67e356e67797c90d296fe411c96a2f76cfea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065007 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#743233}
-
Rayan Kanso authored
Bug: 1051508 Change-Id: I7204e38b3542c322c67030435339a943d7a0c0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054229 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#743232}
-
Lei Zhang authored
Still slowly working through the launch. Also add another owner. Bug: 477699 Change-Id: I3c6dd7e7f0236a0e803a23c32e6716c493bd3c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066278 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#743231}
-
Sylvain Defresne authored
Since AppDistributionProvider is a base class with no-op method implementation, TestAppDistributionProvider is unnecessary (its method have the same implementation as the base class). Remove the sub-class. Bug: none Change-Id: I73ba4d5e0cb3bf4a39efccb694fa77c421eece57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064187Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743230}
-
Wenyu Fu authored
Bug: 1053131 Change-Id: I7c4f445a22b3fef2c56eab573b884d3e163e37cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063534 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#743229}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/74d3f371f201..3cfba7f05be4 git log 74d3f371f201..3cfba7f05be4 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com Revert "VK_EXT_shader_stencil_export support" 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support Created with: gclient setdep -r src/third_party/swiftshader@3cfba7f05be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I96f168f531234543a96e93a20e36c479fac9201e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/099ad342..c9de129a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I44c73b32049b674baa1da7c01edae315b2ce5263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067297Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743227}
-
Nazerke authored
HistoryLocalCommands isn't configured through the dispatcher. This CL renames this protocol (HistoryLocalCommands) to "HistoryUIDelegate", and renames all of the "localDispatcher" properties to be named "delegate". Change-Id: I7fc79e2053292e994ef2db1129b78575fee5112d Bug: none. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062446 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#743226}
-
Jochen Eisinger authored
Bug: 1051415 Change-Id: I2b535953f2fc90a755bd784ceeae2fb86dc9ba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063002 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#743225}
-
Yue Li authored
Bug: None Test: git cl format Change-Id: I1d8938e550b36186d0edd2d9ab5f0034f6e0127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065737Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#743224}
-
Oksana Zhuravlova authored
This change adds a condition so that the renderer part of the contextual search code is only created when the corresponding build flag is defined. It also updates the browser-side ContextualSearchJsApiService interface binder registration depend on the same build flag rather than the more generic OS_ANDROID condition. Bug: 1047680 Change-Id: Ia0c88558736b028b96b0092acb6dde4a7a526b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055992Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743223}
-
Mehran Mahmoudi authored
This fixes a problem in chrome/android/BUILD.gn that caused the paint preview instrumentation test suite to run on monochrome_public_test_ar_apk. Bug: 1050548 Change-Id: I5837016a7ae08d67fc2bf9012a31294aa61c6e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057499Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743222}
-
Avi Drissman authored
Bug: none Change-Id: I355076b24666e0b17fe56ca52c7c878e0f1975fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065854 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#743221}
-
Oriol Brufau authored
Before this patch, list markers were anonymous boxes in legacy layout. This patch makes them be pseudo-elements instead. This is a follow-up of r731964, which did the same for LayoutNG. Just like r731964, this patch improves the flexbox_with_list_item.html performance test by a 30-40% (this time for legacy). BUG=457718 TEST=editing/execCommand/create-list-1.html-disabled TEST=editing/pasteboard/drag-selected-image-to-contenteditable.html TEST=editing/pasteboard/input-field-1.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/move-by-line-002.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html TEST=editing/unsupported-content/list-delete-001.html TEST=editing/unsupported-content/list-type-after.html TEST=editing/unsupported-content/list-type-before.html TEST=external/wpt/css/css-pseudo/marker-content-014.html TEST=external/wpt/css/css-pseudo/marker-content-019.html TEST=external/wpt/css/css-pseudo/marker-content-020.html TEST=inspector-protocol/resources/dom-snapshot-pseudo-element.html TEST=paint/invalidation/list-marker-2.html TEST=paint/invalidation/offset-change-wrong-invalidation-with-float.html Change-Id: I58c8d49e1f2168add3c78a024a2b9371b34262d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007733 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#743220}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4386ad19fb62..7b0ed557a98e git log 4386ad19fb62..7b0ed557a98e --date=short --first-parent --format='%ad %ae %s' 2020-02-20 robertphillips@google.com Start precompiling DDL shaders Created with: gclient setdep -r src/third_party/skia@7b0ed557a98e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ic2d64bd9090c2fffb886338c12ce89de89e9b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743219}
-
Klaus Weidner authored
Instead of depending on Fullscreen API's styling, use a separate :xr-dom-overlay pseudoclass with its own copy of the relevant styles. Lazy-load this stylesheet when DOM Overlay mode is active. Update the Fullscreen API integration to specifically allow XR session setup to configure the fullscreen element, while blocking app-side element changes to avoid inconsistent behavior. Update the WPT test to cover more scenarios and improve compatibility with potential implementations that aren't screen space. Bug: 991747 Change-Id: I2b578570f695f72019c7efccb4c797cdb90e87f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057120Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743218}
-
Rakib M. Hasan authored
Instead of using typ's methods to get the test expectations, we should use blinkpy's methods. Bug: 986447 Change-Id: I58508a44536ccc73864c1acd10c2be06af82a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067377Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#743217}
-
Tim van der Lippe authored
Has to be updated for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067057 TBR=jacktfranklin@chromium.org Bug: 1050549 Change-Id: I79583541c6e1ae13311d55e1c72e762b4da3ed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066780Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#743216}
-
rajendrant authored
This previews bit should be set only when SaveData is enabled and irrespective of LazyLoad feature. Bug: 1047330 Change-Id: I709b96b9518c449a7846634ff44c20b5bf96535d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039895 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#743215}
-
Samuel Huang authored
This reverts commit 4eb9ce3d. Reason for revert: Compile error: Moved file (e.g., vector_icons.cc.template) needs to have #include updated as well. Original change's description: > Move shortcut viewer to ash/ > > Next step: > * Consolidate string grd file into single shortcut_viewer_strings.grd > * Remove NewWindowDelegate::ShowKeyboardShortcutViewer > and open it directly. > * Remove KSV_EXPORT > > Bug: 1046624 > > Change-Id: I4241bd00d5c27520ac11c09e7264e8c8c9729a84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065852 > Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743191} TBR=jamescook@chromium.org,oshima@chromium.org,thakis@chromium.org,wutao@chromium.org Change-Id: I1de5281e9e8ff07850b200dc798d27e0b0b340cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067245Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743214}
-