GitLab

Rather than complicating the API with proposals of key re injection, or runtime registration/deregistration (which we might want for other reasons in the future), here's a very simple change that would probably give us the same functionality. If an extension remove all chrome.commands.onCommand listeners, then they will no longer receive the onCommand event and thereafter, the browser should continue propagating the key event and not drop it. I think this is actually the correct behavior, but also allows extension authors to have a little more control over when a command should be processed.

BUG=407163

Review URL: https://codereview.chromium.org/504183004

Cr-Commit-Position: refs/heads/master@{#292997}

BUG=none
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/535593002

Cr-Commit-Position: refs/heads/master@{#292996}

They should no longer be flaky/crashing because the underlying watch manager is
new, shiny, and more stable.

BUG=390979

Review URL: https://codereview.chromium.org/530703003

Cr-Commit-Position: refs/heads/master@{#292995}

This is the first in a series of CLs intended to reduce the amount of caching
in docserver code. The @Cache annotation is used to indicate that compiled data
should be cached in CompiledFileSystem.

NOTRY=True

Review URL: https://codereview.chromium.org/521693003

Cr-Commit-Position: refs/heads/master@{#292994}

In https://codereview.chromium.org/473643002/ we added a button for users in the
"Remember Certificate Error Decisions" experiment to allow them to revoke their
decision to bypass an SSL error for a given host. This commit adds an UMA
histogram to count how often a hard revoke actually occurs.

BUG=262615
R=felt@chromium.org

Review URL: https://codereview.chromium.org/476513002

Cr-Commit-Position: refs/heads/master@{#292993}

Android's vsync listener will now only dispatch a BeginFrame message if
such was requested. This exposed a hole in our BeginFrame request
pipeline, where short-circuited touch forwarding would bypass the vsync
request. Instead, always request the BeginFrame if a touch event was
received from the platform, potentially reducing the first frame's
latency when the page lacks a touch handler.
latency.

BUG=408377

Review URL: https://codereview.chromium.org/535453002

Cr-Commit-Position: refs/heads/master@{#292992}

Without this I get compile errors in motion_event_web.cc because M_PI
is undeclared.

BUG=409940
TEST=none
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/533863002

Cr-Commit-Position: refs/heads/master@{#292991}

BUG=380875
R=xiyuan@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/522683003

Cr-Commit-Position: refs/heads/master@{#292990}

Recorded additional tough_energy_cases.
Moved all test cases to codepen, so they're easy to edit and all http.

BUG= 386152

Review URL: https://codereview.chromium.org/506063002

Cr-Commit-Position: refs/heads/master@{#292989}

In a previous attempt to prevent SadTab pages from being zoomable we
attempted to use RenderProcessHost::HasConnection, but this fails in
the case where a new tab can be started in the same RenderProcessHost
while the SadTab is still visible. This CL switches to testing to see
if the RenderView for the tab in question is live in order to avoid
this problem.

BUG=407562

Review URL: https://codereview.chromium.org/529993002

Cr-Commit-Position: refs/heads/master@{#292988}

NOTRY=True

Review URL: https://codereview.chromium.org/509253003

Cr-Commit-Position: refs/heads/master@{#292987}

.. and switch evil network profile for bad network profile

BUG=356842

Review URL: https://codereview.chromium.org/511393007

Cr-Commit-Position: refs/heads/master@{#292986}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/525433003

Cr-Commit-Position: refs/heads/master@{#292985}

Review URL: https://codereview.chromium.org/530523002

Cr-Commit-Position: refs/heads/master@{#292984}

If no gesture handler has been established prior to RootView
receiving a ui::ET_GESTURE_END event, do not perform any
targeting based on the event's location (and therefore do not
dispatch this event to any view); GESTURE_END should only
ever be targeted and dispatched to the gesture handler set
by a previous gesture.

BUG=409918
TEST=ViewTargeterTest.ViewTargeterForGestureEvents,
     WidgetTest.GestureBeginAndEndEvents,
     WidgetTest.DisabledGestureEventTarget

Review URL: https://codereview.chromium.org/533793002

Cr-Commit-Position: refs/heads/master@{#292983}

Remove redundant data member and include.
Followup after https://codereview.chromium.org/493363006

BUG=388084

Review URL: https://codereview.chromium.org/527103003

Cr-Commit-Position: refs/heads/master@{#292982}

This reverts commit fe2ae5fb.

BUG=368834,409965
TBR=zea,scottmg

Review URL: https://codereview.chromium.org/534733002

Cr-Commit-Position: refs/heads/master@{#292981}

Cleanup:  This member has been obsoleted by https://crrev.com/516443002.

BUG=334602

Review URL: https://codereview.chromium.org/520613004

Cr-Commit-Position: refs/heads/master@{#292980}

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/533853002

Cr-Commit-Position: refs/heads/master@{#292979}

This fixes all non-RTC-related linker errors for Chrome.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/533743004

Cr-Commit-Position: refs/heads/master@{#292978}

BUG=407561
TEST=Tests pass in Nexus 5

Review URL: https://codereview.chromium.org/521393002

Cr-Commit-Position: refs/heads/master@{#292977}

This also reworks visibility so both it and the testonly flag are checked when
a target is marked resolved, rather than when it is written out. The previous
code would not check visibility when doing non-"gen" commands like "check",
which is counterintuitive.

This change required OnResolved to be able to report a failure, which required
updating many callers. But it makes visibility mush easier to test, so I
added some additional visibility tests.

BUG=357779
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/524623005

Cr-Commit-Position: refs/heads/master@{#292976}

BUG=406596

Review URL: https://codereview.chromium.org/467363004

Cr-Commit-Position: refs/heads/master@{#292975}

The old prefs are no longer needed; M39 should be a sufficiently long
transition time period.

BUG=384668
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/512083002

Cr-Commit-Position: refs/heads/master@{#292974}

https://skia.googlesource.com/skia/+log/871dca8ea99f49b8bbf118d0ccbd9da0c59467c3..98d709bc8d0761df8e0ad35e92c06e500f0be50d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/529083002

Cr-Commit-Position: refs/heads/master@{#292973}

SpdySession::SendInitialData() now only retrieves and sends server-persisted
SPDY settings for SPDY/3.1 and below.

BUG=408348

Review URL: https://codereview.chromium.org/515353002

Cr-Commit-Position: refs/heads/master@{#292972}

Currently there is not enough unit test cases available to cover
the functionality of Text Selection Action Bar. In this patch covering
essentail unit test cases for the same.

BUG=

Review URL: https://codereview.chromium.org/521583003

Cr-Commit-Position: refs/heads/master@{#292971}

Revert of Add Keys() function to ServiceWorkerCache. (patchset #13 id:280001 of https://codereview.chromium.org/477973002/)

Reason for revert:
Failing on content_unittests

EmptyKeys_1
TwoKeys_1
TwoKeysThenOne_1

on Linux ASAN LSAN

Original issue's description:
> Add Keys() function to ServiceWorkerCache.
>
> Other changes:
> * Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf.  This is used by Match() and Keys().
>
>
> BUG=392621
>
> Committed: https://chromium.googlesource.com/chromium/src/+/02812f0a3edcacca1f7e05ea0a47cb3d8c6025e1

TBR=michaeln@chromium.org,gavinp@chromium.org,jkarlin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621

Review URL: https://codereview.chromium.org/534683002

Cr-Commit-Position: refs/heads/master@{#292970}

BUG=388749

Review URL: https://codereview.chromium.org/520913004

Cr-Commit-Position: refs/heads/master@{#292969}

Updates the type used when delivering accelerometer updates in ash to:
- support a variable number of accelerometers
- be measured in m/s^2
- use axes consistent with the web device motion API.

BUG=380831
TEST=MaximizeModeController unit tests still pass.
TEST=Run on a touchview device and verify that entering / exiting touchview as well as screen rotation still works.

Review URL: https://codereview.chromium.org/500613003

Cr-Commit-Position: refs/heads/master@{#292968}

1. the ruler lines in the "not claire" view on mac is not full width.
2. the title cards on windows has extra padding at the top.

BUG=406618

Review URL: https://codereview.chromium.org/516163003

Cr-Commit-Position: refs/heads/master@{#292967}

BUG=407375
TEST=manual

Review URL: https://codereview.chromium.org/527353002

Cr-Commit-Position: refs/heads/master@{#292966}

This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.

The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.

This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.

To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.

The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.

BUG=377891

Review URL: https://codereview.chromium.org/511283003

Cr-Commit-Position: refs/heads/master@{#292965}

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#292964}

Now that the DMServer has been fixed to accept 'agent' strings longer than
64 characters (http://crbug.com/406948), we can re-lengthen the string
produced by lastchange.py to include both the full git hash and the
Cr-Commit-Position.

R=joaodasilva@chromium.org, scottmg@chromium.org
BUG=406783

Review URL: https://codereview.chromium.org/527103004

Cr-Commit-Position: refs/heads/master@{#292963}

The DataTypeManager now maintains its own status table, which it posts a copy
of on each configuration completion. This makes testing configuration results
easier as we can now just check the type status table, and makes the DTM
more self contained.

To make this work a HistoryDeleteDirectives datatype controller was added to
encapsulate the encryption dependency the type has. Additionally, the PSS
is now able to tell the DTM to reset type errors (e.g. when the user is attempting
to re-configure with or without certain types).

BUG=368834

Review URL: https://codereview.chromium.org/523043005

Cr-Commit-Position: refs/heads/master@{#292962}

Update python API to use mixed case identifier for method to conform to
the chromium python style guide.

R=pkl@chromium.org

Review URL: https://codereview.chromium.org/522483006

Cr-Commit-Position: refs/heads/master@{#292961}

POD members of RequestContentScript::ScriptData weren't being initialized,
which a) is really bad because who knows what they might have been, and b)
is bad because it makes Dr. Memory unhappy.  Fix it (and pull ScriptData into
the .cc while we're at it).

BUG=409865

Review URL: https://codereview.chromium.org/531823002

Cr-Commit-Position: refs/heads/master@{#292960}

-Stop all media playback on an undoable tab close

BUG=388600

Review URL: https://codereview.chromium.org/493253002

Cr-Commit-Position: refs/heads/master@{#292959}

BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/416393003

Cr-Commit-Position: refs/heads/master@{#292958}