- 25 Jul, 2020 40 commits
-
-
John Pham authored
Change-Id: Icf8641dc2aed3f8111ef417f078867e832da24ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316409 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: John Pham <johnp@microsoft.com> Cr-Commit-Position: refs/heads/master@{#791379}
-
Erik Chen authored
Currently, when developing lacros-chrome on a ChromeOS device, passing new arguments requires rebuilding ash-chrome. With this CL, the new flag --lacros-chrome-additional-args can be used to pass flags from ash-chrome directly to lacros-chrome. This means that developers can modify /etc/chrome_dev.conf to pass flags to lacros-chrome without rebuilding ash-chrome. Bug: 1107936 Change-Id: I81d1d51451dce0e256c8c5d5d8e94016b4defa79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316812 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791378}
-
Aaron Colwell authored
This change prevents code from creating RenderProcessHostImpl objects that will reference a BrowserContext that is in the process of shutting down. Since RPHI's reference to a BrowserContext is a raw pointer it is easy to accidentally introduce a potential use after free if an RPHI is created as the BrowserContext is shutting down. The goal of the CHECK is to help detect code that might be trying to create RPHIs at inappropriate times. Also added logic to avoid creating a spare RPHI for BrowserContexts that are in the process of shutting down. This should help mitigate crashes that we are seeing where destruction of the spare appears to be referencing a BrowserContext that has already been destroyed. Added a DWOC on this path to help us detect potentially problematic callers. Bug: 1099998 1038844 Change-Id: I9a02e6f9cf19394a990afe3ca41f7d370ff3e2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317827Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#791377}
-
Wenyu Fu authored
Adding FirstRunAppRestrictionInfo to check if any app restriction exists when first run is necessary. This helper class aims to fire an async background task to fetch the restriction information, and respond to callback that queues for that information. This CL also adds a timing metrics Enterprise.FirstRun.AppRestrictionLoadTime. On local build, the estimate avg is about 13 ms. Bug: 1103476, 1106812 Change-Id: I4013bb9b36ea8b649c39252aef542db0dfdc4786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289210 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#791376}
-
Filip Gorski authored
Adds a ripple definition specific to Incognito and changes where the selectable background is applied to DecoratedSuggestionView and action buttons. We logically have 3 possible sources of selection colors now: * Device light theme based * Device dark theme based * Incognito based (very similar to dark theme, but does not leak attributes). To better manage the 3 possible states this patch introduces OmniboxTheme with values { LIGHT_MODE, DARK_MODE, INCOGNITO }. To better resolve attribute values for the OmniboxTheme, this patch introduces OmniboxResourceProvider. All changes appropriately update USE_DARK_COLORS model property to OMNIBOX_THEME. Bug: 1103291 Change-Id: I14f276274b25b6afa51ed7fbc3661a5437c5b1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288074 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791375}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8e04a7cbf86db06bc70db63e67ca226beb489968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316249Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791374}
-
Dan Harrington authored
The server now supports the correct value of AppType. Bug: 1044139, b/161836372 Change-Id: I61736c827a02e3079a7fe781f9bfda8ded4115af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317000 Auto-Submit: Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#791373}
-
Jia authored
Bug: 1096834 Change-Id: I45f1e5cff11df4c889619f32cff00ed292440a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318845Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791372}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595560196-304c2c3cd13e1a2835ed6d3cda951db2ffc9e342.profdata to chrome-mac-master-1595634856-273b35e9c5e7a1fe88efc52ccb79b7a01140c642.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I44855b7b16bdc100b15b10acd1a93c4d9078fb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317783Reviewed-by:
-
Ian Barkley-Yeung authored
Stop unit test FileEnumerator::GetInfoDotDot from failing on Windows. The unit test is showing a real bug in Windows, but it's not one we can fix, so skip the check on Windows. Fixed: chromium:1108304 Change-Id: Ibf0efa1a18fbd6c9a8008425eb7192f6a5e665a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314816 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#791370}
-
Erik Chen authored
The function CreateGlobalMenuBar() is only used in a block guarded by defined(USE_DBUS_MENU), so the function definition should be guarded by the same flag. Change-Id: I4df2786b0e3dacd29bf4869575c5caf6bea01cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316128 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791369}
-
Peter Kasting authored
* Use temps to replace repeated expressions. * Change name to make clear that it's not always the warning icon. * Return ImageModel so callers can use the size; this fixes a bug where callsites used the wrong size in cases where the "help or error icon" would have been painted. This removes GetWarningIconSize(). This does not yet fix a couple of behavioral oddities around the selection of icons and colors (didn't want to mix noticeable behavior changes with cleanup). I will do that in a subsequent CL. Bug: none Change-Id: I44d5e56ea3729b2bc7c6498cbf32f342068ad77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315218 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791368}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2282feee0a7..342ad5228da2 2020-07-24 jleconte@google.com Add special case in isolate mapping. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: zhanliang@google.com Change-Id: I999e097813651f246c19034e8c33f972478f7bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317121Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791367}
-
Andrew Xu authored
This CL utilizes the mapping between account ids and history clipboard data to handle the multi-user environment. A browser test is created to protect this feature. Bug: 1106857 Change-Id: I76d4d7ee2dc5b9525e4173586df168266a7fbb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310848 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791366}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I426a0e3e61e30c331bc756bb7dc5646c4d65f4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315089Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#791365}
-
Vicky Min authored
For enumeration of serial devices, it is necessary to register an observer using an adapter instance. With the adapter it is also possible to use GetDevices() to get a list of the current discovered devices which should allow serial devices to show up in the serial device chooser. Bug: 1043300 Change-Id: I2bc0263f0f2baaacbdc86b6d97034017dff61412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291316Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Vicky Min <vickymin@google.com> Cr-Commit-Position: refs/heads/master@{#791364}
-
Anupam Snigdha authored
The tests already have |Wait| and |OnSuccess| that would process all the messages required for the tests. Removing these redundant calls to wait for the title changes as this leads to flakiness. Bug: 1108551 Change-Id: Id3bf340b5e02697d8a7c847c31cf1bfddd5b59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316801Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2bda4d1319b4..1d5171690554 2020-07-24 vapier@chromium.org licensing: handle more variations 2020-07-24 vapier@chromium.org sync_chrome: drop --ignore_locks option 2020-07-24 saklein@chromium.org sysroot_lib: Update cros_workon wrapper 2020-07-24 yueherngl@google.com shadowkeep: add signing type for recovery/factory 2020-07-23 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I80e41ba36cdcdb597b277b3b064905663e24b1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316996Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If3f7d7e233928c374a934a90a718189bc1d4afd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318631Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791361}
-
Koji Ishii authored
When r752093 crrev.com/c/2111553 optimized two-pass paints of selected text, it used frame rect. This patch changes it to use ink-overflow instead. Using ink-overflow as is can cause the similar performance regression as crbug.com/1062767. From the investigations on blink_perf.paint/select-all-words, the count of 2-pass paint and average speed vary by: 2-pass Avg Frame rect 29 0.0% 3194.094500003848ms Ink overflow 5585 -8.3% 3457.8985000087414ms Ink overflow w/1px inflation 449 -0.9% 3222.998499998357ms Ink overflow w/2px inflation 14 +0.2% 3186.6954999917652ms This patch uses 1px inflation for the balance between the correctness and the performance. Bug: 1108580 Change-Id: I5584461a5b605c77f457181fa597202fa33c4ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315897Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#791360}
-
Gabriel Charette authored
In particular: A) Don't need to ScheduleWork around Run() in QuitStopsWorkWithNestedRunLoop B) Require GMOCK to verify that all expectations resolve InSequence C) Out-of-band invocations of DoIdleWork should only happen *after* DoWork (unexpected but loosened on OS_IOS for ignored reasons; keeping for now). This is a prerequisite to make the diff smaller for tests in https://chromium-review.googlesource.com/c/chromium/src/+/2226216 Bug: 1074019 Change-Id: I0da743e9a6737433a69cdc81669981833fbe6ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313697 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#791359}
-
Varun Khaneja authored
Fix: remove ChromePasswordManagerClient from the InputEventObserver list on WebContentsDestroyed() and RenderFrameDeleted(). Problem summary: We get an input event when the instance of ChromePasswordManagerClient is invalid. Reading through the code, this probably happens because the CPMC is bound to WebContents, which does get destroyed, but we do not unregister CPMC from the InputEvent observer list. Notes: * This is a speculative fix because I could not reproduce the crash locally. * I am also not sure how to add a test for this condition but I'd be happy to add one with guidance. Bug: 1104919 Change-Id: I3077db25343051c5f2a1e3e905e8abec53556f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309814Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791358}
-
Peter Kotwicz authored
The flakiness is due to the timing-dependent value of TabStateBrowserControlsVisibilityDelegate#calculateVisibilityConstraints() the badly-named #mIsFullscreenWaitingForLoad in particular This CL also switches to using static imports for org.junit.Assert BUG=1108587 Change-Id: I6d87f7b2c0bd4e2402b49f43a2d9a96162f7c4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314993 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791357}
-
David Bertoni authored
This CL splits an existing Cookies API test into two separate tests, which makes the bulk of the original test compatible with a Service Worker-based extension. It also adds that test to the other Cookies API tests that are run for both event page-based and Service Worker- based extensions. Bug: 1093066 Change-Id: If4ee1326a73a1c485d126bab54b2516f2892bc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314876 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791356}
-
Anastasia Helfinstein authored
A bug was recently found where enabling Switch Access on the login screen leads to a series of crashes. This is a short-term fix which prevents the crash by removing the option to enable Switch Access when the login state is NOT_LOGGED_IN. R=katie@chromium.org TBR=skuhne@chromium.org AX-Relnotes: n/a. Bug: 1108808 Change-Id: Ie718cda7aaa8c544b0a0cc49615cd1b802f1d353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316437 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791355}
-
Lei Zhang authored
Bug: 61248,1094093 Change-Id: Id4afed57913d957a5f79e05c1720739d4cbccc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316442Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791354}
-
Avi Drissman authored
In the spirit of macOS Big Sur, which is labeled as macOS 11.0, introduce OS_MAC and OS_APPLE. OS_MACOSX implicitly included OS_IOS, which was confusing, so OS_APPLE is the new replacement for "macOS + iOS" and OS_MAC is the new replacement for "just macOS, not iOS". Bug: 1105907 Change-Id: I0f24ff5a74f07eaf2fe7b7fa17bdef7e82a514fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299189Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791353}
-
Lan Wei authored
Since we will not use this experimental feature to transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the TransferUserActivationFrom function from browser and renderer, which is called from post message to transfer user activation from one frame to the other frame. We will also clean up the frame interfaces in browser/renderer in a follow-up CLs. Bug: 1067307 Change-Id: I10b960f7c68b7267013aa5ac78bab1ca5a1e8b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293181Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#791352}
-
Wez authored
Bug: 1078365 Change-Id: Ic1ebe2dea07d3329e6e66b243ea3261ee3c2a289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309695 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: I93e9d0915abc26c89b2690122199002a0b55404f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311041 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791350}
-
Tomasz Wiszkowski authored
This change addresses the issue where zero suggestions are received ahead of onUrlFocusChange call being completed. As a result, both deferred keyboard popup and subsequent keyboard management may cease to function in the zero prefix state. Bug: 1109330 Change-Id: I5ff5c2ee2103b38ecf9c1b7d8cd53136b1f1a256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318312 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
-
Piotr Pawliczek authored
In mDNS cache, names are compared in standard, case-sensitive way. However, according to RFC 6762 mDNS names are case-insensitive. As a result, chrome cannot resolve mDNS name if it has different capitalization than a corresponding field in mDNS record returned by a device. The only solution seems to be switching mDNS cache to a case-insensitive index. BUG=chromium:1108807 TEST=tested on atlas Change-Id: Ia641e82fd4f175c39d1a80f52b1111238bf50b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315355 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#791348}
-
Yicheng Li authored
This enables developing the dialog and related functionalities without having to worry too much about the view itself. Bug: b:156258540 Change-Id: If0dd36671742d9f2b3c576ef3d4f3a52577356ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298586 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: chromium:1063007 Change-Id: I85fcebe7a0934ee27270756ae02c6a06340bfad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317227 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791346}
-
Aaron Colwell authored
Adding GetPartitionDomain() method to make it easier to determine the partition domain and reduce the need for calls to GetStoragePartitionConfigForSite(). There are a few cases where it is unclear whether the domain computed from the site URL actually matches what was returned by the new method, so these cases now call a new GetPartitionDomain() helper function on SiteInstance. This function preserves legacy behavior and will generate crash dumps if we encounter any situations where the config and storage partition disagree. Bug: 1085275 Change-Id: I4fd02a91cf702f3849010d3723bf7a223b723785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252470 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL adds subtitle to the web sign-in bottom sheet. Screenshot: https://crbug.com/1103328#c3 Bug: 1103328 Change-Id: I0a7bd47e069a9d1440805cb87c5e4e480eb95090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310992Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791344}
-
Piotr Pawliczek authored
Quick fix for a bug introduced in CL:2204269. BUG=none, correction of typo made in other CL TEST=none, will be tested with other CL Change-Id: Ic97ac272545252942eb8f220336f414ac6cf90c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315347 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791343}
-
Andrew Grieve authored
* Refactors more common logic for the three expectation file types into diff_utils.py * Changes sort order for proguard expectations so that they diff better * Output "actual_data" rather than .stamp files for expectation targets * Stop writing out .proguard_configs for all proguard runs * I don't think these files have been referenced for a long time, and the expectations file largely serves their purpose in a more discoverable way. * Don't define validate_expectations GN group unless it will have deps (to prevent thinking your GN args are correct when they are not). Bug: 1064151 Change-Id: I5394471e7defd2c2f7e2f2173097a11d830cde65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314265Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791342}
-
Ilya Sherman authored
This header contains serialized and base64-encoded protocol buffers. This utility simply base64-decodes the serialized data, and then parses the proto via compiled JSPB parsing. THis is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2301121, restricting the new build target to only build on Linux. R=asvitkine, dpranke@google.com CC=mathias@chromium.org, yangguo@chromium.org Bug: 1103854 Change-Id: I30bd4d02f89b250c53c06068ab22e97d7fc279ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316448 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791341}
-
Maksim Sisov authored
Sets touch device list from cmd line only for non-ozone/X11 for now. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Iffc4c78d2911d13ace9cc5661c49b69243a6b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315886Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791340}
-
