- 25 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c1e60dcf1165..4cc54b409feb git log c1e60dcf1165..4cc54b409feb --date=short --first-parent --format='%ad %ae %s' 2020-02-25 capn@google.com Fix Android build after SPIRV-Tools update Created with: gclient setdep -r src/third_party/swiftshader@4cc54b409feb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I980d0f912bf913f8486c21fcdb1e8a3e69b8d897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072379Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744369}
-
Katie D authored
This reverts commit ce64e25e. A fix was made so the title does not change on iOS either. Original change's description: > Adjustments to reader mode view page title on desktop. > > Reader mode view page title now says "Loading..." instead of > "Simplified view" on Desktop before the article title is populated. > > The article title is followed by "- Reader mode" to provide an > indication to screen reader users that they are in a distilled page tab. > > Bug: 1016461 > Change-Id: Ie7ab1ab1e89090e182c4c556bd22878ee876b818 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052487 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744120} Change-Id: I363ada8dfedd60673e46d09d57bab75c88144fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072124 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744368}
-
Chong Gu authored
Remove require_kvm arg from GetDeploymentTargetForArgs. Replace useless no-kvm flag with allow-no-kvm. Bug: 1000906 Change-Id: I6d85d351e4089384721d85f697909b4d9280fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071136 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#744367}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3eb0df2c199c..d2b5e7801939 git log 3eb0df2c199c..d2b5e7801939 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 lanwei@chromium.org Disable InspectorMemoryTest.testGetDOMStats on ChromeOS Created with: gclient setdep -r src/third_party/catapult@d2b5e7801939 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055815 Tbr: sadrul@google.com Change-Id: Ic58dba09d13bfa4794867f02aaf4d681967ab638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072456Reviewed-by:
-
Peter Kasting authored
This replaces the slower, more generic RunAllTasksUntilIdle() and saves code to boot. I thought this might make the tests less flaky, but it turned out to be unrelated to the flakiness I was investigating. Still seems worth doing. Bug: none Change-Id: I66814c7596bac79f1e5b05356a86fd87984983cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071586 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744365}
-
David Black authored
Previous versions of LibAssistant did not implement AddTimeToTimer. Now that they do, we can do away with our previous workaround of cancelling the timer and scheduling a new one. Bug: b:149574352 Change-Id: Icea605a009574ec170c1c725deba2008d32458e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057158 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744364}
-
Xiaocheng Hu authored
CanvasRenderingContext2D stores a font to draw text, but doesn't always update it when the document's font cache is invalidated. In particular, it's not notified when @font-face rules are added or removed. This patch makes CanvasRenderingContext2D to ensure font validity when using the font, by updating the font if it's invalid. Bug: 1051715 Change-Id: I29d89a897b9ccaf14848dab0f33b115f4b3eee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053508Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744363}
-
Jian Cai authored
Pattern initialization has been turned on by http://crrev.com/c/2067928 for Linux, therefore enabled on ChromeOS. There is no need of this variable any more. Bug: 1042451 Change-Id: I30aa3a82ab56dac09f7d41fc0ad8cfed4c43f204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070972Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tiancong Wang <tcwang@google.com> Commit-Queue: Jian Cai <jiancai@google.com> Cr-Commit-Position: refs/heads/master@{#744362}
-
sczs authored
Since infobarModalPresentedFromBanner is called as completion for the Modal presentation, there's a chance the Infobar could've been destroyed by then, if this is the case passwordInfoBarDelegate was set to nil in stop, and we shouldn't call InfobarPresenting. Bug: 1055340 Change-Id: I603b7e6bdbd39094dc7cecea7f0e8084a91b6b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072646Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744361}
-
chrome://flagsJosh Simmons authored
This also changes feature flag behavior so that the PerformanceHintsObserver is enabled when kContextMenuPerformanceInfo is enabled. Enabling the UI without enabling the Observer is not a scenario we're interested in. Bug: 1040661 Change-Id: I4970534ad4b21127ef603955c2b22bb7f5ce40dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067690 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744360}
-
Henrique Nakashima authored
Night mode flags are default enabled and can be removed to simplify the code. Bug: 1012975, 1018268 Change-Id: Ib380598ebcd0ca3ae1b2dc26df8cf7e311219adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070115Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#744359}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I9f682aedcb5c849293aea49090e5895c8e813e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069143 Auto-Submit: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744358}
-
Francois Doray authored
MessagePump::Delegate::DoWork/DoDelayedWork are being removed in favor of DoSomeWork. This CL updates NestedMessagePumpAndroid to use DoSomeWork to unblock that migration. Bug: 885371 Change-Id: I0bd84f9f54f7509f7cbfed985d80ed3c6150f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070330Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
David Grogan authored
Purely bookkeeping, no behavior change or new tests. Bug: 1053825 Change-Id: Idf1eae594c9bb755de2325d023bf1706408c97a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072658 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744356}
-
Chris Cunningham authored
Lots of time outs. BUG=1055853 TBR=tbarzic Change-Id: Iaeeff3379dc445466450c2514312330b58f191da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071962Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744355}
-
Yue Ru Sun authored
Also adding screen info and CPU metric providers, and checked that they populate additional fields on system profile proto. Omitted GPU metric provider because it seems not applicable from here https://cs.chromium.org/chromium/src/components/metrics/BUILD.gn?l=212 Bug: 1046923 Change-Id: I0c291aed07a1743811d47f884e17b049945974c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050673 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#744354}
-
Toni Barzic authored
The shelf widget delegate view, which also acts as a shelf widget's contents view, contains two views - login shelf view, and the drag handle. Currently it uses fill layout manager for layout, which makes sense for login shelf view, but not so much for the drag handle. To avoid drag handle from getting resized to the whole shelf view bounds, the shelf widget resets the delegate view layout manager when session state changes. This works because login shelf and drag handle are mutually exclusive. With new final first user run oobe screen mocks, which may have swipe from shelf gesture enabled, login shelf may require drag handle, which now break with fill layout manager. This CL changes shelf widget delegate view to manage its own layout - it sets the login shelf view to full shelf bounds, and centers the drag handle within the shelf bounds. Also, it makes relationship between delegate view and login shelf view more explicit, as the login view is now added to delegate view using explicit AddLoginShelfView method, instead of using GetContentsView()->AddChildView from shelf widget. BUG=976949 Change-Id: Ic5a26c4ab657194c4cf4dfc5a4473eca4807146e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071289 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744353}
-
Cathy Li authored
Change-Id: Ib77234174ece4facb35596808fd964a18db04311 Bug: 1054944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Patrick Monette authored
This is a temporary check that creates a crash report when a DLL is loaded on a thread with background priority. Once a sufficient number of crashes have been reported, this CL will be reverted. Bug: 973868 Change-Id: Ibb777eb64ada04454f50b080a54cb6d2fc371c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067625Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#744351}
-
Adithya Srinivasan authored
We shouldn't set the portal element's content frame if SubframeLoadingDisabler::CanLoadFrame() returns false, this can lead to discrepancies in the connected subframe count and result in frames not being disconnected. In the test case in this CL, we try inserting a portal into a subtree that is being disconnected. Bug: 1041406 Change-Id: I7e0377392457f5b0ca6537c27cb6a5835b8eedd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002859 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
-
Mythri A authored
It was fixed by this cl but forgot to enable it.: https://chromium-review.googlesource.com/c/chromium/src/+/1988355 Bug: chromium:1037905 Change-Id: I8dc0402e55fc308e957fcfcc8d2562ca96c3ff5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072220Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#744349}
-
Tanmoy Mollik authored
Remove ChromeSigninController and migrate to IdentityManager.GetPrimaryAccount. Bug: 1049640 Change-Id: I5ffeb523335c64826dde84b7d08a16e70ac388e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066760 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#744348}
-
yilkal authored
This cl cleans up old comment. Chrome on Chrome Os and web apps' time limit are going to be set through android chrome's time limit. This is because chrome browser on Chrome Os and android chrome are represented together in the Family Link app. Bug: 1015661 Change-Id: Ib3ac4b0ab6109aba07a7e12c9bbeaf4493d5d68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071140 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#744347}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f00494951f9..7a6db4cbf48b git log 9f00494951f9..7a6db4cbf48b --date=short --first-parent --format='%ad %ae %s' 2020-02-25 benjaminwagner@google.com [infra] Move app installation to install method Created with: gclient setdep -r src/third_party/skia@7a6db4cbf48b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I2f0b9e5ce4ead1ef2fecdaa8ff032c58a81a5e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072448Reviewed-by:
-
Vladimir Levin authored
This patch forces all activatable locks in case of a find-in-page query. This is a stop-gap measure to ensure sites that heavily rely on css-render-subtree for performance can also be used with find-in-page reliably. There is a longer term goal of having a better find-in-page which considers the fact that some layout state might not be available (crbug.com/1045517) However, since it is likely that render-subtree is going to be available before the bug is fixed, we're landing this patch for now. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I67953e2f82910dd8ca52cb3b6d7d4ba99acd82d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065052Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744345}
-
Synthia Islam authored
Relying on GetWindowAndroid() returning a non-null value causes crashes in various instances. With this CL, the window is null-checked before use an creation is deferred to when it's actually used. If creation doesn't succeed on first try (e.g. because the window isn't yet attached), a consecutive call might succeed. This approach also has the advantage that the interface remains clean and doesn't require handling the rare Android failure explicitly. This is acceptable since failing to create the surface means, that the UI isn't ready to show any information anyway or anymore. Bug: 1051034 Change-Id: I8e1e8ea8f3eb8e8d59f9654b4c627365d63316c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067771 Commit-Queue: Synthia Islam <synthia.is@samsung.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#744344}
-
Maksym Onufriienko authored
After XC11.4+ TestHostBundleIdentifier is required key in xctestrun, otherwise tests fail wit error xcodebuild[51335:6042032] [MT] DVTAssertions: ASSERTION FAILURE in /Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-16118.3/IDEFoundation/Testing/IDETestRunSpecification.m:818 (self.bundleIdForTestHost) should not be nil. <IDETestRunSpecification: 0x7fa7b9bcd950> Method: -bundleIdentifierForInstallationTracking Fixed: 1054223 Change-Id: Ie8f7b222d3422a5629c755e05a28701a7e6c2395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065420 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
-
Evan Stade authored
mContainerView is a ViewGroup, but some layout code assumed it was a FrameLayout. Update that code to allow any kind of ViewGroup for which the LayoutParams subclasses MarginLayoutParams (including FrameLayout, RelativeLayout, etc). It would be nice to add an assertion to setContainerView so that failures are caught earlier, but I don't see a clean way to do so. Bug: 1054106 Change-Id: If45a16c2864ef200461a08b783b425ea42346f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067247 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#744342}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4028.0-1580727110-benchmark-81.0.4044.14-r1 to 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifb8f3950402c91f70a11d67cac69eced7f2558cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072605Reviewed-by:
-
Arthur Wang authored
R=bsheedy@chromium.org, harringtond@chromium.org Bug: 1028976 Change-Id: I2633728fb7db20bf736f9f23da3558d9030bfe31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072132Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744340}
-
Koji Ishii authored
TBR=drott@chromium.org Bug: 1054656 Change-Id: Idcdc79682709fafed8ea6255c895133df6449829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072518Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744339}
-
Ian Clelland authored
The format for lists has changed since Draft 13, to allow for both inner and outer list members to carry parameters. (This is directly supporting the needs of the Reporting API). Items now intrinsically have parameters, which are ordered. These will be serialized if present. The allowed token characters are also changed with this CL, the characters "!", "#", "$", "&", "'", "+", "^", "`", "|", and "~" are now allowed in tokens. This CL updates the parser and serializer to support the new format. Bug: 1048752 Change-Id: Ib6a6ffdb497d64cf15601fe4a4fa6601809d4ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037344 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744338}
-
Will Cassella authored
http://crrev/0f21e26 did a mechanical replacement of |TraceWrapperMember| to |Member|, and this comment is no longer relevant (and also doesn't make any sense!) Change-Id: I77b888c5ec1092be392742e0651dafc43bcbe4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067280Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#744337}
-
Benjamin Beaudry authored
This CL is just a simple refactor of AXPlatformNodeTextRangeProviderWin::GetEnclosingElement. It introduces GetLowestAccessibleCommonPlatformNode, which returns the lowest common accessible platform node for a range. I think the refactor makes this method a bit easier to understand. Bug: 928948 Change-Id: Ic8bd371d076505c14961c9ec79ccb43943c5a3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068925Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744336}
-
Guido Urdaneta authored
This test is flaking sometimes with an error message about a nonexisting flag. This removes the attempt to use that flag. This is not the reason the test is flaking, but the message is misleading. Bug: 986021 Change-Id: I847ddee6b63a52b25040c49567de29cad91e2560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071018Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744335}
-
Istiaque Ahmed authored
Currently these paths in content verification is base::FilePath::StringType, which can be unintentionally converted from any base::FilePath. This CL make the concept strong typed, using util::StrongType. This CL also names it with a hint that this is a relative path and not a full path. No behavior changes are expected with this CL. Bug: 1051401 Change-Id: Ib4117e4d2f83e58ae3b294a22b6d7e2720ed5fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059572 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744334}
-
Ted Choc authored
This change: https://chromium-review.googlesource.com/c/chromium/src/+/2065416 introduced an observer method that is called in the ViewAndroid destructor, and thus all observer need to outlive the ViewAndroid or be removed before it is destroyed. The test was not designed for this, so this updates the tests and add some testing for the destroy observer call as well. BUG=1048851 Change-Id: I9eb88eacf1badcd13df168dcf5b264b182ba5062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071107Reviewed-by:
-
Wenyu Fu authored
Starting the HomepageSettings, the RadioButtonGroupHomepagePreference will gain focus automatically and have a highlight background on it. This CL disables the focusableInTouchMode attribute in the xml. Bug: 1052498 Change-Id: If89f92fca8195bd4289648511356a2264a55bbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060657 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
In addition to relanding the original crash fix described below: - Turn extra mac nodes back on, which were temporarily turned off until we could figure out the right fix - Delete table info from the table info map when their nodes are deleted - Clear table info map on shut down When a table is updated, it clears the extra mac nodes. This means the cached _children in BrowserAccessibilityCocoa need to be invalidated. By adding a call to OnAtomicUpdateFinished(), the correct invalidation code path is now executed. It calls OnDataChanged() on each node, which calls childrenChanged() on BrowserAccessibilityCocoa. Bug: 1050598,1054158 Change-Id: I0dbf3c3e77fcaccf530affc17af5703e5466c387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066063 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744331}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b1dd9acac569..c1e60dcf1165 git log b1dd9acac569..c1e60dcf1165 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 srisser@google.com Log instead of warn of unsupported extensions Created with: gclient setdep -r src/third_party/swiftshader@c1e60dcf1165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Icb06f4c5a831bbe3d834e994d3219f2d5da7f3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072443Reviewed-by:
-
