- 15 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a29a9947ac96..ab76e332de7a git log a29a9947ac96..ab76e332de7a --date=short --no-merges --format='%ad %ae %s' 2018-11-15 fjhenigman@users.noreply.github.com Validate uniform variable type in Vulkan (#1949) (#2055) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab76e332de7a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I02a75ed134e8af75a34bc2793b5757226ee4b2de Reviewed-on: https://chromium-review.googlesource.com/c/1338148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30746749adb0..5ccf40a90be8 Created with: gclient setdep -r src-internal@5ccf40a90be8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1190a2165c8e4bb31be6080a7c782ef9942aa66c Reviewed-on: https://chromium-review.googlesource.com/c/1337642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608496}
-
Sunny Sachanandani authored
Video surface output rect didn't take rotation into account so when SurfaceAggregator would stretch content to fill bounds, it would end up with the wrong scaling factors (squash in one dimension and expand in another) since the surface quad's bounds (in the embedder) were rotated. To work around this (or by accident), VideoFrameResourceProvider was passing the rotated size as the quad's rect which doesn't make sense intuitively. This also worked by accident with DirectComposition overlays because of applying another scaling which would fix the aspect ratio again. This change makes it possible to use the |quad_to_target_transform| as is, without having to apply an aspect ratio correcting scaling, and to assume that the quad's rect is in the pre-transform space. Bug: 904035 Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 Reviewed-on: https://chromium-review.googlesource.com/c/1334971Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#608495}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2585eafdcba3..2aa7e8cbc413 git log 2585eafdcba3..2aa7e8cbc413 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 tsepez@chromium.org Revert "Track indirect object holder in more CPDF_ objects." 2018-11-15 thestig@chromium.org Revert "Slightly simplify CPDF_FontEncoding::Realize()." 2018-11-15 tsepez@chromium.org Revert "Make orphaning old objects automatic during dictionary set/removal." 2018-11-15 tsepez@chromium.org Speculative fix for unit test failure under code coverage 2018-11-15 thestig@chromium.org Remove some inactive OWNERS. 2018-11-15 tsepez@chromium.org Better tests for AFSpecial_Format(). 2018-11-14 tsepez@chromium.org Process XFA preamble by inclusion rather than hard-coded strings 2018-11-14 thestig@chromium.org Avoid writing out empty streams in CPDF_Stream::WriteTo(). 2018-11-14 thestig@chromium.org Slightly simplify CPDF_FontEncoding::Realize(). 2018-11-14 tsepez@chromium.org Make orphaning old objects automatic during dictionary set/removal. 2018-11-14 tsepez@chromium.org Process XFA config by inclusion in place of hard coded strings 2018-11-14 tsepez@chromium.org Process XFA locale by inclusion rather than hard-coded string. 2018-11-14 tsepez@chromium.org Track indirect object holder in more CPDF_ objects. 2018-11-14 thestig@chromium.org Add some basic CPDF_PSEngine tests. Created with: gclient setdep -r src/third_party/pdfium@2aa7e8cbc413 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:901654,chromium:905142,chromium:901654 TBR=dsinclair@chromium.org Change-Id: Id92cee32fc92da023a16e1bd5fe2e24b0752dbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1337641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608494}
-
Brian White authored
Some enumerations have only a single entry of 0 (which is technically an "underflow"). Support this by changing the maximum from 1 to 2. Bug: 904964 Change-Id: If81522c55da292948f6a04cc51077111200537f1 Reviewed-on: https://chromium-review.googlesource.com/c/1336208Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#608493}
-
Michael Thiessen authored
Introduces a new Activity type to replace ChromeTabbedActivity when running on a device with no touch input. Bug: 904993 Change-Id: I8d9496fdb21735141b74135be3dc975a08c3e850 Reviewed-on: https://chromium-review.googlesource.com/c/1313556 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608492}
-
Robbie McElrath authored
This reverts commit 21f4d499. Reason for revert: crbug.com/905619 Original change's description: > Reland "Get NetworkChangeNotifier working on ChromeOS with network service." > > This is identical to crrev.com/c/1329897, but the underlying issue that > caused that CL to break unit tests was fixed in crrev.com/c/1336066. > > Original change's description: > > Get NetworkChangeNotifier working on ChromeOS with network service. > > > > The current NetworkChangeNotifierChromeOS implementation won't work > > with the network service enabled because it listens for network changes > > from Shill, which only supports a single client. The browser process > > has other dependencies on Shill, so it has to be the client for the time > > being, meaning the network service can't directly listen for network > > changes and has to be notified of them from the browser process. > > > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > > the first will live in the browser process and listen to Shill, while > > the second is the actual NetworkChangeNotifierChromeOS implementation > > which will have an instance in both the browser and network processes. > > Since NetworkChangeNotifierChromeOS can't actually listen for network > > changes itself, it just gets notified of changes from part 1 via a new > > method in NetworkChangeManager. When the thing listening to Shill sees > > a network change, it notifies its local NetworkChangeNotifierChromeOS > > instance, and calls the new NetworkChangeManager method, the > > implementation of which then notifies the network service's > > NetworkChangeNotifierChromeOS instance. > > > > Bug: 882610 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606665} > > Bug: 882610 > Change-Id: I05ecbac510b479eb28520cc0b0ad5b613519fab7 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/1336154 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608265} TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org Change-Id: I0bda42c81a1e445c9d530576d8b6f75630d0c0d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882610 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1338204Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#608491}
-
Becky Zhou authored
Bug: 900755 Change-Id: I07ed1f9e3bc27ff617b0f7d0f22ec5ac9ba22608 Reviewed-on: https://chromium-review.googlesource.com/c/1337069Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608490}
-
Tom Tan authored
Bug: 893460 Change-Id: I40d49723dc53ee45178c95698f05d8cecc040097 Reviewed-on: https://chromium-review.googlesource.com/c/1318059 Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608489}
-
Theresa authored
Creates a new TopToolbarCoordinator to sit between ToolbarManager and ToolbarLayout. TopToolbarCoordinator implements the Toolbar interface and acts as the public message channel to other UI components. The API surface in TopToolbarCoordinator is quite large currently. Future CLs will attempt to slim the API surface. BUG=897294 Change-Id: Ic16df5946f3373ecbea4a1f3e908c05086b2dbc1 Reviewed-on: https://chromium-review.googlesource.com/c/1336081 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#608488}
-
Ella Ge authored
TBR=alph@chromium.org Bug: 905772 Change-Id: Ide0a5695213b14266e154dab9bbf0103f86713b8 Reviewed-on: https://chromium-review.googlesource.com/c/1338321Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608487}
-
Mythri Alle authored
This add layout tests to ensure javascript code caching is working as expected. This also adds virtual tests with ( --enable-features=IsolatedCodeCache --site-per-process) to test that the isolated code cache is behaving as expected. These tests test that: 1. code cache is created on the second visit to the script 2. code cache is consumed on the third visit to the script 3. code cache for the same script resource is not reused if requested from a different origin (for the virtual tests). This also adds a timeout expectation for the failing tests. Bug: chromium:879494 Change-Id: I4b5b4cdce1f9dbccf31ba24f5efee2683b5a0579 Reviewed-on: https://chromium-review.googlesource.com/c/1329561Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#608486}
-
Ella Ge authored
add MSAN expectation TBR=robertma@chromium.org Bug: 856601 Change-Id: Idb002c64071199228cb2b5881e1e773de0325fbc Reviewed-on: https://chromium-review.googlesource.com/c/1338299Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608485}
-
Quan Nguyen authored
Removes another stateful component of LoginBubble to make it easier to refactor in subsequent CLs. Bug: 905512 Change-Id: If3dca30e9bb531ca1acb829e79db07be6f86d3d8 Reviewed-on: https://chromium-review.googlesource.com/c/1336969 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#608484}
-
Joshua Bell authored
If unspecified (in headers or content), resources like HTML in iframes fall back to the parent's encoding. This should not be the case for XML/JSON which have well-defined defaults. Bug: 904017 Change-Id: I42f8950c5c2ef63c98bcec58a1f4b0bd0b190c33 Reviewed-on: https://chromium-review.googlesource.com/c/1331953Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608483}
-
Kristi Park authored
Fix attribution floating above the custom link toast notification. Bug: 851296 Change-Id: Ibcf9ae6e48f89d6a7fece3fa79455d4004bece05 Reviewed-on: https://chromium-review.googlesource.com/c/1336668 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608482}
-
Jun Cai authored
The "Initial upload" patch of this CL is the same as: https://chromium-review.googlesource.com/c/chromium/src/+/1320710 The above original CL was reverted at: https://chromium-review.googlesource.com/c/chromium/src/+/1324104 The revert is caused by a browser test failure: ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange and more details can be found in the following bug link: https://bugs.chromium.org/p/chromium/issues/detail?id=902784 The browser test failure is fixed at: https://chromium-review.googlesource.com/c/chromium/src/+/1336433 So this CL is exactly the same as the "Initial upload". TBR=olivierrobin@chromium.org, michaelbai@chromium.org, jam@chromium.org, fdoray@chromium.org, asvitkine@chromium.org Bug: 883121 Change-Id: I253764764b409e7c6d1522fd5e5d44927c3f3c60 Reviewed-on: https://chromium-review.googlesource.com/c/1323658 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608481}
-
Dmitry Gozman authored
We inline LoadNavigationErrorPage to the callsites and drop "Internal" from LoadNavigationErrorPageInternal. Bug: none Change-Id: I0d6e8cb2dfe42dca981763d3e00063558a6c81f4 Reviewed-on: https://chromium-review.googlesource.com/c/1332706 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608480}
-
Nicolas Pena authored
At TPAC, we agreed that 'script' is confusing because it implies that longtasks only measure script work. Thus, we decided to change the name to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47. Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833 Reviewed-on: https://chromium-review.googlesource.com/c/1336367Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3acb8c133fa..666818eacf79 git log f3acb8c133fa..666818eacf79 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 jmadill@chromium.org Use angle::Result in front-end (Part 8) Created with: gclient setdep -r src/third_party/angle@666818eacf79 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5e67d545fd9e3d7a4a0f41fe0f01772a6eb5e6c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337483Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608478}
-
bsheedy authored
Updates the string used to set the paired viewer to Daydream View during VR tests. It was getting set to this version anytime an NFC scan occurred, causing image diff tests to fail depending on which subset of tests were run due to slightly different render sizes being reported by VrCore. TBR=billorr@chromium.org Bug: 904012 Change-Id: I4ce031ffc0a5fba3abbe59a5d33dff1e5a416885 Reviewed-on: https://chromium-review.googlesource.com/c/1338224Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608477}
-
Elly Fong-Jones authored
Bug: None Change-Id: I5efda82d931dee0c6da98e17d68240a10f5eb885 Reviewed-on: https://chromium-review.googlesource.com/c/1337791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abaffd85abb7..005fdd4ec834 git log abaffd85abb7..005fdd4ec834 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3fc6893c8b24..8f20452b0219 (1 commits) 2018-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3acb8c133fa..666818eacf79 (1 commits) 2018-11-15 csmartdalton@google.com sksl: Add support for 2x2 matrix inversions in Metal 2018-11-15 egdaniel@google.com Add flag to force purge resources from cache as soon as possible. 2018-11-15 mtklein@google.com remove mention of 16-bit shader procs 2018-11-15 brianosman@google.com Use GrVertexWriter in GrLatticeOp Created with: gclient setdep -r src/third_party/skia@005fdd4ec834 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ife7a2224be73c96d0a7583e4a3096764115aa51c Reviewed-on: https://chromium-review.googlesource.com/c/1338146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608475}
-
Regan Hsu authored
We are launching the new multi-device services and removing the old functionality. As part of the internal cleanup, we are removing references to kMultiDeviceApi from MessageTransferOperation - as the functionality it entails will become the default action - and removing code that relies on old methods. Many of the tests that rely on fake classes that mimic old functionality fail. As a result, this CL disables those tests. Bug: 905151 Change-Id: I9ad4572431afe9e659e1a82edf878b09d3734367 Reviewed-on: https://chromium-review.googlesource.com/c/1328163 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#608474}
-
Joe Downing authored
This CL replaces the confusing, generic, platform provided permission dialog on Mojave with one which provides more context and instructions on what the user needs to do to enable Chrome Remote Desktop on Mojave. Bug: 902041 Change-Id: Ibda9459dfba3579c596cf5e2703b8c3d0ea28059 Reviewed-on: https://chromium-review.googlesource.com/c/1334838Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608473}
-
Tom Tan authored
Disable IAT hooks on Windows ARM64 for the same reason as Windows X64. IAT virtual address is 4 bytes in length and insufficient to hook to arbitrary 64-bit address. Bug: 893460 Change-Id: I05b607737e07e12a318f261366a59c8ed1a52782 Reviewed-on: https://chromium-review.googlesource.com/c/1337294Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#608472}
-
Yuki Awano authored
Bug: b/119523533 Test: steps described in the bug Change-Id: I87d594d3655cd0de86a9a783eb9e5fc9ba2665c4 Reviewed-on: https://chromium-review.googlesource.com/c/1337221Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#608471}
-
Vladimir Levin authored
This patch adds ability to delay style until display lock is committed. However, once committed it will go through all the phases and display contents synchronously. It adds the ability for the DisplayLockContext to keep track of the current state, making it easier to reason about what should happen next. As well, it adds a lifecycle update state to keep track of which lifecycle stage should occur next. This is a stepping stone towards a correct solution. R=chrishtr@chromium.org Bug: 882663 Change-Id: I660e81d9cd30604883f8f4971920a1bb19dafe67 Reviewed-on: https://chromium-review.googlesource.com/c/1334656Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608470}
-
mark a. foltz authored
This updates the task posted to check the Windows firewall settings to CONTINUE_ON_SHUTDOWN, to fix a shutdown hang. Bug: 902821 Change-Id: I4f261db1d08a075f39422f7c553394e2a95624ea Reviewed-on: https://chromium-review.googlesource.com/c/1336915Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608469}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I1691063eecb6fa423bc36c21a910adcf21f00da8 Reviewed-on: https://chromium-review.googlesource.com/c/1338108Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608468}
-
Tatiana Buldina authored
Disable WindowTest.testSetsTheSizeOfTheCurrentWindowFromIframe Remove tests from _REVISION_READY_TO_RUN_FILTER Bug: chromedriver:2661 Change-Id: Ibe170f821790be7cdadac10432f7f967b2692e1c Reviewed-on: https://chromium-review.googlesource.com/c/1335107Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#608467}
-
Kevin Ellis authored
This patch fixes the problem where subtle changes to numerical values in matrix interpolation cause mismatches in the expected results. To address the issue: * Styles are checked to see if they are of the form matrix(...) or matrix3d(...). * If the style is a matrix, then arguments are rounded and the style is reconstructed. Bug: 797472 Change-Id: I44d6e0ed13e24dc2ecfeeacbcd4809d6dcdb6465 Reviewed-on: https://chromium-review.googlesource.com/c/1337640Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#608466}
-
Charlie Harrison authored
This test currently waits 30s before completing. This CL speeds it up by injecting a TestMockTimeTaskRunner and using it to fast forward time. Bug: 896787 Change-Id: I35cb9ea8f269bfa1a9d2cb35858e3fd697a41ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1334289 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608465}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a06bf8506fdf..f0db2e2ef5d2 git log a06bf8506fdf..f0db2e2ef5d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 eladalon@webrtc.org nit: Missing space in build_overrides/build.gni 2018-11-15 alessiob@webrtc.org AGC2 flags: remove deprecated fields. Created with: gclient setdep -r src/third_party/webrtc@f0db2e2ef5d2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id1eb83a2d950366ba06c5e49a0914be33c61f038 Reviewed-on: https://chromium-review.googlesource.com/c/1338119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608464}
-
Jonathan Backer authored
Bug: 905511 Change-Id: I1d37cb900749085384c6abcb2e0b9d8224f0a190 Reviewed-on: https://chromium-review.googlesource.com/c/1338160Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608463}
-
Javier Ernesto Flores Robles authored
Hide card and address icons when no data is available. Show them again if data becomes available. Bug: 845472, 905650 Change-Id: If0420746b2df8fd3ebbbbd8dff6524eb326cef7c Reviewed-on: https://chromium-review.googlesource.com/c/1335570 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608462}
-
Javier Ernesto Flores Robles authored
This is the string that UX and the Translation team agreed upon. Bug: 878388 Change-Id: Ibd42ebb2068cac63283389ff50f161baa29d85b9 Reviewed-on: https://chromium-review.googlesource.com/c/1338179Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608461}
-
Lei Zhang authored
- Prefix global with "g_". - Return std::string() consistently. - Remove an #else block that is not necessary. Change-Id: I15017665a37c2010db7bed02a37ebfb4c18a083f Reviewed-on: https://chromium-review.googlesource.com/c/1336514Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608460}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32a6bd7b54fd..30746749adb0 Created with: gclient setdep -r src-internal@30746749adb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I054d86018ec340e1376725ac4f893086b826f34f Reviewed-on: https://chromium-review.googlesource.com/c/1338121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608459}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/144f1014..68fee3ed Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21e04c24617338747d44ec6e60450b93191c9220 Reviewed-on: https://chromium-review.googlesource.com/c/1338172Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608458}
-