- 20 Mar, 2020 40 commits
-
-
Rushan Suleymanov authored
This patch removes old logic of setting cache GUID for old clients which had no this field. Clients must have set this field after one and a half years. Clients that haven't migrated will remove sync metadata (treat as cache guid mismatch) and go through download and merge procedure. There is one more little change: ConnectIfReady is removed from OnPendingDataLoaded because it does nothing and seems to be obsolete. Bug: 947044 Change-Id: I72a441c5ed9bfa2d77a58494aaa2181a1df54d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062277 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752072}
-
George Steel authored
Set the OperationType in TransformOperation::Blend() according so that it is a 3D operation type iff either of the blended values are (previous behavior was to use the second value and ignore the first). This makes Is3DOperation() work for interpolated operations stops z values getting dropped during serialization. Bug: 1057307 Change-Id: Ibcbb3125660ab172a0f65f08b8ccd67534cdd665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102640Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752071}
-
David Van Cleve authored
NetworkContext currently owns a trust token store that is constructed asynchronously; it has a TrustTokenStore*-typed getter that returns null until the store is ready. This change adds a "pending" class that allows enqueuing operations against the store, to be executed as soon as the store is ready, so that clients of the store can use the same asynchronous interface all the time, rather than having to check if the store exists or not. Bug: 1042962 Change-Id: Ib1c6e2a24f5db6796dd7033824e9b6dcf227a050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110474Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#752070}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65a94404..542f8a10 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I39550ed6b02001582b78507da9b1112065a8ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752069}
-
Vladimir Levin authored
As part of the resolution from https://github.com/WICG/display-locking/issues/139 we decided that we should use the contained size information when determining what to scroll into view. In the code, this means we shouldn't activate the element on scrollIntoView and rely on viewport intersection instead. Note that hidden-matchable now (correctly) doesn't unhide. R=chrishtr@chromium.org Change-Id: I9336868ddace68b85e6da4b99ad02ad2f9aa1314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109815Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#752068}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I2c6d78fcaef48db306ac16f6f37d1bb92b954419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112238Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752067}
-
rbpotter authored
Bug: 1026426 Change-Id: Ib3b12943d0186861a4b2dfc74981626bdec19d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111766Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752066}
-
Mathias Bynens authored
CL that temporarily disabled these tests: https://chromium-review.googlesource.com/c/chromium/src/+/2111179 DevTools front-end CL that modified the behavior: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112361 Bug: chromium:1056588 Change-Id: Ic73c42cae0497111e86564c7a347c84ae32508bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112550Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#752065}
-
Bettina authored
If the UX is not ready, there is no place to manually set the enhanced protection for testing. The command line pref store allows mapping a command line flag with a pref. Bug: 1063110 Change-Id: Ib1bef9a8fd01e7db43aeb29c96b7865893206089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111054Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#752064}
-
Ilya Sherman authored
According to the UMA.TruncatedEvents.UserAction.Type histogram, this is one of the most commonly dropped user actions, so we're not getting good data about this event regardless. R=dmazzoni@chromium.org Bug: none Change-Id: Ib43171563b6208a5fbb4402bc1ee6d77275ab41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110398 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Khushal authored
We shouldn't be parsing json data from untrusted sources in the GPU process. For this reason we allow skottie objects to be used only by the GpuChannel associated with the browser process. Fix an error in enforcing this. R=malaykeshav@chromium.org Bug: 894635 Change-Id: If5b0bfb3c95b7475e735b0b74e69d8c1cf533020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112334 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#752062}
-
rajendrant authored
Adds a browser test so that coverage ukm is recorded in both the modes of enabling and disabling the actual image redirection. Bug: 1047330 Change-Id: I97cfaa27f3089fc0d909c1357a3a3fa6b5c8405a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111784Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#752061}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f845b816079e..d423d43a0f50 git log f845b816079e..d423d43a0f50 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 jiancai@google.com chromite: disable DebugInfoTest for non-toolchain builders. 2020-03-19 pfagerburg@chromium.org lib/git: add grep option to git.Log 2020-03-19 cjmcdonald@chromium.org Mark test with pytestmark_output_test Created with: gclient setdep -r src/third_party/chromite@d423d43a0f50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I87595ee5ee9acc518e565c9c6dee045e785bfa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752060}
-
Francois Doray authored
This is a partial reland of https://crrev.com/c/chromium/src/+/2062692. We confirmed that the CL affected startup metrics on Mac. However, our assessment is that the change is correct (restored tabs are painted before non-restored tabs more often). As a precaution, the original CL is split in two: - Start loading restored tabs earlier (https://crrev.com/c/chromium/src/+/2095970) - Enforce stricter requirements in FirstWebContentsProfiler (this CL) Original change description: On Windows, a visible restored tab starts loading in the following stack, before FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewAura::UpdateWebContentsVisibility ... BrowserView::Show SessionRestoreImpl::ShowBrowser SessionRestoreImpl::RestoreTab SessionRestoreImpl::RestoreTabsToBrowser SessionRestoreImpl::ProcessSessionWindows SessionRestoreImpl::ProcessSessionWindowsAndNotify SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun On Mac, it starts loading in the following stack, after FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewMac::OnWindowVisibilityChanged -[WebContentsViewCocoa updateWebContentsVisibility] -[WebContentsViewCocoa windowChangedOcclusionState:] ... base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run ... ChromeBrowserMainParts::MainMessageLoopRun This prevents FirstWebContentsProfiler from having strict cross-platform expectations about events it observes. With this CL, we ensure that visible restored tab start loading in the following stack on all platforms: content::NavigationControllerImpl::LoadIfNecessary chrome::`anonymous namespace'::CreateRestoredTab chrome::AddRestoredTab ... SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun This allows us to enforce strict cross-platform expectations about events observed by FirstWebContentsProfiler, and also have the nice benefits that navigation isn't delayed until we get a window visibility update during a Mac session restore. Bug: 1035419, 1020549, 1022492 Change-Id: I6885f0fc667423bc55cdc201c9ada4dca167ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097368Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#752059}
-
Robert Kaplow authored
Change-Id: I9d2ee1ddea4a1a8e0f392147813b5b68d925f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108344Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#752058}
-
Robert Sesek authored
Bug: 1063349 Change-Id: Ib6c8f119d81a1158bcea66e83e6074c03ed376c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112236Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752057}
-
Elly Fong-Jones authored
This change makes HistoryMenuBridgeTest and HistoryMenuCocoaControllerTest subclasses of BrowserWithTestWindowTest rather than CocoaProfileTest. It also fixes one subtle lifetime problem in the former - it left a dangling HistoryObserver at the test end, which was exposed by BWTWT's more defined teardown behavior. It also created a history DB on disk needlessly, which made the tests pretty flaky for me in local use; it now uses a memory DB instead. Bug: 39725 Change-Id: If4683d2baee146a071002a2dd9e1eb0d933d48f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108960Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752056}
-
Elly Fong-Jones authored
Instead, have them use BrowserWithTestWindowTest, CocoaTestHelper, and the template URL service directly. Bug: 39725 Change-Id: I641c5641e7791758bd0445a843679f421a3c089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112240Reviewed-by:
-
Dave Tapuska authored
The test is testing the return code of vibration not being supported. Some browsers (chromium) implement a user-activation check first. Ensure that a click is simulated first before executing the rest of the test. Change-Id: I960cb568be31b718f773a940271b9eb7d745416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110074 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#752054}
-
Daniel Rubery authored
Bug: 1058431, 1060367 Change-Id: Iccbcf2a53787019e92e9de24c0d2f4862a93e227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110077Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#752053}
-
John Lee authored
Bug: 973674 Change-Id: I479ce1fe1a3d2114bf3dd54c873a43e8b257b72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109039 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752052}
-
Mark Schillaci authored
This CL expands on the work completed in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2070232 Here we expand the work to only include the AccessibilityNodeInfo actions when a node is user scrollable, not just scrollable in general (e.g. only programmatically scrollable). We have added checks to IsScrollable() for all of our directional CanScroll...() checks, ensuring that we aren't looking strictly at position but whether or not the node is user scrollable. b/150010542 Change-Id: I70a9a30b62e165bda01fd05ea4f3513727065d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106534 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2090794 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2108452 Fixed for reland: Added missing route string MANAGE_PROFILE back in settings_routes.js Original Description: Before this CL, routes for both browser and OS where in routes.js file. This CL removes routes for chromeOS to a new file os_settings_routes.js also updates references to SettingsRoutes to OSSettingsRoutes in all chromeOS files. Fixed: 967861 Change-Id: I566d2ea4edf475151ac8374a4c5dfe578dd1c58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110450Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#752050}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d03f6fcf682..0ca7c30ca910 Created with: gclient setdep -r src-internal@0ca7c30ca910 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046374,chromium:1057652 Tbr: jbudorick@google.com Change-Id: I44c6c228dab2ff9b1f843f12a1553fb2161b1949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752049}
-
Andrew Grieve authored
They were causing all commands to fail with: swarming: googleapi: Error 400: request.env_prefixes[u'PATH'] conflicts with pool's template Was able to run base_unittests without them, so guessing they are no longer needed. Change-Id: If7a1992cb98ac96e056be0565b9d0430e498eb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111652Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752048}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I885c7dc96bcd4410c288156344f017e130414071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111315Reviewed-by:
-
Rainhard Findling authored
* When the user clicks the run safety check button, the parent element is focused, without it having a tabstop. This prevents the focus from getting lost and is part of a11y for safety check. * This is a follow-up and improvement to crrev.com/c/2106089. * DD: http://shortn/_uEauSbBMVy Bug: 1015841 Change-Id: I5f7f418769c6908e3c7bcc3c81fe8c497ac1edb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107988 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed744e295fb9..fbd89afae121 git log ed744e295fb9..fbd89afae121 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 mathias@chromium.org Fix DOCTYPE casing in Elements panel 2020-03-20 sigurds@chromium.org Add affected resources for cookies to the Issues 2020-03-20 mathias@chromium.org Simplify test lists 2020-03-20 mathias@chromium.org Remove mkdirp helper 2020-03-20 szuend@chromium.org Typecheck sdk/ServerTiming.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@fbd89afae121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1056588 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id4c07ba2a11b6a1487dffdb94fc22fd6fb7a3322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112611Reviewed-by:
-
Maciek Kumorek authored
Move UUID definitions of the ICompleteStatus and IUpdaterObserver to the BUILD.gn file so it can be customized by adopters. Change-Id: Ia265adba9853cbfc1c6c34d1bba73b54e2fa2c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111278 Auto-Submit: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752044}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1c9f24263e6c..22d73d15e778 git log 1c9f24263e6c..22d73d15e778 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 amaiorano@google.com Subzero: fix CoroutineBegin generation Created with: gclient setdep -r src/third_party/swiftshader@22d73d15e778 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I73877d46ceeeed4c1b8aa850829e65ce08279c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112522Reviewed-by:
-
Daniel Libby authored
This reverts commit 8337e5aa. Reason for revert: Pausing feature-like work while release cycles are pending. Original change's description: > Add support for drawImageRect-based directly composited images > > Directly composited images is a feature that rasterizes images at their > intrinsic size, when an image is the only thing drawn into a layer. > However, this determination is today made prior to painting the image > in blink, which can't be done with CompositeAfterPaint enabled. > > This CL adds support for detecting PictureLayers that qualify as directly > composited images, by analyzing the paint ops of the display item list. > If a single drawImageRect paint op is detected (with some facilities for > detecting images for which orientation is respected), then we'll > propagate the image's intrinsic size over to PictureLayerImpl on commit. > PictureLayerImpl then uses that information to calculate a raster scale > that results in the image being rasterized at its intrinsic size. > > There are a few additional changes needed outside that core calculation. > If the aspect ratio of the layer bounds does not match the image's > aspect ratio, we won't raster the image at the intrinsic size, but > instead will choose the scale from one dimension. In these cases, we will > choose to re-raster when the layer is resized until the layer bounds > aspect ratio matches that of the image. > If we do adjust the raster scale and add tilings to the active tree > (as is seen in the default configuration for web_tests), we should drop > the previous tilings (which are now non-ideal) since the max raster scale > tile will be chosen when the SharedQuadState is created during > AppendQuads. > We also need to tell the LayerImpl if nearest neighbor should be used > when the TileDrawQuad is scaled in the display compositor to preserve > the same output of the original drawImageRect. > > Bug: 875110 > > Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#751891} TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com Change-Id: If186501c3756808f2b92a150debd8a4abea3e8cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112577Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752042}
-
Tricia Crichton authored
During InitSession calls, add a timeout when ChromeDriver is requesting initial connection details from Chrome. This will protect against waiting indefinitely when Chrome is unresponsive. Bug: chromedriver:2520 Change-Id: Ie160118a4b281e2651ab7f155a4cd36b740f1c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110813Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752041}
-
Andrew Grieve authored
Convenient to see status of running jobs. Change-Id: Ia9b04280889aed581f9b08bca6321e57aff30bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112110Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/835dde17a0c9..976cc1ae1901 git log 835dde17a0c9..976cc1ae1901 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 danilchap@webrtc.org Add AV1 encoder wrapper 2020-03-20 peah@webrtc.org Changed fft4g to be built as C++ 2020-03-20 saza@webrtc.org Add empty placeholder target for rms_level.* 2020-03-20 brandtr@webrtc.org libvpx-vp8: Add settings struct to constructor. Created with: gclient setdep -r src/third_party/webrtc@976cc1ae1901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1105c30d78bebcb0fbaf6ab41d3f1db083c9a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112526Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/12a1c373822e..2709f40f3f23 git log 12a1c373822e..2709f40f3f23 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 xiaoxuan.liu@arm.com Skip updating viewport and scissor info if the same Created with: gclient setdep -r src/third_party/angle@2709f40f3f23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I96b389968d22b8fdeda3c07077f3a633f0c3fa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112519Reviewed-by:
-
Livvie Lin authored
Adding OWNERS file listing people who have recently been working on the interstitial code and have more familiarity than OWNERS listed in ios/chrome. Change-Id: Ifacb6852d7c765f304b47ed2ddbed5fa3a5c6b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111355Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752037}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/69c5dd70e796..e5753d2fb87e git log 69c5dd70e796..e5753d2fb87e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 cwallez@chromium.org Enable (and fix) the DeviceLost tests on Metal Created with: gclient setdep -r src/third_party/dawn@e5753d2fb87e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Icfc92a9397e56cf3dd82a9dd5c6b3e083b631b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112524Reviewed-by:
-
Andrew Grieve authored
Support recently added to resource_sizes.py in 6d51b2ee Bug: 1059928 Change-Id: I2bdcdd4a1c4f3b4ad3517443363b3a40383dc6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111787Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752035}
-
arthursonzogni authored
TBR=yhirano@chromium.org Bug: None Change-Id: Ib4ef9bb1903d6cf54b65f909f7b242c5bdbe8cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110024Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#752034}
-
Nicholas Verne authored
Bug: 1062113 Change-Id: I7c2f9b00f3a5a0385b534fe20f50a9f20321b3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105663 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#752033}
-
