GitLab

This is a reland of 88854e15

Original change's description:
> Whitelist Imprivata extensions for networking.onc API
> 
> Whitelisting the Imprivata extensions so that they can send their local
> IP + MAC address to the Imprivata server, which are being used in the
> Imprivata admin consoleto assign the device to a specific "site" and
> also to assign computer policies to specific devices.
> 
> Bug: 1075877
> Change-Id: Id3a14b2ac5618dfcbc6c476da555153792debe57
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169888
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768029}

Bug: 1075877
Change-Id: I73fcce371de0568ea470ca518b856b8e52ba1914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203376
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769060}

Introduce a new BrowserControlsStateProvider interface and migrate
ChromeFullscreenManager to use this interface where possible. Subsequent
CLs will add additional browser controls interfaces for APIs with more
controlled access (e.g. browser controls visibility manipulation).

BUG=995914

Change-Id: Ia9654d45e8ffcb1c683215ceec35bb174bd093cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198117
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769059}

https://swiftshader.googlesource.com/SwiftShader.git/+log/d748e1651af8..c9625f1660da

git log d748e1651af8..c9625f1660da --date=short --first-parent --format='%ad %ae %s'
2020-05-14 srisser@google.com Fix asserts due to missing texture formats

Created with:
  gclient setdep -r src/third_party/swiftshader@c9625f1660da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I3330a594db6aa7672fad6efff09993f36cf6e514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202494Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769058}

This CL highlights the section header row when the user tabs to the
associated chevron button.

The implementation looks kind of big to do something so simple, but
given our exotic / bespoke focus model, I couldn't do it smaller.

Bug: 1078183, 1052522
Change-Id: Ibffd26183b5f182bf42a874797bf161187476759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202669
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769057}

This reverts commit 525a4a22.

Reason for revert:

Fixed missing @end

Original change's description:
> Revert "[ios] Reduce pointer boilerplate in Credential Provider"
>
> This reverts commit ca2e472b.
>
> Reason for revert: breaks compile, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/4247?
>
> Original change's description:
> > [ios] Reduce pointer boilerplate in Credential Provider
> >
> > crrev.com/c/2199891 introduces a reusable class for pointer
> > interactions for non-button views. This class internally handles
> > all the delegate callbacks. So usage is simplified to a single line.
> >
> > This CL should have no impact/change on the UI.
> >
> > Bug: 1073961
> > Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: edchin <edchin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#768924}
>
> TBR=edchin@chromium.org,javierrobles@chromium.org
>
> Change-Id: Ib4e9c99203d3dbb673d49f302b342d2055561b3d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1073961
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203138
> Reviewed-by: Dana Fried <dfried@google.com>
> Commit-Queue: Dana Fried <dfried@google.com>
> Cr-Commit-Position: refs/heads/master@{#768987}

TBR=edchin@chromium.org,javierrobles@chromium.org,dfried@google.com

# Not skipping CQ checks because this is a reland.

TBR=javierrobles@chromium.org

Bug: 1073961
Change-Id: I8534dd58ff1f7ba9f2ad2567bea894ed200b8597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202687
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769056}

The address of the local proxy is sent via a dbus signal when a local
proxy worker becomes active. The local proxy url is sent to the system
services on Chrome OS via Chrome's proxy resolution service. System
services will connect to the local proxy and the local proxy will setup
the connection through the remote web proxy and perform proxy
authentication on behalf of the CrOS services.

BUG=chromium:1042642
TEST=browser_test ProxyResolutionServiceProviderSystemProxyPolicyTest

Change-Id: I73a1c36bb265cba7e6dce0c59431d010a3f096ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192655
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Michael Ershov <miersh@google.com>
Reviewed-by: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#769055}

This CL adds histogram and user action UMA metrics for supervised
users using the Extension Install and Parent Permission Dialogs to
install extensions. There are also histograms for tracking how much
time the user spends on these two dialogs.

Bug: 1022620
Change-Id: I24436d8c6548577f18baa098481192c2d750d395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181226Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769054}

blink.mojom.LocalFrameHost and blink.mojom.RemoteFrameHost are
the target mojo interfaces.

Similarly to https://crrev.com/c/2111133, this CL added a lookup method
RenderFrameHostImpl::FromFrameToken, similarly to RenderProxyHostImpl's.

Also, this conversion has allowed a couple of layer to be eliminated in
the existing flow:

Previously
- <callees>
- LocalFrameClient
- WebLocalFrameClient
- RenderFrameImpl
- old IPC

Now
- <callees>
- LocalFrame|RemoteFrame
- mojo IPC

Note that this CL did not migrated FrameMsg_UpdateOpener IPC together
with it. It will be done in a follow up step, either as a mojo
completion callback (ie using the => construction from the mojo syntax)
or as an independent mojo message.

BUG=1051144

Change-Id: Id379a120899212d93841fce5ec2542273a8632fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196860
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769053}

Third-party themes can configure the styling (e.g. tiling, placement) of
their background images. To support that, this CL adds a new
chrome-untrusted://new-tab-page/custom_background_image helper that
behaves similar to chrome-untrusted://new-tab-page/background_image but
allows for custom styling. The custom styles can be passed via URL
query params. Internally, this new helper uses the same HTML as
background_image. However, background_image sets the styles to the
values we have used previously for first-party background images.

The styling properties are passed to the NTP JS via mojo. And the JS
forwards the styling to the custom_background_image helper. That way
first- and third-party themes share as much code as possible.

Bug: 1081441
Change-Id: I943806aa9ab61c402217f8658ce548a9b85a435f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202502
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769052}

Bug: 1002391
Change-Id: I592eb1d0482da82b78f47b8e8f69b85211494515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203076
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769051}

They are flaky on many CQ bots, regardless of composite-after-paint:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=external%2Fwpt%2Fhtml%2Fuser-activation%2Fconsumption-crossorigin.sub.tentative.html%20external%2Fwpt%2Fhtml%2Fuser-activation%2Fnavigation-state-reset-crossorigin.sub.tentative.html%20%20external%2Fwpt%2Fhtml%2Fuser-activation%2Fpropagation-crossorigin.sub.tentative.html

Move the failure expectations from composite-after-paint into
TestExpectations.

TBR=mustaq@chromium.org

Bug: 1064422, 1066178, 1066190
Change-Id: Iffa9df6e6607f85772d65d2969e3d0964790fe30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203276Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769050}

https://webrtc.googlesource.com/src.git/+log/37120ab59d1f..42748d8e22aa

git log 37120ab59d1f..42748d8e22aa --date=short --first-parent --format='%ad %ae %s'
2020-05-14 danilchap@webrtc.org In rtc_base/ and api/ replace mock macros with unified MOCK_METHOD macro
2020-05-14 marinaciocea@webrtc.org Add GetMetadata() to TransformableVideoFrameInterface API.
2020-05-14 danilchap@webrtc.org In video/ replace mock macros with unified MOCK_METHOD macro

Created with:
  gclient setdep -r src/third_party/webrtc@42748d8e22aa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1069295
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I65ff4f414633216d520483d57e7a8c8c650f2423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769049}

This function was only used for overlay interstitial, and is dead code
now.

Bug: 1076947, 1077074
Change-Id: Ieb208b0c617852cc8f74402ffed89d02d4e7219a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202675
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769048}

Catches CalledProcessErrors when running Intel Power Gadget during GPU
tests and logs its output before re-raising the exception. This is so
that we can get more useful information about the failure than just the
exit code.

Bug: 1079387
Change-Id: I1da82b0772643a3161966d052682239617f0ff81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202940
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769047}

Bug: 1025603
Change-Id: I48762b17e485ba636e880525dfda63324955330c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202963
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769046}

We want to turn CheckTranslationScreenshots into an error, but allow
developers to skip it without skipping all presubmit tests (e.g. because
they are external contributors and don't have access to the images).

We make it possible to skip this check by setting
`Skip-Translation-Screenshots-Check: True` as a git footer. See this
commit message as an example.

Bug: 1082901
Skip-Translation-Screenshots-Check: True
Change-Id: I3c6572b59611ba7cfd2da4a6498b973d8e0e2233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203180Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769045}

- Added response code/error code/manager status/fetcher status
metrics in backend.


Bug: 1068683
Change-Id: Ia55c2daca5c937f8ebd6c5a3864d45cb74458d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200253
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769044}

The widget assumes ownership of the notification view in
NotificationViewMDTest.

Effort was also made to remove as many direct pointers to the widget
as possible to demonstrate the linkage.

BUG=1044687

Change-Id: I010d2cf742c043b5e257f22abb6a4688e3707877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203019
Commit-Queue: Tim Song <tengs@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769043}

This CL also updates the expiry dates of existing system tray metrics.

BUG=1073536

Change-Id: I9dc40194004415ab0eb22be26009eb50cef0aca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198539Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769042}

A previous bug fix resulted in the path being trimmed from the URL
shown in PageInfo on Android. This CL fixes that bug.

Bug: 1082051
Change-Id: I193d7e044d412504478f3240ed94464c13c26f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199989Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769041}

kNewSearchFeatures is a kill switch intended for a long-term holdback of
all search-related launches. See https://crrev.com/c/2132641 and
https://crrev.com/c/2161357 for earlier uses of this Feature.

Bug: 1073606
Change-Id: Ic9ea4394892496c43c6096b22d8236a031f4db6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202119
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769040}

The logging flow for simple doodles looks as follows:
1. On image load -> fetch image_impression_log_url and download
                    additional params for later logging.
2. On image click -> open on_click_url with image_click_params from 1.
                     appended.
3. On doodle share -> ping gen_204 url with share_id from 1. appended.

For animated doodles the flow is:
1. On CTA load (i.e. preview image) -> same as 1. for simple doodles.
2. On CTA click -> ping interaction_log_url from 1.
3. On animation load -> same as 1. but with
                        animation_impression_log_url.
4. On animation click -> same as 2. for simple doodles but with
                         image_click_params from 3. here.
5. On doodle share -> same as for simle doodles but with share_id from
                      either 1 or 3 depending on when sharing.

JS drives the logic for these flows since it owns the required state.
However, JS cannot make the network requests directly since it lives in
a WebUI process. Therefore, JS delegates networking to the browser
process through mojo.

Fixed: 1070762
Change-Id: I786a9cf977d7bce978ab9ccfa4d6e9b00c616656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200420Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769039}

panel_rotation() is the difference between the buffer and hardware's
scanlines as opposed to rotation() which is the "logical" uprightness
of the screen. This matters on devices where the logical orientation
does not match the hardware orientation.

There are two cases where exo uses the wrong rotation which means:
 - cursor images are drawn in the wrong orientation
 - the screen orientation is reported incorrectly to clients. This is
   ~fine~ until you start using applications which refuse to handle
   events which are "offscreen".

We model this CL after changes in crrev.com/c/1911344.

Bug: 1081085
Change-Id: Ia3a01b8dd5d745dbdb6a5b2220cae44061088a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195341Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#769038}

The removal of the UI->IO thread hop in r768133 seems to cause some tests in the PFQ to flake. Add extra hops (now UI->IO->UI) to avoid flakiness in the PFQ. This should be reverted once the test issue is tracked down.

Bug: 1082298

Change-Id: I64e3e27461a73bf269c8193d9d5c7a65cb3a072a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202671
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769037}

https://chromium.googlesource.com/angle/angle.git/+log/ce925b4cbe60..fecd1afcb287

git log ce925b4cbe60..fecd1afcb287 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 timvp@google.com Vulkan: Move necessary members from ProgramState to ProgramExecutable
2020-05-14 timvp@google.com Update Program[Pipeline]State to hold a ProgramExecutable Pointer
2020-05-14 ianelliott@google.com Vulkan: Create a test to debug Android pre-rotation

Created with:
  gclient setdep -r src/third_party/angle@fecd1afcb287

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: geofflang@chromium.org
Change-Id: I4de870579b5bc5e895341756dcb99becd715e4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202485Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769036}

Scenarios that we are interested in:
 - how often is the popup exceeding the owner window bounds
 - how often does the popup receive tap/mouse down/ mouse wheel events
outside the owner window bounds

This CL has no user visible behavior changes.

Bug: 1066241
Change-Id: I0f88e75b452a2c7490045b31f0b9e773314a2d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200425
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769035}

copyFromChannel can produce overlapping areas when the source array is
the same as the channel data array.  Use memmove instead of memcpy to
handle this case.  copyToChannel has the same issue, so fix that too.

Manually tested the repro case with a local asan build.  The issue no
longer reproduces.

Bug: 1081722
Change-Id: I168ef418fccf45646bb4d8a01c22cecfbd5da20b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202394Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769034}

We want to be able to run a VA-API driver in Constant
Quantization Parameter mode for vp9 encoding.
VaapiVideoEncodeAccelerator needs to tell VP9Encoder about the
bitrate control.
This CL adds enum of BitrateControl in AcceleratedVideoEncoder
interface so that VaapiVEA can configure vp9 encoder with the
enum.

Bug: 1060775
Test: video.EncodeAccel.*
Change-Id: I16db7bafcee0642e71bc36ef3e2bce257e33c7b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159669Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769033}

This was causing some -Wshadow compiler errors in Chromecast builds.

Change-Id: I2ebdd629e3472302db5d4d05e340c89223d690eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197490Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Auto-Submit: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#769032}

This will be used by upcoming frame and process priority logic.

BUG=1077217

Change-Id: I817a8af44306598d1294068042b924c7832d434a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199397
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769031}

Bug: 1082919
Change-Id: Ia90e3bd3d428d941842147dcb5dce8440f16b5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202389
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769030}

The started NSPs are just normal for now, but thru future CLs will be
migrated over to a privacy-preserving context.

Adds a command line flag to gate this functionality during development.

Bug: 1082505
Change-Id: I7c4095787c12c210a4fdcb00b553ee69f28dcd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200176
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769029}

This CL modifies MediaCodec path to get use real coded_size and
visible_rect in VideoFrame instead of relying on texture matrix
transform.

To achieve this we utilize similar approach as in YCbCrHelper.
Helper is renamed to FrameInfoHelper. During CreateVideoFrame
VideoFrameFactoryImpl will check if it has cached FrameInfo for
current visible size that comes from media codec. If not it
will post task to FrameInfoHelper to get it. To avoid
unnecessary frame renders FrameInfoHelper also does similar
caching. If info is not cached it will Render frame early to
get the info.

To be able render frame before creation CodecImage and
SharedImageVideo the render logic is extracted from CodecImage
to CodecOutputBufferRenderer.

Bug: 1076564
Change-Id: I5baac124f46d78a89ae4300d5a01a9b9ab04af2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196922Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769028}

This makes it consistent with our other vector icons in the dialog,
which were vectorized.
Does not modify other uses of the print icon.

Change-Id: If76259efef1d8b5e50fa204fd6ea3ba17a18efc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194941Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769027}

Doing so is a DEPS violation. We now move the contents into a portal in
the caller and then pass the portal.

Bug: 1076947
Change-Id: I2aab34bceaf786c65b5b3521ecce7147a9f51d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202528
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769026}

Context:
Devguides suggest against doing any concrete things in constructor
since it's harder to test and prone to reading confusion.

Before:
IsReadyToPayServiceHelper did the service binding in the constructor.

After:
IsReadyToPayServiceHelper did the service binding in query().

Change:
* Move the service binding part from constructor to query().


Change-Id: Ibbc9adae00e64e01cbf1fe15298736b3d83d7950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198651
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769025}

Add a specialization of the settings overridden dialog for extensions
that override the New Tab Page. This involves adding a generic
controller for the settings overridden dialog to handle extension-
controlled settings (which will be re-used for additional controlled
settings) and an NTP-specific provider to handle the NTP bits.

Add unit tests for both the NTP-specific provider and the generic
extension-controlled settings dialog controller, and a UI browser
test for the NTP overridden dialog.

Currently, this is only used in testing; it is not hooked up to any
production codepaths.

Bug: 1079364
Change-Id: I1f360bd603b6514fb492acc0b065d1b6d5236a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186642Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769024}

This is follow up to the CL
https://chromium.googlesource.com/chromium/src.git/+/c26b06c7500c2ecf63b138ed893edf3c89faad77

Bug: 1050838
Change-Id: I48ce1674a96ede2bfc9b66293195c7eaac6b5e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194483Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769023}

Bug: 1008483

Change-Id: Ic8f47c6038fa8cc0a375731b179542fd56ba1eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202681
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769022}

Make AwNonembeddedUmaRecorder an implementation of the
base.metrics.UmaRecorder interface and set it as a delegate in the
CacheUmaRecorder during the startup of WebView non-embedded process.
This will make using RecordHistogram class possible inside WebView
non-embedded processes.

Bug: 1001185
Test: out/Debug/bin/run_webview_instrumentation_test_apk
Test: out/Debug/bin/run_android_webview_junit_tests
Change-Id: Ia324f30f45a334a61bf46a1bf64d69715ad7118a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176771
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769021}