- 19 Sep, 2018 40 commits
-
-
Jérôme Lebel authored
Adding 3 histograms to track issues related to -[WKHTTPCookieStore getAllCookies:]. Those histograms are used by crrev.com/i/678070. + Signin.SSOWKWebView.GetAllCookies.Request: Tracks start and end for each call. + Signin.SSOWKWebView.GetAllCookies.CookieCount: Counts the number of cookies returned by the call. + Signin.SSOWKWebView.GetAllCookies.Duration: Tracks the time waited until the callback is called. Bug: 880981 Change-Id: I8223febe436b15d53a64a52b33a88768f0d41a8b Reviewed-on: https://chromium-review.googlesource.com/1228179 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#592366}
-
Manuel Rego Casasnovas authored
Many of them are failing due to different issues, some already known and some news bugs that have been reported. In the TestExpectations entries the bugs related to each test have been linked. Change-Id: I38a307927758e30bfe16d9c763deb24c88c412c6 Reviewed-on: https://chromium-review.googlesource.com/1233555Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#592365}
-
Greg Thompson authored
This CL migrates the final callers of BrowserDistribution::GetStateKey to install_static::GetClientStateKeyPath. As a result, BrowserDistribution and AppRegistrationData no longer have any consumers. This allows for removal of them and related classes (including Product). Additionally, this CL contains a few small cleanups such as removing the dead IsChromeActivelyUsed function and gently massaging some function parameters. BUG=879568 Change-Id: Id4957b9e269706678c84ea2fac8c24c490a99b0f Reviewed-on: https://chromium-review.googlesource.com/1230016 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592364}
-
Matt Falkenhagen authored
This adds a ?client variant to navigation-redirect.https.html, which does a lot of redirect tests. This tests the following: - resultingClientId is the id of the client, if one was created via that request. - get(resultingClientId) for requests that did not create a client resolves with undefined. - resultingClientId is reset on cross-origin redirects. - Client.url is the creation URL. Bug: 778497 Change-Id: I08387e96a97df4656d800637862b67b7c8466e14 Reviewed-on: https://chromium-review.googlesource.com/1206054Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592363}
-
Marcin Wiacek authored
Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef form: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface There are also done one or two trivial code formatting changes... Change-Id: I0763d62db7f93b418baf3e608f8b230ed0773be4 Reviewed-on: https://chromium-review.googlesource.com/1215202 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#592362}
-
Han Leon authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1214709, now we send GetClient Mojo message from within Blink, no longer need the GetCallback (one subclass of WebServiceWorkerClientCallbacks) to help cross the boundary of Content and Blink. The follow-up CL (part 2) will remove blink::NavigateClientCallback (another subclass of WebServiceWorkerClientCallbacks), then remove WebServiceWorkerClientCallbacks completely. BUG=879019 Change-Id: Ib2c469fc7f7476bd734e14c42850bb16266e37b6 Reviewed-on: https://chromium-review.googlesource.com/1227618 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592361}
-
Yi Su authored
Add metric for Copy Image via context menu. ImageCopier will record when user copies image, and relevant events happen during the Copy Image procedure like alerts popping up or user canceling the copy. Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I611852404fc564595b530f4e2afba7a45c6a20b4 Reviewed-on: https://chromium-review.googlesource.com/1215704 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592360}
-
Patrik Höglund authored
This temporary waterfall is because I'm rewriting all the configs while also porting chromium.webrtc.fyi to LUCI. It will be removed later. The configs are just copies from chromium.webrtc.fyi. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibe26cdf714a7048f90373dfc0a7eec8ddcead1e2 Reviewed-on: https://chromium-review.googlesource.com/1230023Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#592359}
-
A Olsen authored
DeviceOAuth2TokenServiceFactory has an undesirable dependency on g_browser_process. It uses it to obtain LocalState and SharedURLLoaderFactory. This CL removes the dependency on g_browser_process by passing in these dependencies explicitly. Note that the tests still depend on TestingBrowserProcess - this dependency will also be removed in a follow up CL (for tests in the settings package). See go/cros-untangle2 Bug: 446937 Change-Id: I9a046b04175bef6b5af0945d03b03fe1e777fb90 Reviewed-on: https://chromium-review.googlesource.com/1228153 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592358}
-
Colin Blundell authored
It's no longer used after https://chromium-review.googlesource.com/c/chromium/src/+/1224790. Bug: 883722 Change-Id: Ie55a7941fca82f6558cd2f2ecf0a65f2b345b701 Reviewed-on: https://chromium-review.googlesource.com/1224792Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#592357}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01f04032. With Chromium commits locally applied on WPT: 87da8d40 "[Background Fetch] Miscellaneous cleanups." 29028a2d "[css-tables] Force layout when colgroups are removed or added" 66a74d2f "Revert "[css-tables] Force layout when colgroups are removed or added"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24832 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor jfernandez@igalia.com: external/wpt/css/css-align NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib82ef8fef99b6188c5fc2ef96f75476f1b5d808b Reviewed-on: https://chromium-review.googlesource.com/1233124 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#592356}
-
Luciano Pacheco authored
When a folder is renamed all its children entries in the DirectoryTree gets stale, because their |fullPath| property are outdated. Change DirectoryTreeNamingController to force update the renamed folder's children, so they have the new |fullPath|. This fix the linked bug because when navigating to children folder the breadcrumbs is generated based on |fullPath|. Bug: 885328 Change-Id: I02c39d5289454243d2996d765d5631e17e08b31e Reviewed-on: https://chromium-review.googlesource.com/1233274 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#592355}
-
David Jean authored
Bug: 885088 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5d11b0b736b1b040674aef1911ca8a9510e9402c Reviewed-on: https://chromium-review.googlesource.com/1230676 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592354}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fbd3c8eb530..69f640ec0900 git log 2fbd3c8eb530..69f640ec0900 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 machenbach@chromium.org [buildbucket] Fix printing build url Created with: gclient setdep -r src/third_party/depot_tools@69f640ec0900 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:711249 TBR=agable@chromium.org Change-Id: I1bf30df417fec0219431a849f3274e45e039d985 Reviewed-on: https://chromium-review.googlesource.com/1232630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592353}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a8d9e908573..0e67e094d0bb Created with: gclient setdep -r src-internal@0e67e094d0bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idf607c2ba76b3a9cc4aa7569dbbc1042193f4948 Reviewed-on: https://chromium-review.googlesource.com/1232631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592352}
-
Fredrik Söderquist authored
This gets rid of a non-trivial (exit-time-)destructor. Previously a (null) String was returned, but it seems that returning an empty ("") String is more appropriate (if this is reached at all.) Change-Id: Iba329053ea463883b41000ccb9970b3025da1ae7 Reviewed-on: https://chromium-review.googlesource.com/1230736Reviewed-by:Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#592351}
-
Gauthier Ambard authored
This CL changes the way the fullscreen resizer is compensating the frame changes by updating the content offset of the scroll view. When the WebState is set up the first time, the content offset shouldn't be updated. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibface28fd9d0459c411aa74de6bb3075c62eb004 Reviewed-on: https://chromium-review.googlesource.com/1225981 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592350}
-
Gauthier Ambard authored
The scrolling offset of the WKWebView should be handled in the FullscreenResizer, not in Web when the flag is enabled. This wasn't the case before because the flag was created in the middle of the refactoring of the existing function. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I89675ee01c43fe8eecda56f690d08ffb4eabe263 Reviewed-on: https://chromium-review.googlesource.com/1196368 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592349}
-
Han Leon authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1214709, now we send GetClients Mojo message from within Blink, no longer need this WebServiceWorkerClientsCallbacks to cross boundary of Content and Blink. BUG=879019 Change-Id: Ib9025f188708d0d2bb8088c4ead21a7aebe3b65c Reviewed-on: https://chromium-review.googlesource.com/1226813 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592348}
-
Han Leon authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1214709, now we send SkipWaiting Mojo message from within Blink, no longer need this WebServiceWorkerSkipWaitingCallbacks to cross boundary of Content and Blink. BUG=879019 Change-Id: I0c945c3f75713163fce65b6ebed67e117e0f1b34 Reviewed-on: https://chromium-review.googlesource.com/1226810Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#592347}
-
Guido Urdaneta authored
Bug: 860311 Change-Id: I4b2eb3e2c1230ed9388f7e6452d3aa57c9faf61a Reviewed-on: https://chromium-review.googlesource.com/1224050 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592346}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc8fb9374e0a..5c72f28d1a3f git log dc8fb9374e0a..5c72f28d1a3f --date=short --no-merges --format='%ad %ae %s' 2018-09-19 jgilbert@mozilla.com Remove unused include global_state.h from validationEGL.cpp. Created with: gclient setdep -r src/third_party/angle@5c72f28d1a3f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibc49bfc532af95ba4dc99d44679a78b898d32021 Reviewed-on: https://chromium-review.googlesource.com/1232629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592345}
-
Patrik Höglund authored
It turns out that's how it works in the old waterfall, so let's keep doing that. Bug: 877018 Change-Id: If3132684e299a8b090e4b9ed82b3f5be1cb7fe74 Reviewed-on: https://chromium-review.googlesource.com/1230061Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#592344}
-
David Jean authored
Added slide in-out cancel button to the password search field. Added replacing 'Enter' on OSK (On-Screen-Keyboard) by 'Search'. Added constraints which hold when rotating device. Search not focused: https://drive.google.com/file/d/1SVrSJuKEzPTaJUx4dhsNBI6WRPltLkg1/view?usp=sharing Search focused: https://drive.google.com/file/d/13jF7BBE1gP0jmKgONVSA4JSnF9oikisY/view?usp=sharing Bug: 883807, 885092 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56ebf32b57a90c6f4ddc622eb9f192a48bcd3d1e Reviewed-on: https://chromium-review.googlesource.com/1225879 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592343}
-
Koji Ishii authored
compositing/massive-scale-interest-rect.html No longer different from the base, removed flag-specific. compositing/geometry/transfrom-origin-on-zero-size-layer.html Matches better to the base, but text width differ by 1px. Probably from the recent fix for outline thanks to atotic. TBR=eae@chromium.org, mstensho@chromium.org, atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie51a265cb21a277e09878de300ea3625620efb6d Reviewed-on: https://chromium-review.googlesource.com/1233099 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#592342}
-
Matthew Cary authored
Bug: 885071 TBR: pasko@chromium.org Change-Id: I6596edbcf5e8828f1e03b9f0404edb7a9dfaf6e0 Reviewed-on: https://chromium-review.googlesource.com/1233355Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592341}
-
Gauthier Ambard authored
This CL fixes the fullscreen implementation living outside of web for the NTP and other scrolling issues on web page. It also fixes the animation of the resizing when the animator is triggered. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a13b88af6808472ef84ef6902c75c398451c961 Reviewed-on: https://chromium-review.googlesource.com/1195487Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592340}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetFirstInlineFragment()| to call |NGAbstractInlineTextBox::WillDestroy()| if |NGAbstractInlineTextBox| is created so far, to reduce iterating over inline fragments for improving speed of |SetFirstInlineFragment()|. Change-Id: I025a6ae97314247d9e528054ecf77f42a0227142 Reviewed-on: https://chromium-review.googlesource.com/1229674 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#592339}
-
Koji Ishii authored
Unskip "virtual/android" for LayoutNG as these tests seem to be relevant for crbug.com/870008. This directory was marked to skip in r499723. TBR=mstensho@chromium.org, atotic@chromium.org, cbiesinger@chromium.org NOTRY=true Bug: 870008 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I37094e5174ba1941ae9d927d5462a0985b1ade7a Reviewed-on: https://chromium-review.googlesource.com/1233273Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#592338}
-
Matthew Cary authored
Bug: 885071 TBR: pasko@chromium.org Change-Id: Ic0407e2bf97c98db7324099812874645e087ea37 Reviewed-on: https://chromium-review.googlesource.com/1233335Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592337}
-
Fredrik Söderquist authored
This eliminates an exit-time destructor. Change-Id: I18e3d7a9bd965c6898ba31c110b993258503a2d4 Reviewed-on: https://chromium-review.googlesource.com/1230737 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592336}
-
Fredrik Söderquist authored
Change-Id: Ibb54621a413f1928a04498dae65a1ae5f3e48361 Reviewed-on: https://chromium-review.googlesource.com/1230716Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#592335}
-
Richard Li authored
The ultimate target of this work is moving fetch_api_request.mojom into third_party/blink/public/mojom/fetch/ folder. To accomplish the goal, the whole work is seperated into six parts. 1. Remove content::RequestContextType. Use blink.mojom.RequestContextType instead. -------- This CL 2. Remove content::ServiceWorkerFetchRequest. Use blink.mojom.FetchAPIRequest instead. 3. Remove blink::WebURLRequest::RequestContext. Use blink.mojom.RequestContextType instead. 4. Remove blink::WebServiceWorkerRequest. Use blink.mojom.FetchAPIRequest instead. 5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy instead. --------- CL:1212345 6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer instead. Once all the above tasks get done, fetch_api_request.mojom can be moved into that folder. Change-Id: Id9bbac8f67a7aa511a0c642ddd5e9a837dcdd4cd Reviewed-on: https://chromium-review.googlesource.com/1229704 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#592334}
-
Dominic Battre authored
Fix typo in disabling WebRtcGetUserMediaBrowserTest.SrcObjectReplaceInactiveTracks TBR=xiyuan@chromium.org Bug: 848330 Change-Id: I13e2a7883b06a930bd0e6fe7e6f3cce9b3f0563f Reviewed-on: https://chromium-review.googlesource.com/1233194Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#592333}
-
yoshiki iguchi authored
Previously, a long press is cancelled only by swipe scroll. This CL adds the same logic for scroll by mouse. Bug: 869345 Test: manual Change-Id: Iefef9847b9b6bcfbaa5cb528d90e3a0ce978e34c Reviewed-on: https://chromium-review.googlesource.com/1220947Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#592332}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77900be4e71e..2fbd3c8eb530 git log 77900be4e71e..2fbd3c8eb530 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2fbd3c8eb530 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I176157613895b42c4c78ce854286e6b4ffab2997 Reviewed-on: https://chromium-review.googlesource.com/1232628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592331}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00df84c3a8a5..2a8d9e908573 Created with: gclient setdep -r src-internal@2a8d9e908573 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6b513a8cdc675dd2bc62201431e6f5bd59b62e80 Reviewed-on: https://chromium-review.googlesource.com/1232627Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592330}
-
BUG=762641 TBR=stevenjb@google.com, tbarzic@google.com Change-Id: I5d6abf6b4902219d8ae17471253e09dbba64175d Reviewed-on: https://chromium-review.googlesource.com/1233293Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592329}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I558cbdeb55f3abdcd4f4fa95f4694c495512f91a Reviewed-on: https://chromium-review.googlesource.com/1229739Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592328}
-
Joel Hockey authored
Renamed: ui/file_manager/file_manager/foreground/js/VolumeManagerWrapper to ui/file_manager/base/js/FilteredVolumeManager Bug: 884107 Change-Id: Iece36d99f152be1f921c8a20d428415ee0921acb Reviewed-on: https://chromium-review.googlesource.com/1229740 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592327}
-