GitLab

Previously, only PluginPowerSaverBrowserTest had access to the ability
to await the placeholder to be ready.

Now that we want to do this for a PDF placeholder browser test as well,
move this functionality to a test support class.

This is patch 1/3 for this objective.

Bug: 887752, 879149, 878871
Change-Id: Ib0bc70f21d25ec35874025c0952f7c42555fce5b
Reviewed-on: https://chromium-review.googlesource.com/c/1335781
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608399}

If the min/max parameters are really fubar, such as which might come
from a malicious IPC message, min & max can be limited only to then
be swapped and become invalid.  Do the swap first.

Also, remove duplicate bucket-limit condition and set the defined
maximum to be the lower of the two.

Bug: 905226
Change-Id: If73e97e43e93704f93456da6af0708422fa145a0
Reviewed-on: https://chromium-review.googlesource.com/c/1335731
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608398}

This CL puts all pieces together making sure that received messages
get persisted if Chrome is in the background, and replayed next
time it comes to the foreground.

Bug: 882887
Change-Id: I3dea0aa3ad9a01a7f4d59c5b798a018488980beb
Reviewed-on: https://chromium-review.googlesource.com/c/1276608
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608397}

Fixes the following two browser tests for UAv2:
- ExtensionBindingsApiTest.UserGestureFromExtensionMessageTest
- MessagingApiTest.MessagingUserGesture

Bug: 860509
Change-Id: I3a70c3d3fa7a6dd8351422399193e9b49c63bd0d
Reviewed-on: https://chromium-review.googlesource.com/c/1335782Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608396}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7e03047837c..d09518789d3f


git log a7e03047837c..d09518789d3f --date=short --no-merges --format='%ad %ae %s'
2018-11-15 manojgupta@chromium.org Revert "generic_stages: temporarily ignore all target prebuilts."


Created with:
  gclient setdep -r src/third_party/chromite@d09518789d3f

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8036c02397e31dfef707f1ddb597d01d1f24bef6
Reviewed-on: https://chromium-review.googlesource.com/c/1337531Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608395}

This is possible now that Android P SDK is in Chromium.
The direct calls are placed in an ApiHelper class to avoid ART runtime
verification issues.

Change-Id: I88cf7788006aaa63b708a16f52aad00132e28c05
Reviewed-on: https://chromium-review.googlesource.com/c/1335874Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608394}

Test: Built and Run with Android N(on Cast Master) changes (Cast + setup) on the AT1
Bug: 118437285
Change-Id: Iff72a2a2d8eabda619940a256bab1b23daf00c26
Reviewed-on: https://chromium-review.googlesource.com/c/1331579
Commit-Queue: Elvin L <elvin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608393}

This reverts commit bcc4146d.

Reason for revert: android.webkit.cts.WebViewStartupTest#testCookieManagerBlockingUiThread is consistently failing.

Bug: 905025

Original change's description:
> [TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview
> 
> base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
> explicit counterpart.
> 
> It should have been replaced by :
>  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
>  * base::ScopedAllowBaseSyncPrimitives in non-test files
>  * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
>    that don't allow blocking
> The last one is strongly frowned upon but this CL aims to document existing
> behavior rather than address it. Owners are encouraged to follow-up by fixing
> unnecessary waits and more particularly unnecessary waits
> outside-blocking-scope.
> 
> Note: The non-for-testing versions require friend'ing in thread_restrictions.h
> but care was taken to add these friends ahead of git cl split (since it wasn't
> possible to do a line-by-line associated CL split).
> Refer to the top-level CL if necessary :
> https://chromium-review.googlesource.com/c/chromium/src/+/1288533
> 
> Please CQ if LGTY!
> 
> This CL was uploaded by git cl split.
> 
> R=​torne@chromium.org
> 
> Bug: 766678
> Change-Id: I30e57cb0d9a0b1a449a4227561e97ea330ff6a12
> Reviewed-on: https://chromium-review.googlesource.com/c/1325195
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607674}

TBR=gab@chromium.org,torne@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 766678
Change-Id: If1ee0994f4387786662d7814617b297939b4dffb
Reviewed-on: https://chromium-review.googlesource.com/c/1337637Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608392}

This patch ensures that we don't early out under requires_clear when
doing OOP raster. If we early out, and we were doing a partial raster,
then we might end up with previous content on the texture.

R=enne@chromium.org, piman@chromium.org

Bug: 901897
Change-Id: I9e74e7f5b04d14385b733df50b08e027f5e6d1d3
Reviewed-on: https://chromium-review.googlesource.com/c/1335662
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608391}

Add implementation and test for PrimaryAccountMutatorImpl
methods {Set,Is}SettingPrimaryAccountAllowed.

Bug: 889902, 806778
Change-Id: Ibd75f2b3a988b4c403eab3b682a157e31e4b2e18
Reviewed-on: https://chromium-review.googlesource.com/c/1335937Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608390}

Make arrow key navigation through tiles not depend on the pixel width
of the dialog. When using the up and down keys first search for a tile
in the indicated direction that's in a different row ('top' is
different) then the tile that's in the same column ('left' is the same).

Bug: 896630
Change-Id: Ie5c9f7ebffba521dad1b8056626573c5015b3a36
Reviewed-on: https://chromium-review.googlesource.com/c/1335956Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608389}

Remove an unused constant that was moved to a test/ header
Fix copyright header format in cleaner dir
Fix comma in comments in constants dir

R=csharp@chromium.org

Bug: 830892
Change-Id: I8e91c4e320ceb3f8758d7182853dd46874968f6e
Reviewed-on: https://chromium-review.googlesource.com/c/1336048
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608388}

Essentially, this is accomplished by setting a TouchEventFilter with no touch-able area. This will gray out the entire view and look exactly like the overlay used to look.

Also, the unexpected tap counter is now reset each time a TouchEventFilter is disabled. This should result in more consistent and predictive behavior.

Bug: 806868
Change-Id: I308a3dc488e8d778245bfdc88714d1a9e621c8df
Reviewed-on: https://chromium-review.googlesource.com/c/1335940
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608387}

Bug: 866147
Change-Id: Ibdb5bf46ec67c139b18ee6ca2c5853cac6dd99d8
Reviewed-on: https://chromium-review.googlesource.com/c/1337810Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608386}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a59368241b0c..32a6bd7b54fd


Created with:
  gclient setdep -r src-internal@32a6bd7b54fd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id19178f2292e47a0e73124177b5907dda9f95051
Reviewed-on: https://chromium-review.googlesource.com/c/1337482Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608385}

Remove android_lint targets' dependency on the corresponding
compile_java target. This allows javac and lint to run concurrently.

Add srcjar_deps for android_lint target since R.java is necessary to
determine which resources are used. These are no longer transitively
depended upon through compile_java.

Bug: 856189
Change-Id: If8b8abb1796bd50eb602443a36e3a198c3d35160
Reviewed-on: https://chromium-review.googlesource.com/c/1308100
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608384}

Started failing, apparently, in:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8903

TBR=nasko@chromium.org

Bug: 874782
Change-Id: I5c7746682a08fea050bfa711c3f052edf2f7de07
Reviewed-on: https://chromium-review.googlesource.com/c/1337348Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608383}

at the enclosing scrolling ancestor.

Bug: 903067
Change-Id: Ice5deb0047862fa72a47e34b1f54f6a6955ae56c
Reviewed-on: https://chromium-review.googlesource.com/c/1336784Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608382}

This is already being done in the renderer process during InstallNewDocument.
This change will do the clearing in the browser process FrameTreeNode and in
the RemoteFrame.

Test: content_browsertests --gtest_filter=*ClearUserActivationForNewDocument*
Bug: 901069
Change-Id: Ia11aa078ffd9376565893264a5b6ce4257f63908
Reviewed-on: https://chromium-review.googlesource.com/c/1320517Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608381}

This CL implements not saving of passwords in the new Password Manager
architecture when Password Manager saving if off (i.e.
"Offer to save passwords" settings is off).

Bug: 905048, 831123

Change-Id: Ic053f8ae9b28fc1e9d8d80ba5e1a469a4173fdec
Reviewed-on: https://chromium-review.googlesource.com/c/1337344Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608380}

Before this patch, the main payment request view contained a cancel
button. That button is confusing since it shuts down autofill
assistant.

This patch removes the button. The payment request editor mode still
contains a cancel that goes back to the main payment request view.

R=arbesser@google.com, twellington@chromium.org

Bug: 806868
Change-Id: Ib5805d040f351035adbe209af149fb697715f949
Reviewed-on: https://chromium-review.googlesource.com/c/1337622Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608379}

The fix for the missing shadow in https://crrev.com/c/1331400 was
intentionally short but not very clean. This CL fixes that by moving the
shadow into the accessory sheet. This ensures that the view state is
again reflected by the model.

Bug: 903824
Change-Id: I7a7de1cba5586997de8964551b2b4ec94cb38647
Reviewed-on: https://chromium-review.googlesource.com/c/1331587
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608378}

This CL updates the ProactiveTabFreezeAndDiscard testing config to
match the server-side config.

See ProactiveTabFreezeAndDiscard.gcl.

Bug: 844426
Change-Id: Ib40252c10423e8f9bedf6a376328ed915f5fc2a8
Reviewed-on: https://chromium-review.googlesource.com/c/1336068Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608377}

Bug: 845472
Change-Id: I012839e8ee5dee6ae54d66327f1de5f38ff96d71
Reviewed-on: https://chromium-review.googlesource.com/c/1335599
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608376}

https://webrtc.googlesource.com/src.git/+log/95140715009f..a06bf8506fdf


git log 95140715009f..a06bf8506fdf --date=short --no-merges --format='%ad %ae %s'
2018-11-15 tzik@chromium.org Add a presubmit check for absl/memory/memory.h inclusion


Created with:
  gclient setdep -r src/third_party/webrtc@a06bf8506fdf

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:752720
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iac7aba638ab8133c587b282f40892e534293ad38
Reviewed-on: https://chromium-review.googlesource.com/c/1337481Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608375}

Web Speech API [1] consists of two parts:
1. speech recognition (speech-to-text, STT)
2. speech synthesis (text-to-speech, TTS)

Currently Web Speech API can be either enabled or disabled completely,
by means of "disable-speech-api" command line flag. However we want to
be able to enable STT and TTS functionality separately. This has to do
with some security/privacy concerns regarding speech synthesis.

In particular we want to enable STT functionality in Android WebView,
but not TTS (at least until all concerns are addressed).

In this patch the ScriptedSpeech runtime blink flag is split into two:
ScriptedSpeechRecognition and ScriptedSpeechSynthesis. An additional
"disable-speech-synthesis-api" command line flag is added to control
how much of the Web Speech API we want to expose.

[1] https://w3c.github.io/speech-api/

BUG=487255

Change-Id: I959b73600bb8e7a0542661bfb997ceae1aa144ed
Reviewed-on: https://chromium-review.googlesource.com/c/1329150
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608374}

Return to using icon sizes from before crrev.com/c/1243680.
This should exclude a possibility of any regressions.
Updating the icon look to the latest UI design.

Bug: 893548
Test: steps in bug
Change-Id: I596750416a5c87f0239119086b4db84554f3d3a0
Reviewed-on: https://chromium-review.googlesource.com/c/1336188Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608373}

Using wpt-import in Chromium 73b48815.
With Chromium commits locally applied on WPT:
f482e77e "Add report-only mode to Feature Policy"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/resources
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I4111c4acfe912b4ad363acce5b6216afd1b03ec6
Reviewed-on: https://chromium-review.googlesource.com/c/1337633
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608372}

It seems that we can have no layer tree view, but a
visual_viewport_container_layer_, because we
set them up and wind down separately. Adding null-check
to fight the crash.

Note there is no stable repro for this crash, so it
might be something else.

Bug: 902413
Change-Id: I33dc8419f33ab11d8a49d0be543ac0c8119f9d19
Reviewed-on: https://chromium-review.googlesource.com/c/1334887Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608371}

Two copy buttons are added. The first copies the visible table as text; display options, which affect the visibility of tables, columns, rows, also affect what text is copied. The second copies the responses as JSON.

Also, as this CL introduces a second outputs interface, I took this opportunity to consolidate this new interface and the previous OutputController (which served as an interface for OmniboxOutput) into a single interface, OmniboxController, which will be responsible for interfacing to individual Output classes responsible for:
1 render tables from responses
2 control visibility based on display options
3 control visibility and coloring based on search text
4 export/copy output
5 preserve inputs and reset default inputs
6 export/import inputs

Bug: 891303
Change-Id: I1b6e10e6aa2213912235863f61163c9d8e9f66f7
Reviewed-on: https://chromium-review.googlesource.com/c/1329842
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608370}

https://android.googlesource.com/platform/external/perfetto.git/+log/b93264e2b16b..c17c1dc0e795


git log b93264e2b16b..c17c1dc0e795 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fmayer@google.com profiling: Include PIDs in heap dumps.


Created with:
  gclient setdep -r src/third_party/perfetto@c17c1dc0e795

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I283fb20d9a326b05c00ef13d485487d823db184b
Reviewed-on: https://chromium-review.googlesource.com/c/1337479Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608369}

-Wno-null has been disabled for clang in chrome/browser/ui since 2015
but it seems to be enough to disable that warning for mac (the only
platform that used clang by default in 2015).

Bug: 383820
Change-Id: Iadc03f761c120db91fb806369ecf6f3bd8459c1c
Reviewed-on: https://chromium-review.googlesource.com/c/982057
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608368}

Adds gambard@ as OWNER of ntp_tile_views.
Gambard is the original author of ntp tiles before they were moved to
this folder.

Change-Id: Ie93a894cc685e4a0d5783e417ed714ae29901b14
Reviewed-on: https://chromium-review.googlesource.com/c/1337505Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608367}

This reverts commit 6d582d18.

Reason for revert: The leaks are not caused by WebRTC code,
                   but merely revealed by the tests.
We re-enable those tests: either the leaks have been fixed, or we'll add
a suppression (less drastic than muting the whole WebRTC test suite).

Original change's description:
>Disable all WebRtcBrowserTests on ASan
>
>Many of these tests flakily leak and thus fail on ASan bots.
>
>TBR=phoglund@chromium.org
>
>Bug: 898546
>Change-Id: Icd3cc5dc3a46d0194c807c27b66f7eb902b35794
>Reviewed-on: https://chromium-review.googlesource.com/c/1299161
>Reviewed-by: Marc Treib <treib@chromium.org>
>Commit-Queue: Marc Treib <treib@chromium.org>
>Cr-Commit-Position: refs/heads/master@{#602745}

Bug: chromium:898546
Change-Id: Idccff7827e6381e20060f7116cac75ee2b25018f
Reviewed-on: https://chromium-review.googlesource.com/c/1337626Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#608366}

According to a recent spec edit, any fallback in a var()-reference must
match the syntax of the referenced property, otherwise the var()-reference
is invalid. This applies even if the fallback is not used.

To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead
of a bool. This is necessary, because the kNone case may be both an error
state and a success state, depending on whether the fallback is being
used or not, hence a plain bool is not sufficient.

R=futhark@chromium.org

Bug: 641877
Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0
Reviewed-on: https://chromium-review.googlesource.com/c/1335576Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608365}

It takes up space and is redundant, since the user can access more specific settings pages by tapping the edit/add buttons next to the payment methods and contact details.

Bug: 806868
Change-Id: I0ac076930dc605102931bfe2c7d958aa4ad36c3a
Reviewed-on: https://chromium-review.googlesource.com/c/1337503Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#608364}

This CL changes the state of the highlighted state of the location bar,
to have it shaped like a pill, as the non-highlighted state.

Bug: 905630
Change-Id: Ieeb5180d514b928c158ed2cd4f5b39cfde2b7aec
Reviewed-on: https://chromium-review.googlesource.com/c/1337500Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608363}

Replaces two function calls by one at each trace macro call
site. This should save about 12 kiB in 32-bit ARM libmonochrome.so

BUG=898794
R=primiano@chromium.org,oysteine@chromium.org,alexiln@chromium.org

Change-Id: Icf64644355b584dd5ff9910920df02930344f837
Reviewed-on: https://chromium-review.googlesource.com/c/1301913
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608362}

External Search was added for an app that no longer exists. This
feature has never been enabled. This CL cleans up dead code.

Bug: 904616
Change-Id: Id7df06097ac2c5a598e7bc2f0f91657481de4a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1332689Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608361}

This patch enables fragment caching when BFC block offset
changes, as long as 1) either the cached or new doesn't have
floats, and 2) the cached fragment doesn't propagate OOF
objects. The latter may not be needed, but helps to simplify.

Minor but mostly positive improvements are seen in pinpoint:
blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/13a7a7f7e40000
loading.desktop https://pinpoint-dot-chromeperf.appspot.com/job/17a7a7f7e40000

2 block fragmentation tests fail with this change that this
change is not enabled for block fragmentation for now.
* virtual/layout_ng_experimental/fast/multicol/balance-breakafter-before-nested-block.html
* virtual/layout_ng_experimental/fast/multicol/dynamic/spanner-becomes-regular-block.html

Bug: 635619
Change-Id: I46826b45defd556c8dadbf861fb1bbf61c5ae658
Reviewed-on: https://chromium-review.googlesource.com/c/1335072
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608360}