- 22 Jul, 2020 40 commits
-
-
Natasha Lee authored
Previously tests were passing because we would manually discover adapters all adapters on the system and then pick the first one, which just so happens to be the one compatible with ANGLE (when running Chrome normally). We are changing this so that we explicitly pick the adapter that ANGLE is using. Since ANGLE isn't initialized without --use-gpu-in-tests, the WebGPU tests would all fail with no available adapter. We will work on hooking up SwiftShader in the future. Change-Id: Ifecab52bed926d0abee9bb161565e77aeee52885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310391 Commit-Queue: Natasha Lee <natlee@microsoft.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#790677}
-
Minggang Wang authored
This CL converts base::Callback and base::Closure to Once/Repeating in //chrome/browser/net/. After this CL, there should be no base::Callback, base::Closure and base::Bind in this directory. Bug: 1007635 Change-Id: If66dbd7d611c448456e6b40dcd033f9c68ed45c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306292Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#790676}
-
James Darpinian authored
All other WebGL functions that take a program argument use the function ValidateWebGLProgramOrShader instead of ValidateWebGLObject. Fix bindAttribLocation to match. Change-Id: Ic4823c9b0fd0478ac4428293f7a0fc608e873348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311128 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Scott Violet authored
This function is needed by favicons, which I plan to move to //components/favicons. To avoid circular deps I'm moving the function into //components/database_utils. I would have liked to avoid a component purely for this function, but I couldn't find a better place. BUG=1076463 TEST=covered by tests Change-Id: I0877444883eaf9f5f081d4a107879fe4b58697f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309034Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#790674}
-
James Cook authored
Our naming convention is that files in /lacros/ directories are part of the lacros-chrome browser, so the "browser" subdirectory is redundant. (We used to have a "chromeos/lacros/system" directory, which is how we ended up with "chromeos/lacros/browser".) See bug for link to code layout design doc. Bug: 1104273 Change-Id: I248d50c68f64b0b04f9da2f31e3d83e3d1771dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311037Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#790673}
-
David Munro authored
We save the backup when upgrading to the My Files folder, not the Downloads folder. Bug: chromium:1064918 Test: None Change-Id: I975771ef6e33e939b95bdeece223eeafa85c9af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307017 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#790672}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/324578b5537d..4526665f2b81 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 3eb9a5ac7e53 to 6982458867c4 (1 revision) 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fc0d614b6313 to 3eb9a5ac7e53 (1 revision) 2020-07-21 elliotevans@google.com Modify CanvasKit to work in a Web Worker and add a demo of it in action. 2020-07-21 bsalomon@google.com Make GrBicubicEffect coeffs a uniform. 2020-07-21 tdenniston@google.com Add inner loop geometry to miter join for toy stroker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I0c39f4731057e98a6d09c424433aae39ff052080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790671}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iaf79dc81df48a9175d77669b2cfe133c83085c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310820Reviewed-by:
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::GetUsageForOrigin(). Bug: 1055677 Change-Id: I4782799b29b3d6df0d2e55ef82936e5f1b113f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308622 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790669}
-
Ben Pastene authored
Right now, these internal hooks reside in src-internal's DEPS file: https://chrome-internal.googlesource.com/chrome/src-internal/+/refs/heads/master/DEPS#520 But there's no reason for that. We can move them to src's DEPS file and gate them around 'checkout_src_internal'. This lets us centralize the hooks in a single file, and will let us remove those in src-internal. And refactor the ordering of their args so they're a little more compact. Bug: 937821 Change-Id: Ifee414489dc16b30eaf995b89d08fd005514ee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308922 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#790668}
-
Evan Stade authored
See monorail issue for explanation of bug. Bug: 1106641 Change-Id: Ia252dd4879b23e27bd28ba38ee6fa1ee389769b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305234Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#790667}
-
Jeff Yoon authored
MB configs for Linux PGO builders. Adding MB configs for beta and stable trybots for PGO linux as well. Bug: 1105530 Change-Id: Ie4f01a244abfd5cd9e89fe583e7acb8706ef99cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307633Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790666}
-
Matthew Denton authored
And add src/sandbox/linux/OWNERS as an owner of the histogram. Bug: 1104948 Change-Id: I250b095aeaec634d508ba61f69378accf5fd0903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310844 Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790665}
-
Haiyang Pan authored
Changes including: * Use the underline textDecoration for "a" element * Update the code search link * Remove redundant function setTableCellsAsClickable Bug: 1041593 Change-Id: I30c45b5c054974a5e7544ece20a7958de570b16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309754Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#790664}
-
Dan Sanders authored
This matches the naming and behavior of ImageBitmap::close(). Bug: 1108023 Change-Id: I4f5eac7f97eda4b27a38690b75f3c1e3b7545b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311110 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#790663}
-
Devlin Cronin authored
Bug: 117261 Change-Id: If6990d472053ad0f5296d58e96eff659970417bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264770Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790662}
-
Miriam Zimmerman authored
Add a new UMA metric to CrosEventEnum to assist in debugging an issue where crash_sender sends the same crash repeatedly. BUG=chromium:1060019 TEST=CQ Change-Id: Ia57bd32f954b22677ad8e23c4f221a656c883510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311414 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#790661}
-
adamta authored
Adds header on top of Discover feed in NTP. Feed contains "Discover" label on left side and temporary "Menu" button on right side. Bug: 1085419 Change-Id: Ia9c2fbe34a33e185dd6be2fd66d41c6c593bd688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305830 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790660}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/232115851126..6ca2c1162445 2020-07-21 jmadill@chromium.org Make trace tests a shared library. 2020-07-21 jmadill@chromium.org Move restricted trace functions to cpp file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I0d6e61ac6bfd454aea285d2e19865cd2913ba0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310956Reviewed-by:
-
Mei Liang authored
crrev.com/c/2247404 pushes update to native only when FrameRequestSupplier has a new frame. The early return in LayoutManager#onUpdate(long, long) causes some missing frames, because the FrameRequestSupplier did not get the updated frame, and native did not get the update calls. This CL fixes the regression by setting the newly generated frame to FrameRequestSupplier in the early return as well. Change-Id: I2f4036490cd6e9333eb3d0291153fe5fcd0ae594 Bug: 1106477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309749Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790658}
-
Alex St-Onge authored
This change adds a test that create and then remove a persistent-usage-record session and verifies that the record of key usage is present in the license-release message and are both 'null' Bug: 1102976 Change-Id: I766a3104d84b1e477e54c65f30e62aa5645bd426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308173 Commit-Queue: Alex St-Onge <alstonge@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790657}
-
Erik Chen authored
The screen manager crosapi is used to take snapshots of the screen and window. This CL adds an ash-chrome only browser-test which confirms that the implementation of the mojo interface calls returns appropriately sized snapshots. Bug: 1094460 Change-Id: I6f65d0ba01b60b82c35a5dd896cf3e2f132e3b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310890 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790656}
-
Mohamed Heikal authored
This changes android_resources targets under chrome/ to no longer generate and R.java but instead generate the R.java in the android_library targets themselves. Additionally adds a resources package to base_java and fixes errorprone warning about R class shadowing. Bug: 1073476 Change-Id: I9654b72939bbecd5cd0c014834a663c5b96dbdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297808Reviewed-by:
-
nancylingwang authored
This is the preparing for CL:2305816. Add RawIconPngData to fetch the foreground and background icon images. BUG=1083331 Change-Id: I16112cebffc0296852c585c05b9047ce5926dcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307010Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790654}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/b3359b0b014d..8b6881bd2a9b $ git log b3359b0b0..8b6881bd2 --date=short --no-merges --format='%ad %ae %s' 2020-07-21 bnc Update goaway frame field name and type. not protected. 2020-07-21 haoyuewang Deprercate gfe2_reloadable_flag_quic_enable_ack_decimation. 2020-07-20 fayang Disable server blackhole detection. protected by gfe2_reloadable_flag_quic_disable_server_blackhole_detection. 2020-07-20 wub Rename uberlossalgorithm.tuning_enabled_ to uberlossalgorithm.tuning_configured_. not protected. 2020-07-20 wub For quic loss detection tuning: return response_size from quicacklistenerinterface::onpacketacked in addition to the response_time, then use it to normalize the average http latency used for reward. stats not protected; lossdetectiontuner change protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-07-20 wub Deprecate --gfe2_reloadable_flag_quic_avoid_leak_writer_buffer. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iea8bf2612491da1f58febd07f4f3157d4939671e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311310 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#790653}
-
David Van Cleve authored
Out of concern about the compat effects on Android WebView if we change its UA string override API to prevent custom headers, revert a couple CHECKs added recently to net::HttpRequestHeaders's setters and to WebContents's "set the UA override" method. (The consequence is we'll go back to a state where we're regularly silently handling a DCHECK failure.) This reverts: - f998816 "content: Enforce precondition that UA overrides must..." - e98b84ec "net: Change HttpRequestHeaders::SetHeader's DCHECKs to CHECK" Alternatives considered: - extend the network service API to allow privileged clients to append arbitrary headers to outgoing requests in order to accommodate the WebView case, migrating the WebView UA override setter to use this (too much effort) - move back to a DCHECK on Android only (saddles //net with platform- specific logic with a compat motivation far removed from the network stack) - keep the CHECKs (could have led to WebView-embedding apps crashing in production with unknown frequency) Fixed: 1105745 Change-Id: I4423a68f1884da3a9248041f75c800e4803d4e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310774Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790652}
-
Nidhi Jaju authored
Currently, the PaymentAppInstaller uses ServiceWorkerContextWatcher to retrieve all service worker registrations by calling GetAllRegistrations(). However, this is a problematic as GetAllRegistrations() performs many unnecessary memory allocations and data conversions (see [1] for details). When the browser has many service worker registrations for different origins, these allocations/conversions have considerable performance impact. Hence, ServiceWorkerContextObserver is used instead to keep track of changes in the service worker registration. Relevant callbacks were also added to SelfDeleteInstaller to keep the behavior consistent. [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA Bug: 807440 Change-Id: I3449fe8af5dde495ffb6bb0eca937513fa2630f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291186Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Nigel Tao authored
This will minimize the diff for a follow-up commit. Change-Id: I79bfaf5913550acb9c579e3e2037012241c6639b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310050 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790650}
-
Josip Sokcevic authored
Return of GetAllFileList is not used anywhere so it's safe to convert to CancelCallbackOnce. Bug: 1007686 Change-Id: I57ff303b8d34fab9926199615a95eb0e81937e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304952Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Diff since last roll: https://chromium.googlesource.com/chromium/dom-distiller/+/ccfe233400..3eef8a0ce4 Picked up changes: https://chromium.googlesource.com/chromium/dom-distiller/+log/ccfe233400..3eef8a0ce4 3eef8a0 Strip all unsafe HTML attributes using an allowlist. a1612e0 Update and improve readability of README.md. 56b365d Use goog:loggingPrefs in get_screenshots.py 4072533 Bump selenium version to 3.141.0 5438a7b Use --enable-distillability-service for native features 45fe4a6 Update Travis CI environment from Ubuntu 14.04 to 18.04 ba2c5d9 Adapt new version scheme of Chrome Driver c38fd83 Use Open JDK 8 Bug: 1012955, 610944 Change-Id: I5f620ccafea1b95dbdd8a53fc9d1a61201b98ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304997Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790648}
-
Scott Violet authored
This will make it easier to move the database into the favicon directory. BUG=1076463 TEST=covered by tests Change-Id: I98c64f1794530771ebcee70928b5d1e2f3d5445e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308933Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6d3a035..15011595 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e34ede9b760fdf6cd0a2ce237b73625128eba44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311329Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790646}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d9e64e11. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I150e6fd1ff03501edf18ffcbf7a389127fa0cb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790645}
-
Dale Curtis authored
PaintImage::GetContentColorUsage() and gfx::ColorSpace construction both use ad hoc methods for determining if the transfer function is PQ or HLG, instead use the new sanctioned Skia methods. R=ccameron Fixed: 1106417e Change-Id: Ia515c60d92d1733e4edfba369071050dd6805ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311123 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790644}
-
Richard Knoll authored
This adds a mojo interface for the discovery page to find nearby devices and connect to one. For unknown devices we require an additional confirmation step to verify a connection id. The user has the option to accept or reject on the nearby-confirmation-page. Bug: 1099710 Change-Id: I308a7926efef61a3fa872051b00fcf35e62a8287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235516 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#790643}
-
Sangwoo Ko authored
This helps clients to decide when to rasterize ui::ImageModel. For instance, if a new ImageModel is same with the old one, they can skip rasterization. Bug: 1048901 Change-Id: I72ba2bdc71d9cde576f99fe5cbf3db994a8b6837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303747Reviewed-by:
-
Mike Dougherty authored
The page at the previous url was much more complicated than necessary for a network check so it could more easily fail for other non-network related issues. Bug: None Change-Id: I9f79cb9f948b090c065cf6b9f9331217e65b380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311043 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#790641}
-
Ben Pastene authored
The bots no longer need to be in their own pool. After crrev.com/i/3177503 lands, they'll also be in the standard test pools. Bug: 1057152 Change-Id: I0d0f335a036156683d1f53334860569f427800d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311271Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#790640}
-
Ben Joyce authored
Temp filter to use to restore code coveage while working on a solution to combine all code coverage. Bug: 1107004 Change-Id: I3b011e038cc60b6692858d4e4179807fd43061fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311057 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790639}
-
Alexander Cooper authored
Converts shell_integration::DefaultWebClientWorkerCallback to a RepeatingCallback, since it is used to pass the result of state queires. Converts callbacks for shell_integration::win::GetIsPinnedTaskbarState to Once callbacks, given that exactly one of them is called once. Converts the sole caller of GetIsPinnedTaskbarState to base::BindOnce. Converts the shell_integration::win::DefaultBrowserActionRecorder to use a OnceClosure, wince this matches it's usage. Updates a missed comment in process_resource_usage.h Switches the ChromeContentBrowserClient UnitTest to use a NullCallback. This matches the intention of the test, and can be used independent of updating the underlying API. Finally, with all top level usages of base::Bind/Callback cleaned up, modifies PRESUBMIT.py to replace chrome/browser with the children that still need to be converted. Where a directory has only one file that needs conversion, that file is listed. Otherwise, the deepest subdirectory under chrome/browser that has files that need to be converted is listed. Bug: 1007635 Change-Id: I2cbdcd37cd0da411e106c0f3b14b8f6e92d7209f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304129Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
