- 17 Sep, 2020 40 commits
-
-
James Hawkins authored
This reverts commit 4b5732c0. Reason for revert: Breaks linux-rel trybot. These files need to be is_chromeos as well: https://source.chromium.org/chromium/chromium/src/+/master:chrome/test/data/webui/BUILD.gn;l=225?q=chrome%2Ftest%2Fdata%2Fwebui%2FBUILD.gn Original change's description: > Nearby Share: Update build files to limit to CrOS only. > > For now Nearby Share is only planned to ship on CrOS and supporting > multi-platform builds is quite costly. > > Bug: none > Test: none > Change-Id: If879641d0d5b766f384f184078015eeabbf2215f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415135 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807903} TBR=jhawkins@chromium.org,khorimoto@chromium.org,gab@chromium.org,thestig@chromium.org,rockot@google.com,reillyg@chromium.org,msarda@chromium.org,emaxx@chromium.org,knollr@chromium.org,vecore@google.com Change-Id: Ia362800da9ea21f994e38dcbc0dad4397fff81f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416891Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#807918}
-
David Bertoni authored
This test was disabled because it was flaky on Mac. Testing indicates it's not flaky on any other platform and is only flaky on the mac_chromium_10.12_rel_ng bot. Bug: 988934 Change-Id: Iaa028f7792906db6ef7554f4a824f1810f706a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393007Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807917}
-
Stephen McGruer authored
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead - however in this case the tests don't actually need async functions (they don't use await or rely on promises). Bug: https://github.com/web-platform-tests/wpt/pull/25540 Change-Id: I9be1f0b89350b611ed7db260e9ec5b79def03305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414758Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807916}
-
Andrei-Laurențiu Olteanu authored
Change NVME to NVMe. Bug: b:168687888 Change-Id: Ibc660ececc5d2fdf31eea3ed91c44a41172266c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410042Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#807915}
-
Orin Jaworski authored
This flag/feature is expired and unused. Bug: 1110706 Change-Id: I64e3d44eb13572bff53421492fcaba8eaad91222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415219Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807914}
-
Tanmoy Mollik authored
The sync row in main settings page should launch sign-in screen when there is no sync consent account in chrome. On the other hand when there is an account present it should launch ManageSyncSettings page. This cl adds a OnPreferenceClickListener for the sync row. Also the sync row is always shown if there is a signed-in account present. Bug: 1125464 Change-Id: I97fb6c3cca04654fde148e5c70b211fa3fc3bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398682 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807913}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600171148-2256b3d9ffc2b53c8daccc3d78ab79199aeff8aa.profdata to chrome-win32-master-1600300188-843ccc7f4981299b9d59bff076f7994d3bf42fe8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3ca5c1dc348eb4d2a20890ecd8a817f1450ccdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807912}
-
Alice Wang authored
This CL is a small refactoring of the class IdentityDiscController. Bug: 1127886 Change-Id: I00cca9a945c5fab454a4b0c4678173b9874ff57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410490 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807911}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e25d6ac..dbc042b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f9cd32972748d838b18fd0925468778ef2bdff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416252Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807910}
-
Nektarios Paisios authored
For every editing operation in Blink, this patch exposes to the browser and to automation clients the "type" property of its input event from Blink. The enumeration listing event intents was too long, and it included intents such as paste, type and replace. To make using intents simpler, the list of commands is now trimmed down to a few generic ones, such as insert, delete, format and SetSelection. For intents attached to text changed and text attributes changed events, more information is now provided in the intent's input_type member. Values are provided by a new enumeration that uses the same members as the W3C Input Events Specification. This makes the information more detailed, accurate, as well as standard's based. The TextBoundary and MoveDirection enums were also modified to add the "kNone" member so that event intents such as "kClearSelection" that have no boundary information and no directionality need not use them. Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org Change-Id: Ifa2a94451596980cf36ecc13bb073ca7062e9587 Bug: 989156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401028Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807909}
-
Stephen McGruer authored
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead. (The naming conflict is a sad historical legacy; WPT had async_test long before EcmaScript spec'd promises!) Bug: https://github.com/web-platform-tests/wpt/issues/21435 Change-Id: I6082d03b6821781ed62d274dc0ca0b2741d2d285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414675Reviewed-by:
Alex Turner <alexmt@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807908}
-
Gyuyoung Kim authored
This is a reland of 0e23bba9 Make web_preferences.cc include v8_cache_options.mojom.h instead of v8_cache_options.mojom-blink.h. Bug: 919392, 1128983 Original change's description: > Use mojom::V8CacheOptions instead of blink::V8CacheOptions > > Now we can use mojom::V8CacheOptiosn directly in Blink. So, > this CL replaces all uses of blink::V8CacheOptions, then > remove it. > > Change-Id: I636e0259d0b7da692bf693c3ec13f99dba9cd410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409665 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#807427} Change-Id: I9205469dcb039f3e8220a169d540a2af885a1312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413685Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#807907}
-
Guillaume Jenkins authored
In preparation for the full launch of the Windows native spell checker integration, this change enables the WinUseBrowserSpellChecker feature by default. Also fixes a few tests that were making assumptions about the code path that was used inside the spellcheck provider, which no longer hold true when the native spell checker integration is enabled by default. Bug: 978460 Change-Id: I0cac4a5ab8384c03485fb827308e40598f0828b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413038Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#807906}
-
Sean Gilhuly authored
This test is now passing again. A skia change was rolled in that had depended on a spirv-cross change, which has now also been rolled in. Bug: 1126617 Change-Id: I86c9de10732cc39d7860cbc982186f5695a7e112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412888 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#807905}
-
Sylvain Defresne authored
The warning is benign (warn about an empty block protected by an if) but cause Xcode 12.0+ to consider the build as a failure (as soon as the output contains the string "error", Xcode consider the build as a failure). Silence the warning until the dependency can be rolled (currently blocked by the fact that mirroring from github is misconfigured). Bug: 1129390, 1129393 Change-Id: I170de8cac0fa88612bac157737f7abd2fbfa4989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416273 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#807904}
-
James Hawkins authored
For now Nearby Share is only planned to ship on CrOS and supporting multi-platform builds is quite costly. Bug: none Test: none Change-Id: If879641d0d5b766f384f184078015eeabbf2215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415135Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#807903}
-
Robert Ma authored
The test has non-deterministic output and cannot be rebaselined. TBR=smcgruer No-Try: True Bug: 1129420 Change-Id: I36bebe78bb3b12e82a024175e9b298998177ca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416392Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#807902}
-
Olle Liljenzin authored
A misplaced underscore in a variable name breaks gn gen with enable_bazel_desugar=false, thus remove the misplaced underscore. BUG=1067278 Change-Id: I51948879637bf7e7b7dae471561c46564be1197e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416073Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#807901}
-
Nico Weber authored
This is a reland of a359d11d This time, leave the force-off on non-tot bots in place unchanged, and add a block to force-on on tot bots, and add a somewhat detailed comment for why. Third time's the charm? Original change's description: > clang tot bots: Force-enable memoryssa-based dse > > Now that the flag is off-by-default again upstream, let's force it on > on the tot bots to see if things work with it on. > > TBR=akhuang > > Bug: 1127713 > Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807727} TBR=akhuang Bug: 1127713 Change-Id: I154cb9f12c2500e715fe9215bd87e96cc03c5040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416768Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807900}
-
Asanka Herath authored
As described in https://www.chromestatus.com/feature/6246151319715840 the deprecation timeline now extends to M88. Bug: 333943 Change-Id: I3de98ec1692dba84bfffcfab595535a0897d5919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415215Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#807899}
-
Glen Robertson authored
Also a more useful error message if incorrect. This makes it works as documented in docs/origin_trials_integration.md Change-Id: I97d549d10917911d636fc8d41ebd58b1f32838de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415750 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#807898}
-
Jamie Madill authored
This reverts commit a173775c. Reason for revert: Broken builders, e.g.: https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20dEQP%20Builder/100576 https://ci.chromium.org/p/chromium/builders/ci/win-swangle-x86/13670 Original change's description: > Reland "clang tot bots: Force-enable memoryssa-based dse" > > This is a reland of a359d11d > Fix conditional to enable this on the tot bots, not on the non-tot bots. > > Original change's description: > > clang tot bots: Force-enable memoryssa-based dse > > > > Now that the flag is off-by-default again upstream, let's force it on > > on the tot bots to see if things work with it on. > > > > TBR=akhuang > > > > Bug: 1127713 > > Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807727} > > Bug: 1127713 > Change-Id: I1252ee68251279c82da5ef00c06f7f1514780baa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416668 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807882} TBR=thakis@chromium.org,akhuang@google.com Change-Id: I45874319ef7c4643909694a9f5e138cf693f9837 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416750Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#807897}
-
Takashi Sakamoto authored
- support aligned_realloc and aligned_free because media uses the functions. - support malloc_base, calloc_base and free_base because the functions are also used during crt startup (the same reason why need realloc_base). Bug: 998048 Change-Id: I4b861f9123dd2492ddf7c50c5c096c90bc31d6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409477 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807896}
-
Mario Sanchez Prada authored
It is an error to call AXContext::GetAXObjectCache() if the underlying document is no longer active, so early return in that case to prevent crashes that might otherwise happen in some cases, as the one detected by clusterfuzz in crbug.com/1094576. This method is used by AXTreeSnapshotterImpl::SnapshotContentTree(), which will behave correctly after receiving a default WebAXObject in these cases, since the root.UpdateLayoutAndCheckValidity() check will return false in that case and early return as well as in other cases that hit the same code path. Bug: 1094576 Change-Id: I5879b3637db0279d0fdd507c0916426ff459aeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416370Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#807895}
-
Swapnil authored
The browsertests related to developer tools policy are moved to a separated file. Bug: 1128483 Change-Id: I6fcce200aa2159b12d5769a79f814be9ec6e11e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410389 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807894}
-
Alex Ilin authored
This CL calls ChromeColorsService::RevertThemeChanges() from ~ChromeCustomizeThemesHandler() to not apply unconfirmed changes when the user navigates away from a webUI page with the color picker. Screencast: https://drive.google.com/file/d/1APJjUVJv3WL3m2Nr71ukAG9o1ZRMnMMc/view?usp=sharing Bug: 1095530, 1115301 Change-Id: Ic2a7a886b1e9ad8328687621a5dd9e44d1563280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414175 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807893}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a2ba0ce189ca..d62add52c69b 2020-09-17 treehugger-gerrit@google.com Merge "Flow events are highlighted when slice is hovered" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id29a3f0905166ad38e1f0f195c0cb477ecca20bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807892}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25f15e6f33a4..88907d712312 2020-09-17 changhaohan@chromium.org TypeScriptify elements/ElementsPanel.js 2020-09-17 alexrudenko@chromium.org Display persistent overlays in the regular inspect tool If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1109224 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I430e0f26a459ae73f48ac24c13467ec0a9c6fd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807891}
-
Chris Hamilton authored
In preparation for using strongly typed frame tokens (with no null value) this migrates all frame-opener related functions to use a base::Optional<base::UnguessableToken>. This makes all of these functions consistent, as some were already doing this, and the related Mojo IPCs also use a base::Optional<base::UnguessableToken>. BUG=1096617 Change-Id: I640b6e53997b2214868c73d664a0bb632bd73429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401846Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#807890}
-
Mark Yacoub authored
Replace modesetting displays using Legacy APIs to use Atomic Commit APIs for enabling and disabling screens. The flow for modeset follows closely the flow for atomic page flip. Change only apply to devices supporting Atomic APIs. Legacy APIs are still used by older systems. Tests are improved to accommodate for props being set on modeset and an extra commit being called. (Reland of "Ozone: Implement Atomic Modeset" reverted on crrev.com/c/2152766) BUG=987274 TEST=Enable and Disable displays, ozone_unittests Change-Id: I452b271c5bf2d6b67151c08fe81933e4bc20e9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415050Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#807889}
-
Swapnil authored
The browsertests related to native messaging policy are moved to a separated file. Bug: 1128467 Change-Id: Ie07028d38b58fad47ebe0c23363359b4b732c10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412487 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807888}
-
Tymofii Chudakov authored
Use category-default-setting-radio component to implement privacy page redesign, which is hidden under a flag. The following content setting categories are redesigned in this CL: - ADS - MIDI_DEVICES - AR - PAYMENT_HANDLERS - AUTOMATIC DOWNLOADS - PLUGINS - BACKGROUND_SYNC - POPUPS - CAMERA - SENSORS - CLIPBOARD - SERIAL_PORTS - FILE_SYSTEM_WRITE - SOUND - GEOLOCATION - UNSANDBOXED_PLUGINS - IMAGES - USB_DEVICES - JAVASCRIPT - VR - MIC - ZOOM_LEVELS Bug: 1113642 Change-Id: If1b3503efa459cb05d83bd7a8dc1fc6933e205b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323390 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807887}
-
Henrique Ferreiro authored
Migrate the legacy IPC message DragHostMsg_StartDragging to the StartDragging Mojo message in blink.mojom.DragDropHost. WebWidgetClient::StartDragging is changed to return a bool. This allows to move the implementation in RenderWidget to WebFrameWidgetBase, but keep the one in WebWidgetTestProxy. See the discussion at https://crbug.com/1039255#c34. Bug: 1039255 Change-Id: I99aac416d6159836a29d65c16c9ec5c88d48479d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320268 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807886}
-
Caitlin Fischer authored
content/ already depends on components/variations in multiple places; see the bug for more details. This will also eliminate the need to add additional variations-related dependencies in content/renderer/DEPS and content/browser/DEPS, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/2411489/2. Bug: 1129078 Change-Id: Id9c8ddef40e70671d4e42ef0b24cdb6239be2f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414842 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#807885}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0a8a3ea25b36..8da60e2523c7 2020-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e4cbd27e to d9fa0d46 (420 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ibd76df7148eae7af73fcde80ff0c9b0cdf7fd6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807884}
-
Maggie Cai authored
This CL adds a feature flag for using the App Service to provide data for external protocol dialog on Chrome OS. BUG=853604 Change-Id: I4ee2273fc78599c2ec77ec5844f2903a24c187dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415917Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807883}
-
Nico Weber authored
This is a reland of a359d11d Fix conditional to enable this on the tot bots, not on the non-tot bots. Original change's description: > clang tot bots: Force-enable memoryssa-based dse > > Now that the flag is off-by-default again upstream, let's force it on > on the tot bots to see if things work with it on. > > TBR=akhuang > > Bug: 1127713 > Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807727} Bug: 1127713 Change-Id: I1252ee68251279c82da5ef00c06f7f1514780baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416668Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807882}
-
Rune Lillesveen authored
Flaky on multiple platforms. Disabling. TBR=qinmin@chromium.org Bug: 1064435 Change-Id: I3692b20bda7ff481d9502b02df84b3f877ec77f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416449Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807881}
-
Tanmoy Mollik authored
This cl makes two key changes that should fix this bug. 1. The onPreferenceClickListener in the SignInPreference is too generic. It should only be invoked for managed accounts and generic promos. The code is moved to the setup of the specific states. 2. AccountManagementFragment should check for signed in accounts, not syncing accounts, when MOBILE_IDENTITY_CONSISTENCY is on. Bug: 1128931 Change-Id: Ifbd0fbef5acfdca7412b9ae5056f7208ff59c366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414233 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807880}
-
Joshua Pawlicki authored
This reverts commit 4e4ea3fd. Reason for revert: Speculative revert to fix BrowserTest.CloseWithAppMenuOpen failures on linux-lacros-tester-rel bot. [ RUN ] BrowserTest.CloseWithAppMenuOpen [27984:27984:0917/013814.891745:WARNING:ozone_platform_wayland.cc(203)] Failed to find drm render node path. [27813:28015:0917/013814.933599:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [27813:28015:0917/013814.933632:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [27813:28015:0917/013814.933859:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [27813:28015:0917/013814.934033:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [destroyed object]: error 1: popup parent not constructed Original change's description: > USB devices are only shared with one VM at a time > > Remove map of VmSharingInfo from CrosUsbDeviceInfo since device > is only shared with one VM at a time. > > TBR=khorimoto@chromium.org > > Bug: 1129266 > Change-Id: I2025091bf63eeed538c62d8b39cfbb744339aa64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413716 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807786} TBR=joelhockey@chromium.org,nverne@chromium.org Change-Id: I96cab98518776d10ef10d7c8376eb7379c92d6e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416389Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#807879}
-