- 22 Aug, 2018 40 commits
-
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/465d65ba9903..a4238afbd1d0 git log 465d65ba9903..a4238afbd1d0 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 primiano@google.com UI: fix deploy script 2018-08-21 primiano@google.com Merge "UI: Rearchitect controllers and improve tracks performance" 2018-08-21 primiano@google.com TraceProcessor: improve error handling in presence of null columns Created with: gclient setdep -r src/third_party/perfetto@a4238afbd1d0 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id509660d3b58ac2af980a5746fad285197a1ad5e Reviewed-on: https://chromium-review.googlesource.com/1184762Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585042}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85f5e7ccd1af..29361ca11fa3 git log 85f5e7ccd1af..29361ca11fa3 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 cwallez@chromium.org Add standalone dawn gclient config 2018-08-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@29361ca11fa3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875245 TBR=agable@chromium.org Change-Id: I03a614427f950472893d317d70dd2c59944750e4 Reviewed-on: https://chromium-review.googlesource.com/1184763Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585041}
-
Ramin Halavati authored
Braille IME preferences are not actual preferences and are never written/modified from an incognito window. So they are removed from incognito persistent whitelist. Bug: 861722 Change-Id: Id8ac77909c0927eebfdf6e0a2e9e5afce528c5d9 Reviewed-on: https://chromium-review.googlesource.com/1180891Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585040}
-
Victor Costan authored
The function populates an AppCacheInfo instance passed by pointer, and is always called with a default-initialized instance. This CL makes the function return an AppCacheInfo instead, and relies on NVRO to avoid degrading runtime performance. Change-Id: I62b6f2a71409634d3264c84954744c9d265e3c8c Reviewed-on: https://chromium-review.googlesource.com/1184506 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585039}
-
Xianzhu Wang authored
We had output the clip before SPv175 with ClipRecorder but not for SPv175. We also lost the early return on empty clip_rect in crrev.com/569459. See https://chromium-review.googlesource.com/c/chromium/src/+/1110496/6/third_party/blink/renderer/core/paint/file_upload_control_painter.cc for the old code. Now enable ControlClip for LayoutFileUploadControl to emit the clip. Bug: 875460 Change-Id: I0f4141eeb0e8d62ccdf9aa4df368f65e207df7d3 Reviewed-on: https://chromium-review.googlesource.com/1183783 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585038}
-
Orin Jaworski authored
The increase from 5 to 18 entries significantly reduced entity image flicker, but the problem was not eliminated completely until the underlying cause of cache overwrite was addressed. With image prefetch logic fixed, the cache size can be reduced to a tighter bound. 5 is still not enough, but 12 is sufficient (see comment). Bug: 866580 Change-Id: Ifc3f7d84ee59eea277756d5f32d302cc7f5949cc Reviewed-on: https://chromium-review.googlesource.com/1182610Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#585037}
-
chrome://discardsChris Hamilton authored
This removes a spurious bit of debugging code that made it through review. TBR=fdoray@chromium.org Change-Id: Ie1567dc92d1a6b97d443d7f63b1fb8f557e18533 Reviewed-on: https://chromium-review.googlesource.com/1184105Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#585036}
-
Alexei Filippov authored
OOPHP needs address, allocator type, and context fileds. BUG=803276 Change-Id: Id2c93825921f768d7a10d779a2ac25c19c2b004b Reviewed-on: https://chromium-review.googlesource.com/1183860Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#585035}
-
liberato@chromium.org authored
Previously, MCVD would flush immediately when draining the codec, or eliding a drain. This causes a lot of flushes during scrubbing, for example, when the next seek would happen before the next decode. Now, MCVD will defer the flush even if it elides the drain, so that many flushes can be elided too. This requires some care, since the codec is entirely unaware that we've elided an eos and deferred a flush; it might produce output from previously submitted inputs. MCVD will now ignore these. Bug: 869365 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If0490de8754abcb18c8ed60e26215e0a7df9e607 Reviewed-on: https://chromium-review.googlesource.com/1183881Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585034}
-
Peter Beverloo authored
There is a low rate of errors where notification clicks cannot be processed due to internal reasons, such as not being able to find it in the appropriate database or database read errors. In those cases we can't give the developer the means to handle the event, and the notification sticks around until the user closes it. Per this CL, we'll automatically close notifications when the click could not be processed. The eventual goal is for such clicks to be very rare, so fixes will happen in other parts of the code as well. Bug: 872336 Change-Id: I3f184b6d1a36deb42d9f5c95be5dc15aa285bb66 Reviewed-on: https://chromium-review.googlesource.com/1183674Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585033}
-
Mythri Alle authored
Pass in 0 as the size of code cache, so disk_cache backend picks a default value based on some heuristics. The size of code cache would be the same as the size of http_cache. We can tune it once we have some initial results. We also need to add support for embedder to override this default value and that is tracked in this bug: crbug.com/867552 Bug: chromium:812168 Change-Id: Iab8d98764e3e306cb006377e5b8adaf2c727b689 Reviewed-on: https://chromium-review.googlesource.com/1161922 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585032}
-
Ramin Halavati authored
First run, Enrollment, and OOB preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: Iafe1ff19e7954ca2c420ee26708ba6f963a7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1180217Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585031}
-
Sujie Zhu authored
If IssueOAuthToken() is not called after StartUploading(), the GetUploadData() will always be empty which makes that unittest (which checks fields are not included in the upload data) meaningless. So we add IssueOAuthToken() and check the upload data is not empty before we check the fields. Change-Id: I30f776f52e86e74a08018dbc4db4f20925af871a Reviewed-on: https://chromium-review.googlesource.com/1175211 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585030}
-
Ben Pastene authored
It's not doing well. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 Fortunately, the M bot is ok: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel?limit=200 NOTRY=true Bug: 876539 Change-Id: Icb9770bf0df60fe28ad92dfabeb0c5c8f14f30af Reviewed-on: https://chromium-review.googlesource.com/1185229 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585029}
-
Aaron Leventhal authored
Accessibility must consider any kind of non-visible overflow as programatically scrollable, so that the bounds of scrolled objects in these containers correct for the scroll offsets. This fixes a scrolling issue where screen readers were not scrolling to the content they were reading, as they were getting incorrect bounds. The content in question was using hidden overflow, which can be programatically scrolled. Bug: 646117 Change-Id: Ie083d7544b0e6dd2bdb7c5b8c1d41fc7c2377daf Reviewed-on: https://chromium-review.googlesource.com/1178321 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585028}
-
Olivier Robin authored
This method can be used to configure the TestWebClient to inject scripts needed for tests. Also migrate other test methods in web::test Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie8a69a02defd2dd071b42b3c6654a7f25009af82 Reviewed-on: https://chromium-review.googlesource.com/1136301Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585027}
-
Kuo-Hsin Yang authored
NOTRY=true Bug: chromium:876636 Change-Id: I516f4f2920b7fa99c1cab1b0ab4dcef0053f0564 Reviewed-on: https://chromium-review.googlesource.com/1184740 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#585026}
-
Joe Mason authored
R=wfh Bug: 830892 Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 Reviewed-on: https://chromium-review.googlesource.com/1171737 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585025}
-
Joe Mason authored
Launch chrome_cleaner unit tests without using job objects on win7 to make sure SpawnSandboxTarget works. Bug: 871924 Change-Id: Ie9b80894851cc2f7420a79e4fe3fffaf8e849a4a Reviewed-on: https://chromium-review.googlesource.com/1171659 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#585024}
-
dalyk authored
This URI template parser will be used by the DoH implementation to interpret DoH servers and to construct requests. The URI template parsing code is derived from the public Google API C++ Client code with significant modifications. Bug: 872987 Change-Id: Ia9a1c761a16607911034c1d8419fed82b7e918dd Reviewed-on: https://chromium-review.googlesource.com/1170591 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585023}
-
Lindsay Pasricha authored
Bug: 856622 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I250a7899963fa1d43aabb6419e7044677b61b975 Reviewed-on: https://chromium-review.googlesource.com/1114918 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585022}
-
Jeremy Roman authored
This matches the API of base::Lock, which we intend to eventually switch to, better, and doing a DCHECK is the only reasonable thing to do with the result of Locked anyhow. Bug: 856641 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibd31cb7d1c0982929b6aa09135c7b331cadec984 Reviewed-on: https://chromium-review.googlesource.com/1183633Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585021}
-
Sahel Sharify authored
Please find the intent ot implement here: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: Id77ceb7352629a6a9417617602d330919904ed44 Reviewed-on: https://chromium-review.googlesource.com/1183538Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585020}
-
Sahel Sharify authored
TBR=jonross@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874162 Change-Id: Ic8dcdd70cdd5dc5c606d58195121251783a744d4 Reviewed-on: https://chromium-review.googlesource.com/1184219Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585019}
-
Yao Xiao authored
if ad script is in stack. Bug: 864160 Change-Id: I6ccac6ae44cfbb0d8bb98d8502b7f85da00479b3 Reviewed-on: https://chromium-review.googlesource.com/1176266 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585018}
-
Nicolas Ouellet-payeur authored
s/v4_update/g4_update/ Change-Id: I7e49423763afddaaebad5b326dfd4f447398d531 Reviewed-on: https://chromium-review.googlesource.com/1184110Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#585017}
-
Tommy Martino authored
Per UX request (see bug). See also screenshots (Googlers only): https://docs.google.com/presentation/d/1IeyKg22nSbt8aDkvCGrHx1SBg7UBQIqymWDj2sLJ9JQ/edit#slide=id.g3fd38cc212_0_5 Bug: 876291 Change-Id: I8c782d42a5901286ee2c657b7625fbdab4dd62a2 Reviewed-on: https://chromium-review.googlesource.com/1184057Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#585016}
-
Martin Robinson authored
Bug: 866337 Change-Id: I316fa8be8ce10f638f67fbc7e1eb28d05f1c0ab3 Reviewed-on: https://chromium-review.googlesource.com/1183321 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585015}
-
David Bokan authored
Update visual viewport unit tests for blink gen property trees. BGPT still creates layers in the compositor so the changes are fairly limited. In places where we check layer properties, this patch also adds checks for the equivalent paint properties. Bug: 836915 Change-Id: I3d821cea1021b28d87ceff188931eaae3fa3b7c4 Reviewed-on: https://chromium-review.googlesource.com/1184963Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585014}
-
Guido Urdaneta authored
This reverts commit ba40c8a2. Reason for revert: Causing failure on Linux Tests (dbg) bot. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52253 Sample logs: [ RUN ] AXPlatformNodeAuraLinuxTest.TestAtkText ../../ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc:871: Failure Value of: ATK_IS_TEXT(root_atk_object) Actual: false Expected: true Stack trace: #0 0x000008299a59 StackTraceGetter::CurrentStackTrace() #1 0x0000082be414 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x0000082bd86e testing::internal::AssertHelper::operator=() #3 0x00000821fe0c ui::AXPlatformNodeAuraLinuxTest_TestAtkText_Test::TestBody() #4 0x0000082f91eb testing::internal::HandleSehExceptionsInMethodIfSupported<>() [ FAILED ] AXPlatformNodeAuraLinuxTest.TestAtkText (2 ms) Original change's description: > Expose the basic AtkText interface for text elements > > AtkText is the proper way to expose static text to accessibility agents. > This change adds initial support for the interface, but there is quite a > bit of work left to properly expose hypertext as well as implement the > rest of the required interface functionality. > > Bug: 866337 > Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18 > Reviewed-on: https://chromium-review.googlesource.com/1179752 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584989} TBR=dmazzoni@chromium.org,mrobinson@igalia.com Change-Id: Idb25bb0c8bd494b10f6eed2fd213552178a5f62b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866337 Reviewed-on: https://chromium-review.googlesource.com/1184924Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585013}
-
Ehsan Chiniforooshan authored
I changed the metric name in https://chromium-review.googlesource.com/c/catapult/+/1181702. This CL comments out the test for that metric so that the Catapult roller is unblocked. After Catapult is rolled to after the renaming CL the test should be re-enabled. Bug: 876276 Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a NOTRY=true # CQ flake Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a Reviewed-on: https://chromium-review.googlesource.com/1183694Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585012}
-
Guido Urdaneta authored
Bug: 875544 Change-Id: I8d2b81e6131df537fbea872753e08cf8f638783f TBR: huayinz@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1184910Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585011}
-
Gauthier Ambard authored
This CL makes sure that it is possible to exit fullscreen by tapping the collapsed toolbar. For now, it is possible to exit it by tapping the steady view. Bug: 862557 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I31667dd679d1b38f41d819197aedc54c76024ab4 Reviewed-on: https://chromium-review.googlesource.com/1184912Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585010}
-
Javier Ernesto Flores Robles authored
Adds the new icon for addresses and for keyboard. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I775b06b39a8f797c16669511ab8aa057bdd14133 Reviewed-on: https://chromium-review.googlesource.com/1183223Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585009}
-
Takuto Ikuta authored
Currently there are some more people actively working on determinism things. Derived from https://chromium-review.googlesource.com/c/chromium/src/+/1183999#message-173c888fec19d325b8f1c8b4a1e8d835b82b52aa Change-Id: I0306ad04dc0e7cb71592daa5a5005eb423ea4236 Reviewed-on: https://chromium-review.googlesource.com/1184124 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#585008}
-
Ehsan Karamad authored
The method CreateMimeHandlerViewGuestIfNecessary() has an implementation in mime_handler_view_container_base.cc. It is marked as abstract by mistake. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: If4751752f05ff120f47c7d65a5a6c3189aa08ac3 Reviewed-on: https://chromium-review.googlesource.com/1184119Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#585007}
-
Joe Mason authored
If the sandbox target process is very short-lived (as in some multiprocess tests), and also takes long enough to spawn that the first TimedWait on the init done notifier times out, then there's a race between the target process exiting and the parent process calling TimedWait again. Instead of polling in a loop, use WaitForMultipleObjects to wait for both the init done notifier and process exit. TBR=csharp TBR_REASON=Already reviewed in internal repo. Bug: 874387 Change-Id: I86af661bbe43f3fc044fb5afd6bcbd9f9d7b297c Reviewed-on: https://chromium-review.googlesource.com/1184214Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585006}
-
Robert Phillips authored
Skia's mask-filter occlusion rect feature has been defunct since the Skia CL: https://skia-review.googlesource.com/c/skia/+/147561 (Remove occluder feature from blur mask filter) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa5656f0ff9e4b99500389651789f549f4352846 Reviewed-on: https://chromium-review.googlesource.com/1183623Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#585005}
-
Juan Antonio Navarro Perez authored
Add a function to conver the data returned by test-results server about known masters, builders, and test_types into a DataFrame for more convenient querying of the data on it. Also add a corresponding unit test. NOTRY=true Bug: 875251 Change-Id: Ifa03250669fe3b661f093ff0e1ca172db85fade6 Reviewed-on: https://chromium-review.googlesource.com/1179888 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585004}
-
Alexander Hendrich authored
This CL adds a python schema validator that can validate JSON schemas. The schema validator is used in a presubmit to validate all the schemas in policy_templates.json. The schema validator itself supports the minimal set of features needed for our current policies. Bug: 873641, 856903, 856901 Change-Id: Ie577e825807e4438eca6921722b88af7c8d1781c Reviewed-on: https://chromium-review.googlesource.com/1172433 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#585003}
-