- 24 Sep, 2020 23 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19ce8322..4ee4324d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icc8066c1fd0577bf8fa8a666471779329b01b4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810044}
-
Minoru Chikamune authored
[MBI] Make ThreadTaskRunnerHandle::Get() return currently active AgentGroupSchedulerImpl's default task runer. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I4a215c8cd93f10e894071af6836027289d8225a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413728Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#810043}
-
Hirokazu Honda authored
This CL fills VideoEncoderInfo::fps_allocation in VaapiVideoEncodeAccelerator properly in temporal SVC. Bug: 1030199 Test: vaapi_video_encode_accelerator_unittest Change-Id: Iba020a26841d6ed35ad4b5bbf0d4cfc1442b282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425606 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810042}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a4f6db0. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" 8d82b92f "Origin isolation: add crash test for noopener popup windows" 6a4f6db0 "MSE-in-Workers: Cross-thread registry with stubbed attachment" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: If2e72a490c721d20991eaa5cc3d362dc57f676c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426367Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810041}
-
Xiaohan Wang authored
While we are in "media" namespace, no need to use "media::" Change-Id: Icf214d62b2d2c7203ce8399cce6ee68c0b771503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427020 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#810040}
-
Rafael Cintron authored
Since owned_fd (and future 'owned' objects) have their own notion of being null/invalid and are mutually exclusive of one another, there is no need to keep a separate GpuFenceHandle "type" member variable. To facilitate empty objects on some platforms, adjust the declaration of needs_comma to avoid 'variable not used' warnings from the compiler. Bug: 1131616 Change-Id: I2da1b719ac2770edcbf1f5e9c26b909004925170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423164Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810039}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie6290c0851c773a43ca2a466801bdf119e127780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810038}
-
Lei Zhang authored
https://crrev.com/809702 added a global constant to ambient_background_image_view.cc, but the constant adds a static initializer. Avoid this by making the constant local to the method it is used in. Then it is initialized on first use instead. Bug: 537099 Change-Id: I1724e5a563e1a30a6aa6c8b306626ec86f6a570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427549Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810037}
-
Caroline Rising authored
This change is behind the kReadLater feature flag. Add new tab context menu option for adding one or more tabs to read later. Bug: 1131030 Change-Id: Id902a40ccb3c3bc86a28fc8b9aa5ab7d92878896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426343 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#810036}
-
Xinghui Lu authored
Log SafeBrowsing.Settings.* user action sequence on both desktop and Android. Break "Showed" into different entry points so we can analyze users's behavior based on different entry points. Bug: 1124491 Change-Id: I6a30765ae8754b88eb8cb4a6f9fcd89be0d7d78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416564 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#810035}
-
Kuo Jen Wei authored
Bug: 1123750 Test: Manually Change-Id: Ic690c74ebab88563d98ae753213ab25e3d763435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425687 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810034}
-
Noel Gordon authored
Load a file containing UTF-8 and other characters in the preview panel and wait for the <webview> to load and display the file content [1]. Read the displayed text content and verify. Test is a PASS if the text content of the <webview> contains 'їсти मुझे |∊
☀ ✌ ✂ ♁🙂 \n' and the right file size "191 bytes" is shown in the quick view metadata box. [1] Note: the test file must have a file extension that is known to be text (an extension that files app deems to be text) to enable UTF-8 in the preview panel <webview> renderer. Test: browser_tests --gtest_filter="*openQuickViewUtf8Text" Bug: 1064855 Change-Id: I7c07b7f98922a1bb93ea2b46c3bc93dd4ee9085d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426084 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810033}
-
Thiabaud Engelbrecht authored
Bug: None Change-Id: I5590d0fa8e19f8d8c40bc1acc6cf458e6850d8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426467Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#810032}
-
Maksim Ivanov authored
This CL fixes this script to use a correct exception class (RuntimeError) instead of non-existing RuntimeException one. Bug: none Change-Id: I221f66ac7eac4af46f53f7137840fbf62445e4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426567 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810031}
-
Hiroki Nakagawa authored
This reverts commit e69195e1. Reason for revert: This is a speculative revert. updater_tests has been failing on Win7 Tests (dbg) since the CL range containing this change: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85110 Original change's description: > Initialize the WRL::Module only once. > > The issue with the crashing code is that on the RPC client side > of the updater, both update and control services must be instantiated. > They both called WRL::Module::Create, which caused WRL code to assert. > > The server side of RPC also initializes the module, in a slightly > different way. Therefore, module initialization in the App base > class is not practical. It has to be done in a way specific to > the client, or the server, or the mode App is instantiated as. > > Using a leaky singleton is not great. However, there is singleton > already in the WRL::Module, so a leaking singleton in the updater > just shows that fact. > > Bug: 1128748 > Change-Id: I646c5ef779c4affe7f2fe8f751d1dea1f16f8608 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414847 > Reviewed-by: S. Ganesh <ganesh@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807682} TBR=ganesh@chromium.org,sorin@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1128748 Change-Id: I63884d9bc165130c7eaab196520eb4583c87970d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426149Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#810030}
-
Chris Palmer authored
Use Clang option -ftrivial-auto-var-init=pattern in production on more platforms. Previously it was only enabled on Linux in production; now it's on for all Desktop platforms. This CL may reduce time efficiency and increase object code size. We hope the effect is within an acceptable range, however. Notably, V8 opts out. Bug: 977230 Change-Id: I785638c3a6d0d08c999031769ed9f858086515b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410588 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810029}
-
Jared Saul authored
This should be a no-op because the functionality for this switch was removed back in May, in https://chromium-review.googlesource.com/c/chromium/src/+/2191161. Change-Id: I630a03b4a82857c1e9785e4472c5cb4108dd57e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422256Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#810028}
-
Keishi Hattori authored
This reverts commit 23b8809f. Reason for revert: Showed regression even on non debug builds crbug.com/1131453 Original change's description: > Insert CheckIsNotDestroyed() in all LayoutObject Methods > > CheckIsNotDestroyed() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected. > CheckIsNotDestroyed() should be the first statement for all methods on LayoutObject and its subclasses. > > Bug: 1030176 > Change-Id: I4862ad8d068311b8cccf3881b21f0d62f787c333 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409837 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809687} TBR=haraken@chromium.org,keishi@chromium.org,ikilpatrick@chromium.org Change-Id: I99213419df0c39d9d6c39e4b8117354126c4e2e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427605Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810027}
-
Xianzhu Wang authored
This reverts commit b179b125. Reason for revert: for debugging crbug.com/1121730 Original change's description: > Enable transformed rasterization for most layers > > Background: transformed rasterization is used to render sharp text in a > composited layer with fractional transform. It snaps the composited > transform of the layer to whole pixels, then applies the fraction > during rasterization. > > Previously we disallowed transformed rasterization in blink for directly > composited layers (excluding backface-visibility:hidden and trivial 3d > transforms such as translateZ(0)), especially for will-change:transform > because change of fractional transform would cause re-rasterization > which would defeat the purpose of will-change:transform. > > Now for a layer that was not eligible for transformed rasterization, > calculate the initial raster translation which achieves sharp text > rendering with the initial transform. When the transform of the layer > changes, keep its original raster translation to avoid invalidation > of tilings, to ensure animation performance. The rendered result will > be blurry during animation but the initial rendering result is sharp. > > Remove blink-side transformed rasterization conditions and let cc > decide it based on screen and draw transforms of the layers. > > Bug: 1111195 > Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798268} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111195, 1121630 Change-Id: Ibab42e963cab263cab062377ffa2aad38291c5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427125Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810026}
-
Alan Cutter authored
This CL splits ExternalWebAppManager's config loading flow into discrete steps and removes the various testing entry points that omit or duplicate logic used by the real thing. Tests can now inject data (file_utils, config_dir, configs) into the config loading pipeline instead of having separate mini pipelines just for them. This change is in preparation for adding a new "FilterExtensionIds" step to the config loading flow. Without this refactor there would be duplication of logic between real and test code code paths that would be prone to bitrot and missing real coverage. Bug: 1128801 Change-Id: Ie5e87b26ab47782fab6589a4127df3ea5e876fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423823Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#810025}
-
Wenyu Fu authored
Seems fonts are only loaded when it is needed. Adding empty text view to load Google Sans to "preload" for following pages. More context in the original bug. Bug: 1119990 Change-Id: I026b80cf15b939c30f97a1174aad4d8259ef66b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427524Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810024}
-
Alexandre Courbot authored
I'm trying to watch less stuff in Chromium. Still staying owner in some media/gpu directories. BUG=None Change-Id: I2678d405f083e75841cbc341e1d02752a44cf576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426144Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#810023}
-
Natalie Chouinard authored
Show vertical scroll bars on settings screens, matching the Material style. These scroll bars appear briefly when the settings screen is opened, and again whenever the user scrolls the page to show their current scroll position. This change only affects settings screens that extend PreferenceFragmentCompat. Other custom setting screens will be addressed in follow-up bugs (i.e. https://crbug.com/998609). Bug: 1131073 Change-Id: Ie9c9a7f118e9a00d5f5439d285fb67958b83b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424506 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#810022}
-
- 23 Sep, 2020 17 commits
-
-
Dirk Pranke authored
The existing documentation for where to put any artifacts produced by a test wasn't completely clear, so this adds some additional text to hopefully make it so. Namely, paths should be specified relative to the location of the results file, which normally is in $ISOLATED_OUTDIR, meaning that the paths will also be relative to $ISOLATED_OUTDIR). Change-Id: I7f03b9f31e7141051a4c783c383547e9dd27d286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426975 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#810021}
-
Rune Lillesveen authored
Accessibility code calls EnsureComputedStyle during layout. That is not strictly a problem, but we lazily clear computed styles outside the flat tree during EnsureComputedStyle when querying computed style outside the flat tree. Since we use the style recalc code to clear ComputedStyle objects from a subtree we got a lifecycle issue with going to style recalc during layout. It would be interesting to find out why we end up querying computed style for an element outside the flat tree for accessibility, but otherwise using style recalc traversal to clear the ComputedStyle objects was a bit more complicated than necessary. This CL introduces a separate traversal that just clears ComputedStyle along with dirty bits instead of going through style recalc. TEST=StyleEngineTest.* Bug: 1130436 Change-Id: I22ce417c6bc133e0429ba794f555821d74d08512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424344Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810020}
-
Hidehiko Abe authored
Now modifiers are tracked in XkbTracker, so remove the cache from exo::Keyboard. Instead, it is cached in WaylandKeyboardDelegate for re-sending purpose. BUG=1123705 TEST=Ran exo_unittests locally. Change-Id: I2800f507a030a938d2e0d58163e2e5005f1de299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426663Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810019}
-
Josiah K authored
Fixing accessibilityPrivate.on* names to only be used for events. No functional changes - should be mechanical only. AX-Relnotes: N/A Change-Id: I9e6af36eff39a3fdee09b38ff1cec91c366ea14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423058Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#810018}
-
Khushal Sagar authored
This mode is currently at 1% stable and the data shows improvements in scroll latency and smoothness. R=sunnyps@chromium.org Bug: 1080911 Change-Id: I3b8e2455eebcf05369758f120bc63cb209162c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427347 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#810017}
-
Haiyang Pan authored
See crbug.com/1111436#c35 and #c36 for detail. Bug: 1111436, 924194 Change-Id: Iacbe51efafbc521ac891f66e82ce89b78864d404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427028Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#810016}
-
Weilun Shi authored
The summary child in the histogram tag should not be empty. Change-Id: I7030df527b7852bd36de9e37ab48d09fca600d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422985 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#810015}
-
Melissa Zhang authored
This CL adds accessible names to the buttons on the sharesheet for screen readers. Bug: 1131296 Change-Id: I4182b3ed982e9f4da7800502ab530e458f91dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423646Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810014}
-
Elly Fong-Jones authored
This reverts commit 4c93f79b. Reason for revert: broke ash_unittests on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20568 2020-09-23T19:55:14.797906Z 17555455662 FATAL ash_unittests[27683:27683]: [gles2_implementation.cc(6920)] Check failed: mailbox.Verify(). CreateAndConsumeTextureCHROMIUM was passed a mailbox that was not generated by ProduceTextureDirectCHROMIUM. Original change's description: > desks: Add tests for RootWindowDeskSwitchAnimator. > > Test: added > Bug: 1111445 > Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809854} TBR=afakhry@chromium.org,khushalsagar@chromium.org,sammiequon@chromium.org Change-Id: I7803aa521023f1063f7cb584126bbffb5311c420 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427037Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810013}
-
Akihiro Ota authored
This change adds a test that confirms the behavior of the 'Exit tutorial' button in the interactive tutorial. Clicking this button should close the tutorial and return ChromeVox to the web content. Bug: 1127047 Change-Id: I12e348fed7e01cc73b54e204cc9447a95b73e86d AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416818 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810012}
-
Patrick Noland authored
Rather than setting the profile each each time directly, we inject a supplier that can be observed. This reduces the complexity of the interface and will let us constructor inject the supplier more easily in the future. Change-Id: Ibd587e1a5496e5bca3d27eb7120aacbedb2ff138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419635 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810011}
-
Caitlin Fischer authored
The IPH_Bookmark feature is no longer in the code. Bug: 1126640 Change-Id: I06773fe1440c046bb5138ec44a6c3ebd02ccb578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427348Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#810010}
-
Benoit Lize authored
Bug: 1013082, 998048 Change-Id: I9b44c0da86f9fd93046a57fdd7f397122b90e3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424218 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#810009}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I84ff78d0100606a1cbc69ecd5840a57f8776debd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426976Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810008}
-
Xianzhu Wang authored
This is the first of a series of CLs to improve performance and flexibility of subsequence caching. The basic idea is to split a previous monolithic PaintArtifact into segments which are the basic unit of subsequence caching. A segment will be created when we start or end a subsequence. It's either a leaf subsequence or the gap between two leaf subsequences. When a subsequence can be cached, its segments will be copied from the previous PaintArtifact with trivial cost. The mechanism will work for both CAP and pre-CAP. In pre-CAP we'll also use one PaintController for each local frame tree, and we'll also create segments at GraphicsLayer boundaries. In this way, the difference in painting of CAP and pre-CAP will be greatly reduced. This CL prepares PaintArtifact and PaintChunkSubset for segmenting. PaintChunkSubset supports iterating paint chunks in a PaintArtifact: - for all paint chunks; - for a subset of paint chunks, with a segment range, which will be for pre-CAP GraphicsLayers; - for a subset of paint chunks, with an array of paint chunk indices which will be for CAP layerization algorithm, including CompositeSVG for SVGs. Now we can also iterate the display items in a chunk with PaintChunkIterator::DisplayItems(), so that a PaintChunkSubset (which references the containing PaintArtifact) can represent all painted result of a composited layer. Bug: 917911 Change-Id: I5c894e105463e866ac38a17cdc9c5e43eca6a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407298Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810007}
-
Miguel Casas authored
This CL removes VaapiWrapper::SubmitVAEncMiscParamBuffer, pushing the logic to its only client, VaVEA. Bug: b/166646505 Change-Id: Ic671525e6936856ec370c3670f35665c4b185b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414565Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810006}
-
Mark Schillaci authored
This CL addresses an issue with <div role="progressbar"> not being interesting on Android. With this CL, kProgressIndicator's are now set to interesting by default, making it possible for a user to linearly navigate to the node via a screenreader. We have added a new method, IsSeekControl, to differentiate progress indicators, which are range type nodes, from the other range type nodes, such as sliders, which allow the user to use seek control to set the value. A user should not have the ability to seek control and change the progress of an indicator. AX-Relnotes: Progress indicators (role="progressbar") are interesting on Android Bug: 1129688 Change-Id: Ifca9a4048d695e33eedbb1b0bd43e97fcb8d29ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424976Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#810005}
-