- 14 May, 2018 40 commits
-
-
kylechar authored
The D3DVsync feature doesn't work with OOP-D, so don't try to use it at the same time. GpuVSyncProviderWin can be simplified with OOP-D as it's just an ExternalBeginFrameSource essentially without the process boundary. Bug: 787814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I814671841df65fcd3141bcfa2ca9db8ea745ea0b Reviewed-on: https://chromium-review.googlesource.com/1057846Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#558390}
-
Vlad Tsyrklevich authored
BUG=842768 Change-Id: Ic59dcbb02d413d9830e11fd7117307c31ee60621 Reviewed-on: https://chromium-review.googlesource.com/1057948Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558389}
-
Ken Rockot authored
This reverts commit 27c99670. Reason for revert: https://crbug.com/841565 Original change's description: > Mojo EDK: Improve internal process handle ownership > > Mojo passes around base::ProcessHandle values for various reasons. On > most systems this is fine, but at least on Windows, a ProcessHandle > refers to an owned reference to a system process object, and if not > careful it's possible for a base::ProcessHandle value to inadvertently > change meaning over time. > > This CL introduces the concept of a move-only ScopedProcessHandle > within Mojo, which on most platforms is just a base::PlatformHandle. > On Windows, this represents an owned base::ProcessHandle which closes > on destruction and clones correctly using DuplicateHandle rather than > merely copying the raw handle value. > > ScopedProcessHandle is used in a few places where process handle > ownership semantics were previously weaker than necessary, or were > correct but implemented ad hoc. > > This also updates ScopedPlatformHandle (and supporting code like > Channel::RewriteHandles) such that the |owning_process| field (if not > the current process) is always an owned process handle. This ensures > that when such handles are closed in unsent messages, they can be > safely closed in the target process (from within the source process) > without any risk of raciness against target process termination. > > Bug: 837612 > Change-Id: I943bb5f70ede56351d52b2ecea7d76fcfdee46ce > Reviewed-on: https://chromium-review.googlesource.com/1036459 > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555117} TBR=jcivelli@chromium.org,rockot@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837612 Change-Id: Ief6e1d6d6f2f96dc7420e06d8438cc06cbf17490 Reviewed-on: https://chromium-review.googlesource.com/1057699Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558388}
-
gogerald authored
Bug: 829965 Change-Id: I0edaa674fc4820dc6229270abd53ba92ae72d18a Reviewed-on: https://chromium-review.googlesource.com/1057845Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#558387}
-
Jao-ke Chin-Lee authored
Also clean up some other migrated builders. BUG=793905,793907,793908,793914,793944,793913 Change-Id: I0a047112e0cf319bb00ad45f2c8441d96060ca67 Reviewed-on: https://chromium-review.googlesource.com/1056467Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558386}
-
Daniele Castagna authored
Add a comment explaining why it's ok to silently fail to schedule an overlay plane in GbmPixmap::ScheduleOverlayPlane when fb is 0. Bug: 779356 Test: It's a comment Change-Id: Id68fe9464b1b18023d16176005c8fb5af62e8c6f Reviewed-on: https://chromium-review.googlesource.com/1057867Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#558385}
-
Charlie Harrison authored
We have a suitable UKM replacement now. Bug: None Change-Id: Ic628dbc19b69f56d0ee5a4184f8bcb786348c594 Reviewed-on: https://chromium-review.googlesource.com/1056330Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558384}
-
Boris Sazonov authored
This CL converts ManagedPreferenceDelegate into an interface and replaces most of its anonymous subclasses with lambdas. Bug: None Change-Id: Icb207a94dcc268c326836eb3204a74b212e40d71 Reviewed-on: https://chromium-review.googlesource.com/1047870Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558383}
-
Kyle Horimoto authored
The base class for this factory ensures that only one operation instance is active at any time. Bug: 824568, 752273 Change-Id: Ia0b4220aef2f021802b7f43ead7b2915a7cf983a Reviewed-on: https://chromium-review.googlesource.com/1054097 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#558382}
-
Bo Liu authored
Getting too many file open error reports relatively frequently. Try raising the fd limit to see if things improve. Changed base implementation to only increase the fd limit. In case this is used in webview and app has already set the limit above what we need. Bug: 842271 Change-Id: I418ea96b4a51fd15e8166d111a191d00153a565c Reviewed-on: https://chromium-review.googlesource.com/1056070Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558381}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1de725e0b53..babd098f3684 $ git log d1de725e0..babd098f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 ehmaldonado gclient: Simplify GetScmName and CreateSCM. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I63a00f02cbf4ee0a5c3c83fe758b807edf801abe Reviewed-on: https://chromium-review.googlesource.com/1057894 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558380}
-
Alexis Hetu authored
While running layout tests on MacOS, one of the tests failed within CopyTextureCHROMIUM() because of an unsupported type. The origin of the failure was wihtin canvas_color_params.cc, where GL_HALF_FLOAT was used instead of GL_HALF_FLOAT_OES. The validators for this type is initialized within gpu/command_buffer/service/feature_info.cc and contains GL_HALF_FLOAT_OES, but not GL_HALF_FLOAT, which isn't supported on GLES2 and unfortunately has a different value. Bug: chromium:757974 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If7a28c53db4a4f6acef035ee432153cec4f0acbb Reviewed-on: https://chromium-review.googlesource.com/1057360Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558379}
-
Alan Cutter authored
This CL is the start of a refactor to pull update methods for page action icons out of the LocationBar interface and into a PageActionIconContainer interface so that page action icons can live outside of the location bar. Design doc: https://docs.google.com/document/d/18HJywSmw6JiYMxFTbP496ivilPblOT8A63V12ip3ymE/ Bug: 788051 Change-Id: I2ae0e289d1e777e7bde5d0d73094dbbc60b2109a Reviewed-on: https://chromium-review.googlesource.com/1049126Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558378}
-
Findit authored
This reverts commit 78aa0578. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 558371 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc4YWEwNTc4ZTA2Y2MyODgzNDNkMzk1Mzk3MzZhYzdjMzJhMTJlNTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/64263 Sample Failed Step: compile Original change's description: > Add a tool to render new QUIC trace format using gnuplot > > Merge internal change: 195841296 > Merge internal change: 195910638 > > R=rch@chromium.org > > Change-Id: Id9681a3360ced19d329b68e161ff897e17ef43e7 > Reviewed-on: https://chromium-review.googlesource.com/1055756 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558371} Change-Id: I533684421c474ebb17bfcc1cd7aabbc5aa7d4bd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1057528 Cr-Commit-Position: refs/heads/master@{#558377}
-
Sergey Ulanov authored
Now the config files refers to the open fonts from third_party/test_fonts instead of ms-ttf-corefonts that were used previously. Also fixed android_fallback_fonts.xml to refer to NotoSansCJKjp-Regular.otf instead of NotoSansCJKkr-Regular.otf to match the fonts we have in //third_party/test_fonts Bug: 787020 Change-Id: Ie50f76c0a183e9904a3dae2d6fef091a6c2abe83 Reviewed-on: https://chromium-review.googlesource.com/1048872Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558376}
-
Jeffrey Yasskin authored
I left one instance of "whitelist" in shared_modules, where it's actually part of the public API. BUG=842296 Change-Id: I63c8533c88801c283af5a6ddca710c2a246ce6bf Reviewed-on: https://chromium-review.googlesource.com/1056027 Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558375}
-
Sorin Jianu authored
The retries are set to 3, as most of the Chromium code using the url fetcher does. Bug: 842364 Change-Id: I0f6e295231c36301c6ca44806233f841d316b58e Reviewed-on: https://chromium-review.googlesource.com/1056222Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558374}
-
Koji Ishii authored
Following CL:986982 that optimizes re-layout for inline by re-using previous items, this patch invalidates the re-use when the resolved direction is changed. The resolved direction is an input to HarfBuzzShaper that such items need to be reshaped. This patch is on top of another invalidation fix CL:1056647 to avoid conflict in FlagExpectations. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic5fd81985db1aa0f05762fda63430d96a632ea89 Reviewed-on: https://chromium-review.googlesource.com/1056648 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#558373}
-
Ben Pastene authored
When a test command is specified, the run_cros_vm_test will run the vm sanity test. This test is baked into the VM and smoke checks the system browser by loading empty pages and running some simple javascript. Since it depends on the system browser, we need to first deploy a locally built Chrome to the VM (via the --deploy arg). The deploy script needs to know the gn args that built the browser to know which libs to copy over. Since we don't have the full set of args at test-time, give it a dummy set of args to trigger the default deploying behavior. Bug: 832374 Change-Id: I84f7fdd94672fcb220eaa4d9625395c1d0ab7636 Reviewed-on: https://chromium-review.googlesource.com/1050981 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558372}
-
Victor Vasiliev authored
Merge internal change: 195841296 Merge internal change: 195910638 R=rch@chromium.org Change-Id: Id9681a3360ced19d329b68e161ff897e17ef43e7 Reviewed-on: https://chromium-review.googlesource.com/1055756Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#558371}
-
nednguyen authored
TBR=charliea@chromium.org NOTRY=true # test covered by CQ Bug: 838504 Change-Id: I8ec5666a5b15df157ec552f06c1504a3592ef482 Reviewed-on: https://chromium-review.googlesource.com/1057954Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#558370}
-
Koji Ishii authored
Following CL:986982 that optimizes re-layout for inline by re-using previous items, this patch invalidates the re-use when LayoutText is moved. LayoutObject::InsertedIntoTree() catches the most cases, but we have an optimization to skip the notification when LayoutObject is moved within the same tree. The inline items need to be invalidated in this case as well, because they depend on context and in which inline formatting context (LayoutBlockFlow) it belongs to. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia65d3e1e948c4eb0079cf81027e84ac5a90b339e Reviewed-on: https://chromium-review.googlesource.com/1056647 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#558369}
-
Sandeep Vijayasekar authored
Test: cast_shell_junit_tests Fixes: removes unnecessary code Change-Id: I1debe20ff2cddf6818c2c2861bb77251a56a4118 Reviewed-on: https://chromium-review.googlesource.com/1056169Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558368}
-
Joe Downing authored
This feature controls whether the low-level keyboard hook is enabled when keyboard lock is requested. I wanted to separate browser and system level keyboard lock functionality as I get closer to launching the blink api for keyboard lock. This will allow us to release browser-level keyboard lock w/o the system hooks if needed and will also give us the ability to target a finch kill switch for the system-level functionality if needed. BUG=680809 Change-Id: I2d522046c90fd8776bfb1d9c53978f2c41e1c7cc Reviewed-on: https://chromium-review.googlesource.com/1046154Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558367}
-
Eugene But authored
- use EmbeddedTestServer instead of web::HttpServer - do not assert inside test helpers - inherit fixture from WebTestWithWebState - replace deprecated base::test::ios::WaitUntilCondition with testing::WaitUntilConditionOrTimeout Bug=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e7fbd67193f68fc5575fc529a7ac1f80d89126c Reviewed-on: https://chromium-review.googlesource.com/1055777Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558366}
-
Mark Pilgrim authored
Bug: 842484 Test: CommonNameMismatchBrowserTest.NoCrashIfBothSubdomainsHaveCommonNameErrors Change-Id: I6551dfbc129a544e449040c12a30236c6a57efe8 Reviewed-on: https://chromium-review.googlesource.com/1057417Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#558365}
-
Daniel Bratell authored
Unfortunately there are two i18n namespaces, including one global one, so if you are in ::autofill, referring to i18n is ambigious if the compiler knows about both of them. This happens in jumbo builds which means that my previous jumbo fix here didn't actually work. Change-Id: I7467ff958e93433581da0134d9a6e8ddd21bde49 Reviewed-on: https://chromium-review.googlesource.com/1057728Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#558364}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df79808d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17628 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Ia28c569855eb9bfde15cc3300936177394cb190a Reviewed-on: https://chromium-review.googlesource.com/1057419 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558363}
-
Stephan Stross authored
comparative_tester.py contains the initial comparative testing script, designed to accept a list of test targets, compile and build the targets(and generate them with default args using gn if necessary), build them using ninja and goma, and then execute them, sending targets one at a time to both linux and fuchsia NUCs to be executed. Once a test is completed, its output is filtered for informational lines, they are collated, and written to csv. Bug: 839491 Change-Id: I287470ae9f50f169fbd1d9296c69ee9560318837 Reviewed-on: https://chromium-review.googlesource.com/1031294 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558362}
-
Farah Charab authored
Change-Id: I0ab635c48c63ff68a8aeca1d725904d0f4eb56b9 Reviewed-on: https://chromium-review.googlesource.com/1053774Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558361}
-
Ryan Sleevi authored
//components/certificate_transparency is logically stuff that would belong in //chrome/browser/net ideally, and //net potentially in the much longer term, but for various reasons lives in between. Update the OWNERS to reflect that BUG=none Change-Id: I1046e6cda5b9233d3aa20cabb77f69fe79cbada1 Reviewed-on: https://chromium-review.googlesource.com/1055737Reviewed-by:
Eran Messeri <eranm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558360}
-
erikchen authored
This CL is a refactor with no intended behavior change. Previously, observers were using the |index| parameter and comparing against TabStripModel::active_index() to determine if the detached tab was active. This relies on assumptions about the timing of TabDetachedAt(), which will soon be changed. Bug: 842194 Change-Id: I282bcd42a17701f8f3347d535b2bebfa6d7fd8fa Reviewed-on: https://chromium-review.googlesource.com/1055748Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558359}
-
Corentin Wallez authored
https://chromium-review.googlesource.com/c/chromium/src/+/655801 modified the code tweaking the GPU Info with driver-provided information and added a an ASSERT that didn't exist previously. It gets triggered probably because the driver returns information that doesn't match our SystemInfo. BUG=chromium:842650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife295b97d050814d6173ca96626fe1cc7c4bd3a5 Reviewed-on: https://chromium-review.googlesource.com/1057421Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558358}
-
Peng Huang authored
Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5457797bc7166e9af193c3ff3f248c146833c58d Reviewed-on: https://chromium-review.googlesource.com/1055615Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558357}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d936a701..d58b7e0b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5bc1844c2601ac3f373d7b5c071be58252a9c7ec Reviewed-on: https://chromium-review.googlesource.com/1057463Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558356}
-
Bailey Berro authored
Adds username and password as parameters to SmbSerice::Mount and the corresponding internal functions. Bug: chromium:757625 Change-Id: I8e5f9ea4f9779746703d066098408afc4489f620 Reviewed-on: https://chromium-review.googlesource.com/1054690 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558355}
-
Eugene But authored
Wait until the navigation is committed before stopping the load. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f8d65bd2ee6e4a6617257ad83e19cc9a9ba5c2e Reviewed-on: https://chromium-review.googlesource.com/1054707Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558354}
-
https://pdfium.googlesource.com/pdfium.git/+log/e20f0c4938f8..22c24441a3a4 $ git log e20f0c493..22c24441a --date=short --no-merges --format='%ad %ae %s' 2018-05-14 npm Merge some values of JBig2_Result Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcc8a73f0133d64caa10b840b94e93eca5b24ea5 Reviewed-on: https://chromium-review.googlesource.com/1057690 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558353}
-
Emily Hanley authored
Bug: 840427 Change-Id: I80c13fefb4e5594ad29a6511845415584d7ea11a Reviewed-on: https://chromium-review.googlesource.com/1047854Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558352}
-
Brian Osman authored
There are only 7 ColorFormat values. Bug: chromium:842483 Change-Id: I92e10ed9147b8df607fd5ea62e9a0a5f2300c14c Reviewed-on: https://chromium-review.googlesource.com/1057452Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#558351}
-