- 27 Jun, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0de1093..56b60a2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib5be3feec7c019250980dc87c92183b40ec13934 Reviewed-on: https://chromium-review.googlesource.com/1117119Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570809}
-
Becca Hughes authored
This refactors the code that sends the safe areas moving it to WebContentsImpl which will be useful for metrics later on. BUG=855721 Change-Id: I9d4976ec9bdeddef3b0d8a1a824b8a65f78516ba Reviewed-on: https://chromium-review.googlesource.com/1112071Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570808}
-
Marc Treib authored
In particular, this gets rid of ProfileSyncServiceStartupCrosTest, which was not meaningfully different from the non-Cros version. Also adds a few extra assertions and comments. Bug: none Change-Id: Iabba34647d084b1518a2cea239c9f25d463aa27b Reviewed-on: https://chromium-review.googlesource.com/1117073 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570807}
-
Eugene But authored
Dismissing SSL interstitial may change SSL status, in which case WebStateImpl should call WebStateObserver::DidChangeVisibleSecurityState Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If9737cfa13829f17c2f4d9b5d965df2197f71669 Reviewed-on: https://chromium-review.googlesource.com/1114839 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570806}
-
edchin authored
This CL adds keyboard shortcuts related to opening tabs to the tab grid. - Command + n = open new (regular) tab - Command + Shift + n = open new incognito tab - Command + t = open new tab in current window Bug: 818451 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iae029bf53f5a2d71c2fe569b6481ee9eeec98ef0 Reviewed-on: https://chromium-review.googlesource.com/1116257 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570805}
-
Ivan Sandrk authored
Currently managed Chrome OS devices support remote commands issued by the admin on CPanel. Add a command that wipes all the users off of the device when run (equivalent to removing all the user PODs manually from the login screen). Most changes are glue or wiring things through, main files are: - device_command_wipe_users_job - user_removal_manager More details at the design doc @ go/remove-users-command Bug: chromium:827467 Change-Id: I77a130bf4dda0757a60a141713baae27d2b5b5a2 Reviewed-on: https://chromium-review.googlesource.com/1107803Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570804}
-
Oystein Eftevaag authored
NOTRY=true TBR=nednguyen@chromium.org BUG=857108 Change-Id: I6618a9fd72d4b618d6228d6ab1bc58b98c96664e Reviewed-on: https://chromium-review.googlesource.com/1117209Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#570803}
-
Jason Roberts authored
Bug: 856704 Change-Id: I48b28d389aa602718c5dae2afed98dc19322dd24 Reviewed-on: https://chromium-review.googlesource.com/1115356Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jason Roberts <jasonroberts@chromium.org> Cr-Commit-Position: refs/heads/master@{#570802}
-
chrome://killWez authored
The implementation of this debug URL was changed in https://chromium-review.googlesource.com/c/chromium/src/+/907675 to one which _exit()s the process under POSIX, rather than self-terminating via kill(). Since we detect process kills (versus self-termination, crashes etc) by checking for SIGTERM, this broke chrome://kill. Fix chrome://kill by explicitly kill()ing the process, and structure the implementation to make clear that we need to simulate termination by a peer process, specifically. Bug: 806451, 854926 Change-Id: I0408dd1d248e04b3045f37d46051c220b33ab081 Reviewed-on: https://chromium-review.googlesource.com/1116076Reviewed-by:
-
Justin Cohen authored
Bug: 852705 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I611e9625e988e077f61e71e58a7f44b741a20eab Reviewed-on: https://chromium-review.googlesource.com/1116702Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Scott Graham authored
This reverts commit 0895c797. Reason for revert: Missed a hardcoded gn location: https://crbug.com/857107. Original change's description: > Pull GN via CIPD package > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where gn is no longer in buildtools. > > Because buildtools has no way to cleanup after itself, add > build/util/gn_cleanup.py to delete the old binaries so that we don't > accidentally depend on them. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Bug: 855791 > Bug: 794764 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 > Reviewed-on: https://chromium-review.googlesource.com/1112840 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570792} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I89e180710b5ce483106fa3b4ff6e8dec06780c07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 794764, 856883, 856884, 856878, 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117219Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570799}
-
danakj authored
If the gpu process crashes, the viz service is gone and bitmaps need to be re-registered, but they are still valid bitmaps. So we can keep the ResourceId alive and not returned it as lost to the client in that case. R=kylechar@chromium.org Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1ef6af3a90bf90310793fcdbbb70ea00a0d85d25 Reviewed-on: https://chromium-review.googlesource.com/1115591Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570798}
-
Qiang Xu authored
changes: MagnifierType is only used in chrome/. This CL moves it to chrome/. TBR=emaxx@chromium.org Bug: none Test: compile Change-Id: I75241de96f77004b906cfb762829c9bd01e470b9 Reviewed-on: https://chromium-review.googlesource.com/1116760 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
gogerald authored
Bug: 856743 Change-Id: Icee41ddd6bd4d593ae19b12ac601644d0a004be1 Reviewed-on: https://chromium-review.googlesource.com/1115803 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570796}
-
Adithya Srinivasan authored
Using a double timestamp is error prone and it's hard to tell which units are being used. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bb9e1fba0df15be9954cf055abed78016c39c9a Reviewed-on: https://chromium-review.googlesource.com/1114180 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570795}
-
Jonathan Backer authored
ContextState is meant to track GL state. It is used for virtual context switching and temporary changes to GL state (e.g. temporarily change GL state and restore back to ContextState). Whenever we call Ganesh we must assume that GL state has diverged from ContextSate. This CL does 2 things within RasterDecoder: (1) Whitelists certain commands as not caring if GL state has diverged from ContextState. This would be if the command doesn't access GL state (e.g. InsertSyncPoint) or is using Ganesh (RasterCHROMIUM). (2) Does a hard reset back to ContextState whenever the GL state could have diverged from ContextState and a command is not whitelisted. The purpose of the whitelist is to avoid unnecessary state resets on the common OOP-R codepaths. Correctness: - GLES2Decoder: The GL state matches the ContextState before and after a command is executed here. The interesting case is making a GLES2Decoder current. If using a virtual context, we will restore state appropriately when the GLES2Decoder is made current because of RasterDecoderImpl::GetContextState. - RasterDecoder: There are two cases to consider Case 1: Making a RasterDecoder current. If we are using virtual contexts, we will restore to |state_| and GrContext::resetContext because of RasterDecoderImpl::{GetContextState,RestoreState}. If not, we will restore to the previous GL state (either |state_| or GrContext consistent with previous GL state). Case 2a: Executing a whitelisted command: Either the command doesn't inspect/modify GL state (InsertSyncPoint, CreateAndConsumeTexture) or it requires and maintains that GrContext state tracking matches GL context state (e.g. *RasterCHROMIUM). Case 2b: Executing a command that is not whitelisted: We now force GL state to match |state_| with as necessary RestoreState(nullptr). This will GrContext::resetContext. Bug: 856219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I85d9391f833760b37cb70d216e9e1e44ffe1c23f Reviewed-on: https://chromium-review.googlesource.com/1114136 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570794}
-
Owen Min authored
Bug: 855378 Change-Id: I4c14ad013f891f6abe76604321c52e97cecaf874 Reviewed-on: https://chromium-review.googlesource.com/1115433Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570793}
-
Scott Graham authored
The gn binary will be downloaded into third_party/gn. This CL rolls buildtools forward to a revision where gn is no longer in buildtools. Because buildtools has no way to cleanup after itself, add build/util/gn_cleanup.py to delete the old binaries so that we don't accidentally depend on them. Update mb.py to use the new location. Update explicit location in ios/web_view/BUILD.gn for the new location. Update explicit location in tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new location. Update explicit location in tools/licenses.py with for the new location. Bug: 855791 Bug: 794764 Bug: 856883 Bug: 856884 Bug: 856878 Bug: 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 Reviewed-on: https://chromium-review.googlesource.com/1112840 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#570792}
-
Xiaocheng Hu authored
Previous CL crrev.com/c/775550 was supposed to be pure refactoring, but changed behavior that ComputeInlineBoxPosition no longer enters inline blocks, because the CL moved the branch handling atomic inlines above the branch that moves input position into inline blocks. This patch fixes the regression by moving the branches back to their old positions. Bug: 856417 Change-Id: I94a22259f723af11b701d3a1078e68b5729bb0d0 Reviewed-on: https://chromium-review.googlesource.com/1116357Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570791}
-
Kouhei Ueno authored
This CL follows signed exchange spec change: https://github.com/WICG/webpackage/commit/3903da6e Bug: 803774 Change-Id: I7f122272cf93f46a26757b08fe8a9d80f0404518 Reviewed-on: https://chromium-review.googlesource.com/1114403Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#570790}
-
Kevin McNee authored
In EventFactoryEvdev::DispatchPinchEvent, we were attempting to set the scale for pinch begin (and end) events, instead of just pinch update events, which hits the DCHECK in GestureEventDetails::set_scale. Bug: None Change-Id: I6fc89469b4ec1ddc21f102cf3bb181e10243c545 Reviewed-on: https://chromium-review.googlesource.com/1114249Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#570789}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa2ef190cd68..32dc063f6647 git log fa2ef190cd68..32dc063f6647 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 lalitm@google.com Merge "trace_processor: cleanup code in trace parser" 2018-06-25 lalitm@google.com trace_processor: cleanup code in trace parser Created with: gclient setdep -r src/third_party/perfetto@32dc063f6647 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I91d82b062e45888e587348cadc80a356a3124686 Reviewed-on: https://chromium-review.googlesource.com/1116818 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570788}
-
Emily Hanley authored
Bug: 840427 Change-Id: I1f11ed443c31afe50607cde766df13e610a07762 Reviewed-on: https://chromium-review.googlesource.com/1104793 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570787}
-
James Wallace-Lee authored
When a button's textContent changes, post a textChanged notification. A button's textContent is a child of the button container, but in the accessibility tree button elements cannot have children, so ChildrenChanged previously did not update the button. Bug: 793078 Test: DumpAccessibilityTreeTest.AccessibilityButtonContentChanged Change-Id: I2be389c77763cb60fd2fc9951070370856b0c894 Reviewed-on: https://chromium-review.googlesource.com/1110658 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570786}
-
Marc Treib authored
It was never accurate: It was recorded during most profile destructions, even if Sync was never enabled in the first place. Since I'm not aware of anything that depends on this number, let's just get rid of it rather than replace it with something that works. Bug: none Change-Id: I397e499f559852188c731c04cbb748f98a69fe24 Reviewed-on: https://chromium-review.googlesource.com/1117068Reviewed-by:
-
Vaclav Brozek authored
Currently, chrome://password-manager-internals shows AutofillField::Type() as server predictions. This is not completely accurate, because Type() comes from multiple sources, and actually, it is AutofillField::server_type() which is passed to the password form parser as server predictions. Therefore this CL changes the internals page to output server_type() instead. Bug: 855987 Change-Id: Ib4bf8cdcbca21ee38450d6d0a0026dd2da71b2e5 Reviewed-on: https://chromium-review.googlesource.com/1114850Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570784}
-
Joshua Pawlicki authored
Bug: 855724 Change-Id: Ib0a7ccc2f2fe272d53d19ef833b47dcf3994b0ba Reviewed-on: https://chromium-review.googlesource.com/1114096Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#570783}
-
sczs authored
This was ported from the legacy implementation and its no longer needed now. Bug: 839384 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia3edcfb790ec3567fb24b0ebbb02903d5788fec1 Reviewed-on: https://chromium-review.googlesource.com/1116285Reviewed-by:
-
Josh Karlin authored
What: PrioritizedTaskRunner currently runs its tasks (from RunTaskAndReply) in prioritized order but not the replies. This CL adds a priority queue for replies to run in order as well. Why: At least for the cache, the reply task is equally important to the posted task and should run in priority order. Bug: 856674 Change-Id: Icea37adb96891473292e0c38805c42e84f9d4f5f Reviewed-on: https://chromium-review.googlesource.com/1114921Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570781}
-
sczs authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I312851c5408ad34f690dc0b456612506350d8be7 Reviewed-on: https://chromium-review.googlesource.com/1116347Reviewed-by:
-
Rayan Kanso authored
DatabaseTasks can create subtasks out of other DatabaseTasks in order to re-use components and not rewrite code. Change-Id: I04d84e90ddf4e2ac1986f7ccff122d210523d752 Reviewed-on: https://chromium-review.googlesource.com/1112665 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570779}
-
Mustaq Ahmed authored
With User Activation v2, activating a parent frame doesn't activate its subframes. We fixed these two tests by sending the click to subframes. This needed a workaround in auto-click.js because the mutation observer there in doesn't seem to work when a button element is added to a subframe. Bug: 802371 Change-Id: I786668c87b802565e99ad16223cafc8ac1fd6296 Reviewed-on: https://chromium-review.googlesource.com/868323Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570778}
-
Justin Cohen authored
-Fix tapping NTP action cells when omnibox is focused. -Do not remove action items when most visited is empty. -Disable dynamic type sizes on most visited and action items. -Fix omnibox visibility on iPad when search provider changes. Bug: 846764, 852108, 850469, 848762 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie1c38be47fb9a60325387a78f55eb1a548dae831 Reviewed-on: https://chromium-review.googlesource.com/1110148 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570777}
-
Vadym Doroshenko authored
This CL contains: 1.Filtering blacklisted matches in NewPasswordFormManager. 2.Extracting blacklisted matches to |blacklisted_matches_| variable in NewPasswordFormManager. 3.Implementing functions GetBlacklistedMatches and IsBlacklisted in NewPasswordFormManager. Bug: 854197, 831123 Change-Id: I50476c16c2ebfa8c8a1062889b8d133d323233f5 Reviewed-on: https://chromium-review.googlesource.com/1116962Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#570776}
-
bsheedy authored
Disables Skia's CCPR support for the VR browser since it somehow causes serious rendering issues. This workaround can be removed once the root cause is found and fixed. Requires that https://skia-review.googlesource.com/c/skia/+/137763 be landed and rolled first. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4121319cae3a465798077cfeac058d84e9e9dd93 Reviewed-on: https://chromium-review.googlesource.com/1116066 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#570775}
-
Arthur Sonzogni authored
The bug was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1107808 Soon after creating a new provisional DocumentLoader, the parser of the current DocumentLoader is canceled. It can causes document.onreadystatechange to fire. If window.stop() is called it can remove the new provisional DocumentLoader. This CL fixes the bug and add a regression test. Bug: 856759 Change-Id: Ifb39a75d04b250f0c97ebf07c5a9abf1f4631ff7 Reviewed-on: https://chromium-review.googlesource.com/1117038Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570774}
-
Allen Bauer authored
Bug: none Test: none Change-Id: Ifecd2ab5a68c843a835b68f41bd6ac3b248dabde Reviewed-on: https://chromium-review.googlesource.com/1115217 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570773}
-
Marc Treib authored
IsSyncAllowed, IsSyncRequested and HasUnrecoverableError have all been replaced by GetDisableReasons/HasDisableReason, so use those instead. Bug: 839834 Change-Id: Id4939bd4de6a43ae4bfd5c64b6aa79be51a82ebf Reviewed-on: https://chromium-review.googlesource.com/1116704 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Nico Weber authored
Not clear why it wasn't running, and network_service_browser_tests, not_site_per_process_browser_tests, viz_browser_tests already all run and pass -- and what's better than running browser_tests three times? Running it four times, so add vanilla browser_tests too. Bug: 843511 Change-Id: I682375c0c4a5a673a0e5410452d5560cad3ccebd Reviewed-on: https://chromium-review.googlesource.com/1117019 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570771}
-
Nico Weber authored
The one test that used to fail seems to pass now. Bug: 815190,843511 Change-Id: I2e77719aa557b2055209d58dcb3c124bc0ad2576 Reviewed-on: https://chromium-review.googlesource.com/1116899Reviewed-by:
-
