- 10 Dec, 2020 40 commits
-
-
Joel Fernandes authored
Core-scheduling tests have completed and is stable/performant. Make it default enabled. Finch experiment will be set to launch process. Bug: b:152605392 Signed-off-by:
Joel Fernandes <joelaf@google.com> Change-Id: I902e282b23cb95b2f78bf52042fdc5f76aa959c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584608Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835779}
-
David Tseng authored
One test was disabled prior to the migration to changes in SpeechMonitor. Both tests pass locally under heavy load. Let's see if they still flake. R=akihiroota@chromium.org Bug: 1114854, 950049 Change-Id: I6ab79c828e0bcdf3c6e3ae5034b2c3db54d4d68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584684 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#835778}
-
Torne (Richard Coles) authored
Throw IllegalArgumentException if we are passed invalid header names or values via loadUrl() or setUserAgentString(), as this violates a network stack invariant. Remove the metrics collection code (since throwing the exception will generate a crash anyway if the app doesn't handle it), but update the expiry on the existing metric to keep collecting it on older versions until this change goes to stable, for outreach purposes. Bug: 1106002 Fixed: 1153855, 1153856 Change-Id: I84dc2a45ed42e004f1154fe4053d60ea9d0f0167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579913 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835777}
-
Nick Burris authored
* Create LegacyExternalAuthUtils and related classes, which are empty subclasses of the ExternalAuthUtils classes. These will be referenced downstream temporarily while ExternalAuthUtils is moved to //components. * Create empty new target //components/externalauth/android:java so we can add the downstream dependency before the migration. This is patch 2/6 for refactoring ExternalAuthUtils into //components. Bug: 1144858 Change-Id: I928ee2998f7042c85e64d8e91e275d23b789fc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568689 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835776}
-
Yulun Wu authored
Bug: 1155762 Change-Id: I964f4a01300fc2c173b6e1244c0f64da773f2d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582633Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835775}
-
rajendrant authored
This CL changes how resource URL check for robots rules is returned. If results are immediately available they are returned, otherwise nullopt is returned and callback is invoked with the result when available. This CL also introduces an enum to differentiate whether resource was disallowed by robots rules due to rule fetch already timedout or due to new timeout. Bug: 1144836 Change-Id: I55fa7c57b749dd53907c9deb3e045beafd74463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583846 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835774}
-
Greg Kerr authored
This is a reland of d24c918a Original change's description: > CrOS: Enable Hyper-Threading by default if core scheduler is available. > > If the kernel supports core scheduling, Hyper-Threading is enabled by > default. Users, admins and Finch may still override this setting. > > BUG=b:152605392 > > Change-Id: Iffcec33455ec277ec6f79f03908d02015c7d1f6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209676 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Auto-Submit: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774920} Bug: b:152605392 Change-Id: I50590824454aa5d33267d0c6783b002c1925fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584566Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012100600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/yEb6ecEc9J9wemIY47NfFUY-LveAjJpCX06ML5tGgJYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168265723,b/168422458,b/171154801,b/172376551,b/174442020,b/174603791 Tbr: media-app@grotations.appspotmail.com Change-Id: I4385c4c6edac367ee3af82f0017d6725af0dec0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835772}
-
Monica Basta authored
This CL adds a tooltip with the label of the avatar. The tooltip is shown on hover and keyboard focus. Change-Id: I4a64be6f4646353ae65dd941df2dc7ea347357ba Bug: 1157391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581481 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835771}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59df85b5457e..9f89587dc4fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie3e89e19d11eec2dff31256febe98161ce2b611e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835770}
-
Eugene But authored
All these metrics are useful monitoring metrics. Bug: 1156197, 1156198, 1156199, 1156200 Change-Id: I09f024f1e0777b7c31ace21dca5ea6227016999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576944 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#835769}
-
Yashar Dabiran authored
ChromeActivity is used to provide WindowAndroid, BrowserControlsManager and the activity creation time. These dependencies are instead given through direct constructor injection. Bug: 1155786 Change-Id: Ibcdaaf9be26142f7ce3a5d4f0b3ba0667b966627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575858Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#835768}
-
Jan Wilken Dörrie authored
This change adds post increment operations to WTF::Deque's iterators. Without these operations the iterators fail to fulfill the requirements for bidirectional iterators [1] they claim to implement, making them potentially unusable in generic algorithms. [1] https://en.cppreference.com/w/cpp/named_req/BidirectionalIterator Bug: None Change-Id: I72e3371333fe8adcc609c9b05c13693c9e512f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584026Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835767}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d94a77b304f4..35f077086ef3 2020-12-10 sugoi@google.com Context refactor: from OpenGL-like state to Vulkan-like state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I66b984eb939d5639d76e4b250756813a29caef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584353Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I5d3cc0260d9b4611a54f94e5cd7a94f62b7bbbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584690Reviewed-by:
-
Adam Langley authored
In order to have a smooth A/B test, this change duplicates the existing spinner screen used by Play Services for caBLEv1 so that it appears for server-linked caBLEv2. BUG=1002262 Change-Id: I36b4c9fc30693cb94bfd4b82a7dc78921384e59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580839Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#835764}
-
Yue Zhang authored
AllPasswordsBottomSheetViewTest# testCredentialsChangedByModel is failing on "Lollipop Phone Tester". TBR: fhorschig@chromium.org Bug: 1157497 Change-Id: Ic36507ed53a68a13fe06d441ab4eda712c21b689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585445Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835763}
-
Yue Zhang authored
FeedAppLifecycleTest# testSecondWindowDoesNotTriggerForegroundOrBackground is flaky on "android-pie-x86-rel". TBR: harringtond@chromium.org Bug: 1157507 Change-Id: I1bb06e2f27c934db2bb1e2155e8632b6f8175ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585305Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c566c247eb76..6def748c92e9 2020-12-10 lalitm@google.com Merge "tp: use instants for binder events and fixed scoped" 2020-12-10 delphick@google.com Merge "metrics: Clean up actual_power_by_combined_rail_mode test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f2c822c4884e9e1d7352bcff242140eb4bec80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585164Reviewed-by:
-
Sophie Chang authored
The current test waits for the download to be completed but we still need to verify the CRX as the first step and the test often returns the run loop earlier than that Change-Id: I52f163539c4f49b3ffc348346d23d43f510ef461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585304Reviewed-by:
-
Patrick Noland authored
Bug: 1147581 Change-Id: Iaa39fc9bb763955476cfade0cf54bcf069147aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533332 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53f69f15398a..55abaf5893ae 2020-12-10 csmartdalton@google.com Add a stencil test for transparent tessellated strokes 2020-12-10 fmalita@chromium.org [skottie] Add text colorization GM 2020-12-10 jmbetancourt@google.com clean playback methods and constructors in SkottieView 2020-12-10 scroggo@google.com Fix blending bug in animated webp decodes 2020-12-10 johnstiles@google.com Add support for float/int bitcast intrinsics in Metal. 2020-12-10 johnstiles@google.com Add support for float/int bitcast intrinsics in SPIR-V. 2020-12-10 johnstiles@google.com Fix floatBitsToInt family of intrinsics and add tests. 2020-12-10 jvanverth@google.com Revise creation of blitCommandEncoder for speculative fix 2020-12-10 bsalomon@google.com Add read pixels test for GrSurfaceContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I98388a88625eef6a6ad39e60f9f3b041fdef72c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585105Reviewed-by:
-
James Cook authored
Per discussions with product and legal, we want to continue to use a single metrics reporting / crash upload consent on Chrome OS, for both the OS and the lacros browser. Notes at go/lacros-crash-consent This CL connects the browser settings toggle for metrics reporting to the canonical OS metrics reporting pref over mojo. See design doc at go/lacros-metrics-consent Bug: 1148604 Test: added to unit_tests and lacros_chrome_browsertests Change-Id: I38b20ba6d92c6e6b46be297a2120a964023cd195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582642Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#835757}
-
Leonid Baraz authored
Rid cloud_policy_client.h of dependences on EncryptedRecord and related stuff. Bug: 1078512 Change-Id: I45345388e738727d1593d49cfb4042a1d80e63c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580560 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835756}
-
cfredric authored
This CL also makes the existing --use-first-party-set switch enable the First-Party Sets feature. Change-Id: I8ef099d0eb932e5f4f25f20dc7a426f3a29f6538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583003Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#835755}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32f1a8e81217..108b759ef91b 2020-12-10 xiaoxuan.liu@arm.com EGL: Update EGL headers/xml If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ieb8e1b437e529a305135ad281623e9331dbacc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584333Reviewed-by:
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I02bd38160961d061606f4ffd25334857c24146cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583204 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Alexander Surkov authored
Bug: 1136957 Change-Id: I7ccfadcac9f584668508234b3869e919afece962 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563923Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#835752}
-
Marijn Kruisselbrink authored
The first file type will be used as default extension in save dialogs. Previously the mac implementation of the save dialog would arbitrarily re-order the passed in file types (by adding them all to a set, and using the resulting order), which makes it impossible for callers to actually enforce what extension should be used in save dialogs. This fixes this behavior by keeping the order of file types as passed in, only using the set to avoid duplication. Bug: 1103133 Change-Id: I08d9d944eee977a1c99c1b1ecd72f6bb2c9afdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582823 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835751}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, and update callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: Ice3ac3cd4e7eca5e6e6876e99576fdca6687063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560583 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835750}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c18d56820d2..145deff4ccea 2020-12-10 jacktfranklin@chromium.org Fix new Linkifier clicks not registering If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie82c851e58a1c608403e6ca6729ece503a05c293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584332Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..59df85b5457e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I12673c92d94bc0527d706be94062a3a515bfd9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584582Reviewed-by:
-
Jan Wilken Dörrie authored
Following the removal of PasswordStoreX, PasswordstoreDefault is the only remaining production implementation of the PasswordStore interface. To avoid confusion and to be consistent with existing Chromium practice, this change renames PasswordstoreDefault to PasswordStoreImpl. Bug: 950269 Change-Id: I0ce1c73407b587ace9fdc2d2dfed1a53765a2433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584167 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#835747}
-
Yusuke Sato authored
Now that the function is in arc_util.h, it's better to have tests in arc_util_unittest.cc (rather than indirectly test the function in arc_vm_client_adapter_unittest.cc.) Bug: None Test: components_unittests Change-Id: I75ef434ee39f28cdb545342cec535337849382c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582996Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835746}
-
Shannon Chen authored
This reverts commit cd68a26c. Reason for revert: Focus ring disappears in switch access menu crbug.com/1157261 Original change's description: > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1143814 > Change-Id: I1c4fce614404c6cabd0336eed2ab6fa7ac1d4c48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568547 > Commit-Queue: Joel Riley <joelriley@google.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833155} TBR=dmazzoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,joelriley@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143814 Change-Id: I08c1552e93763dfbf8e09ff75e23e64033456675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583106Reviewed-by:
-
Hidehiko Abe authored
Currently, startup data is passed from ash-chrome to lacros-chrome via LacroChromeService::Init() Mojo call. This requires Mojo initialization so that the data is available only after that. However, there are some needs that the data would like to be available earlier. In order to support that situation, this CL introduces another approach, where ash-chrome dumps the serialized data into a memory backed file and lacros-chrome inherits its file descriptor. For backward compatibility, both lacros-chrome and ash-chrome supports older protocol, i.e. LacrosChromeService::Init() for now, while it is now deprecated. Thus, any {old,new} {lacros-chrome,ash-chrome} combination should work. It is planned to remove the older protocol support, when newer/older chromes are distributed enough. BUG=1155494 TEST=Ran tryjob. Ran {old,new} {lacros-chrome,ash-chrome} combinations on DUTs to make sure lacros-chrome can be launched successfully via Shelf icon and mojo_connection_lacros_launcher.py script. Change-Id: I09c7004d07cec9a58ccfc7ee24c0e256149e4951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573264 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#835744}
-
Benjamin Beaudry authored
Allow fragmentation for an abspos element that is positioned using the bottom property and has a computed height. This CL is relatively simple as all of the logic to estimate the block size from the content was already there. It only required some tweaking. There are edge cases, like how to handle break-rules, that I'll address in follow-up CLs. Bug: 1156250 Change-Id: Ibca325df2a22fa6cf6ec3b30409183f459d092b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577757 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835743}
-
Monica Basta authored
This CL adds a tooltip that is visible on keyboard focus and hover over the theme colors in the 'cr-customize-themes' component. Bug: 1156184 Change-Id: I61739db8af17e58aa7f37f773d6a5488c5bad60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584009Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#835742}
-
Eugene But authored
This CL leaves old headers to avoid changing the clients in one large CL. Those old headers import new headers and typedef the old names to point to the new names. Bug: 688063 Change-Id: I31c34463d47e31335dd0909fe816707733cf1a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583386 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835741}
-
Jacques Newman authored
Some IDLs do not generate a dlldata or proxy stub file. In these cases, midl.py should not expect midl to generate these, similar to how .tlb files are handled today. Currently, midl.py will assert as the output comparison will always try to find the dlldata and proxy files. This issue was found in a project downstream, currently there are no such IDLs being build in chromium. Bug: 1157129 Change-Id: Id6069eb7879ce917ab683c7ac00543f36d0dee4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582261Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835740}
-
