- 21 Oct, 2019 40 commits
-
-
Jonathan Wright authored
$ git log 9d3bf3e96..bc1357852 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jonathan.wright Implement slow IDCT using Arm NEON intrinsics Created with: roll-dep src/third_party/libjpeg_turbo Bug: 922430 Change-Id: I71f446ec2ef5c30ac2074b73d09cff0aa52f5602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872051Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#707857}
-
Kaan Alsan authored
This is a follow up to attaching SnapContainerData to ScrollableArea. Now that ScrollableArea has the snap container data, we don't need the snap coordinator to execute scroll snapping. Moved GetSnapPosition, SnapAtCurrentPosition, SnapForEndPosition, SnapForDirection, SnapForEndAndDirection, and PerformSnapping from SnapCoordinator to ScrollableArea. This revealed a bug in the logic for choosing the ScrollableArea to execute the snapping on; in the case where we are snapping the global root scroller we should be scrolling the RootFrameViewport. Currently, we are only scrolling the RootFrameViewport if the layout box is the layout view. This will be addressed in a follow up CL. Bug: 853295 Change-Id: Icde1a3263c84d0b8b5062d5dbb62d171b6a176ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862703Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#707856}
-
Vadym Doroshenko authored
Bug: 999871 Change-Id: I7150887216de2fcb0245def70c60ca00bbfe9192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869219 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#707855}
-
edchin authored
There was a bug where the startup logo was not properly sized in the fake launch screen. Forcing layout fixes this issue. Bug: 1014841 Change-Id: Iadfcfb9fb15b01fdca4b7623bdbcc49c42175757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872450Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707854}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0a4d95ef687..80bbce361517 git log f0a4d95ef687..80bbce361517 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 lalitm@google.com Merge "trace_processor: change UpdateSetBits and RemoveIf to use new iterators" Created with: gclient setdep -r src/third_party/perfetto@80bbce361517 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I93c6f0953a9ed76bf5bf46a16ab1e32bea4735bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707853}
-
Charlie Hu authored
Add fields of DocumentPolicy to SecurityContext(Document) and render_frame_host_impl. Rename document_policy in renderer/core to dom_document_policy to avoid name conflict. Implement DocumentPolicy::IsPolicyCompatible Bug: 993790 Change-Id: If3e3965b5d7822abc4bb74079da810dd7885d800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814938 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#707852}
-
Anastasiia Nikolaienko authored
Change-Id: I8b16f6c73bfcba4271c571db36846b8ea43f3e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864685 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#707851}
-
Andrew Grieve authored
Also renames the nested targets to follow current conventions and to ensure that any bot that does still depend on the _apk target will fail because of this. TBR=agrieve # trivial test update Change-Id: Ic958e1e74dd2f9628512369bd5a7ce01dd9c19cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857571 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#707850}
-
Yue Ru Sun authored
When the extension sync is disabled, purge all sources whose URL has `chrome-extension` scheme and all events from these sources, from both in-memory recordings as well as compressed reports in the unsent log store. Bug: 948881 Change-Id: I67bc5bd7c4a0b9c9ed02353dddceaf090eb655c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829953 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#707849}
-
Jaeyong Bae authored
This patch does remove generation_popup_was_shown as param on SetGenerationPopupWasShown function. Because it is always true. Bug: 831123 Change-Id: I04004b5c77c62f8ab425866c3e93197b60522ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872073Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#707848}
-
Chris Lu authored
To improve accessibility, the selectAndScrollToVisibleMatch() JavaScript function will now also return a string containing the selected match and words in the nodes before and after the match. This string will then be sent out as a UIAccessibilityAnnouncementNotification. Bug: 979707 Change-Id: I767530460b5d58c8d99bda3feb2fe29c56fb5f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857280 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707847}
-
Michael Ludwig authored
This updated the two leaf drawing functions, DrawSingleImage and DrawColoredQuad, to take optional RPDQ parameters and apply them to the current SkCanvas. It also cleans up DrawRenderPassQuad to rely on these utility functions instead of drawing everything directly. Bug: 1013735 Change-Id: I1f731b5ad84db708d2d072eee5f012f861bde1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860298 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#707846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6efb3466e0f2..1d2ab0dfbb1b git log 6efb3466e0f2..1d2ab0dfbb1b --date=short --no-merges --format='%ad %ae %s' 2019-10-21 mmortensen@google.com Check whether a board builds a version before setting chrome version. Created with: gclient setdep -r src/third_party/chromite@1d2ab0dfbb1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I11c06b3610fa6941fbe386649df37c65713d69fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872113Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/26c6c4a5eb83..4100b733bf4c git log 26c6c4a5eb83..4100b733bf4c --date=short --no-merges --format='%ad %ae %s' 2019-10-21 sugoi@google.com Fix queries with arrays containing other structures Created with: gclient setdep -r src/third_party/swiftshader@4100b733bf4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142740524 Change-Id: I4ed9d2592c45de088cfe65809743435e4ed38a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872116Reviewed-by:
-
Tomasz Wiszkowski authored
This change corrects definitions for suggestion icon area size and margins for large screen devices. This value is currently missing and inferred from small screen devices, which is not adequate for tablets. Bug: 982818 Change-Id: Id8d977760605b8c0504d939e3a9c9ab5282783bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868915Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#707843}
-
Lindsay Pasricha authored
main, fyi, webrtc, and clang. Bug: 1012928 Change-Id: I62823fbe33cd616ae70257429342648cd1126f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860519 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Use ClassLoaderContextWrapperFactory from WebView instead of wrapping the context ourselves, as the requirements are the same. Move the wrapping to the implementation side instead of the client side so that we can update it easily in future. This means that there's no longer any need for the client side to hold on to the Context for the implementation, as only the ClassLoader is actually required to bootstrap loading; ClassLoaderContextWrapperFactory simply uses its own classloader instead of requiring that a Context/ClassLoader be passed in. Change-Id: I9fb4418da7267b8f015b61c08d44cb6fa2faf65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867409Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#707841}
-
Alan Screen authored
Routine isn't needed by platform implementations, so can be safely made anonymous. Simplification that came out of larger crrev.com/c/1616461. Bug: 872935 Change-Id: I9a17edc72ad2222d31968e9bcaeebdb932eda4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869375Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707840}
-
David Bertoni authored
Context menu IDs are currently generated through a synchronous IPC from the renderer to the browser. This was done to ensure a unique, long-lasting source of IDs, since the browser is guaranteed to at least live as along as any renderer. It turns out this is not necessary, since only extensions with persistent background pages are allowed to use a generated ID and they are required to re-register their context menus at startup. Also, generated IDs are only required to be unique to the extension, so keeping an atomic counter in the renderer will work just fine. TBR=dcheng@chromium.org (Removed IPC message.) TBR=seantopping@chromium.org (Removed creating IO thread filter) Bug: 942373 Change-Id: If483ede0daf3ef02470e4fd7041974e2d6eb2aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869120 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707839}
-
Anatoliy Potapchuk authored
These classes will hold the data about PWA-based kiosks. Also, merge Ash::LoginStatus ARC_KIOSK_APP and KIOSK_APP together. Cq-Depend: chromium:1852254 Bug: 1006230, 1015383 Change-Id: Ia8442c73d9cfb1640dc2c7231d9ac91bcdf5fc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835503 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#707838}
-
Sidney San Martín authored
Web content refreshes its desired cursor on every mouse event, but TouchEmulator did not, so the custom "grey circle" touch cursor could get lost when, say, you move your mouse out of and back into its bounds. This change make the touch emulator work like web content and refresh its cursor on every mouse event. Bug: 989006 Change-Id: If9a943b276b250363541384878cea9a2ddab117e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867090Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707837}
-
François Doray authored
This reverts commit a913d408. Reason for revert: Tentative revert to try to understand https://crbug.com/1006940. Original change's description: > [threadpool] Remove _MayBlock suffixes. > > Since the blocking and non-blocking have been merged, there is no > need to report data for blocking tasks in separate histograms. > > This CL also makes passing an |histogram_label| to the constructor > of ThreadPoolImpl optional. If no |histogram_label| is provided, no > histograms are recorded. This CL takes advantage of that to not record > histograms from TaskEnvironment. > > Bug: 1002318, 995496, 982145, 980409, 972890, 972888, 972883 > Change-Id: Ib192f80fc7a706780f0e75bed14df6b58a7db9ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813780 > Auto-Submit: François Doray <fdoray@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698458} TBR=fdoray@chromium.org,altimin@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002318, 995496, 982145, 980409, 972890, 972888, 972883 Change-Id: Ia94d381699e5c660e6f0b2d8d4e9ea0a50708ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872311Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707836}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f11f58996811..63aaa927a3c7 Created with: gclient setdep -r src-internal@63aaa927a3c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifda67fe7e0342c4ff9b9e899ed5e6c3c60fc7706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871732Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707835}
-
Julian Pastarmov authored
This first change only adds the owners verbatim. This in most cases is enough but some policies refer to OWNERS file in the code tree. Since the people involved with translation are not Chromium engineers it will be beneficial to also dereference OWNERS files to their contents. BUG=1005850 TEST=grit unit tests Change-Id: I21630b74ea34af6697b90402566358191a1a717c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814693Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ia44c6badc61728a483203809df4f4d4153a42d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871289 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707833}
-
Olivier Li authored
Prepare explore_sites unittests for imminent switching on of the HistoryServiceUsesTaskScheduler experiment. The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: I7e08e21c212c2852891d30d0db70b946d932dd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865595Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/682dabd1c153..72cc71cd70d4 git log 682dabd1c153..72cc71cd70d4 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 saza@webrtc.org Harmonize APM config logging, update config ToString Created with: gclient setdep -r src/third_party/webrtc@72cc71cd70d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I61b10d5d2c658ef16cb5b289bdbb4dec9d7de5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872114Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 093809a5. Reason for revert: The test has been all green since crrev.com/707576: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=compositing/video/video-poster.html Original change's description: > Disable test compositing/video/video-poster.html > > compositing/video/video-poster.html > is flaky from 10/18 on Windows, Mac and Linux. > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBjb21wb3NpdGluZy92aWRlby92aWRlby1wb3N0ZXIuaHRtbAw > > TBR=wangxianzhu@chromium.org > > Bug: 1015764 > Change-Id: I3701bb7ea8cdacd3324469ab779239c80c903545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868981 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707494} TBR=wangxianzhu@chromium.org,lanwei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015764 Change-Id: Ic02c83b3c8c689e580b9a9b7af7d3a9067fd715b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872454Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707830}
-
Thomas Tangl authored
... and use bubble background for sync badge background. Bug: 995720 Change-Id: Id9f0d68eb1695c2b74fc41a6a888d9db38e413d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872213 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707829}
-
Mikhail Khokhlov authored
'pixels' is not a valid unit name, should use 'count' instead. Bug: 1016295 Change-Id: Ib24aef1c912b28d2ca5377490a2bc3bfb1de4b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871875Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#707828}
-
Jan Wilken Dörrie authored
This change moves the check to conditionally disable Touch To Fill on secure origins to the renderer. Checking this in the browser is not sufficient, as it can lead to UI bugs where the renderer believes Touch To Fill is shown while it reality it is not. Bug: 1014042 Change-Id: Ie6e1ef57bad0dc3991e38f3c535836935561b569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871512Reviewed-by:
-
Laís Minchillo authored
A null String shouldn't be passed to findAllAsync. This CL throws an IllegalArgumentException so developers have an easier way debugging (what would otherwise be a native crash). Also add a new test in AwContentsTest. Bug: 1014948 Change-Id: I7dd06dd4b09b3024c3f72ecbe3f227fec496fa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865172Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707826}
-
Ella Ge authored
Flaky on Linux and Mac dbg bot TBR=alph@chromium.org No-Try: true Bug: 1016364 Change-Id: Id9f45fa49309ed5e5838799867f1211dc0e6f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872451Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707825}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I9616c6c0e270059fb220df87b5d60936e69f8a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864663 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#707824}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Id18d8b2048d757ac0c27f68726d3d4ebee9f02f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872072 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#707823}
-
Francois Doray authored
This is a reland of 9d6a01ba We now handle negative values returned from ::GetThreadPriority(). https://chromium-review.googlesource.com/c/chromium/src/+/1829570 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=rkaplow@chromium.org Bug: 973868 Change-Id: I392cfb2f92e2ac0fa888fa1e323557ab35055b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872312Reviewed-by:
-
Kevin Ellis authored
This reverts commit af74d157. Reason for revert: pref regression in queuing durations Original change's description: > Web-animation: Remove some uses of PlayStateUpdateScope. > > PlayStateUpdateScope is problematic for handling timing of finished > promises in addition to not conforming with the algorithm outlined in > the web-animations spec. This patch removes several uses of > PlayStateUpdateScope and refines handling of pending flags. > > Bug: 960944 > Change-Id: I093a3aa86084adfbe128a5aedd36206d67dd12c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851927 > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705966} TBR=kevers@chromium.org,majidvp@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960944 Change-Id: Ib16d862d5834f837717e64bb86277860e50ec11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866624Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Martin Robinson authored
The introduction of text-change signals for the omnibox included a regression that prevented the emission of AtkValue property change signals. Fix this error and also add an implementation of atk_value_set_value. The implementation is used in a test to verify the correct behavior. The fix is that we correct the misuse of a logical operator and now always try to emit AtkValue property change events when receiving the kValueChanged event in AXPlatformNodeAuraLinux. Bug: 1015387 Change-Id: I18baa44a52190913ff70708bd5133bdcdea83b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871692 Auto-Submit: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#707820}
-
Sergey Poromov authored
DeviceStatusCollector is used only for enterprise reporting, consumer (child) reporting is extracted to ChildStatusCollector, so it's safe to remove this flag for simplicity and ensure that DeviceStatusCollector is initialized only for enterprise reporting. Test: Run trybots. Change-Id: Ib64ca56c3e402b6c99ededc856a96674a2e025c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864992Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#707819}
-
Raymond Toy authored
The values of an AudioParam are supposed to be clamped to the nominal range. We do this already, but we forgot the case where there is a connection to the AudioParam. This can cause the values to go outside the nominal range and cause issues for the nodes that expected the values to be clamped appropriately. Manually tested ASAN build with this CL and crashes don't happen anymore. Without this, the crash was very reliable. Bug: 1015737, 1016165 Change-Id: Ia02bac7b60a7e20bdc5165dbfbb17df56d4d3171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869373 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707818}
-
