GitLab

Review URL: http://codereview.chromium.org/8832001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112641

Review URL: http://codereview.chromium.org/8565019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96010
TEST=trybots

Review URL: http://codereview.chromium.org/8831005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113429 0039d316-1c4b-4281-b951-d872f2087c98

[ Reland of 113290 http://codereview.chromium.org/8790004 ]

I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense.

I also removed the ppb_opengles2_impl file since it was just a forward to the shared version.
Review URL: http://codereview.chromium.org/8849003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106716
TEST=On Chrome OS, manually test typing and autocompleting in the omnibox with accessibility turned on.

Review URL: http://codereview.chromium.org/8850001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113427 0039d316-1c4b-4281-b951-d872f2087c98

Looks like they're the same and only one of them is being reported now.

BUG=101781
TEST=none


Review URL: http://codereview.chromium.org/8824011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113426 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8786013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105872
TEST=no change

Review URL: http://codereview.chromium.org/8775064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113424 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=sky@chromium.org


Review URL: http://codereview.chromium.org/8815013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113423 0039d316-1c4b-4281-b951-d872f2087c98

This test looks like it's passing now.

BUG=104384
TEST=ran the test locally a few times on an aura build and didn't see any failures


Review URL: http://codereview.chromium.org/8758027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113422 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue where the network menu gets an I-beam
cursor instead of the default arrow cursor.

BUG=chromium-os:23842
TEST=manual: ran it and checked that the I-beam cursor is gone


Review URL: http://codereview.chromium.org/8826009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104535,75249,51716
TBR=timurrrr@chromium.org

Review URL: http://codereview.chromium.org/8853001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113420 0039d316-1c4b-4281-b951-d872f2087c98

  was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8817021

TBR=rch@chromium.org
Review URL: http://codereview.chromium.org/8850003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113419 0039d316-1c4b-4281-b951-d872f2087c98

Discovered this while debugging WorkerTest.SharedWorkerHttpAuth for
Bug 106383.

BUG=103386
TEST=None


Review URL: http://codereview.chromium.org/8771055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113417 0039d316-1c4b-4281-b951-d872f2087c98

Adds code to explicitly destroy the Aura Shell class prior to the destruction of Aura Desktop.  The reason for this is that the Shell leaks the DesktopFilter event listeners otherwise and DCHECKs fire.

Note, this currently only affects the Mac port because other platforms exit() from the run loop and don't do explicit tear-down.

BUG=none
TEST=Manually run aura_shell_exe on Mac.
R=sky@chromium.org, xiyuan@chromium.org

Review URL: http://codereview.chromium.org/8824017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113415 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113414 0039d316-1c4b-4281-b951-d872f2087c98

TBR=simonjam@chromium.org

Review URL: http://codereview.chromium.org/8854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113413 0039d316-1c4b-4281-b951-d872f2087c98

This is an incremental change rolled out of a larger one to remove cros_user, and make
the ProfileSyncService<Foo>Test framework easier to configure / decouple from the cros case. 
In the upcoming patch I'll remove cros_user and in several cases rely on SigninManager's new GetAuthenticatedUsername.

Also makes it so we always initialize the signin manager, regardless of platform.

Also fix a case in ProfileSyncService that calls DisableForUser when a UI error seems more appropriate.

This effectively re-implements the fix for bug 103861.

BUG=88109
TEST=


Review URL: http://codereview.chromium.org/8698001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113412 0039d316-1c4b-4281-b951-d872f2087c98

This flag determines which policies will be included in the recommended policies
templates.

BUG=49941
TEST=Everything works as before

Review URL: http://codereview.chromium.org/8773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113411 0039d316-1c4b-4281-b951-d872f2087c98

The DnsRRResoler has served its time and I don't have any further plans for it.

The TransportSecurityState will be used (in a future CL) to enforce public key
pinning at certificate verification time. Currently we only enforce it in
url_request_http_job.cc which means that we've already sent the HTTP request
(inc cookies) by the time we catch the problem. This was expeditious while we
fixed some other issues, but it's time to fix it.

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/8692012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113410 0039d316-1c4b-4281-b951-d872f2087c98

  was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8817021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113409 0039d316-1c4b-4281-b951-d872f2087c98

I'm not sure why it's causing valgrind errors, since the IPC system should
always be writing the variable. But it's probably good practice to initialize
it anyway.

BUG=106067
TEST=

Review URL: http://codereview.chromium.org/8773018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113408 0039d316-1c4b-4281-b951-d872f2087c98

Limiting InstallUninstallGarbageCollect to Windows.

TBR=aa@chromium.org
BUG=106381


Review URL: http://codereview.chromium.org/8847003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113406 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113305 - Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed.

Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.

Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.

Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).

Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.

BUG=62364, 92244, 105839
TEST=none


Review URL: http://codereview.chromium.org/8340012

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007

TBR=willchan@chromium.org

Review URL: http://codereview.chromium.org/8803019

TBR=rtenneti@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113305

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8836002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113405 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=willchan@chromium.org


Review URL: http://codereview.chromium.org/8817019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113404 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=jam@chromium.org


Review URL: http://codereview.chromium.org/8818014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113403 0039d316-1c4b-4281-b951-d872f2087c98

These two also TIMEOUT on GPU win release bot.

BUG=106557
TEST=
TBR=nduca
Review URL: http://codereview.chromium.org/8844004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113402 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113401 0039d316-1c4b-4281-b951-d872f2087c98

TBR=simonjam@chromium.org

Review URL: http://codereview.chromium.org/8847004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113400 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113399 0039d316-1c4b-4281-b951-d872f2087c98

This relands r113203, which was reverted in r113229. Hopefully the ChromeOS
bots will be happy this time.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113398 0039d316-1c4b-4281-b951-d872f2087c98

In combination with shawnsingh's scissoring, this is a huge win on 10.5 which uses a readback through main memory. Some numbers given on https://bugs.webkit.org/show_bug.cgi?id=67341

The win on >= 10.6 is probably less because there is not readback through main memory. The 10.6 implementation assumes that nothing outside the partial swap region was damaged (i.e. it's a SwapBuffers that always preserves the backbuffer --- it's not a true partial swap a la GLX_MESA_copy_sub_buffers). This is all that the scissoring needs.

BUG=none
TEST=ran with shawnsingh's patch on http://www.webkit.org/blog-files/3d-transforms/poster-circle.html on 10.6 and 10.5

Review URL: http://codereview.chromium.org/8726046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43460
R=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8833001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113396 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mmenke@chromium.org
BUG=106707

Review URL: http://codereview.chromium.org/8832009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113395 0039d316-1c4b-4281-b951-d872f2087c98

Workaround for a crash.

BUG=106485
TEST=VMTests, no seg fault.


Review URL: http://codereview.chromium.org/8834011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106557
TEST=
TBR=nduca
Review URL: http://codereview.chromium.org/8841001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=bradnelson, noelallen

Review URL: http://codereview.chromium.org/8827008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23768
TEST=


Review URL: http://codereview.chromium.org/8818020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113389 0039d316-1c4b-4281-b951-d872f2087c98

Add --enable-accelerated-filters flag to Chrome.  This is the chrome-side change corresponding to http://trac.webkit.org/changeset/102088.  Note that most of this is the result of blind devotion to cargo cult, based on code for other flags.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8822025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113388 0039d316-1c4b-4281-b951-d872f2087c98

The primary commit was 113249, the dependents were 113261, 113263.

This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem.

TBR=jhawkins@chromium.org
BUG=none

Review URL: http://codereview.chromium.org/8832006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113387 0039d316-1c4b-4281-b951-d872f2087c98