GitLab

On some circumstances, pause events are generated several times during start up.
Since current implementation finishes CastShellActivity on pause events, the
app doesn't start unexpectedly.

BUG=425812

Review URL: https://codereview.chromium.org/668053003

Cr-Commit-Position: refs/heads/master@{#300714}

This lands server change 77795511 by raullenchai.

BUG=345769

Review URL: https://codereview.chromium.org/661743003

Cr-Commit-Position: refs/heads/master@{#300713}

When removing ServiceWorker data with the QuotaClient we should remove both registrations and cache data.  This CL adds the cache data id.

BUG=420159

Review URL: https://codereview.chromium.org/672433002

Cr-Commit-Position: refs/heads/master@{#300712}

This patch also adds SendRawMessage, which is used for performance
in tracing handler.

BUG=405566

Review URL: https://codereview.chromium.org/635733003

Cr-Commit-Position: refs/heads/master@{#300711}

Added Net.QuicServerInfo.DiskCacheLoadTime histogram to track the read
time.

R=asvitkine@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/674453003

Cr-Commit-Position: refs/heads/master@{#300710}

Instead of implying the fences based on read and write access
to the underlying texture, have sync point insertion imply
an EGL fence which is acquired when we wait on that sync point.

BUG=399226

Review URL: https://codereview.chromium.org/661973003

Cr-Commit-Position: refs/heads/master@{#300709}

Added UserSessionManager::InitializeUserSession()
(1) Launches browser for most common case
(2) Continues new user sign in with TOS (public sessions)/image screen (new users)
(3) For kiosk flow delegates launching app to the existing kiosk initialization flow

(1) Currently results in LoginUtils::Get()->DoBrowserLaunch() which may postpone launching browser for these reasons:
(a) There's custom user login flow defined like SupervisedUserCreationFlow. In that case login UI continues to live and custom flow UI is launched in that context.
(b) User has different app locale which requires reloading resource_bundle prior to launching browser
(c) User has custom flags set (or user flags are different from login screen flags defined by the owner), this requires restarting Chrome which will be launched in the active user session.

Small refactoring in ExistingUserController, added

* PerformPreLoginActions() - performs sets of actions right prior to login has been started.
* PerformLoginFinishedActions() - performs set of actions when login has been completed or has been cancelled.

BUG=370175

Review URL: https://codereview.chromium.org/656283002

Cr-Commit-Position: refs/heads/master@{#300708}

BUG=401707

Review URL: https://codereview.chromium.org/649653003

Cr-Commit-Position: refs/heads/master@{#300707}

Note: I still plan to refactor these so that more logic is shared between
the platforms, but it's nontrivial. In the meantime I think this is worth it
as long as it keeps improving the tests, because that will make the refactoring
that much less error-prone.

BUG=417104

Review URL: https://codereview.chromium.org/665333004

Cr-Commit-Position: refs/heads/master@{#300706}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/649313004

Cr-Commit-Position: refs/heads/master@{#300705}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b4384b9..22b5ab6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/670953002

Cr-Commit-Position: refs/heads/master@{#300704}

The paint events were updating the document_state of whatever the last
frame in the frame list was. In a case of "how did this ever work" it
must have been sheer luck that the last local frame in the list was the
main frame.

The update just checks to make sure that the local frame is actually
the main frame (no parent) when selecting the frame to update the
document_state of.

Could be that this broke in 38 when the proxy frames were added and
maybe they were only tested on pages with a single frame.

BUG=422913

Review URL: https://codereview.chromium.org/670513003

Cr-Commit-Position: refs/heads/master@{#300703}

Moves most of the large file lists in chrome_tests to variables defined at the top of the file. This will allow the lists to be shared with the GN build.

R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/671503006

Cr-Commit-Position: refs/heads/master@{#300702}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=junov@chromium.org

Review URL: https://codereview.chromium.org/665373005

Cr-Commit-Position: refs/heads/master@{#300701}

The issue is that the WebRtcLocalAudioRenderer is using 128 samples as buffer size on Mac, which can screw up the CoreAudio. And it makes perfect sense to use the same buffer size to render both the local and remote audio stream.
And we have the same issue on Linux as well.

This patch fix the problem on all platforms.

BUG=412765,410258

Review URL: https://codereview.chromium.org/646033007

Cr-Commit-Position: refs/heads/master@{#300700}

This patch ensures that we don't rasterize low res tiles unless we're
in smoothness mode. The reasoning is that the visible area that is
going to be covered already will have high res tiles returned for
rasterization, so we don't need to bother with low res.

Once a smoothness mode is entered, we will first rasterize low res
tiles, followed by high res tiles.

R=reveman

Review URL: https://codereview.chromium.org/665423002

Cr-Commit-Position: refs/heads/master@{#300699}

BUG=418882

Review URL: https://codereview.chromium.org/670813003

Cr-Commit-Position: refs/heads/master@{#300698}

This allows ime extensions creat window with proper shadow through css and a round button as in this mock:
https://folio.googleplex.com/chromeinput/final/voice#%2F00%20VK_start%20to%20speak.png

BUG=425539

Review URL: https://codereview.chromium.org/643283002

Cr-Commit-Position: refs/heads/master@{#300697}

BUG=423945

Review URL: https://codereview.chromium.org/650013007

Cr-Commit-Position: refs/heads/master@{#300696}

BUG=
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/671433005

Cr-Commit-Position: refs/heads/master@{#300695}

Treating displays without EDID specially results in exiting mirror mode
every time a display configuration operation happens.

BUG=413278

Review URL: https://codereview.chromium.org/667753002

Cr-Commit-Position: refs/heads/master@{#300694}

Revert of Roll src/third_party/WebKit 9fdcfe1:f6b3ead (svn 184159:184165) (patchset #1 id:1 of https://codereview.chromium.org/673613002/)

Reason for revert:
This roll broke linux bots.

Original issue's description:
> Roll src/third_party/WebKit 9fdcfe1:f6b3ead (svn 184159:184165)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/9fdcfe1..f6b3ead
>
> TBR=aboxhall@chromium.org,kochi@chromium.org
>
> Committed: https://crrev.com/af24ad6cc96e3878f4026efb29e9d47032893e74
> Cr-Commit-Position: refs/heads/master@{#300666}

TBR=aboxhall@chromium.org,kochi@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/675533002

Cr-Commit-Position: refs/heads/master@{#300693}

This script was installing an ancient version of the Noto
fonts; update it to use 20140815 instead.

BUG=none

Review URL: https://codereview.chromium.org/666413002

Cr-Commit-Position: refs/heads/master@{#300692}

BUG=425813
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/664413006

Cr-Commit-Position: refs/heads/master@{#300691}

Original CL https://codereview.chromium.org/671723002/

BUG=424363
NOTRY=true

Review URL: https://codereview.chromium.org/674523003

Cr-Commit-Position: refs/heads/master@{#300690}

BUG=419867
R=jar@chromium.org

Review URL: https://codereview.chromium.org/663223003

Cr-Commit-Position: refs/heads/master@{#300689}

Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/)

Reason for revert:
Downstream x64 and mips bots didn't like it.

Original issue's description:
> Roll android_tools and breakpad to the latest.
>
> This picks up in android_tools:
> Updated SDK build tools to 21.0.1 and removed old versions.
> Upgrade NDK to r10c.
>
> And in breakpad:
> Update breakpad to support Android NDK r10c
> Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> Refactor .so name detection logic in minidump/linux_dumper.
> The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> Remove workaround for Linux credential-passing bug.
>
> TBR=brettw, danakj
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> Cr-Commit-Position: refs/heads/master@{#300671}

TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/676453002

Cr-Commit-Position: refs/heads/master@{#300688}

Revert of Add src-side launcher for telemetry_unittests (patchset #7 id:120001 of https://codereview.chromium.org/649683005/)

Reason for revert:
windows trybots broken

please be around after landing changes and verify that bots are working

Original issue's description:
> Add src-side launcher for telemetry_unittests
>
> This will need a recipe-side change to pass the paths known to recipe
> (from the path recipe module) and properties (from the properties
> recipe module).
>
> Each of these key-value pairs is passed as two command line arguments,
> so that parsing them is easy and rock solid (avoids escaping issues),
> and is also easy to convert to dict python-side.
>
> BUG=422235
> R=iannucci@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5316422143176a4a6457ce173ec9597a2e0eda69

TBR=iannucci@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422235

Review URL: https://codereview.chromium.org/655843004

Cr-Commit-Position: refs/heads/master@{#300687}

Revert of Make get_compile_targets.py work on Windows (patchset #1 id:1 of https://codereview.chromium.org/671513014/)

Reason for revert:
windows trybots broken

please be around after landing changes and verify that bots are working

Original issue's description:
> Make get_compile_targets.py work on Windows
>
> BUG=422235
> R=bartfab@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/9f8fcc9bf8f8a47ce9178f2d8b4a9459f7063b1d

TBR=bartfab@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422235

Review URL: https://codereview.chromium.org/676443002

Cr-Commit-Position: refs/heads/master@{#300686}

Revert of Make telemetry_unittests.py work on Windows (patchset #1 id:1 of https://codereview.chromium.org/647103003/)

Reason for revert:
windows trybots broken

please be around after landing changes and verify that bots are working

Original issue's description:
> Make telemetry_unittests.py work on Windows
>
> BUG=422235
> R=bartfab@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f9f4000b3b94e82f7cf22277c649618f0bb97b66

TBR=bartfab@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422235

Review URL: https://codereview.chromium.org/671933002

Cr-Commit-Position: refs/heads/master@{#300685}

Randomly sized test headers would occasionally fit exactly in the stream flow control window, resulting in the stream being flow control blocked but without any pending queued data. Do one extra write after becoming blocked to ensure there is queued data.

BUG=423586

Review URL: https://codereview.chromium.org/669963003

Cr-Commit-Position: refs/heads/master@{#300684}

This patch adds a unittest for https://codereview.chromium.org/667053003/
The test fails without the patch and passes with.

R=enne, skyostil

Review URL: https://codereview.chromium.org/670773002

Cr-Commit-Position: refs/heads/master@{#300683}

Revert of [Ozone] Properly initialize multitouch slot values (patchset #9 id:160001 of https://codereview.chromium.org/671723002/)

Reason for revert:
EVIOCGMTSLOTS isn't defined on some of the bots.

Original issue's description:
> [Ozone] Properly initialize multitouch slot values
>
> BUG=424363
> NOTRY=true
>
> Committed: https://crrev.com/826d0a0cc35014f243399625b53929af9a3773db
> Cr-Commit-Position: refs/heads/master@{#300680}

TBR=spang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424363

Review URL: https://codereview.chromium.org/672633002

Cr-Commit-Position: refs/heads/master@{#300682}

BUG=417463

Review URL: https://codereview.chromium.org/670073003

Cr-Commit-Position: refs/heads/master@{#300681}

BUG=424363
NOTRY=true

Review URL: https://codereview.chromium.org/671723002

Cr-Commit-Position: refs/heads/master@{#300680}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/667293002

Cr-Commit-Position: refs/heads/master@{#300679}

Remove InlineEditableItemList (but not the InlineEditableItem items
inside of it) from the tab order. Giving the list focus is useless, so
skip it and go straight to focusing the first item.

Improves "Manage search engines" dialog by making focus go directly to
the first item in each list.

Tested with all other InlineEditableItemList subclasses:
autofill_options_list.js
content_settings_exception_area.js
browser_options_startup_page_list.js
language_dictionary_overlay_world_list.js

This change does not negatively impact any of these classes.

Depends on https://codereview.chromium.org/666823003 to function properly.
BUG=276874

Review URL: https://codereview.chromium.org/668603004

Cr-Commit-Position: refs/heads/master@{#300678}

 - Extracted BisectPrinter, which contains everything related to printing
 - Extracted BisectState and RevisionState, which represent bisect-in-progress
 - Rewrote BisectResults - in particular split up GetRevisionDict, which is now its constructor
 - Added tests for BisectResults, fixed bugs in _FindOtherRegressions
 - Added tests for BisectState

R=qyearsley@chromium.org

Review URL: https://codereview.chromium.org/664753002

Cr-Commit-Position: refs/heads/master@{#300677}

BUG=422235
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/647103003

Cr-Commit-Position: refs/heads/master@{#300676}

BUG=417463

Review URL: https://codereview.chromium.org/655693003

Cr-Commit-Position: refs/heads/master@{#300675}