- 10 Mar, 2020 40 commits
-
-
Daniel Cheng authored
Bug: 1059157 Change-Id: Ic6d20bad1f0827e3e3e715a6309ab2932307a7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090981Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748697}
-
Yutaka Hirano authored
Spec: the sixth item of https://mikewest.github.io/corpp/#integration-html Fix stale implementation, and add reporting. - Run CORP on redirects. - Use the parent COEP instead of the response COEP value. - Add reporting plumbing. Bug: 887967, 1052764 Change-Id: I3723e671fb7d571dcce741f859d8d831ae7c584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089183 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#748696}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aafa9b5c733c..bf9df5292254 git log aafa9b5c733c..bf9df5292254 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jacktfranklin@chromium.org Move utilities test to being built with Ninja 2020-03-10 jacktfranklin@chromium.org Move StringUtilities test into Ninja/TS land. 2020-03-10 szuend@chromium.org [utilities] Remove Array#remove
🎉 2020-03-10 szuend@chromium.org [cleanup] Use Map + Set instead of Object + Array in CSSModel 2020-03-10 szuend@chromium.org [utilities] Remove Map#remove Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf9df5292254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I22cf8ef2cd65c0059fe1a77eea8c97ee9f199e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096088Reviewed-by:chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748695}
-
Daniel Cheng authored
Bug: none Change-Id: I9691adc8e1a1e652e3f5c9b54746bd358b91ad5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096105 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#748694}
-
Michael Ershov authored
This file is not used anymore after migrating its content into paltform_keys_service.h. Bug: 1045895 Change-Id: I6e2918f9ccc7a8383651eee82b44b514270cb402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096638Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#748693}
-
Side Yilmaz authored
|ProfileKey#getLastUsedProfileKey| always returns regular profile key. Hence, to reduce misconceptions when profiles are used in incognito sessions, |ProfileKey#getLastUsedProfileKey| function is renamed to |ProfileKey#getLastUsedRegularProfileKey|. Bug: 1041781 Change-Id: If945d58c8d8251e965c5c9d5eac7fb2d4744a47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083486Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748692}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: I39ee5bf184349d5511095e1064fe99b38c3136d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095204 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#748691}
-
Jonathan Freed authored
Change-Id: Iaa8b1a6b66ab3d1d10c8c5544a0df1083a959281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092126 Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748690}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4df814181ef866f68a2242e3e375ace7a6c4d818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748689}
-
David Roger authored
This function was just a straight wrapper around the SigninErrorControllerFactory but is not defined on ChromeOS. This does not seem very valuable. Moreover, it was only used from AvatarButtonErrorController. And since AvatarButtonErrorController will be needed on ChromeOS, there is no point in keeping this wrapper. Bug: 1041472 Change-Id: If6f7e84dc9250e3d542206022a20620235eb885a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093597Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#748688}
-
Ali Juma authored
This adds an OWNERS file to this recently-added directory. Change-Id: I3ffd7971c195b73a713b518aec4756f6c6d9778a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096776Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#748687}
-
Fredrik Söderquist authored
This is one of those "we're only in it for the ComputedStyle (and notifications)" LayoutObject, so inheriting via LayoutSVGHiddenContainer only adds overhead. Inherit directly from LayoutObject instead. While doing this also rename to LayoutSVGFilterPrimitive to avoid any confusion with LayoutObjects for actual resources. Change-Id: Icfc293d3ece94d56cc2136975f49bd21e7e8d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094304 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#748686}
-
ckitagawa authored
Fix an issue where TabService attempted to proceed to write the proto even if there was an error. Change-Id: I5734921cd77baa026cc47e47d2656b87f672aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095012Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#748685}
-
kylechar authored
SkTraceMemoryDump provides Skia a way to produce Chrome memory dumps. The dumpStringValue() function had an empty implementation however. Bug: 1043676 Change-Id: I915ccbcb21ba4462bbb6ade1e66f64df322427ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064820Reviewed-by:
Brian Osman <brianosman@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748684}
-
Mark Cogan authored
Refactors the AppUrlLoadingService to get a Browser from its delegate and not care about TabModel. There should be no functional changes. Also : - Updates TestAppUrlLoadingService to use correct variable naming. Bug: 1046373 Change-Id: I1da8a1033b0bf26972f07908bbe815c6b9d8f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094308 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748683}
-
Jan Wilken Dörrie authored
This change adds a preference to remember the last time a Bulk Check ran to completion and sets the elapsed_time_since_last_check field on CompromisedCredentialsInfo appropriately. Bug: 1047726 Change-Id: I2115cb582c3edbedd3b1d82df8db362353a286d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095100Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748682}
-
henrika authored
Ensures that style is consistent. Goal is to fix these details before M82 cut. Tbr: olka Bug: 1017219 Change-Id: I69d00b614ec0c1b35464be1ea22f3f79273c473c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089897Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#748681}
-
Nazerke authored
This CL modernizes the ChromeActivityOverlayCoordinator to use |browser| in the initializer. This includes updates in corresponding table view controllers and unittests. Bug: 1029346, 1048395 Change-Id: I8f1a642d1c9d4c1daf67c2fedf554fdde969e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089830 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#748680}
-
Rainhard Findling authored
* Safety check status-changed events will all contain a display string in the future (see https://crrev.com/c/2089868). This allows for better string customization with pluralization, links, etc. * This CL prepares the remaining two safety check UI elements to expect those strings in state-changed events, and makes them populate the UI from those strings. Bug: 1015841 Change-Id: I6a47829d766b40c29fe504aee2df01174536a318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095074 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748679}
-
Christian Dullweber authored
Swap the cookies section and the permissions section to have permissions close to the site settings button. Screenshot: https://crbug.com/1040091#c26 Bug: 1040091 Change-Id: If8fb0bb256caa47c05e4c4829763b8c81b73900b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095723Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#748678}
-
David Van Cleve authored
Trust Tokens key commitment responses are served during the issuance and redemption steps of the Trust Tokens (Privacy Pass) protocol. As part of implementing Trust Tokens, we need to fetch and parse these responses during the "issuance" and "redemption" protocol steps, triggered by requests' having been tagged with the corresponding fetch flags. For the preliminary version, these key commitment responses' contents are specified in the design doc: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit#bookmark=id.6wh9crbxdizi This CL adds parsing code; a concurrent change adds a flow for requesting these records from issuers' key commitment endpoints. New code: - KeyCommitmentResult describes the information we get from a key commitment response; - key_commitment_parsing.* implement logic and tests for parsing the commitments. We try to err on the side of being very strict, rejecting outright many messages that have any part malformed (for instance, if a record contains three keys and one is bad, the entire message gets thrown out). Bug: 1042962 Change-Id: I3b3d9b0b71bc74f80839b0f14309b990bcbe5a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029292 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#748677}
-
Sorin Jianu authored
ref_counted.h is only needed for defining or instantiating ref counted classes. Change-Id: I9250c12fbd8362aa66861c7cde7fa5a257da3ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094623 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748676}
-
Mikel Astiz authored
This patch refactors the SyncedBookmarkTracker API to make it less sync-ID-centric (aka server IDs). Instead, entity pointers are proposed (const SyncedBookmarkTracker::Entity*) as handles, following the design principle in BookmarkModel and const BookmarkNode*. This spares a few lookups but otherwise introduces no behavioral changes. Change-Id: Idfcaff7dfc268a29ca3f52e68b54ae11a51c6c71 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094982Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748675}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a2cb93d8b965..c782263e5f19 git log a2cb93d8b965..c782263e5f19 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 mbonadei@webrtc.org Whitespace change to kick bots. 2020-03-10 nisse@webrtc.org Delete ACMVADCallback Created with: gclient setdep -r src/third_party/webrtc@c782263e5f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia61e116d981d45b4e5b10e7a382f3320f73adc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748674}
-
Guido Urdaneta authored
Adds Origin Trial entry and feature counters for WebRTC Insertable Streams. Intent to experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Oy84pXDhajI Bug: 1052765 Change-Id: I8514438339bb57b3dab07beebde3333b4e0c68f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094123 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#748673}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29afd4ae. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7df62572e5c012924124e00e09bf1775d8389c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096509Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748672}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the third in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, including updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Remove the implementation of the shimmed API. 8. Upstream, remove the loading shim protocol and the old shimmed CreateLogoVendor() API. Call only the new shimless API. Specifically this CL changes the contents suggestion coordinator to call the CreateLogoVendor API added in CL #1, and to implement the shim URL loading protocol. It also adds the upstream provider API implementation that should have been in place in CL #1, and hardens ContentSuggestionsHeaderViewController against a nil logo vendor. (Also, as a minor note, this CL removes the synthesis of -setLogoVendor: in ContentSuggestionsHeaderViewController, which was confusing and a mismatch for the protocol definition which doesn't define it as a property). (This CL should not land until downstream CL #2 has landed and rolled). correctly TEST: Manually set #use-ddjson-api and tested that doodle links open Bug: 1046374 Change-Id: Ibf971db36daf9ba35196cd424f28e637b8d2663b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089785 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748671}
-
Ye Kuang authored
This is to roll crrev.com/c/2096056 Bug: 1059167 Change-Id: I9f73acad1b1109406144a347d7e5e94da54285ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094923Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748670}
-
Sorin Jianu authored
Since UpdateClient::Install now takes a repeating callback to convey state changes, the updater can use this callback mechanism instead of observer events. Also, fixed the second parameter for the ctor, which imo, it was confusing. A ctor decl like Ctor(param, callback) may indicate to the reader that the ctor is handled in a non-blocking manner. In this case we are talking about, it is the InstallApp call which is non-blocking: void InstallApp(const std::string& app_id, base::OnceCallback<void(int)> callback); I made the InstallAppController ref counted thread safe, since the class is shared among different threads of execution, and it is more correct to be declared this way. There is no corresponding component state for the COMPONENT_WAIT event, so at one point we may do something about the state machine, or come up with a different way to receive this, or just ignore. Bug: 1059938 Change-Id: Ib27f7fed50e5513a974bef1c74c6eac6827935fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095866Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748669}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e18f749d97e8..4f10b113a191 git log e18f749d97e8..4f10b113a191 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 6861ea4e10a1..343d4f6f1870 (3 commits) 2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 97484d689869..014968c3b6b3 (11 commits) Created with: gclient setdep -r src/third_party/angle@4f10b113a191 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Idc21565c35b6bcff4bda278f889803a3e03f4b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748668}
-
Jonathan Ross authored
This reverts commit b0fc3d10. Reason for revert: Pixel_Video_Context_Loss_VP9 has begun failing on all Android platforms Original change's description: > Remove expected leftover minidumps > > Removes expected leftover minidumps from several tests that > intentionally crash a Chrome process. This is so that these > intentional crashes are not caught as failures once pre/post test > minidump checking is enabled with crrev.com/c/2090590. > > Bug: 1056235 > Change-Id: Iad026563b3a7acfc6e2078ffec36a000ed4b2dec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080863 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748433} TBR=kbr@chromium.org,bsheedy@chromium.org Change-Id: Ie3903e7c61b4731ffa6ede93866d4105e1c0aec9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096775Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748667}
-
Tim Volodine authored
This reverts commit a3520fb4. Reason for revert: multiple build bots are failing to compile, see crbug.com/1060155. Original change's description: > Move //chrome/lib/lifecycle/ to //chrome/browser/android/ > > Patchset 1 of 3 to introduce new target and switch upstream dependencies. > Patchset 2 will update downstream build targets. > Patchset 3 will remove the old //chrome/lib/ directory. > > BUG=1052382 > > Change-Id: Ia17859f630003eded43ee1b928e8ddc2ab22814e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095444 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748553} TBR=yfriedman@chromium.org,dtrainor@chromium.org,twellington@chromium.org Change-Id: Ia87cdc63156402445b313a1a80bb2bd79af9eef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096755Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#748666}
-
Rouslan Solomakhin authored
Before this patch, payment_app_provider_impl.cc wrote out payments::mojom:: prefix for every type it used from that namespace. This made reading and writing code in this file cumbersome. This patch places several "using payments::mojom::XYZ" statements at the top of the anonymous namespace in payment_app_provider_impl.cc and removes payments::mojom:: prefixes throughout the rest of the file. After this patch, the majority of payment_app_provider_impl.cc omits the payments::mojom:: prefix, which makes reading and writing code in this file easier. Bug: 1005076 Change-Id: If44010e2bb0f3aea364742a4b28395a650e1a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089963Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748665}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ca9e417e03e..aafa9b5c733c git log 3ca9e417e03e..aafa9b5c733c --date=short --first-parent --format='%ad %ae %s' 2020-03-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-10 szuend@chromium.org [utilities] Inline Promise#catchException at all use-sites 2020-03-10 jacktfranklin@chromium.org Extend GRDP tooling with TypeScript support 2020-03-10 tvanderlippe@chromium.org Fix input for build_release_applications 2020-03-10 szuend@chromium.org [utilities] Move loadXHR to its only use-site in ResourceLoader.js 2020-03-10 szuend@chromium.org [utilities] Use Set instead of Array in ResourceTreeModel 2020-03-10 szuend@chromium.org [utilities] Replace Array#remove with helper in WatchExpressionsSidebar 2020-03-10 szuend@chromium.org [utilities] Replace Array#remove with helper in ApplicationPanelSidebar 2020-03-10 jacktfranklin@chromium.org Exclude `front_end/third_party` from GRDP file checks 2020-03-10 tvanderlippe@chromium.org Add e2etest for forcing pseudo states Created with: gclient setdep -r src/third_party/devtools-frontend/src@aafa9b5c733c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1046596,chromium:1050549,chromium:1060003,chromium:1060009 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5e67c1e7fc5b59d89c71c873cdb5cdf9692dc013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748664}
-
Stepan Khapugin authored
Adds a test to prevent regression of crbug.com/1039228 Bug: 1039228 Change-Id: Ia8735b233288c22d5b96f7022fa272f710b07cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082915Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748663}
-
Arthur Eubanks authored
Chrome now successfully builds with ToT Clang after crrev/9243da16. Bug: 1059231 Change-Id: I5208e0c6d5990146e28ef57617038430a4b3a310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095705 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748662}
-
Ulan Degenbaev authored
This changes the |type| field of the result to |userAgentSpecificType| that contains a list of memory types instead of a string. Bug: 1049093 Change-Id: I313135f8c23f6a7cd00d0861bdd9ef9017846d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096444Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748661}
-
Omer Katz authored
Change-Id: I378d8444ed8d0526ce1b34983167579e7441aceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094313 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#748660}
-
Gauthier Ambard authored
This CL removes the animation of the content offset of the TabGrid which allows the selected tab to be at the top of the collection. When BVC is presented the animation isn't seen. When it is contained, the animation was creating a visible glitch. Fixed: 1056611 Change-Id: I8b32e8191c413e368f75c88dce1fee0665f6d075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095722Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748659}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2572b81df7cb..391bb28f91a4 Created with: gclient setdep -r src-internal@391bb28f91a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibd66ec87f5236cba1979ce2fbd4547d60e7219aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748658}
-