GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/132145aa..6d5c73cf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6825e1d5079de8edf509d1cbf5234d2263135f6d
Reviewed-on: https://chromium-review.googlesource.com/1187184Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585585}

Bug: 851981
Change-Id: I2e97155353f2119661df92cdd023e2e086328d18
Reviewed-on: https://chromium-review.googlesource.com/1157441
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585584}

Now that ash and the ui service are in the same process we don't need
to use PointerWatcher in ash anymore.

This is a partial manual revert of:
https://codereview.chromium.org/1934123004/

Bug: 595851, 872450
Test: ash_unittests
Change-Id: Ifbbb407210d0b3ec8d20993bff7a0f2cf44ba38e
Reviewed-on: https://chromium-review.googlesource.com/1186032
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585583}

This CL folds VaapiJpegDecoder, a class with only one static method,
into its only caller VaapiJpegDecodeAccelerator. The static method,
VaapiJpegDecoder::Decode(), is renamed to DoDecode().  This method and
the bunch of file-static ones are moved verbatim -- untouched.

It also takes the chance to clean up: removes unused includes and
member variables, and forward declares as much as possible (otherwise
va/va.h, a pretty large file was transitively included, ugh).

All in all, less lines !

Test: jpeg_decode_accelerator_unittests passing as before.
Bug: 876810
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1f37f378121840d6d1eb83018c5122bb0ed6b01c
Reviewed-on: https://chromium-review.googlesource.com/1185218Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585582}

Related spec change:
  https://github.com/w3c/payment-request/pull/721

Tests:
  chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
  chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
  components/payments/content/payment_request_spec_unittest.cc
  components/payments/content/payment_request_state_unittest.cc

Manual tests:
  wpt/payment-request/payment-response/retry-method-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html

Demo:
  https://youtu.be/_mbcGkbwfw8

Bug: 861704
Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
Reviewed-on: https://chromium-review.googlesource.com/1144587
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585581}

Currently all CSP errors are reported wrongly as INITIALIZATION_ERROR,
this change will report it as BAD_ORIGIN.

Change-Id: I2cc09d9dcd722ab0657605e540acac69e142eb6c
Bug: 686364
Reviewed-on: https://chromium-review.googlesource.com/1141047
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585580}

In this CL, we finish the basic two round pop-up window workflow.

We add LoadRiskData at the same time the first prompt pops up when the legal docs are successfully fetched. The callback of the first prompt(ShowLocalCardMigrationPrompt) is OnUserAcceptedIntermediateMigrationDialog() which will trigger the second prompt.

We will send the Migration request only when both the risk data is prepared and user accepted on the main prompt. Send Migration Request will included in the following CL.

Use the intermediate bubble as the main prompt for now. Need to wait for Siyu's Main Prompt skeleton check-in to replace the main prompt call.

TBR=rogerm@chromium.org

Bug: 852904
Change-Id: Ic881a64b7da93316ff8a8a0e84bc0c20a39a030d
Reviewed-on: https://chromium-review.googlesource.com/1149151
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#585579}

Since we didn't do them yet, they probably weren't important.

Bug: none
Change-Id: Ifbb2da04f2f6b0f3b125a7dbaa8ab732bd77fc6b
Reviewed-on: https://chromium-review.googlesource.com/1187013Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585578}

The test failed with a NO_RESOURCE error; try to match the bot config
of the other testsuite exactly.

https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/6935

R=nednguyen@google.com

No-Try: True
Change-Id: I30a90a5991030f26ff70bbedc26fd5c8785fcd33
Reviewed-on: https://chromium-review.googlesource.com/1187074Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585577}

This is a reland of 66ce35f8

Reverted in :
https://chromium-review.googlesource.com/c/chromium/src/+/1184062

See : https://crbug.com/876463

Build #2592 succeeded without reversion and test seems flaky in
more recent builds (#2608). Not believed to be the cause of the failing
test.

TBR=kinuko@chromium.org

Original change's description:
> Remove data use updates from page load metrics
>
> Now that per-resource updates are sent to page load metrics, we no
> longer need to send totals from the renderer process. Remove all
> piping/callbacks and convert existing consumers to
> OnResourceDataUseObserved.
>
> Per-resource updates:
> https://chromium-review.googlesource.com/c/chromium/src/+/1164222
>
> Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a
> Reviewed-on: https://chromium-review.googlesource.com/1178324
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584744}

Change-Id: Ifdc90e57677eb214e404616a41242d5fc1fa64a0
Bug: 876463
Reviewed-on: https://chromium-review.googlesource.com/1185101
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585576}

1) Change FidoRequestHandler to not terminate a WebAuthn request when a
request handler replies with the CTAP2_ERR_INVALID_CREDENTIAL or
CTAP2_ERR_CREDENTIAL_NOT_VALID CTAP2 error codes. These error codes do
not indicate that the user has interacted with the authenticator and
we therefore must not resolve the  WebAuthN request promise upon
receiving such an error.

2) Remove kCtap2ErrCredentialNotValid since
CTAP2_ERR_CREDENTIAL_NOT_VALID has recently been dropped from the CTAP2
spec.

3) Change references to kCtap2ErrCredentialNotValid in U2F code to
kCtap2ErrNoCredentials in order to not change behavior of that code with
regards to request canceling.

Change-Id: Ied8dd2c8b4af939d6b922c0007520b90d3a92388
Reviewed-on: https://chromium-review.googlesource.com/1185220
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585575}

This rename enables adding a DeferImageLoad for css background images

Bug: 846170
Change-Id: I5c243e3560ae222742c08a6ac18ebb6cb859b37f
Reviewed-on: https://chromium-review.googlesource.com/1178686
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585574}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I16cea32fc83ea6ce616efd941daf587786b6e7dd
Reviewed-on: https://chromium-review.googlesource.com/1187067
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585573}

With Settings adding a test for Polymer 2 for CQ submission, two
browser tests, multidevice_feature_toggle_tests and
multidevice_feature_item_tests started failing. Because they were
blocking dogfood and the failures were with the tests rather than than
the prod code, we decided to remove the tests as a temporary measure.

This CL adds them back and changes them to deal with a problem caused
by the Polymer 2 migration: In Polymer 1, the shadow tree of an element
is build upon creation while in Polymer 2, it is not built until the
element is appended to document.body. As a result, some paths that were
safe to reference before appending in Polymer 1 can now only be
referenced after.

Change-Id: I78945bfad0675602ebf9a73ae08e21ffa2292e13
Reviewed-on: https://chromium-review.googlesource.com/1184315Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585572}

Bug: 848073
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I60408ab991595b0057d017e53a4746794343c0b8
Reviewed-on: https://chromium-review.googlesource.com/1182949Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585571}

Change padding of title label in AppListItemView
from 0px to 8px to match specifications:

https://screenshot.googleplex.com/bmrE2eaixE0

Bug: 876503
Change-Id: Id12b3ddfe4bc95372d236b81468e25db5db576b5
Reviewed-on: https://chromium-review.googlesource.com/1186098Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#585570}

This is a reland of 42e740f0

Original change's description:
> Move call to GetInfo command after AuthenticatorAdded()
> 
> In order to prevent system UI dialogs for BLE/Touch ID from appearing
> prior to WebAuthN UI, we hold off on dispatching request to
> authenticators until user consents on using the specified transport
> type. However, in current implementation, we send GetInfo command to
> external BLE authenticators as soon as we discover the device. This
> would trigger OS UI dialog on Mac for unpaired devices and potentially
> cause BLE connection failures on other platforms. As so, move call to
> GetInfo command after FidoRequestHandlerBase::AuthenticatorAdded().
> 
> Bug: 847985
> Change-Id: I37b7cd8118c3edb799fa29c36700febbb2b3d08e
> Reviewed-on: https://chromium-review.googlesource.com/1182946
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585130}

Bug: 847985
Change-Id: I457228768db9abc25a57f167928e55f342c1f15e
Reviewed-on: https://chromium-review.googlesource.com/1187082
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#585569}

Because of this cl
https://chromium-review.googlesource.com/c/chromium/src/+/1173158
The new selector item will be scaled up when we start drag a window from top.
But actually we just want to get the bounds of the scaled up new selector item,
we don't actually want to scaled it up in this case.

Bug: 872528
Change-Id: I4d132680ed35440eb5873620412fba1931db1857
Reviewed-on: https://chromium-review.googlesource.com/1182799Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585568}

The mojoms TouchDeviceServer, NativeDisplayDelegate and AccessibilityManager
are all not needed. Additionally TouchTransformSetterMus is not used.

BUG=none
TEST=none

Change-Id: I8d42aac5d548e5a109289133baeb3dd7fa3dd26b
Reviewed-on: https://chromium-review.googlesource.com/1185969Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585567}

Right now, ContextCreationAttributes are initialized differently in
OOP-D [1] and on non-OOP-D Android [2].

Update OOP-D's initialization to match what Android needs.

[1]
https://cs.chromium.org/chromium/src/components/viz/service/display_embedder/viz_process_context_provider.cc?l=42&rcl=696fb33bfb93ed9b759fa06aea81d26beedb4872
[2]
https://cs.chromium.org/chromium/src/content/browser/renderer_host/compositor_impl_android.cc?l=291&rcl=696fb33bfb93ed9b759fa06aea81d26beedb4872

BUG=867453

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I2e7abe55d3a7df84686e233ebd71cfbd51a77afd
Reviewed-on: https://chromium-review.googlesource.com/1155841
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585566}

This is a reland of e00fddec

Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan.
Verified this works with msan build.

Original change's description:
> Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker"
>
> This is a reland of a9ed46b7
>
> ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange
> was flaky in the original change. Added logic in the test to wait for the
> connection type change.
>
> Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc
>
> Original change's description:
> > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker
> >
> > A getter is used for NetworkConnectionTracker because some services that
> > use ResourceRequestAllowedNotifier are initialized early in browser
> > startup (e.g. VariationsService), and only perform the initialization
> > of ResourceRequestAllowedNotifier later on the UI thread. The getter
> > allows us to run get the connection tracker at that point so we don't get
> > DCHECKs about being on the UI thread when running
> > content::GetNetworkConnectionTracker().
> >
> > This also moves the NetworkConnectionTracker in ios/ from BrowserState to
> > ApplicationContext, which is available everywhere. It also matches non-IOS
> > usage more closely, since we have it as a global there.
> >
> > Bug: 868021
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802
> > Reviewed-on: https://chromium-review.googlesource.com/1180360
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#584849}
>
> TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org
>
> Bug: 868021
> Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1185602
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585387}

TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org

Bug: 868021, 876861
Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1187081
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585565}

As MultiDevice is consolidating its release blockers, I want to clean
out my todo list to make it as easy as possible to line up and burn
down bugs. For context,

multidevice_subpage.js: khorimoto multidevice_subpage is now taking
care of building the 'forget device' dialog

multidevice_setup_dialog.cc: I already added the strings

Change-Id: Ic8aa834f247df5064240dbc6f2b910acd2cb10b3
Reviewed-on: https://chromium-review.googlesource.com/1186030Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585564}

Change-Id: Ie1299b65bfb6a6b05e91cd2f8fed55f73f208734
Reviewed-on: https://chromium-review.googlesource.com/1186269Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585563}

This CL has a few changes that should simplify onion souping
webfilesystem_impl and webfilewriter_impl:

- Adds sync versions of Write, Truncate and ReadDirectory in the
  FileSystemManager interface and makes all the other methods sync
- Makes each WebFileSystemImpl and WebFileWriterImpl own a unique
  dispatcher object (allowing it to call dispatcher methods on worker
  threads without worrying about thread safety). They directly call the
  sync methods of the mojo service in order to block the worker
  thread (instead of using WaitableEvent and posting tasks on the main
  thread).
- PepperFileSystemHost now directly connects to the FileSystemManager
  service instead of using FileSystemDispatcher.

Bug: 787281
Change-Id: Ib497c0a6700c52a7abf4661f2f6a959c11b63519
Reviewed-on: https://chromium-review.googlesource.com/1175149
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585562}

https://skia.googlesource.com/skia.git/+log/9db44ed0ef7f..4c6514490e96


git log 9db44ed0ef7f..4c6514490e96 --date=short --no-merges --format='%ad %ae %s'
2018-08-23 reed@google.com fix dashimpl underflow
2018-08-23 mtklein@google.com fix clamp_0/clamp_1 stages in lowp
2018-08-23 fmalita@chromium.org [skottie] Improved text rendering
2018-08-23 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9259fd0d4f4c..c40974417610 (1 commits)
2018-08-23 robertphillips@google.com Add GPU-side caching of mask-filtered path masks (take 2)
2018-08-23 bsalomon@google.com Try again to fix leak of SkSL parser map when built standalone
2018-08-23 robertphillips@google.com Add 0-blur-sigma check to directFilterMaskGPU


Created with:
  gclient setdep -r src/third_party/skia@4c6514490e96

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:875494
TBR=fmalita@chromium.org

Change-Id: I14937f931974c643045181bd29f7ab477fc4fc00
Reviewed-on: https://chromium-review.googlesource.com/1187202Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585561}

In the Lifecycle State column, we were showing internal
TabLifecycleUnitStates rather than Page Lifecycle
states. As a result, we were showing "active" for the active, hidden,
and passive page lifecycle states. As chrome://discards will be used by
external developers, we should show Page Lifecycles States from the
spec (https://github.com/WICG/page-lifecycle).

This CL plumbs focus to the discards UI and uses the 3-tuple of
(internal_tab_state, visibility, focus) to compute the page lifecycle
state. Internal states are still shown in parentheses to aid in
TabManager debugging, e.g. "hidden (pending frozen)".

Bug: 856321
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ieb6f0a098cc165c0b7544b3f27a7317f8c78caa1
Reviewed-on: https://chromium-review.googlesource.com/1114282
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585560}

Preparation for matching src: local() descriptors in @font-face
declarations from Blink.

Unit test added which tests matching against the set of test fonts we
are using on Linux.

Bug: 859898
Change-Id: I4b28e2ef01edbc01e5a30c24480ef893bd32c9b2
Reviewed-on: https://chromium-review.googlesource.com/1124697Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585559}

Original CL: https://chromiumcodereview.appspot.com/11857007

  TCMalloc: restrict maximum size of memory allocations

  For security purposes, we restrict the maximum size of memory
  allocations under what can be indexed by an int.

  BUG=169327
  NOTRY=true

BUG=724399,b:70905156

Change-Id: I530659b9d0f519db1bc70f8d8f5b15537dc1f1b8
Reviewed-on: https://chromium-review.googlesource.com/1184336
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585558}

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I033579043cecd5a122175936255ab237e1ffb709
Reviewed-on: https://chromium-review.googlesource.com/1179091
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585557}

Using wpt-import in Chromium 845a36ef.
With Chromium commits locally applied on WPT:
2160c22c "Modify source path for wpt test of Accept-CH"
3152c6f7 "[UserTiming] Correct measure where start is undefined"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23213

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rob.buis@samsung.com:
  external/wpt/quirks

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I83e0217a8f0b870b676980fb99d0715f5968994a
Reviewed-on: https://chromium-review.googlesource.com/1186549
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585556}

Original CL: https://chromiumcodereview.appspot.com/10391178

  1. Enable large object pointer offset check in release build.
  Following code will now cause a check error:
  char* p = reinterpret_cast<char*>(malloc(kMaxSize + 1));
  free(p + 1);

  2. Remove a duplicated error reporting function "DieFromBadFreePointer",
  can use "InvalidGetAllocatedSize".

BUG=724399,b:70905156

Change-Id: I77b71593373d0c279b95f27cb4931be41c8605b0
Reviewed-on: https://chromium-review.googlesource.com/1184335Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585555}

This is an attempt to improve histogram documentations to use more
standard wording among similarly tracked histograms and clarify what
each histogram and bucket is actually tracking.

Change-Id: I07c4551075e670ec4676848a1e7e3fa4df584cac
Reviewed-on: https://chromium-review.googlesource.com/1125418Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585554}

PipelineController
   (closure)   <----- calling this closure allows the rest of the track switch
       |              and seek queue to continue to happen.          ^
       |                                                             |
       v                                                             |
FFmpegDemuxer::OnSelectedVideoTrackChanged                           |
    (closure)  <----- closure is passed down, but this function      |
       |              toggles some stream bits and then passes       |
       |              the closure down to the seek.                  |
       |                                                             |
       v                                                             |
FFmpegDemuxer::SeekAnyEnabledVideoFrame                              |
    (closure)  <----- If there are no tracks to enable, we're        |
       |                done, and can call the closure    -----------|
       |                                                             |
       v                                                             |
FFmpegDemuxer::SeekInternal                                          |
    (closure)  <----- Otherwise, we keep state that we're enabling   |
       |              a track and seeking it. This state lets us     |
       |              know later that we should drop some audio      |
       |              frames.                                        |
       v                                                             |
  FFMPEG MAGIC                                                       |
   (closure)   <----- Push the callback into an ffmpeg callback      |
       |                                                             |
       |                                                             |
       v                                                             |
FFmpegDemuxer::FFmpegAfterSeekCallback                               |
    (closure)  <----- FFmpeg has moved it's file cursor back to      |
                      wherever the seek point was, and is now        |
                      reading the interleaved data from all          |
                      streams. The state set in                      |
                      SeekAnyEnabledVideoFrame lets us keep track    |
                      of which of these frames are actually          |
                      worth re-rendering; we drop the audio, play    |
                      the video, and since in-band text isn't        |
                      displayed, we just ignore it and let it        |
                      go out of sync.                                |
                      At this point, the closure is also called      |
                      and the pipeline is free do whatever. ---------|

Bug: 663999
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I30897e3f7daddd2a818af47475e20f049665236d
Reviewed-on: https://chromium-review.googlesource.com/1132678
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585553}

Update profile icon badging for shortcuts and taskbar on Windows, bump icon version to get automatic update.

Use circular profile icon when creating taskbar and desktop shortcut icons.

Image preview (new icons vs. old icons, showing both transparent and non-transparent avatars)
https://drive.google.com/file/d/1smDN3CBvlYWehIjtRwyIRYKax3_1_F3g/view?usp=sharing

R=droger@chromium.org, sky@chromium.org, tbergquist@chromium.org

Bug: 857069
Change-Id: Id41d68a7f6f56583801d6cd112cf4ed7fd3e35bb
Reviewed-on: https://chromium-review.googlesource.com/1185403Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585552}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: I4cc6bde5c2d738bf5bc908735110ac420325e86c
Reviewed-on: https://chromium-review.googlesource.com/1183663Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#585551}

Remove send usage report toggle from cast setting menu.
Make the crash report upload directly decided by internal code.
Use timer to control the periodic crash upload tasks.

Bug:79208340

Test:change the frequency of uploading to 5 seconds
     switch the toggle and check whether the update function works
     and the status of upload function.
     view the remove effect of cast setting menu.

Merge-With: eureka-internal/175156

Change-Id: Ia49c10edb3b2b65fd62bf5734d0ca06376a60d09
Reviewed-on: https://chromium-review.googlesource.com/1114227
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585550}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: Ibfce629a890785c6b367d38ab45b05ecac893934
Reviewed-on: https://chromium-review.googlesource.com/1183488Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#585549}

Legacy layout has a bug that, whitespaces before <br> are not collapsed
(https://crbug.com/40634). The issue is fixed in NG.

This difference results in that, in some editing/selection layout tests,
one less character is moved through when EditingNG is enabled, so these
tests fail.

This patch removes the spaces before <br> so that these tests pass.

Bug: 707656
Change-Id: I4256865abb0a1fe925cfa584fe111b8ba8312332
Reviewed-on: https://chromium-review.googlesource.com/1185998Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585548}

A failed navigation commits a fake data: page (see
RenderFrameImpl::LoadNavigationErrorPageInternal).  This commit should
preserve most aspects of the original request which failed.  This
includes the http method and POST data.

This CL makes sure that the |failed_request| in
RenderFrameImpl::CommitFailedNavigation includes POST data (this is
fixed by making sure that CreateURLRequestForNavigation preserves the
POST data.

This CL also passes |failed_request| from
RenderFrameImpl::CommitFailedNavigation into
WebLocalFrameImpl::CommitDataNavigation - this ensures that the
|failed_request|'s properties are properly preserved.

This CL also makes sure that |replace| value calculated in
RenderFrameImpl::CommitFailedNavigation is correct not only for reloads,
but also for back/forward navigations.

Bug: 860807, 869117
Change-Id: Id4e781379defddb26f4e684632d173c46a6f660f
Reviewed-on: https://chromium-review.googlesource.com/1153564Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585547}

[Password Manager] Fix negative performance by not reading the database twice when merging passwords with Sync

After enabling the feature which deletes undecryptable logins and recovers Sync users who lost their passwords, there were a significant negative performance impact (the sync association time for passwords has almost doubled).
This fix skips checking if each password could be decrypted (which is currently done for every user) if the first read from database succeeds.
For ~95% of users it's not even required to check which passwords are decryptable, because reading from database immediately succeeds.
For other ~5% of users it's expected that those check would have to be done only once while recovering.

Bug: 791541
Change-Id: I460f3692eef330b82ae18fa9f6d52de834ee06e1
Reviewed-on: https://chromium-review.googlesource.com/1186463Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#585546}