GitLab

Remove a non-const pass-by-reference while we are at it.

Review URL: https://codereview.chromium.org/470693003

Cr-Commit-Position: refs/heads/master@{#290075}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290075 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr@chromium.org, enne@chromium.org, danakj@chromium.org
BUG=403829

Review URL: https://codereview.chromium.org/478723002

Cr-Commit-Position: refs/heads/master@{#290074}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290074 0039d316-1c4b-4281-b951-d872f2087c98

1. stack the link and button in the upgrade tutorial card
2. limit the width of the title label to accomodate long names.
3. increase the height of signin view
4. adds missing 'x' button

BUG=403572, 399663, 403105
R=asvitkine@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/465313003

Cr-Commit-Position: refs/heads/master@{#290073}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290073 0039d316-1c4b-4281-b951-d872f2087c98

This is an output surface that displays the content using
overlays and render-to-FBO, instead of the usual system-managed
framebuffer. Implementation to follow in another CL.

BUG=380861
TBR=stevenjb

Review URL: https://codereview.chromium.org/433543002

Cr-Commit-Position: refs/heads/master@{#290072}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332205
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/476213002

Cr-Commit-Position: refs/heads/master@{#290071}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290071 0039d316-1c4b-4281-b951-d872f2087c98

This change closed the build tree for Linux and ChromiumOS bots due to
failing interactive_ui_tests:

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=12979

> Omnibox: Prevent Asynchronous Suggestions from Changing Default Match
> 
> Calls to the suggest server may normally result in a new inline
> autocompletion.  This can be disruptive because it means pressing enter
> may bring the user to different places depending on how long he/she
> waits after typing the last key.
> 
> This change prevents new suggestions from becoming the default match.
> In other words, the default match is only allowed to change on a
> keystroke, not due to a reply coming back from the server.
> 
> The consequence of this change is that if previously we'd show an
> inline suggestion on a server reply, now we only show it one keystroke
> later.  I think this trade-off (one keystroke versus inconsistent
> omnibox behavior) is a good one to make.
> 
> We still end up with default matches (inline autocompletions within
> the omnibox) from the suggest server after this change.  Here's an
> example of why:
> 
> User types "facebo"
> We send a suggest server request.
> Server asynchronously returns "facebook" as a top suggestion,
>   beating the server-provided verbatim score for "facebo".
> We decide not to show it within the omnibox.  It's instead shown
>   somewhere in the dropdown.
> User types "o".
> We send a suggest server request.
> We reuse our cached suggestions and suggestion scores.  <<< THE KEY
> We show "facebook" as an inline suggestion because it beats
>   the default verbatim score that gets assigned to "faceboo".
>   (This is the score that we assign by default without having
>   yet received the most recent suggest server response.)
> We receive the response, which includes "facebook" as a top
>   suggestion, beating the server-provided verbatim score
>   for "faceboo".
> We show "facebook" as an inline suggestion.  i.e., we decide
>   not to demote it because it was already being shown inline
> 
> TESTED:
> unit tests plus interactive tests (facebook.com/l, google.com/a)
> 
> BUG=398135
> R=msw@chromium.org
> 
> Review URL: https://codereview.chromium.org/471673002

TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/477293002

Cr-Commit-Position: refs/heads/master@{#290070}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290070 0039d316-1c4b-4281-b951-d872f2087c98

(either ones blocking guest mode in particular or guest mode).

Follow-up to the CL http://codereview.chromium.org/385073008

CL is currently blocked on crbug.com/394413. No more, it landed!

BUG=306322

Review URL: https://codereview.chromium.org/471973003

Cr-Commit-Position: refs/heads/master@{#290069}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290069 0039d316-1c4b-4281-b951-d872f2087c98

Removing as bug http://crbug.com/284662 is fixed.

BUG=284662

Review URL: https://codereview.chromium.org/469213008

Cr-Commit-Position: refs/heads/master@{#290068}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290068 0039d316-1c4b-4281-b951-d872f2087c98

Undoes some previous work towards encryption support.  That approach
suffered from some subtle deadlock issues that could not be easily
worked around.  The new approach involves less sharing and less locks.

Gives the ModelTypeSyncWorker its own copy of the Cryptographer.  By
passing around copies, it no longer needs to worry about acquiring locks
in order to access the Directory's cryptographer.  This required
a rewrite of some changes to the way the ModelTypeSyncWorker detects the
current encryption state.  Most notably, its Cryptographer is NULL if
encryption is not enabled for its model type.

Makes the ModelTypeSyncRegistry responsible for observing changes
emitted by the SyncEncryptionHandler and forwarding them to the
ModelTypeSyncWorkers.  It should receive callbacks from the
SyncEncryptionHandler during startup, so it does not need to cache or
query any new data.

Removes the CryptographerProviders.  Since the ModelTypeSyncWorker no
longer need to access the directory's cryptographer, it's no longer
necessary.

BUG=351005

Review URL: https://codereview.chromium.org/452283003

Cr-Commit-Position: refs/heads/master@{#290067}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290067 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290066}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290066 0039d316-1c4b-4281-b951-d872f2087c98

643ccb5: (thestig) system_api: Remove deprecated mtpd method constants.
dce25dd: (pstew) Add property for WakeOnLan
e59913e: (chirantan) dbus: Add signal and methods for dark resume

BUG=397346
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/474333002

Cr-Commit-Position: refs/heads/master@{#290065}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=aarya@google.com, mbarbella@chromium.org

Review URL: https://codereview.chromium.org/465403004

Cr-Commit-Position: refs/heads/master@{#290064}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290064 0039d316-1c4b-4281-b951-d872f2087c98

This add an window.testRunner API that sends do-nothing IPC message
roundtrip. This API can be used to build IPC benchmark using
JavaScript.

TEST=none (Will add blink-side LayoutTest once this is landed)
BUG=402185
R=darin@chromium.org, jam@chromim.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/478483005

Cr-Commit-Position: refs/heads/master@{#290063}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build

Review URL: https://codereview.chromium.org/471163004

Cr-Commit-Position: refs/heads/master@{#290062}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290062 0039d316-1c4b-4281-b951-d872f2087c98

With the recent device polling changes
(https://codereview.chromium.org/424093004/), any failure in enumerating
devices/services prevents the background polling task from reporting
changes (to avoid reporting inconsistent configuration). However, when
devices are offline and polling is done in "discovery" mode,
enumerating services fails because the underlying SDP request fails.
The workaround if to ask for cached services only instead, so that at
least the services already previously known are returned and the
polling operation can succeed.

BUG=396337

Review URL: https://codereview.chromium.org/476823003

Cr-Commit-Position: refs/heads/master@{#290061}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290061 0039d316-1c4b-4281-b951-d872f2087c98

normalization was not working properly.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/468653003

Cr-Commit-Position: refs/heads/master@{#290060}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290060 0039d316-1c4b-4281-b951-d872f2087c98

Calls to the suggest server may normally result in a new inline
autocompletion.  This can be disruptive because it means pressing enter
may bring the user to different places depending on how long he/she
waits after typing the last key.

This change prevents new suggestions from becoming the default match.
In other words, the default match is only allowed to change on a
keystroke, not due to a reply coming back from the server.

The consequence of this change is that if previously we'd show an
inline suggestion on a server reply, now we only show it one keystroke
later.  I think this trade-off (one keystroke versus inconsistent
omnibox behavior) is a good one to make.

We still end up with default matches (inline autocompletions within
the omnibox) from the suggest server after this change.  Here's an
example of why:

User types "facebo"
We send a suggest server request.
Server asynchronously returns "facebook" as a top suggestion,
  beating the server-provided verbatim score for "facebo".
We decide not to show it within the omnibox.  It's instead shown
  somewhere in the dropdown.
User types "o".
We send a suggest server request.
We reuse our cached suggestions and suggestion scores.  <<< THE KEY
We show "facebook" as an inline suggestion because it beats
  the default verbatim score that gets assigned to "faceboo".
  (This is the score that we assign by default without having
  yet received the most recent suggest server response.)
We receive the response, which includes "facebook" as a top
  suggestion, beating the server-provided verbatim score
  for "faceboo".
We show "facebook" as an inline suggestion.  i.e., we decide
  not to demote it because it was already being shown inline

TESTED:
unit tests plus interactive tests (facebook.com/l, google.com/a)

BUG=398135
R=msw@chromium.org

Review URL: https://codereview.chromium.org/471673002

Cr-Commit-Position: refs/heads/master@{#290058}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290058 0039d316-1c4b-4281-b951-d872f2087c98

By default there is no change in behavior, but autofilling can now be disabled
for the sync credential entirely or just disabled for reauth pages that support
transactional reauth.

Note that this also changes GetSyncUsername() to not return the username if
password sync is disabled if it is possible to determine. This makes GetSyncUsername() a little inconsistent depending on the state of sync setup, but it's important to be as specific as possible when disabling autofilling, since it's a
usability hit.

BUG=386692
R=isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290030

Review URL: https://codereview.chromium.org/451853003

Cr-Commit-Position: refs/heads/master@{#290057}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401834

Review URL: https://codereview.chromium.org/471703002

Cr-Commit-Position: refs/heads/master@{#290055}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290055 0039d316-1c4b-4281-b951-d872f2087c98

Use it to log error type in BypassOneNetworkError UMA.
This fixes DataReductionProxy.BypassOnNetworkError UMA recording bug.

BUG=395769

Review URL: https://codereview.chromium.org/473513002

Cr-Commit-Position: refs/heads/master@{#290054}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290054 0039d316-1c4b-4281-b951-d872f2087c98

added in r288784 but the schema missed out.

BUG=388164
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/476243003

Cr-Commit-Position: refs/heads/master@{#290053}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290053 0039d316-1c4b-4281-b951-d872f2087c98

Add an overscroll effect implementation that mimics that of Android L. The
primary differences are the use of a single rasterized arc layer and the
inclusion of motion orthogonal to overscroll in computing the effect offset.

BUG=389744

Review URL: https://codereview.chromium.org/367173003

Cr-Commit-Position: refs/heads/master@{#290052}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290052 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/482433002

Cr-Commit-Position: refs/heads/master@{#290051}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290051 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/)

Reason for revert:
breaking XP

Original issue's description:
> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593

Review URL: https://codereview.chromium.org/481493002

Cr-Commit-Position: refs/heads/master@{#290050}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290050 0039d316-1c4b-4281-b951-d872f2087c98

BrowserOptionsOverlayWebUITest.testNavigationInBackground fails on DrMemory
bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%2811%29/builds/476

This changes the test to wait if it detects that the appropriate message has not yet been
sent to the uber page. This ensures that we are only testing the finalized state of the
page.  If the test times out, that would indicate that the problem lies elsewhere.

BUG=403627
R=estade@chromium.org

Review URL: https://codereview.chromium.org/476573002

Cr-Commit-Position: refs/heads/master@{#290049}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290049 0039d316-1c4b-4281-b951-d872f2087c98

We need input methods "config" object to switch between IME states.

This CL also fixed issue with incorrect input method after
screen unlock in multiprofile mode.

BUG=292774,399129
TEST=manual

TBR=nona@chromium.org,asargent@chromium.org,davemoore@chromium.org

Review URL: https://codereview.chromium.org/419293002

Cr-Commit-Position: refs/heads/master@{#290048}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290048 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/472213002

Cr-Commit-Position: refs/heads/master@{#290046}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290046 0039d316-1c4b-4281-b951-d872f2087c98

This caused a tree closure due to unit_tests failure:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47244

> [Password Manager] Setup experiment to restrict autofilling of sync credential
> 
> By default there is no change in behavior, but autofilling can now be disabled
> for the sync credential entirely or just disabled for reauth pages that support
> transactional reauth.
> 
> Note that this also changes GetSyncUsername() to not return the username if
> password sync is disabled if it is possible to determine. This makes GetSyncUsername() a little inconsistent depending on the state of sync setup, but it's important to be as specific as possible when disabling autofilling, since it's a
> usability hit.
> 
> BUG=386692
> R=isherman@chromium.org
> 
> Review URL: https://codereview.chromium.org/451853003

TBR=gcasto@chromium.org

Review URL: https://codereview.chromium.org/477273003

Cr-Commit-Position: refs/heads/master@{#290045}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290045 0039d316-1c4b-4281-b951-d872f2087c98

If a network was configured with a client certificate before R38, the slot ID will either be missing or not be valid in R38 and later because of the added device wide token.

This migration code will look up a configured client certificate by its PKCS#11 ID and update the slot id.
If the certificate can't be found, the client configuration will be removed in order to trigger a clean 'missing configuration' error in the UI.

This change is primarily targeted for manually configured networks and not policy-configured networks. The latter are automatically updated by the chromeos::ClientCertResolver.

BUG=403900

Review URL: https://codereview.chromium.org/471183002

Cr-Commit-Position: refs/heads/master@{#290044}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362679

Review URL: https://codereview.chromium.org/481473002

Cr-Commit-Position: refs/heads/master@{#290043}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290043 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290042}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290042 0039d316-1c4b-4281-b951-d872f2087c98

$ git log bbf1fcca7..b8aeeaef0 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-08-15 maruel Greatly improve subprocess42.
2014-08-15 maruel Fix parallel_execution which would pass the wrong argument in case of error.
2014-08-15 maruel Fix bugs in run_swarming_tests_on_swarming.py.
2014-08-15 maruel R.I.P. googletest/
2014-08-15 maruel Add callback support in net_utils.py when evaluation http request mock.
2014-08-14 maruel Fix third regression introduced in 0a62061f6e8e3f.
2014-08-13 maruel Fix second regression introduced in 0a62061f6e8e3f.
2014-08-13 maruel Fix regression introduced in 0a62061f6e8e3f.
2014-08-13 maruel Make json API url request saner.
2014-08-06 maruel Add .mp4 as already-compressed extension.

R=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/481523002

Cr-Commit-Position: refs/heads/master@{#290041}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290041 0039d316-1c4b-4281-b951-d872f2087c98

Preloading the plugin starts NaCl translator, which saves time when
the user tries to connect.

Review URL: https://codereview.chromium.org/467903002

Cr-Commit-Position: refs/heads/master@{#290040}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391922

Review URL: https://codereview.chromium.org/396033002

Cr-Commit-Position: refs/heads/master@{#290039}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290039 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Move sqlite_channel_id_store from chrome/browser/net to net/extras. (patchset #26 of https://codereview.chromium.org/381073002/)

Reason for revert:
Closed the tree on failing net_unittests:

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=32912

Original issue's description:
> Move sqlite_channel_id_store from chrome/browser/net to net/extras.
> Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store. 
> 
> TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest*
> TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore*
> 
> BUG=397545
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289996

TBR=mef@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/477253002

Cr-Commit-Position: refs/heads/master@{#290038}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/429763003

Cr-Commit-Position: refs/heads/master@{#290037}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290037 0039d316-1c4b-4281-b951-d872f2087c98

- Add edge menu bg assets for tablets.
- Add back the vertical offset to properly line up this offset

BUG=400549
NOTRY=true

Review URL: https://codereview.chromium.org/466993002

Cr-Commit-Position: refs/heads/master@{#290036}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/475333004

Cr-Commit-Position: refs/heads/master@{#290035}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290035 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290034}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290034 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180329:180365&mode=html
TBR=adamk@chromium.org,mkwst@chromium.org
BUG=

Review URL: https://codereview.chromium.org/480523002

Cr-Commit-Position: refs/heads/master@{#290033}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290033 0039d316-1c4b-4281-b951-d872f2087c98