Commits · fc2436bac6a8e5f6839f6e62e8680a15e7d592eb · eriksson monteiro / tangled

18 Nov, 2011 1 commit

[Aura] Fix HtmlDialogBrowserTest.SizeWindow. · fc2436ba

xiyuan@chromium.org authored Nov 18, 2011

- Fix HtmlDialogBrowserTest.SizeWindow for Linux + Aura + Chromeos==0.
- Remove minimum_size_ from auralWindow and add an OnBoundsChanging to aura::WindowDelegate so that a delegate can apply bounds constriant;
- NativeWidgetAura uses OnBoundsChanging to apply Widget's minimum size;
- Remove minimum_size_ member from Widget because it is only used for widget with no frame (i.e. no non_client_view_) and such widget should have no minimum size;

BUG=104412
TEST=Verify the HtmlDialogBrowserTest.SizeWindow should pass for Linux + Aura + Chromeos==0.


Review URL: http://codereview.chromium.org/8574049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110608 0039d316-1c4b-4281-b951-d872f2087c98

fc2436ba

17 Nov, 2011 39 commits

base::Bind() conversion for content/common/gpu and content/gpu · 35a5b75c

dcheng@chromium.org authored Nov 17, 2011

There will be a followup patch to finish the conversion for GpuCommandBufferStub.

BUG=none
TEST=compiles and passes try bots

Review URL: http://codereview.chromium.org/8572047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110607 0039d316-1c4b-4281-b951-d872f2087c98

35a5b75c

allocator.gyp target needs to be conditionally included in compositor.gyp · 9c7db28e

dhollowa@chromium.org authored Nov 17, 2011

Changes the compositor.gyp file to only include the tcmalloc allocator on linux when use_linux_tcmalloc is specified. This was conflicting with ASAN compile flags.

BUG=none
TEST=compile on linux with GYP_DEFINES='asan=1 linux_use_tcmalloc=0...'
TBR=oshima@chromium.org, backer@chromium.org

Review URL: http://codereview.chromium.org/8591029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110606 0039d316-1c4b-4281-b951-d872f2087c98

9c7db28e

Add buttons to clear the cache and flush socket · 4b5e71de

mmenke@chromium.org authored Nov 17, 2011

pools to net-internals events view.  This can make
reproducing some issues much less painful.

Review URL: http://codereview.chromium.org/8590037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110605 0039d316-1c4b-4281-b951-d872f2087c98

4b5e71de

Valgrind: Disable way too many Mac PPAPI UI tests. · 7e644a81

jhawkins@chromium.org authored Nov 17, 2011

Started with r110580.

BUG=104535
TEST=none

R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8558005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110603 0039d316-1c4b-4281-b951-d872f2087c98

7e644a81

Revert 110587 - Microphone support for Pepper Flash. · 7aac3055

ajwong@chromium.org authored Nov 17, 2011

[Committing for pbrophy@adobe.com. Original review:
http://codereview.chromium.org/8138008/ .]

This change supports audio capture from the microphone and supplies the data
through a Pepper interface. Its enumeration is limited to the default audio
device that uses mono 44.1kHz.

TBR=tony@chromium.org

Review URL: http://codereview.chromium.org/8574029

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8569003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110602 0039d316-1c4b-4281-b951-d872f2087c98

7aac3055

Replace FileManagerUtil class with namespace file_manager_util. · 81c5deab

achuith@chromium.org authored Nov 17, 2011

file_manager_util namespace is consistent with other utils in the codebase (platform_util, mime_util, file_util), and is the preferred way in the google style guide to do this kind of thing. The FileManagerUtil class is never initialized and has no state.

BUG=None, cleanup
TEST=Compiles, tests pass.
Review URL: http://codereview.chromium.org/8574054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110600 0039d316-1c4b-4281-b951-d872f2087c98

81c5deab

Fix resize issues when using threaded compositing · 58264a37

enne@chromium.org authored Nov 17, 2011

Threaded compositing doesn't ever call DoDeferredUpdate, so never has a chance
to send the resize ack via an update message back to the browser. Fix by piping
through didBeginFrame (called at the beginning of a main thread frame) and
didFinishFrame (called during the client side OnSwapBuffers when a main thread
frame has been committed). This patch queues up update messages during
didBeginFrame and then sends them out during the corresponding didFinishFrame.

BUG=103776
TEST=run with threaded compositing, resize page multiple times

Review URL: http://codereview.chromium.org/8528006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110599 0039d316-1c4b-4281-b951-d872f2087c98

58264a37

Valgrind: Fix the suppression for bug 16092 since PendingTask has moved. · e816a9ad

jhawkins@chromium.org authored Nov 17, 2011

BUG=16092
TEST=none

R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8591039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110598 0039d316-1c4b-4281-b951-d872f2087c98

e816a9ad

Initial check-in of Linux virtual Me2Me. · 1a98c25f

lambroslambrou@chromium.org authored Nov 17, 2011

This CL includes a Python script, remoting.py, that sets up and runs a virtual X session and host process. It also includes a remoting_me2me_host executable target, which is a simplified version of remoting_simple_host, using the config files that remoting.py sets up.

remoting.py uses Xvfb which needs to be installed (sudo apt-get install xvfb).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8511029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110597 0039d316-1c4b-4281-b951-d872f2087c98

1a98c25f

corresponding change in CaptureVideoDecoder and RTCVideoDecoder due to pull... · 9ab22690

wjia@chromium.org authored Nov 17, 2011

corresponding change in CaptureVideoDecoder and RTCVideoDecoder due to pull model used in media VideoRenderer
1. Recent refactoring in media stack went back to pull model between VideoDecoder and VideoRenderer. Necessary change is needed in VideoDecoder subclasses.
2. fix racing condition during video capture shutdown. Now VideoCaptureImpl is guaranteed to be deleted after all events have been processed.

BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8528045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110596 0039d316-1c4b-4281-b951-d872f2087c98

9ab22690

ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system. · 262060ff

jhawkins@chromium.org authored Nov 17, 2011

BUG=none
TEST=none

R=willchan@chromium.org,stoyan@chromium.org

Review URL: http://codereview.chromium.org/8591009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110595 0039d316-1c4b-4281-b951-d872f2087c98

262060ff

Valgrind: Fix a leak in ContentSettingsProvider. · c2632ab1

jhawkins@chromium.org authored Nov 17, 2011

If the call to SetWebsiteSetting() fails, the value is still owned by the
caller and must be deleted.

BUG=none
TEST=none

R=bauerb@chromium.org

Review URL: http://codereview.chromium.org/8592001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110594 0039d316-1c4b-4281-b951-d872f2087c98

c2632ab1

Use scoped_ptr for memory management rather than calling delete through WindowSizer. · 7b580671

tfarina@chromium.org authored Nov 17, 2011

R=ben@chromium.org

Review URL: http://codereview.chromium.org/8585035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110593 0039d316-1c4b-4281-b951-d872f2087c98

7b580671

Disable PrintDialogCloudTest.HandlersRegistered for aura builds in browser_tests. · b0be4f31

jennyz@chromium.org authored Nov 17, 2011

This reverts commit 567376dd.

BUG=103497
TEST=NONE


Review URL: http://codereview.chromium.org/8589026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110592 0039d316-1c4b-4281-b951-d872f2087c98

b0be4f31

Disable StartMinimized test for aura · 9542316a

oshima@google.com authored Nov 17, 2011

Aura doesn't support minimized window.

BUG=104571
TEST=none

Review URL: http://codereview.chromium.org/8585014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110591 0039d316-1c4b-4281-b951-d872f2087c98

9542316a

Revert 110584 - Make pulseaudio available for all posix platforms and add support on OpenBSD. · ea0340d1

scherkus@chromium.org authored Nov 17, 2011

Patch by robert.nagy@gmail.com:
http://codereview.chromium.org/8499029/

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/8590045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110590 0039d316-1c4b-4281-b951-d872f2087c98

ea0340d1

Fix watchlist definition for clipboard. · c767b065

dcheng@chromium.org authored Nov 17, 2011

BUG=none
TEST=python $DEPOT_TOOLS/watchlists.py clipboard matches

Review URL: http://codereview.chromium.org/8574077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110589 0039d316-1c4b-4281-b951-d872f2087c98

c767b065

Microphone support for Pepper Flash. · 0ac8fd43

viettrungluu@chromium.org authored Nov 17, 2011

[Committing for pbrophy@adobe.com. Original review:
http://codereview.chromium.org/8138008/ .]

This change supports audio capture from the microphone and supplies the data
through a Pepper interface. Its enumeration is limited to the default audio
device that uses mono 44.1kHz.

TBR=tony@chromium.org

Review URL: http://codereview.chromium.org/8574029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110587 0039d316-1c4b-4281-b951-d872f2087c98

0ac8fd43

sync: remove includes from ProfileSyncFactory + add to AutofillDataTypeController · f21cf6a8

tim@chromium.org authored Nov 17, 2011

Probably the awesomest patch evar

BUG=none
TEST=compiles!


Review URL: http://codereview.chromium.org/8590041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110586 0039d316-1c4b-4281-b951-d872f2087c98

f21cf6a8

Add arguments in macros where required · d480ae50

jar@chromium.org authored Nov 17, 2011

This was breaking a variant of the current macro, so I defined
a no-op for the "code" values.

r=slightlyoff
BUG=103830
Review URL: http://codereview.chromium.org/8511083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110585 0039d316-1c4b-4281-b951-d872f2087c98

d480ae50

Make pulseaudio available for all posix platforms and add support on OpenBSD. · a1ced36b

scherkus@chromium.org authored Nov 17, 2011

Patch by robert.nagy@gmail.com:
http://codereview.chromium.org/8499029/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110584 0039d316-1c4b-4281-b951-d872f2087c98

a1ced36b

Propagate the SafeBrowsing download protection verdict to the DownloadItem. · 3ab4c0af

noelutz@google.com authored Nov 17, 2011

This is where the UI will be notified when a malicious binary is being
downloaded.  The UI currently does not support displaying a warning after
the download started.  We'll fix that in a separate CL.

BUG=102540
TEST=No visible changes.


Review URL: http://codereview.chromium.org/8468020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110583 0039d316-1c4b-4281-b951-d872f2087c98

3ab4c0af

Adding pyauto-based perf test for WebGL SpaceRocks demo. · b5703e97

dennisjeffrey@chromium.org authored Nov 17, 2011

BUG=chromium-os:23108
TEST=None

Review URL: http://codereview.chromium.org/8574067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110582 0039d316-1c4b-4281-b951-d872f2087c98

b5703e97

Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). · 9814a5bd

tfarina@chromium.org authored Nov 17, 2011

BUG=100276
R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8513023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110581 0039d316-1c4b-4281-b951-d872f2087c98

9814a5bd

Pepper: Add some simple tests for most functions in the PPB_Flash interface. · d67f5ae4

viettrungluu@chromium.org authored Nov 17, 2011

BUG=104560
TEST=ui_tests {OutOfProcessPPAPITest,PPAPITest}.Flash


Review URL: http://codereview.chromium.org/8589009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110580 0039d316-1c4b-4281-b951-d872f2087c98

d67f5ae4

Fixes use after free in BrowserView, and cleans up a couple of style · caf5161e

sky@chromium.org authored Nov 17, 2011

nits I noticed along the way.

BUG=104387
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8586033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110579 0039d316-1c4b-4281-b951-d872f2087c98

caf5161e

[Sync] The cryptographer should be able to handle empty or old nigori nodes. · 03c41c9e

zea@chromium.org authored Nov 17, 2011

This includes never unsetting the encryption status of a type once it has been
set.

BUG=104218
TEST=unit_tests


Review URL: http://codereview.chromium.org/8564032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110578 0039d316-1c4b-4281-b951-d872f2087c98

03c41c9e

Revert 110555 - sync: Remove ModelNeutralExecuteImpl() · 9f65f4b3

rlarocque@chromium.org authored Nov 17, 2011

ProcessUpdatesCommand was the only child of ModelChangingSyncerCommand
to override this function.  Since it is special, let's just treat it
specially in syncer.cc rather than modifying ModelChangingSyncerCommand
to suit its needs.

BUG=36594
TEST=


Review URL: http://codereview.chromium.org/8510079

TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/8586042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110572 0039d316-1c4b-4281-b951-d872f2087c98

9f65f4b3

Revert 110557 - Use nacl::CreateMemoryObject to create dynamic code shared memory object · cbbe7846

ajwong@chromium.org authored Nov 17, 2011

Use NaCl's code rather than base::SharedMemory to create the shared memory
object to whose mappings NaCl needs to apply PROT_EXEC.  We'll be changing
that NaCl code to deal with the Linux cases where shm_open objects cannot
have PROT_EXEC applied to their mappings.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= nacl_integration

R=mseaborn@chromium.org

Review URL: http://codereview.chromium.org/8574065

TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8587055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110571 0039d316-1c4b-4281-b951-d872f2087c98

cbbe7846

base::Bind migrations in chrome/renderer · 80c3df83

csilv@chromium.org authored Nov 17, 2011

BUG=none
Review URL: http://codereview.chromium.org/8523037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110570 0039d316-1c4b-4281-b951-d872f2087c98

80c3df83

Fix initial offline state response handling · 81d4ea28

adamk@chromium.org authored Nov 17, 2011

to read a Variant of uint32 instead of a uint32,
as specified by the Properties.Get interface.

R=satorux@chromium.org,willchan@chromium.org
BUG=104637

Review URL: http://codereview.chromium.org/8591021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110569 0039d316-1c4b-4281-b951-d872f2087c98

81d4ea28

Don't build a bunch of stuff on Aura, rather than ifdefing out code in it. · f6d2a3ea

ben@chromium.org authored Nov 17, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8591004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110567 0039d316-1c4b-4281-b951-d872f2087c98

f6d2a3ea

chromeos: Add "virtual" to d'tor to appease clang. · b9476c72

derat@chromium.org authored Nov 17, 2011

The lack of a "virtual" on InitialBrowserWindowObserver's
destructor generates an error on the linux_chromeos_clang
builder.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8586039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110566 0039d316-1c4b-4281-b951-d872f2087c98

b9476c72

Get content to build again with aura & component build. · 68a1d2b3

ben@chromium.org authored Nov 17, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8574047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110565 0039d316-1c4b-4281-b951-d872f2087c98

68a1d2b3

Give Constrained windows the proper square frame corners. · 282b3f1f

ben@chromium.org authored Nov 17, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8488014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110564 0039d316-1c4b-4281-b951-d872f2087c98

282b3f1f

chromeos: Fix a clang build error in CandidateWindowView. · e354398e

satorux@chromium.org authored Nov 17, 2011

Clang doesn't like the destructor to be inlined in .h file.

./chrome/browser/chromeos/input_method/candidate_window_view.h:32:3: error: [chromium-style] Complex destructor has an inline body.

The error was caused by crrev.com/110492

TEST=chrome builds
BUG=none

Review URL: http://codereview.chromium.org/8585043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110563 0039d316-1c4b-4281-b951-d872f2087c98

e354398e

base::Bind migrations in chrome/browser · e01976f0

csilv@chromium.org authored Nov 17, 2011

BUG=none
Review URL: http://codereview.chromium.org/8590012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110562 0039d316-1c4b-4281-b951-d872f2087c98

e01976f0

base::Bind migrations in chrome/browser · 6198f798

csilv@chromium.org authored Nov 17, 2011

BUG=none
Review URL: http://codereview.chromium.org/8513020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110561 0039d316-1c4b-4281-b951-d872f2087c98

6198f798

Make power button in status view invisible until we are sure battery is supported on device. · da910fe4

tbarzic@chromium.org authored Nov 17, 2011

BUG=chromium-os:21360
TEST=Verified power button is visible on Cr48
     Verified power button is invisible when there is no battery
     Verified power button is invisible in vm
     PowerMenuButtonBrowserTest.*

Review URL: http://codereview.chromium.org/8536048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110560 0039d316-1c4b-4281-b951-d872f2087c98

da910fe4