- 12 Dec, 2017 40 commits
-
-
Sunny Sachanandani authored
ScopedMakeCurrent and ScopedReleaseCurrent don't check for errors when restoring the previous context. In most cases the MakeCurrent that restores the previous context should not fail, and if it fails we don't return errors up the stack so we CHECK that MakeCurrent succeeds. However, for DirectComposition, we use ScopedReleaseCurrent when reallocating the drawing surface. Restoring the context can fail in this case. This CL adds a Restore method to both classes whose return value must be handled. This prevents the CHECK in the destructor. The lack of error checking is causing a crash in SetSwapInterval, due to null-dereference of GLContext::GetCurrent. This was found by adding a crash key to get the stack trace for SetCurrent(NULL). BUG=724999 R=piman Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I370ff470c78afa76bd000de60a6a63295746ee1b Reviewed-on: https://chromium-review.googlesource.com/818533Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#523562}
-
Devlin Cronin authored
The entire suite of externally-connectable messaging tests has been disabled on Windows. I'm unable to reproduce any failures locally, and all the logs have dried up. Try re-enabling one, and see how it goes. Bug: 350517 Change-Id: Ib08941ad1b5c6fd007056d2c9af8a8c349c08e05 Reviewed-on: https://chromium-review.googlesource.com/823012 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523561}
-
Devlin Cronin authored
ExtensionPrefs::GetExtensionsFrom() is never used. It was originally exposed for the ProtectedPrefsWatcher, but that was removed in crrev.com/102253f8. Remove it. Bug: None Change-Id: Ibc1f246f81e5826762d6183cca3c37c7a6b38624 Reviewed-on: https://chromium-review.googlesource.com/822517Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523560}
-
clamy authored
This CL ensures that the base URL is properly used as the first_party_for_cookies URL in Android WebView if it is non-null. This fixes an issue with cookies being unproperly set for iframes if their parent was loaded through LoadDataWithBaseURL. BUG=793648 Change-Id: I0f7da293f1e102f7b414ae799f701d48667eefc1 Reviewed-on: https://chromium-review.googlesource.com/822572 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523559}
-
Joel Einbinder authored
If a workspace root was exluded, it would instead exclude "undefined" Change-Id: Ib82e11f2182a1fcced176735ae714212a153d5b2 Reviewed-on: https://chromium-review.googlesource.com/822457Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523558}
-
Devlin Cronin authored
v8_helpers::CallFunction wraps v8::Function::Call. However, we should be avoiding using v8::Function::Call whenever possible, since it doesn't account for all possible state in the renderer (e.g., script suspension, etc). Remove v8_helpers::CallFunction and inline the v8::Function::Call at the two places it was used, along with a TODO to update them. Bug: None Change-Id: If3358bfda74126c3898cea2483fc6a012bdd6f24 Reviewed-on: https://chromium-review.googlesource.com/823010Reviewed-by:
-
Konstantin Ganenko authored
CompletionHandler is used in CacheThread_BlockFile. CacheThread_BlockFile is lazy + leaky instance, thus, there was race condition when all lazy instances are already destroyed, but message io pump still processes some io overlapped operation,leading to using IOHandler after free. Make completion handler to be refcounted and add ref to each overlapped operation it participates with. R=jkarlin@chromium.org, morlovich@chromium.org Bug: Change-Id: I7bd5fbdc83aae05489d5089ee16a94857ea1b104 Reviewed-on: https://chromium-review.googlesource.com/793158Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#523556}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/7f5c3eb76834..3c613c0d79fa $ git log 7f5c3eb76..3c613c0d7 --date=short --no-merges --format='%ad %ae %s' 2017-11-16 fjhenigman Update docs for GN standalone and GYP deprecation. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I56bd58391a560f0f938e0006f850a7758ddd7f24 Reviewed-on: https://chromium-review.googlesource.com/822178Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523555}
-
Bret Sepulveda authored
As per the Harmony spec, the arrow is removed. This patch also includes related cleanup. Bug: 605657 Change-Id: Icdca8e14ee135578d57840cafc4397987262a141 Reviewed-on: https://chromium-review.googlesource.com/817952Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#523554}
-
Robert Hogan authored
Bug: 180722 Change-Id: I187155b0076d8f4e7d9e7c9e7b80d9686a12ad2c Reviewed-on: https://chromium-review.googlesource.com/808929 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523553}
-
John Chen authored
Currently, the ChromeDriver water shows green status even when some tests have failed. Updating the build script to fix that. Bug: 768880 Change-Id: I5f3ccadd00a119390dd9fbd625172f987a1100eb Reviewed-on: https://chromium-review.googlesource.com/809726 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#523552}
-
Robert Sesek authored
Bug: 598854 Change-Id: Ie1774cca339e3a0a169cc367e21b113aab6a8b70 Reviewed-on: https://chromium-review.googlesource.com/821250Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523551}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f7aa204aafe9..ebcbb85ea364 $ git log f7aa204aa..ebcbb85ea --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair Move Script_Som_Border{Width|Color} to CJX_Object 2017-12-12 thestig Roll DEPS for Skia to 40ca2087. 2017-12-12 thestig Combine WideString::operator< and Compare(). 2017-12-12 dsinclair Move Script_Attribute_Integer to CJX_Object 2017-12-12 thestig Use early returns in pdf_parser_decode.cpp. 2017-12-12 dsinclair Remove unused script attribute methods 2017-12-12 dsinclair Move Script_Attribute_BOOL to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I892e5f50dc275d95a080f6962e2072f82e36828f Reviewed-on: https://chromium-review.googlesource.com/822177 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523550}
-
Will Chen authored
This enables the new integration test framework to support startup tests that need to exercise activities in the inspected page prior to starting the DevTools session. This migrates console-format-startup.js as an example test. Bug: 667560 Change-Id: Ifdd82135494ef7e05879297197e210a9b812d3ea Reviewed-on: https://chromium-review.googlesource.com/803909 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523549}
-
Alice Boxhall authored
Bug: 793225 Change-Id: I888f166d099b7829b942fc8d31c16fec8a3df411 Reviewed-on: https://chromium-review.googlesource.com/821950Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#523548}
-
Brian Salomon authored
These factories don't require casting of GrGLInterface/GrVkBackendContext to GrBackendContext and return a sk_sp<GrContext> rather than a bare pointer. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie0673c724a9d1d853a571e68ad001ce491860e85 Reviewed-on: https://chromium-review.googlesource.com/817677 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523547}
-
Ben Chan authored
The notification view for SMS messages is limited to show at most 3 lines, which is not sufficient to show the full content of a SMS message with multiple line breaks. As a workaround, this CL collapses whitespaces in a SMS message to minimize the number of lines needed to show the SMS message in the notification view. Bug: 775786 Change-Id: I807a50c888a1d36439b19805e946d7fb261de633 Reviewed-on: https://chromium-review.googlesource.com/821850 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523546}
-
Joel Einbinder authored
We shouldn't mess with the folder structure while the user is inside it. They might be crushed. Bug: none Change-Id: Iaa03fc58d2992d849b3fc097747549e938c7761d Reviewed-on: https://chromium-review.googlesource.com/821560Reviewed-by:
-
Penny MacNeil authored
- kFileNotFound and kArraySizeZero now treated as kSuccess. - Updated shared definitions in whitelist_packed_format source set. New timestamp to track last load attempt in local cache. Added relative path and file name too. - Decision made to check is_sorted on array during init. The array will be smaller than in original design, so speed hit will be minimal. - New tests. BUG=769590 TEST=chrome_elf_unittests.exe, WhitelistFileTest.* Change-Id: I45c4321ccdf89d8768509c0dad21c9c15f73c4e3 Reviewed-on: https://chromium-review.googlesource.com/794551 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#523544}
-
Dominick Ng authored
https://crrev.com/c/737610 fixed a performance issue in WebsitePermissionsFetcher by overriding android.util.Pair's hashCode method. This allowed a previous fix for a NullPointerException crash on Android pre-Kitkat to be removed. Unfortunately, the pre-KitKat crash occurs not only in the hashCode() method, but also in the equals() method. This CL overrides equals() with an implementation that correctly handles nulls. The implementation is taken from the CL which introduced correct null handling to android.util.Pair - https://android.googlesource.com/platform/frameworks/base/+/162fabbcf81157fddab1c38de09bdabaff8c068a%5E%21/#F0 BUG=793974 Change-Id: Ica6b102146222fbeac98c3179dbcf0c9ef101f85 Reviewed-on: https://chromium-review.googlesource.com/821330Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#523543}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/8cc672aa9c1c..d076c5980367 $ git log 8cc672aa9..d076c5980 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 simonhatch Dashboard - Parallelize some things in /add_histograms_queue Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I92852cee232fa1d454ada70f4b221038d067c430 Reviewed-on: https://chromium-review.googlesource.com/822452 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523542}
-
Sadrul Habib Chowdhury authored
Start running content_unittests with the --mus flags on linux-chromeos bots. BUG=786453 Change-Id: Ied53b0f651dbec49ee7a3224623bb69343eaf891 Reviewed-on: https://chromium-review.googlesource.com/817691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523541}
-
Paul Miller authored
UpdateEnabledState is really 2 functions in one: UpdateEnabledState(true) is only called from Enable, and UpdateEnabledState(false) is only called from ~Connector. Despite its name, UpdateEnabledState(false) must not actually disable accessibility, because of bugs 775532 and 792269. So fold the 2 parts into their respective call sites. BUG=792269 Change-Id: Ie7afcebda79820d4856a8b050f9b865c2bd1f5c3 Reviewed-on: https://chromium-review.googlesource.com/812084Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523540}
-
Tarun Bansal authored
A URLRequest is heuristically marked as hanging if its value is M times more than the transport RTT estimate, and/or N times the HTTP RTT estimate. A throughput observation window is marked as hanging by comparing the duration of the window with the HTTP RTT estimate, and the number of bytes received during the window with the expected congestion window size. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 765378 Change-Id: Ia215102194a4426cf6c447a629e29145fa8cb13c Reviewed-on: https://chromium-review.googlesource.com/777855Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523539}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c896eddc1cf7..09757b29feeb $ git log c896eddc1..09757b29f --date=short --no-merges --format='%ad %ae %s' 2017-12-12 kjlubick Fuzz skpicture with ReadBuffer 2017-12-12 robertphillips Remove GrBackendObject from tests (except image_from_yuv_textures) 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 7f5c3eb76..3c613c0d7 (1 commit) 2017-12-11 halcanary dm: require tmpDir, reasonable defaults Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I678b50b539327c401c4218ac2b31e7e5a4bd75f9 Reviewed-on: https://chromium-review.googlesource.com/822600Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523538}
-
Scott Chen authored
Bug: 793369 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If5b0fe0db0ddbbacce655ef90cd8fe3d135982d0 Reviewed-on: https://chromium-review.googlesource.com/817939 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523537}
-
Devlin Cronin authored
One of the variants of ModuleSystem::RunString() was unused. Remove it. Bug: None Change-Id: I551b5b2baec597d20d8923578b52ea6f02a169ce Reviewed-on: https://chromium-review.googlesource.com/822730Reviewed-by:
-
Erik Luo authored
A recent CL to persist sidebar state introduced a regression where the console sidebar is open by default. It should be closed by default. Bug: 794236 Change-Id: Ia9e58843bc10b7cbbe94aae511ca05a1a833b5f3 Reviewed-on: https://chromium-review.googlesource.com/822598 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
In the Payment Request and the Autofill address editor, for the admin area field (state/province), the default selection must be the hint (which is "Select"). Previously, the default was the first item in the list. BillingAddressAdapter is used for both Card Editor and Address Editor dropdown lists. Modify it so that it works correctly for Address Editor as well. Bug: 793436 Change-Id: Ib91b9d62105f255edddbc67fc295387e23aaffb2 Reviewed-on: https://chromium-review.googlesource.com/820050 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#523534}
-
Ryan Sturm authored
This tracks network and cache bytes and rounds them to a lower bounding exponential bucket threshold before reporting them to UKM. Bug: 723703 Change-Id: Ica14f0c7e396c9086e71f6cdc3c9b869cf75d0a8 Reviewed-on: https://chromium-review.googlesource.com/791529 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523533}
-
Nicolas Pena authored
This CL adds toJSON to the following: * PerformanceLongTaskTiming * PerformanceResourceTiming * TaskAttributionTiming * Performance within workers Link to Intent to Implement and Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ZnXvNe_wNyk Bug: 740094 Change-Id: I54622b9bd213fd806a9108598ccf4798c2ceffa2 Reviewed-on: https://chromium-review.googlesource.com/802019Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523532}
-
Tom Anderson authored
Example flakes: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65337 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65304 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65296 BUG=799129 TBR=pavely@chromium.org Change-Id: Id9775baf2e5f82e7c5b7a9bd3194cf24dd3ad74e Reviewed-on: https://chromium-review.googlesource.com/822980Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523531}
-
Charles Harrison authored
The experiment is over and this could mask real improvements on the critical loading path, especially CPU performance wins on the IO thread. Bug: None Change-Id: I904e1be21961aca3e35245f569651700f1b0dad8 Reviewed-on: https://chromium-review.googlesource.com/822298Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523530}
-
Ned Nguyen authored
Bug:786385,786010 TBR=eyaich@chromium.org NOTRY=true Change-Id: I0fd582abd70963b56616c90434ebbf3971f0adaf Reviewed-on: https://chromium-review.googlesource.com/822978Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523529}
-
Scott Chen authored
Bug: 793397 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9ae040cfc149fe3483156ab80dfaeaa5a2566de Reviewed-on: https://chromium-review.googlesource.com/817371Reviewed-by:
-
Tom Sepez authored
The restriction is only required when "temporary file" permissions have been granted, since that is what implies no access to pre-existing files. Fixes the issue hit by https://chromium-review.googlesource.com/c/chromium/src/+/818486 in that the network service may try to ensure a file is present via a single call with O_CREAT without knowing if it pre-exists. Change-Id: I3cf3f2389a78a5a46f43505a64d106614e4dcf90 Reviewed-on: https://chromium-review.googlesource.com/820611 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523527}
-
Shivani Sharma authored
HttpCache.ParallelWritingPattern histogram's 0 enum value is actually a valid value and not undefined. This CL fixes the description and adds tests for testing the 0 value. Bug: 472740 Change-Id: Iac4cdb38b6141221e901003e3540c60228626400 Reviewed-on: https://chromium-review.googlesource.com/820191Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#523526}
-
Dave Schuyler authored
This CL replaces some examples of using old i18n with new $i18n{} replacements. Bug: 677338 Change-Id: Ibdd8b98bd067262879ea11842b5b20c2c4ac34e7 Reviewed-on: https://chromium-review.googlesource.com/820550 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#523525}
-
Boris Sazonov authored
This CL implements account list filtering when there are multiple accounts on the device and one of these accounts is a child account. In this case AccountManagerFacade will expose the child account only. Bug: 779568 Change-Id: I70fb00fc692e3f54c779ac618167afd9ad728c09 Reviewed-on: https://chromium-review.googlesource.com/819414Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523524}
-
Maks Orlovich authored
In particular the motivating case was when the partial write was before the bitmap... ... however this is done by rewriting the function entirely to be formulated in terms of net::Interval, since I found the details of the original pretty much inscrutable, but believe to have understood both the data representation and the interface. Bug: 791056 Change-Id: I297ee4cbcfc204df8ccab9c45145eaf0a82eb0b7 Reviewed-on: https://chromium-review.googlesource.com/806687Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#523523}
-
