GitLab

Preparation for adding a postscript and full font name unique matching
function to WebSandboxSupport, in which a similar return type is needed,
but the use case is not fallback.

BUG=880832

Change-Id: Ibb66f3fe0007c517d74f56ba10096141b702676e
Reviewed-on: https://chromium-review.googlesource.com/1209842Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589214}

Add the mojo interface to start an OffscreenTab mirroring with the
mirroring service.

Bug: 734672
Change-Id: I3b9edbdccffdfb06b0a325170ed6108be81a6975
Reviewed-on: https://chromium-review.googlesource.com/1195821Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589213}

This CL makes sure that tests for cross-origin fetches from content
scripts cover both 1) programmatic content scripts (i.e. ones triggered
by chrome.tabs.executeScript) and 2) declarative content scripts (i.e.
ones listed under "content_scripts" entry in an extension manifest).

The extra test coverage is desirable to ensure that the future work to
provide a separate URLLoaderFactory for content scripts gives correct
results both for programmatic and declarative content scripts.  For
example - providing the URLLoaderFactory in ExtensionMsg_ExecuteCode
would be wrong because it would not cover declarative content scripts.

Bug: 846346
Change-Id: Ibe3f32fd69d502e0a0874fde7636629e5b6693fa
Reviewed-on: https://chromium-review.googlesource.com/1208816Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589212}

In-memory download service (for incognito) returns a blob instead of a
file path when the download is complete. This CL passes the value down
to the (in memory) DatabaseTasks that expect a valid blob handle.

Bug: 863939
Change-Id: I7840c6d6e10ddf883cd44d6eb316a6cc7cbbee47
Reviewed-on: https://chromium-review.googlesource.com/1208171Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589211}

This change feeds offline status information to the Feed component so that
it can properly display the offline badges on articles that are downloaded.
The call to actually open Feed articles with custom load params is not
done in this change, but the cache FeedOfflineHost holds is preparing for
this eventual use case.

Bug: 866125
Change-Id: Ie28cfe0913d9d93f197d5aba1bff181369d3bf39
Reviewed-on: https://chromium-review.googlesource.com/1197268
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589210}

Its possible for users to enter clamshell but still need the VK by
plugging in an external mouse. This cl check whether the internal
keyboard is disabled to determine showing or hiding VK instead of just
tablet mode or not.

TabletModeController is getting a lot of friend test class, so also
introduce TabletModeControllerTestApi.

Test: ash_unittests
Bug: 878795
Change-Id: I0b6e07ef6833e00dd1b6d5358ad7aca4e63a12e5
Reviewed-on: https://chromium-review.googlesource.com/1198486
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589209}

This CL is not a straight revert of
https://chromium.googlesource.com/chromium/src/+/76a593e26e0e5e1d962bbcc95562490e56901787

but it essentially recovers that functionality.
The revert is needed due to a bug in Chrome bookmark
manager.

Bug: 878392
Change-Id: Ifa5867691ffe88ed557fb548a5de572ec5236580
Reviewed-on: https://chromium-review.googlesource.com/1210124
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589208}

Bug: 872404
Change-Id: I6b169bf470d9af2ef3c7fca9ef59081615ece5cf
Reviewed-on: https://chromium-review.googlesource.com/1208692Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#589207}

Per the mocks, move the throbber and the info icon to the left of the view.
Also factor out constants and throbber creating code into a helper file.
Screencap: https://drive.google.com/open?id=1UF1uamxoR0oG-3aEHwdJkoHU_7pJW_CB

Bug: 879630
Change-Id: I42ee54d063df0f9af74cad10a4a21a9a8f78a869
Reviewed-on: https://chromium-review.googlesource.com/1199945
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589206}

The auth_type parameter is always a const char[]. This saves allocating
a string copy of it.

Bug: none
Change-Id: I53c57252c9006b8dd0cf155a04132aad0975ed70
Reviewed-on: https://chromium-review.googlesource.com/1208144Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589205}

Currently a crash can occur if CustomTabsConnections starts the browser
synchronously while an async browser startup is in progress.

Bug: 881019
Change-Id: I2d1b764c8212a05b85f59c5edfa92ac28a4171f9
Reviewed-on: https://chromium-review.googlesource.com/1210623Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589204}

After adding "use_jumbo_build=true" args in GN, jumbo build can be
enabled.

Bug: 869381
Change-Id: Ia95bfd39e2f8f5b7ab1df879d12433341245d046
Reviewed-on: https://chromium-review.googlesource.com/1204372
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589203}

Crash happens inside documentInteractionController:willBeginSendingToApplication:
delegate callback on removing observer from _downloadTask. It is
possible to stop coordinator before willBeginSendingToApplication: gets
called, in which case DownloadManagerCoordinator will crash. This CL
adds null check before calling UnopenedDownloadsTracker::Remove to
prevent the craash.

Bug: 880919
Change-Id: Ib73d6663b2a100b4f3c075f4c8643eaacc3b45a5
Reviewed-on: https://chromium-review.googlesource.com/1208963Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589202}

Some dialog boxes, like the accelerator confirmation dialog that appears
when you press Search+Control+M, focus the dialog and then immediately
after focus one of the buttons. This was causing ChromeVox to suppress
information about the context of the dialog.

Fix this by using PostTask to defer all events from Views. This doesn't
even add any delay, it just pushes the event firing to after the current
call stack so that transient changes get suppressed.

Manually confirmed that the experience with this particular dialog is
improved, other dialogs and views seem to continue to work fine.

Bug: 729449
Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373
Reviewed-on: https://chromium-review.googlesource.com/1176207
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589201}

R=dpranke

Bug: 879147
Change-Id: Ic975848737614812a94460f6c3ef7653d3d1329a
Reviewed-on: https://chromium-review.googlesource.com/1210682
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589200}

This CL improves accessibility based on feedback of issue 870627 and
mocks from issue 838387:
1. The keyboard accessory is announced when made visible (string [1]).
Before this CL, android:clickable=true was used to prevent clicks
from propagating to the content area behind it. This caused Talkback
to read "double-tap to activate". This is gone now, by setting the
appropriate listeners when initializing the layout.

2. The key icon's name changed to "Show passwords" (string [4]). Once
triggered, it changes to "Show keyboard" (string [2]) in accordance to
what it does.

3. An opened password sheet is immediately announced with string [3]:
"Showing saved passwords and password options".

4. The title ("Saved passwords for XYZ") doesn't read "Double-tap to
activate" anymore.

5. Disabled entries (e.g. password entries when email fields are
focused) are now read back with the proper "Disabled" suffix.


Uploaded pictures for the new hashes (because there is no way to
download them anywhere):
[1] IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION:
https://photos.app.goo.gl/kiYYx8tzyjfPB7oA7

[2] IDS_KEYBOARD_ACCESSORY_SHEET_HIDE:
https://photos.app.goo.gl/RxuGqCZp6QtmNLUJ9

[3] IDS_PASSWORD_ACCESSORY_SHEET_OPENED:
https://photos.app.goo.gl/NBpw2HavFSiZ5NSq8

[4] IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE:
https://photos.app.goo.gl/fMprsLC8Y8giAdxF7

Bug: 870627, 838387
Change-Id: Iebccefa8d5ede702b8bdc2dc92f055064981fa80
Reviewed-on: https://chromium-review.googlesource.com/1209405Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589199}

- The StreamFailBeforeReadIsExecutedOnNetworkThread is flaky on Fuchsia.

Bug: 880474
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I36c11741d674fec99286f25bd8503bb77903e950
Reviewed-on: https://chromium-review.googlesource.com/1210364Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589198}

Make sure the USS implementation also clears data on signout, just like
the directory-based implementation does. This also enables an
integration test to test this in the butter scenario.

Also making a small fix: Updating the storage in PDM in
OnSyncInitialized, because if sync is disabled, we won't get the
OnStateChanged call.

Bug: 880735
Change-Id: I6aa49b8c459a48cb92a1e3d7283f05eed8e6eb5c
Reviewed-on: https://chromium-review.googlesource.com/1206490
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589197}

Also actually use this ability when the "Set Up" button in multidevice
settings is clicked.

R=khorimoto@chromium.org

Bug: 870093
Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586
Reviewed-on: https://chromium-review.googlesource.com/1185498
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589196}

Each leaked NSCandidateListTouchBarItem carried a CALayer and other
resources; holding on to them caused a major slowdown.

This change makes |-createCandidateListItem| return an autoreleased
NSCandidateListTouchBarItem instead of a retained one, and renames it to
|-makeCandidateListItem| to match the naming and ownership semantics of
|-makeTouchBar| (and be consistent with the create rule).

Bug: 877137
Change-Id: Icfb335c341cb86e8691562ade4c222a59c990bf7
Reviewed-on: https://chromium-review.googlesource.com/1208428Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589195}

This CL moves JpegDecodeAcceleratorTestEnvironment upwards so that
the test-specific classes and the static classes are grouped together.

No new code whatsoever.

Bug: 877694
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ida2c6024526baf62933f058b3539bbb51306406e
Reviewed-on: https://chromium-review.googlesource.com/1204772Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589194}

Unicode 11 added a new set of Georgian captial letters and changed
the case-conversion rule to map lowercase (pre-Unicode 11) Georgian
letters to the new Goergian capital letters. [1]

However, virtually nobody has a font to cover the new characters.
Because these are new characters, they're very unlikely to show up
unless 'text-transform: uppercase' is applied to generate contents.

This CL maps new Georgian capital letters back to the corresponding
pre-Unicode 11 lowercase letters for CSS text-transform: uppercase until
new Georgian fonts are more widely available. CrOS will get a couple
of Georgian fonts supporting new characters pretty soon.

FYI, Firefox added a similar work around:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1476304

Another FYI: There's no worry about title-casing because Georgian
title-casing is not supposed to capitalize the first letter of a word
and ICU's title-casing API leaves alone Georgian lowercase letters.

[1] http://unicode.org/versions/Unicode11.0.0/ : see section 'Casing
issues'.

Bug: 865427
Test: fast/css/case-transform-georgian-capital.html
Change-Id: If957df8407cf08f6752499522518a90d3e55251e
Reviewed-on: https://chromium-review.googlesource.com/1205712Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589193}

Bug: 880886
Change-Id: Ie13ab55b4b35ffe24e0cbbbaf75a9796db132631
Reviewed-on: https://chromium-review.googlesource.com/1184221Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589192}

Shrinks expanded page.h size by ~2.1M.

Change-Id: I20c304f7c2a47e86a14dfecd792f0b9b4da35531
Reviewed-on: https://chromium-review.googlesource.com/1204131Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589191}

Upon exiting fullscreen restore back to the default page scale instead
of restoring old values. This is a simplier model and doesn't cause
scroll jumping when the page scale isn't changing.

BUG=878773

Change-Id: I107e517bd3c76300d0a8ce02622f4a05dc9ce79b
Reviewed-on: https://chromium-review.googlesource.com/1195714
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589190}

Now Chrome parses the systemLanguage attribute as a COMMA separated-
list (with optional space), following the SVG specification
for systemLanguage attribute.

The previous behavior was:

- The systemLanguage attribute is a space-separated list
of langtags (the comma separator was treated as a character).

Example:

<text systemLanguage="en-US, zh-Hans,zh-Hant"></text>

Now, the three langtags are: "en-US", "zh-Hans", "zh-Hant".
Before, the three langtags were "en-US,", "zh-Hans,", "zh-Hant".

R=fs@opera.com, schenney@chromium.org

Bug: 732063
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7738bc4eb77de2c1ca7593dd9277fab14d39cc1f
Reviewed-on: https://chromium-review.googlesource.com/1207250Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589189}

Bug: 835234
Change-Id: Ic285e99e68b8371a06ad923b98ce7aa1cfb816fa
Reviewed-on: https://chromium-review.googlesource.com/1202204Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589188}

Desktop Omnibox component will need access to the profile-keyed
QueryInOmnibox service.

This can is provided by the embedder, so add its access to
OmniboxClient like the other embedder-provided profile-keyed services.

Bug: 874592
Change-Id: Ibc12b563a9d2fe7a2625cdc5fdc0d10bf85c45d7
Reviewed-on: https://chromium-review.googlesource.com/1208455
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589187}

The first usage will be full screen applist, so it doesnt show up while
overview windows are moving around.

Also move blur to after animations, and fix a bug with app list overview
animation pause, and add a pause for homecher -> overview window
animations.

Test: manual
Bug: 873394, 871875, 880613
Change-Id: Id9ede4b412c609cff6a1ec4c841b20aaab9aa5e2
Reviewed-on: https://chromium-review.googlesource.com/1199814Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589186}

Approved Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ODzbWn-xRrQ/dhkJzD8-CgAJ

BUG=383813

Change-Id: Ia0b1e681520728c290ce7e1f95388bc27ebf91d0
Reviewed-on: https://chromium-review.googlesource.com/1204595
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589185}

on web_requests. This causes us to crash when converting
FetchAPIRequest mojo type to content::ServiceWorkerFetchRequest
since the latter doesn't currently support request body.

Once we switch to using the mojo type everywhere in content, we
can start setting the blob data handle  again from blink.

Bug: 789854, 774054
Change-Id: Icec9a74b9302fb9731febc5adc30f4153dfb698c
Reviewed-on: https://chromium-review.googlesource.com/1209522
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589184}

This crash only affects pre-ui-refresh, but it is safe to add
this fix for all experiments.

Bug: 881229
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic200f8dfac105b73fe8903b050249683d1f2d1c1
Reviewed-on: https://chromium-review.googlesource.com/1210162
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589183}

This feature has been enabled for the past few stable releases, so the
flag is not needed anymore.

Bug: 838789, 792840
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib79921d30792dbd8e03fd2ec7652c15a76e84b73
Reviewed-on: https://chromium-review.googlesource.com/1203956Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589182}

Bug: 880959
Change-Id: I87d4d222ea3b748171624846bfade66cca994a1b
Reviewed-on: https://chromium-review.googlesource.com/1208145Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589181}

Refer here for details:
https://cs.chromium.org/chromium/src/base/bind_internal.h?rcl=9050148b1dffa4d6e695d0732c368e954e15a4e0&l=787

Change-Id: I6aab905a1fc8d21967a0aff5df6fea3eab7decfc
Reviewed-on: https://chromium-review.googlesource.com/1208726
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589180}

It's possible that the change landed in
https://chromium-review.googlesource.com/c/chromium/src/+/1172723
will resolve the flakiness seen in this test. If not, it would be
nice to get some fresh logs from the bots for debugging purposes.

Bug: 863971
Change-Id: I332b48990e0503e078ccc657d3537c3a6d4f9c7a
Reviewed-on: https://chromium-review.googlesource.com/1210042Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589179}

Moving InitOzone() from content::GpuProcessHost to viz::GpuHostImpl as
part of moving viz::mojom::GpuHost implementation out of content. This
is a follow-up to https://crrev.com/c/1180658.

BUG=709332

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I022ee15c3a1f194313bf2566e9503e357cd46494
Reviewed-on: https://chromium-review.googlesource.com/1195151Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589178}

Follow-up to https://crrev.com/c/1188664 to remove unnecessary
braces in test methods (originally kept to reduce the size of
the patchset).

Bug: none
Change-Id: I966c86d121ae7ea9861c895ed2492d52c8f94b71
Reviewed-on: https://chromium-review.googlesource.com/1196513
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589177}

ExternalStringResource can be locked in V8, meaning that it should not
be parked. Add support in Chrome for this.
Separately, some blink strings will never be parked. For these, allow V8 to
cache the data pointer.

Bug: 877044
Change-Id: I0100a3b13887c417dfcf568186c9cf7f9c57706f
Reviewed-on: https://chromium-review.googlesource.com/1203376
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589176}

Throughout Chrome settings, we expose the textual content of a control twice at times.

1. As the visible label/sublabel
2. as the aria-label/aria-describedBy on the button or control

This is extremely painful when navigating through settings especially with a screen reader (and likely switch control).

When navigating, you will first land on the label, then the actual control, which repeats the label.

Change-Id: Ia8633f12ddd4ddbc6ad6658c051af57c9cf34d93
Reviewed-on: https://chromium-review.googlesource.com/1195804Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589175}