- 07 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610009713-6f95aef060564dd70c8d09ec603d31a9c7b42ed0.profdata to chrome-win64-master-1610042255-9fb87833d682e7ab89f65b59b49fe1c3c9960d61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I164d198110b1967ff9cfb990c5fc96abc2442e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615943Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841205}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1da011f..edfb3b4d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5fbc83582d5151364fa3139449596966609339fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841204}
-
Thomas Guilbert authored
This CL converts RemoteChangeProcessor::PrepareChangeCallback from base::Callback to base::OnceCallback. Bug: 1152272 Change-Id: I3c0ff1e629ed476c8a5f2258f129258d13c7797c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606666 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841203}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47a632b2ab93..7a13b94a1d4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cmumford@google.com,tmartino@google.com Change-Id: Ic1c78605689754b5308992f68090b828c9768b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615301Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841202}
-
dpapad authored
- Add an |enable_pdf| assertion in c/b/r/pdf/BUILD.gn - Add an |enable_print_preview| assertion in c/b/r/print_preview/BUILD.gn - Fix all newly found violations. The new assertions reveal a few places where the above mentioned BUILD.gn files are unnecessarily evaluated. For example unnecessary work has happening for the |is_chromecast| case. Bug: None Change-Id: Ide832f251de493c1ab87ace8ee5ff46bc6c383e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615498 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841201}
-
John Lee authored
This CL removes the `three-line` CSS class and related CSS variables and updates the one subpage they were used in. Using the CSS class `cr-padded-text` instead keeps padding consistent with other row-like UI in WebUI and also keeps the heights the same as they were before with the `three-line` CSS class. https://imgur.com/a/MPYDcHY Bug: 686905 Change-Id: I5fdcbe9f98655ba87f08ea093279abbeb34b5830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612393Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841200}
-
spdonghao authored
Bug: 1155757 Change-Id: Iadce101e501f1a9355b7dd479ba7aed38864a599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605870 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841199}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bdc3d3c60fa9..d60c919fc866 2021-01-07 csmartdalton@google.com Revert "Move GrTriangulator internal struct definitions to the .h file" 2021-01-07 johnstiles@google.com Remove compile-time constant support from PrefixExpression. 2021-01-07 adlai@google.com Add a new implementation of reduceOpsTaskSplitting 2021-01-07 kjlubick@google.com [canvaskit] Add docs and example for flags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I8a9c6fbc2a78bc578a99a80812b72c30acb063ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615958Reviewed-by:
-
Mitsuru Oshima authored
Optimize ArcOverlayManager so that it observe arc windows only. Bug: None Test: covered by unittest Change-Id: Id8272cca58a555689cd12a976a812bc25b4b28b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610625 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#841197}
-
David Bertoni authored
These uses of the this flag were to prevent flakiness with Service Worker-based tests. Now that the UnpackedInstaller is fixed with regard to granting file access and incognito permissions, these workarounds are no longer needed. Bug: 1146173 Change-Id: Ic07e6482592767f3666e17c4cfc8bf0c5d70509e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610937Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841196}
-
Josh Simmons authored
Bug: 1138280 Change-Id: I324adc96fe80c917f3ab38852464445e7a0b6251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612336Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#841195}
-
Hui Yingst authored
Change-Id: Icce433ddc546f1557e2d9632c0dc506eb8b57911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613788Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841194}
-
Stephen McGruer authored
This brings in the latest wptrunner code (normally imported via the WPT importer), along with upgrading mozlog as necessary for recent changes in wptrunner. This should unblock the WPT importer. Bug: 1161212, 1161210 Change-Id: Ic89ddf17128ec454e4560e359d788e17f649464d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614858Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841193}
-
Ken Rockot authored
Adds associated interface support to modern Mojo JS bindings and generated JS modules. Fixed: 914165 Bug: 1004256 Change-Id: I5421ace585ad129374526bc7237980333b141b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611647 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841192}
-
minch authored
After this change, colors at http://crrev.com/c/2601363 can use the Get* APIs in ColorProvider to get corresponding layer's color. Bug: 1163179 Change-Id: Ifeed52ae3bc9cc5a528b44cf508a049f8aeb31d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611568 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#841191}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Idd61d93dce062e687ba8f563bd2279e814ddca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596015Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841190}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7b2f93895418..071cf0cff810 2021-01-07 srisser@google.com Add structs for VK_KHR_vulkan_memory_model If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I96dba42874ad0ac08038a36e68d0d5acffa4dc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615300Reviewed-by:
-
Andrew Grieve authored
* Fix being run when CWD != CHROMIUM_ROOT * Fix typo in error message when an expected file doesn't exist * Don't ignore missing files by default * Increase verbosity of "This may take a few minutes" message so it shows by default. * Guava files added that seem to have been missed last time script was run. Bug: None Change-Id: Ic610db8d5e56acf217f3b162591a438d1909964d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613149 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841188}
-
Etienne Bergeron authored
Currently, only TimeZoneMonitorWin has trace events to debug power suspend/resume. This CL is adding trace events to the base class to make them visible on every platforms. R=gab@chromium.org, fdoray@chromium.org Bug: 1074036 Change-Id: I01478cd8036a18dd9edf7755e28fb66358338634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583007Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#841187}
-
minch authored
Remove the inkdrop related functions in default_colors file. Unify all the inkdrop/highlight color and opacity. Bug: 1163179 Change-Id: I215b2b761bc91d79a80ee20258411039abd83088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613552Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#841186}
-
Matt Reynolds authored
Updates runtime_enabled_features.json5 and the stable webexposed tests to mark the WebHID API stable on desktop platforms. Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/rL1csFYD1Ms Bug: 890096 Change-Id: I36a6b62475dd9de01a4dbf013b2be00e8901359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610995 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841185}
-
Sven Zheng authored
InProcessBrowserTest times out on mac. I can't repro this issue locally, nor the tryjob. When running locally with 4 parallel jobs, I do occasionally see RunLoop timeout. It's just not hundreds of test failing. But if I run with 1 parallel job, I don't see any failures. This cl use 1 parallel job first and see if this can reduce the flakiness. This will make the job slower. But as it's not on CQ, it should be fine to try this out. Bug: 11527703 Change-Id: I55ff27a506676b1688455c404611a65d643b30fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601578Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841184}
-
Francois Doray authored
Change-Id: Iee2654bfbfa321c9249de4785edbe6549532ba6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615819Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841183}
-
James Cook authored
This is the target directory for //chrome/browser/chromeos code. See bug for migration plan. Since the code is moving, not changing, clone the DEPS file as-is to avoid bothering OWNERS. Bug: 1164001 Change-Id: Ie15d4faff0d235110a49a103fb780f5940e66a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#841182}
-
Joshua Pawlicki authored
Bug: 1163625 Change-Id: Iaf87321b3ed90fc563f991d61a8300f3c6c7edf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614861 Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841181}
-
Austin Eng authored
These test cases microbenchmark important entrypoints in the WebGL and WebGPU APIs where CPU performance is critical. Variants are added with/without V8's Fast API calls as the feature is still in development, and we don't want to regress performance. Bug: 1155348 Change-Id: I21a0b2ba9c2cb8be2ca56f7470ca8bf37ec90b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573385 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#841180}
-
Ben Pastene authored
This copies the following builder to chromium.memory: https://ci.chromium.org/p/chromium/builders/ci/UBSanVptr%20Linux And also renames it to conform to the lowercase, hyphenated builder naming scheme. The old builder's configs will be removed after the new builder is up and running. Bug: 1137496 Change-Id: Ie0bd99a377d63654261c6e9b484793120c84c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615132Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#841179}
-
Jérôme Lebel authored
This patch should have been part of crrev.com/c/2612844. Bug: 1143204, 1146459 Change-Id: I494e6520794936a2f969c18b9d522836ac9365cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613969 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#841178}
-
Xing Liu authored
Add 2 flags so people can enable weekly reminder notification in chrome://flags. Bug: 1139073 Change-Id: Id1aeb192d2c4b587053a6b4a8ee53ec3cf0883f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615583 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841177}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/06aa1af28a72..00fcab636a05 2021-01-07 cwallez@chromium.org Fix default viewDimension in deprecated BGLEntry path. 2021-01-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 40b4928a73b7 to 766e31d50710 (4 revisions) 2021-01-07 bclayton@google.com Reland "Update PrimitiveTopologyTests to use WGSL" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ie963b70767806b5da73fa34c64e5d933120c37a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615838Reviewed-by:
-
Chris Harrelson authored
The bugfix is: https://chromium-review.googlesource.com/c/chromium/src/+/2586969 Bug: 1141739 Change-Id: I8056b71d60442f53ab52d62066e152f76ed02db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615305Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841175}
-
Tommy Martino authored
This reverts commit 909901eb. Reason for revert: Causing failures on Mac bots, see crbug.com/1164011 Original change's description: > [Controls Refresh Android] Fixes input missing border > > Prior to this CL, controls-refresh text input is missing its border. > > The fix is to make sure property text_field.has_border is passed to > native theme. This property is only used by form controls-refresh > so it has no impact on existing text input. > > Bug: 1155397 > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841106} TBR=clamy@chromium.org,masonfreed@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I2704b803c8aea565781632e8f07bbd0b29947f6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616279Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#841174}
-
Austin Eng authored
The device lost callback is stored in a unique_ptr since it may never be called. If it's never called we need to free the allocation on GPUDevice deletion. However, if it is called, we should release the managed pointer since the callback is self-deleting. Bug: 1160448 Change-Id: I780eae1dcb8fac34a0128351f47224c83d8c6727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612120Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I257ca719bf6abdbe801f7c88ddc532a5aeeddf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615459Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#841172}
-
Max Curran authored
the new Translate metrics. The initial implementation of the new Translate metrics assumed that when a translation failed or was cancelled there would be some error. There are a few cases where this is false, including when a translation is interrupted for a new translation with a different source or target language. This CL adds a second input parameter to TranslateMetricsLogger.LogTranslationFinished so we can specify if a translation finished successfully and if there was any translation error separately. Bug: 1155291 Change-Id: I762fe069ee9b69969a7ade84f5d5933cf43d8552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583107 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841171}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610019930-98b4330725909b282b32db0e07c7a238a41191db.profdata to chrome-linux-master-1610042255-43b4d84a21124c058546cf1e621ecfbb55dbe4e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I32251f5cdb2534e94b49d994ff9e2d1ac77e6af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615919Reviewed-by:
-
Scott Violet authored
This reverts commit ff9183ee. Reason for revert: for various reasons this is no longer necessary. Reverting. Original change's description: > cct: adds extra that controls whether client data header is added > > Prior to this the header was always added. After this, the header > is only added if an extra is supplied. This only changes whether > setClientDataHeaderForNewTab() is called and does not alter > the implementation of that function. > > BUG=1163158 > TEST=covered by tests > > Change-Id: Ic5d222d719a81c6da3d4e0c7866e18cbcee6e817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611340 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840370} TBR=sky@chromium.org,tedchoc@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163158 Change-Id: I97429cd16f7a2830d612f787a52b3270f05ccaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615302Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841169}
-
Alex Leung authored
Bug: b/174777644 Test: internal CQ Change-Id: I3d4ed076e290f1dd3cda60f111b0ad747d73bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615658Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#841168}
-
Nancy Wang authored
BUG=1146900 Change-Id: Iebbf4b53aef5723dfc71e394a302ff3f9557a17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611144 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841167}
-
Nick Czajka authored
This change cleans up type definitions in display_layout.js for improved readability. Bug: 1077365 Change-Id: Ib1aac690ca56db9a833cbc7c87985eb80922fc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596063 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#841166}
-
