- 03 Apr, 2018 40 commits
-
-
Leszek Swirski authored
This enables code caching for <script> tags whose source code is embedded in the HTML. External scripts store their cached code on metadata associated with the external script resource; now, inline scripts store their cached code on metadata associated with the HTML document's RawResource. To allow multiple inline scripts per HTML page, the RawResource metadata can hold multiple code caches. These are keyed by the SHA-256 hash of the script's source, which is a large enough hash that we don't have to worry about collisions, and thus don't have to store the script's source in the cache. The multi-script metadata has a simple serialization format optimized for easy serialize/deserialize: marker (uint32) num_entries (int) key 1 (Key type) len data 1 (size_t) type data 1 data for key 1 ... key N (Key type) len data N (size_t) type data N data for key N Inline scripts receive a CachedMetadataHandler implementation which is a view onto this multi-script handler. Bug: chromium:823663 Change-Id: Ib14edfaf460aa8bfc90cfe12b8a6b4b7af050de7 Reviewed-on: https://chromium-review.googlesource.com/893401 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#547671}
-
Takashi Toyoshima authored
Blink should set the request_initiator correctly to use OOR-CORS for security checks. Blink had several Origin variants, but now the right SecurityOrigin is set to the blink::ResourceRequest's RequestorOrigin. If something get broken, we need to modify Blink-site to set a suitable origin. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic5e184a58009189f128082c4232526e046e743cc Reviewed-on: https://chromium-review.googlesource.com/964103 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#547670}
-
Rayan Kanso authored
The metadata will store additional developer-provided fields that will help retain & recover the state of the background fetch. Create/Get/Update registration database tasks are updated to support the new metadata proto. Bug: 826257, 757760 Change-Id: I5b97638d3ab90e482911fb50479e5b8c312b4331 Reviewed-on: https://chromium-review.googlesource.com/984356 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547669}
-
tanvir.rizvi authored
UpdateStartEnd takes start and end position as parameters, and then does a DCHECK_LE for start and end. EphemeralRange constructor also does same DCHECK. Since UpdateStartEnd is called from many places, so to catch a bug at the call site, function UpdateStartEnd is made to take EphemeralRange instead. Bug: 826106 Change-Id: I6e1cd23e9aac2846a2f083cd6f4d8110fa3a9085 Reviewed-on: https://chromium-review.googlesource.com/989852Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#547668}
-
Rune Lillesveen authored
Bug: 813068 Change-Id: If8b7489c69b85237d422c6b3d030fdd79ca7017a Reviewed-on: https://chromium-review.googlesource.com/983955Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547667}
-
Mugdha Lakhani authored
Bug: 822276 Change-Id: I8ed04d4681e2f0e7bb41b869d6b855547b023965 Reviewed-on: https://chromium-review.googlesource.com/986294Reviewed-by:
-
Darren Shen authored
Add support for the following properties: - image-rendering - text-anchor - text-combine-upright - text-overflow - text-rendering - transform-style - user-select Lots of failing tests, usually because a keyword isn't implemented in Blink yet. Bug: 820299 Change-Id: Ifd0193ac55d12a31d28b486166ad78a38012314b Reviewed-on: https://chromium-review.googlesource.com/985337Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#547665}
-
Kim Paulhamus authored
This requirement is derived from clause 5.1.3.19.1 in the spec: "If options.authenticatorSelection.authenticatorAttachment is present and its value is not equal to authenticator’s attachment modality, continue", and the fact that there are no U2F platform devices. This CL also fixes the error message when the all U2F devices are filtered out by the resident key and user verification criteria. While the CL (crrev.com/c/949453) introducing these options correctly documented the intended behavior in a comment in u2f_sign, it did not actually change the DOMException itself. Finally, the CL moves related webauthn tests from credentialmanager_browsertests to webauth_browsertests. Bug: 803832 Change-Id: Ie8f124af3783c2aaec85abd3baac050cfbb926b7 Reviewed-on: https://chromium-review.googlesource.com/989413 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547664}
-
https://webrtc.googlesource.com/src.git/+log/5b4f075f9c59..644fde40a9c3 $ git log 5b4f075f9..644fde40a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:827917,chromium:828220 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I51cd91f0fca62013f2f17b6e113f783c90b45f0a Reviewed-on: https://chromium-review.googlesource.com/991606Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547663}
-
Guido Urdaneta authored
On Mac, audio devices may have an active source. For example, the built-in audio device might be using the internal speakers or headphones (same device, different sources). This CL changes audio device enumerations so that the device label uses the source instead of the device name if the source is available. The reason is that the source (together with the transport, added in crrev.com/c/980951) is a better description of the device. Some examples: Before: "Built-in Microphone" Now: "External Microphone (Built-in)" or "Internal Microphone (Built-in)" Before: "Built-in Output" Now: "Internal Speakers (Built-in)" or "Headphones (Built-in)" Before: "HDMI" Now: "HP Z30i (HDMI)" This change also requires firing the devicechange event if the source for a device changes, since that results in a change to the enumeration results. This CL includes the required changes to AudioDeviceListenerMac. Bug: 811687 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb6801fe979cfed528036862471203f5d29e4603 Reviewed-on: https://chromium-review.googlesource.com/984312 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547662}
-
Eric Noyau authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I03347d01754a2fb7e28ffd73696f7dd03fdbba8b Reviewed-on: https://chromium-review.googlesource.com/987952Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#547661}
-
Noel Gordon authored
Per http:crrev.com/336357 the variable existed when the old file manager browser test was split up after growing too large. It is not used in GalleryBrowserTestBase today: remove scripts_. Test: browser_tests --gtest_filter=GalleryBrowserTest* Bug: 804413 Change-Id: Iada83b00c5644d8ea8d9d3a334affe103a59d1db Reviewed-on: https://chromium-review.googlesource.com/991772 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547660}
-
Egor Pasko authored
This switches tools/cygprofile/run_tests to vpython, which should have been done as part of http://crrev.com/546845. After the vpython switch the workaround in http://crrev.com/546845 should not be necessary, so revert this commit as well: > cygprofile: Fix unittests for cygprofile on CQ. > > orderfile_generator_backend_unittests imports > orderfile_generator_backend, which transitively requires psutil, which > is not available on the CQ bots. > > As psutil is not used in unit tests, handle the import error to > allow unit tests to run on CQ, and CLs in //tools/cygprofile to pass > presubmit checks. > > Change-Id: Id06bd2b7936509ef44a02d7b6497fa818d439291 > Reviewed-on: https://chromium-review.googlesource.com/985975 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546790} Bug: None Change-Id: Ib0737acf652b283c212a61a2bae83a9c373c9fbf Reviewed-on: https://chromium-review.googlesource.com/988072Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547659}
-
Tatsuhisa Yamaguchi authored
The test were replicated from the one in zip_archiver/unpacker_test and rewritten to be based on JsTest. Test: browser_tests --gtest_filter=ZipArchiverJsTest.* Bug: 454910 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I141f310cdab10ca10e6084caac545b8be8c26ec8 Reviewed-on: https://chromium-review.googlesource.com/978224 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#547658}
-
arthursonzogni authored
Add a new test, it makes use of chrome.app.window.create() with a sandboxed page. It checks no window is returned to the background app. There were no tests trying to open a new window with a sandboxed document already. Bug: 820995 Change-Id: I0e59723ee23b31845545774b3ff3dfede0278af0 Reviewed-on: https://chromium-review.googlesource.com/982627 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#547657}
-
Fergal Daly authored
Make it a public method on SpaceSplitString so that it can be used in unit tests etc. Also add some unit tests. Change-Id: I2169259c29bb6e5a5a62c8dc6245ba8af31bc053 Reviewed-on: https://chromium-review.googlesource.com/991693Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#547656}
-
Vaclav Brozek authored
Bug: None Change-Id: I72665789d93e1eb0b5fe8ac8920cac8a5e0b2615 Reviewed-on: https://chromium-review.googlesource.com/984873Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547655}
-
Keishi Hattori authored
Fix GCState transition checks for when incrmental marking is enabled Bug: 757440 Change-Id: I01cf15b45800d15bd50542824f64dd24d8e0ef0f Reviewed-on: https://chromium-review.googlesource.com/991621Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547654}
-
Daniel Bratell authored
In jumbo builds many files are compiled in the same translation unit and then their anonymous namespaces will also be one and the same. In blink/inspector two (identical) UrlWithoutFragment functions end up colliding. This patch changes it so that one of them has a more narrow scope. The patch also removes the special casing of these files from the build system. Bug: 713137 Change-Id: If0b8bfb8a13c1191aa4e1c07d2aa1472ed168f29 Reviewed-on: https://chromium-review.googlesource.com/985978Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#547653}
-
Takashi SAKAMOTO authored
[Sheriff] Mark svg/W3C-SVG-1.1/text-intro-01-t.svg and svg/W3C-SVG-1.1/text-intro-04-t.svg as failure on Win10 The following 2 tests are failing (Image/text failures) on Win10: svg/W3C-SVG-1.1/text-intro-01-t.svg svg/W3C-SVG-1.1/text-intro-04-t.svg TBR=jam@chromium.org Bug: 828314 Change-Id: I7768c906400f48fbaed0b8e69e4232278e04fbf7 Reviewed-on: https://chromium-review.googlesource.com/991894Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#547652}
-
Yoshifumi Inoue authored
This patch Introduces |TextOffsetMapping|[1] class to mapping between character offset in block and DOM position for ease of implementing selection modification with text segments, such as word/sentence/paragraph. This patch is a preparation of the patch[2]. [1] https://goo.gl/v2Ax8d Text Offset Mapping [2] http://crrev.com/c/737981 Simplify word granularity handling Bug: 778507 Change-Id: I63957165ab2741d5c3f1e2b1d29302541d12841b Reviewed-on: https://chromium-review.googlesource.com/983336Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547651}
-
Vaclav Brozek authored
FormParser provides parsing PasswordForm structures from HTML data. It currently is only used on iOS, and hence resides inside //ios. However, in order to fuzz it, it has to be compiled on Linux and/or Mac. Therefore the file itself is being moved to the component. A side effect of this change is: * Dropping iOS PlatformTest fixture, because the test does not need it. (The fixture was responsible for draining the autorelease pool, but the test is pure C++, no Objective C). * Renaming to IOSFormParser, to ensure that iOS is still mentioned in the file path. It will also help to keep two different form parsers once the FormParser for desktop is added into the new target directory. Bug: 827945 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I114e01af40d5d29f221e15e44f0fdf635ea1c8b4 Reviewed-on: https://chromium-review.googlesource.com/989952Reviewed-by:
-
Christian Dullweber authored
Using a set of exlude pattern it is possible to exclude all out/ files except for files in out/Debug/gen. This removes the need for a symlink. Change-Id: Ie2b410fa4d4fe12eecbd9c37e5d677b813819b63 Reviewed-on: https://chromium-review.googlesource.com/985977 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#547649}
-
Kent Tamura authored
String16MojomTraits*.* in platform/mojom/ should be renamed to string16_mojom_traits*.* for consistency with //base/strings/string16*.*. Bug: 578345 Change-Id: Ic84f8e356281a446baaadaf498b31788202d1f97 Reviewed-on: https://chromium-review.googlesource.com/991795Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547648}
-
Yoichi Osato authored
This patch adds a layout test that confirm no warning if imported document adds style to the main document by appendChild. Bug: 523952 Change-Id: Idd5a603d3e585378fc57958969b491d866abf997 Reviewed-on: https://chromium-review.googlesource.com/970046Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "transpose-empty.html" to utilize |selection_test()| for ease of maintenance. Note: "transpose-empty.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Ibeb10cf4f7b6d0f270a30467060b9fba2891999d Reviewed-on: https://chromium-review.googlesource.com/991496Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5272440.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5272440.html" to "delete_all_contents_in_root_editable.html". Note: "5272440.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: I1455f820e8e0baf729fc8a1cca87705db4046674 Reviewed-on: https://chromium-review.googlesource.com/991493Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "type-delete-after-quote{1,-2}.html" to utilize |selection_test()| and integrate into "type-delete-after-quote.html", since both tests use similar test input, for ease of maintenance. Note: "type-delete-after-quote.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: I27db14fae0ab951df387e4d58c45f556470209c6 Reviewed-on: https://chromium-review.googlesource.com/991796Reviewed-by: -
Kenichi Ishibashi authored
This is failing because we don't support byte-for-byte update check to all service worker importScript() resources. Update test expectations to point an appropriate bug entry and remove the entry from S13nSW expectation as this failure isn't specific to S13nSW. Bug: 648295 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I65dca2a31baa500ae8f1d347af8c77d9e9fd8c29 Reviewed-on: https://chromium-review.googlesource.com/991472Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547643}
-
Rune Lillesveen authored
Getting rid of another mutable style access. Bug: 813068 Change-Id: Ied084dcce6c9477ce43763ba42dd4256e87efa25 Reviewed-on: https://chromium-review.googlesource.com/983953Reviewed-by:
-
Yoichi Osato authored
This patch adds a layout test that confirms unintentionally warning if imported document adds style to the main document by appendChild after load. This simulates polymer's workaround for style deprecation: (Copy <custom-style> styles to main document: https://git.io/vxP3p) Bug: 523952 Change-Id: I2eb696b26af06000bc07af6ea9eeb87a67179368 Reviewed-on: https://chromium-review.googlesource.com/991655Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d0fcc3fa3ad..87c1c3dbea9a $ git log 5d0fcc3fa..87c1c3dbe --date=short --no-merges --format='%ad %ae %s' 2018-03-25 lgoodby chromeos_config: Return gale-paladin to important. 2018-03-23 yueherngl eve-campfire: add eve-campfire-paladin 2018-03-08 phobbs cidb: Add Pre-CQ flake count query 2018-03-06 mortonm Adjust tester for new groups of which shill is a member. Created with: roll-dep src/third_party/chromite BUG=chromium:819287,chromium:820230,chromium:649417 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I41db1195a6cb655884268cbfb46050f8f09b96d8 Reviewed-on: https://chromium-review.googlesource.com/991609 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547640}
-
Yoichi Osato authored
This patch modifies the function so that it returns valid LayoutRect for line break. The function didn't work if (LayoutObject, offset) points after line break: 1. (LayoutBR, 1) 2. ("foo\n", 4) on white-space: pre. Because ComputeInlineBoxPositionForTextNode didn't receive such position. Historically, VisualPosition canonicalization updated Position not to point end of Node and LocalCaretRectOfPosition and ComputeInlineBoxPosition assumed that. This patch updates LocalCaretRectOfPositionTemplate to check if Position is after line break(NeedsLineEndAdjustment) and return the first InlineBoxPosition of next line(NextLinePositionOf). * Notes: This kind of adjustment should be done inside ComputeInlineBoxPosition. However, SelectionModifierCharacter and SelectionModifierWord depend on the current behavior of ComputeInlineBoxPosition that it returns null InlineBoxPosition for such position of line end (see L261 and L332 for each function). Since regression is about LocalCaretRectOfPositionTemplate, this patch only fixes the function. Bug: 807930 Change-Id: I46630d86401c165e0bb908d748adc069e03a5374 Reviewed-on: https://chromium-review.googlesource.com/906263 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547639}
-
Yutaka Hirano authored
Some tests want to run all microtasks at the end of each test case, but I guess it is good for all tests. This CL adds v8::MicrotasksScope::PerformCheckpoint in ~V8TestingScope and removes ScriptPromiseTestTryCatchScope which is now needless. Bug: None Change-Id: Icb237c7bb58f1ec7cfe1ce80d03f1b8106459e1a Reviewed-on: https://chromium-review.googlesource.com/991615 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547638}
-
https://skia.googlesource.com/skia.git/+log/873086957bdf..c0528e2418e0 $ git log 873086957..c0528e241 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5a7e61bbd..30b604d8d (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I00b638b049e06e1d17549baaa893ff891bac3890 Reviewed-on: https://chromium-review.googlesource.com/991732Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547637}
-
Karan Bhatia authored
This CL ensures that all the page whitelisting API functions (chrome.declarativeNetRequest.*) can't be called by extensions which don't have a declarative ruleset. It doesn't make sense for extensions to whitelist page patterns if they don't have a registered declarative ruleset. BUG=811460, 696822 Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing Change-Id: Id2822af5f258a32889e9217a3c63e13879984312 Reviewed-on: https://chromium-review.googlesource.com/987314 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547636}
-
Vaclav Brozek authored
The PRESUBMIT test _CheckUniquePtr reported the following false-positive: std::unique_ptr<ParseResult> result = std::make_unique<ParseResult>(); suggesting that one uses nullptr instead. This CL fixes that bug and also adds regression tests for this presubmit check. Bug: 827961 Change-Id: I60a088f6590f01c51be7e3ffc0c6d65ad9e5c329 Reviewed-on: https://chromium-review.googlesource.com/989972Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547635}
-
Kenichi Ishibashi authored
The method is similar to EnsureControllerServiceWorker but in some cases we can't make sure that the controller service worker is running (as existing comment described). Update the description of the method to state that this method doesn't guarantee that the controller is running. The method will be called during navigation when S13nSW is enabled. During navigation, we need to make sure that the controller is running before calling this method. Currently we make sure this by calling ServiceWorkerFetchDispatcher::StartWorker() in the following sequence: ServiceWorkerControlleeRequestHandler::MaybeCreateLoader() -> ServiceWorkerURLJobWrapper::ForwardToServiceWorker() -> ServiceWorkerNavigationLoader::ForwardToServiceWorker() -> ServiceWorkerFetchDispatcher::Run() -> ServiceWorkerFetchDispatcher::StartWorker() After creating a loader, we call GetControllerServiceWorkerPtr() in ServiceWorkerControlleeReuqestHandler::MaybeCreateSubresourceLoaderParams(). Bug: 797222 Change-Id: If7ef6dbe2e59c15e2f737f16d68f0c851d889556 Reviewed-on: https://chromium-review.googlesource.com/987832Reviewed-by:
-
Alexander Yashkin authored
This fixes DCHECK caused by TemplateURLService::UpdateNoNotify incorrect update of search engines that have same keyword after update. Bug: 697745 Change-Id: Ib554ca3e1748a3827fdbbb06a2168bb41dbdc150 Reviewed-on: https://chromium-review.googlesource.com/989753 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547633}
-
btolsch authored
The text in the fullscreen exit toast is confusing on Chrome OS since it is not commonly known how to access the F11 key. It is not usually used in BrowserView since immersive mode is used instead. Additionally, Chromebooks have a hardware fullscreen toggle button which should be easily accessible for exiting fullscreen. Bug: 825803 Change-Id: I855c9920e37e4176140c874e4a7c357cc6ab3e22 Reviewed-on: https://chromium-review.googlesource.com/988940Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547632}
-
