- 22 Jul, 2020 40 commits
-
-
Nico Weber authored
Bug: 1098899 Change-Id: I9423e63db7f55fe4c18271a26ff60cee6b802bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314676 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#791026}
-
Yuwei Huang authored
This CL makes HeartbeatSender send request via Protobuf over HTTP. This is OK to be checked in now since unlike FTL, our backend is ready to accept Protobuf/HTTP requests. Bug: 1103416 Change-Id: Iefdbcb59602436e01dbf4475cab3f6db67004e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311121 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#791025}
-
zhaoyangli authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/119c1b0adbc0..a1c3b1271dcd $ git log 119c1b0ad..a1c3b1271 --date=short --no-merges --format='%ad %ae %s' 2020-07-16 tirodkar Remove UIWebView loading in GREYAutomationSetup. 2020-07-16 tirodkar Fix comment breakages in the OSS Xcode project. 2020-07-15 chanheepark Remove deeplink error as EarlGrey minimum target os is iOS 11. 2020-07-15 chanheepark Add new error code for deeplink action error. 2020-07-14 chanheepark Look for textField in case the URL field is the first responder. 2020-07-14 tirodkar Remove the UIHierarchy legend 2020-07-14 albertbow Make kGREYIntializationErrorDomain use new error format. 2020-07-13 tirodkar Guard duplicate TextField id's for iOS 14. 2020-07-13 tirodkar Ensure that replaceText calls the valueChanged control event. 2020-07-10 chanheepark Return frame for top level windows when converting to screen coordinate. 2020-07-09 tirodkar Add the keyboard dismissal error code for the new formatter. Created with: roll-dep src/ios/third_party/earl_grey2/src Change-Id: I64ec59c89d11c617d0f04fdc180e8df1a9db7966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304725Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791024}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ie88ba35be8ee0d8c78cf685a270a3cedee0c872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314023 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#791023}
-
Peng Huang authored
Concurrent read access from both GL and Vulkan is not allowed. Get rid of the concurrent read problem by releasing the texture from GL temporarily, when a Vulkan read is requested. And resume GL read access, when the Vulkan read access is over. Current chrome GL and Vulkan concurrent read pattern is - Blink holds and caches read access for a backing shared image for a WebGL or 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just before playing back DDL and releases the read access after playing back DDL and before SwapBuffers. The GPU will not schedule other tasks between playing back DDL and SwapBuffers. So it should be safe to temporarily pause GL read access. Bug: 1104231 Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791022}
-
Josh Nohle authored
Add a certificate manager implementation class, where the overridden methods are currently marked as NOTIMPLEMENTED(). We also include a fake implementation and factory for use in unit tests. The full implementation will happen in a follow-up CL. For now, these classes unblock consumers of the certificate manager. Bug: b/154863644 Change-Id: Ib81bd4e09b7fed0d98e7e18792de78664ff9d20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311078Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791021}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf25ef52..9d73e198 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c8abe5a5a73a0d6c194e542937b88eb265c3772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314376Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791020}
-
Maxime Charland authored
Having a custom accessibilityIdentifier for the cell set through the TableViewItem enables easier egtests and better accessibility without having to set the ID in cellForRowAtIndexPath. A use case for this is RecentTabs, which will use the same TableViewIllustratedItem for all the empty states, with different ItemTypes. Without this modification to TVIllustratedItem, RecentTabs would have to manually set the a11yID of the cell for every itemType. Bug: 1098328 Change-Id: I341692643556a42984c843594a9be8d24b139762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313297 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791019}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a469e5b085a5..ed914d124174 2020-07-22 brgoddar@microsoft.com Grid: Update grid telemetry to fire on devtools launch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106888 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I462988ff27faa999a7cbee4a10133814ec9a9673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791018}
-
W. James MacLean authored
Disables another test for all platforms. TBR=brucedawson@chromium.org Bug: 1084931 Change-Id: Id84a3030a4ffa49784c39eb5dfd01c8b92058d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313980Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791017}
-
Travis Skare authored
Fixes crash when using a keyboard shortcut to close the active tab with the bubble open. Note with recent changes, the icon intentionally stays visible after bubble close, so this call is no longer needed anyway. Bug: 1107857 Change-Id: Ic254f28522e3b405591d068d2395aa4f4f281f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314696Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#791016}
-
Jimmy Gong authored
- Previously print jobs that are ongoing or printed within 24 hours displayed the printed time in a 12hr format. - Not all language locales are in the 12hr format, so the fix is to remove that parameter and use the numeric locale format. Before: https://screenshot.googleplex.com/B3Y9JiAp6ET After: https://screenshot.googleplex.com/srMiTVBJT6G Bug: 1106231 Change-Id: I4103e954b5b3b26b6eacc9b188366ee022e5e10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311616Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#791015}
-
Edward Lesmes authored
Bug: 1108003 Change-Id: If664a3b974ef0f110ce18518c5b211ed23e9e7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310869Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#791014}
-
Toni Barzic authored
Adds a feature flag and general code structure that will be used for the feature: * chrome/browser/ui/ash/holding_space - browser context keyed service that keeps track of per-user holding space items, and that will be used as an entry point to add items to the holding space from Chrome. * ash/public/cpp/holding_space - general holding space data model, that contains information about items that have been added to the holding space, and that propagates model changes between chrome and ash * ash/holding_space - the UI implementation for the holding space. The logic is pretty bare, mostly focused on propagating model state updates to ash. The UI implementation, and entry points to add items will be done in coming weeks. BUG=1106991 Change-Id: Id0a70929aecfe4164b613a39db42b9412368abbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310902Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791013}
-
Joshua Bell authored
The term "whitelist" was retired from the spec and is being removed from the Chromium codebase. Update the AppCache code to use the term "safelist" instead, which is what the spec[1] and parser use: Note that this CL does not update the database table names using the old term. See the tracking bug for further discussion about doing that in a follow-up. [1] https://html.spec.whatwg.org/multipage/offline.html Bug: 1108479 Change-Id: I12af2c3de1e1b6f5a638ec3d3cd75967b9f94b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314277 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791012}
-
Haiyang Pan authored
This reverts commit 4f6da930. Reason for revert: InputEventBrowserTest.TouchStartEventTimeStamp is flaky in android pie CQ builder: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BJbnB1dEV2ZW50QnJvd3NlclRlc3QuVG91Y2hTdGFydEV2ZW50VGltZVN0YW1wDA It is flaky in several waterfall builders as well, starting at https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1565 https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/5952 https://ci.chromium.org/p/chromium/builders/ci/android-asan/7107 Original change's description: > Rewrite hr-timestamp/input-events.html to a browser test > > hr-timestamp/input-events.htmlEvent timestamp tests that the received > events on the page should be equal to the timestamp provided by the > eventSender's recorded last event. But we should deprecate eventSender in > the future, and GpuBenchmarking sends events based on the current system > time, which cannot be equal to the received events' timestamp. > > > Bug: 1047176 > Change-Id: I225dec07b1928ae254d61e8a8384ebfc7dab75e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173421 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790868} TBR=bokan@chromium.org,lanwei@chromium.org,majidvp@chromium.org Change-Id: Ifd5238546ed74824628a5d126b69a9fa37958ee3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314806Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791011}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2d4bfbed79c5a921401eabaaaa349fbdd8328cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314421Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791010}
-
Andre Le authored
BUG=921267 Change-Id: I6bbb3723975666cf2b488eda8a34d69e80384f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308229 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791009}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d7a1fced41b0..a45603bd6801 2020-07-22 amaiorano@google.com Fix GN debug builds of SwiftShader on LLVM 10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1108382 Tbr: swiftshader-team+autoroll@google.com Change-Id: I6340e870fa9efc2e2355aa3f3697e629e4632e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791008}
-
Evan Stade authored
This reverts commit 2544a4d3. Reason for revert: Clank was updated; no change to original patch > Original change's description: > > Remove PrefServiceBridge.java > > > > Port PrefServiceBridgeTest to PrefServiceTest. > > Update docs. > > Update OWNERS. > > > > Bug: 1071603 > > Change-Id: I48f83e1faade5263a6b105268bfd57ded3db27e5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307609 > > Commit-Queue: Evan Stade <estade@chromium.org> > > Reviewed-by: Dominic Battré <battre@chromium.org> > > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790210} TBR=battre@chromium.org,chouinard@chromium.org Bug: 1071603 Change-Id: I1687c20d38ac72131b874b8222127cb23329d30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310316Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#791007}
-
Min Qin authored
This allows us to switch between prod and prototype servers when needed. BUG=1107976 Change-Id: I945fcf7824c3463bc51b74c2e9a56747a0704414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309812Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791006}
-
Scott Violet authored
This code has no use. BUG=none TEST=none Change-Id: If31ffcf26cf8f6519216280e9ef0d0c3abe7f7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314119Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791005}
-
Sasha McIntosh authored
In some cases, when the kernel fails to read/parse an EDID the EDID property is present but empty. We should treat an empty EDID as a failure case and not attempt to parse, which results in inconsistent default values. Ex. We expect an invalid EDID to have a kInvalidProductCode. Currently, an empty EDID blob will generate a product code of 0. Change-Id: Ifd3f993c10e0bb728412028b357bbba0f6631146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219518 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#791004}
-
Will Harris authored
This is a reland of f56c8f8e Original change's description: > Reland "Add test that verifies CFG loader config is generated correctly." > > This is a reland of c2b6797f > > Fixed to add CALLBACK in front of the callback function. > > Original change's description: > > Add test that verifies CFG loader config is generated correctly. > > > > This CL adds a test that creates a callback from operating system > > code to a module that has CFG enabled where the callback is not > > listed as a valid indirect target. > > > > Note: this test does not require dispatch guards to be present > > in chromium code, just for them to be present in OS code and > > for the CFG load config to be generated correctly. > > > > BUG=584575 > > > > Change-Id: Id6f5f4061f7237c23f08c8fe1b7471ea200f0628 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308854 > > Commit-Queue: Will Harris <wfh@chromium.org> > > Reviewed-by: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790587} > > Bug: 584575 > Cq-Include-Trybots: luci.chromium.try:win7-rel > Change-Id: Ie721a3f3aebcb3ff1eaae711e588ba1ec8a6e507 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311038 > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790690} Bug: 584575,1108222 Change-Id: Ifda66b80f5832178f3e8fe5c6f55b95d7e00281a Cq-Include-Trybots: luci.chromium.try:win7-rel,win-asan Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314017Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791003}
-
W. James MacLean authored
Disabling flakey test on ChromeOS. TBR=joedow@chromium.org Bug: 1108391 Change-Id: I6ce8105e10f936f2cb4708f556badf32c62e1e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314039Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791002}
-
Devlin Cronin authored
An extension controlling settings, like search provider, could potentially have the same settings as the user previously set. For instance, a user could: 1) set search provider to example.com 2) install the example.com search extension In this case, we shouldn't display the settings overridden dialog, because there's no effective change. Add logic to not display the dialog if the fallback search provider is not extension provided, and matches the origin of the new provider. If the previous provider was an extension, we'll still show the dialog - this simplifies the implementation, and can also be useful to the user because the controlling extension changed. Add tests for the same. Bug: 940923 Change-Id: I3ab9ba91d8bb473e44892a6bcc9d746d8472a465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313997Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791001}
-
Khushal Sagar authored
This histogram tracks the performance of caching of uploaded images and is needed for continuous monitoring. Change-Id: I74805f414671e3bcf8188ef09b09b876eca9c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314156 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791000}
-
yjliu authored
Bug: 1106963 Change-Id: I5ce0cc13d9fff2b73e2e94c9cfb39413d56b0511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313046Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790999}
-
Lei Zhang authored
Clean up some stragglers that called DeleteFile() without the base:: prefix, but still got the right function with argument-dependent lookup. Bug: 1009837 Change-Id: I6a11c92cc9f928830ea772f7a998b4c23bf939fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313043Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790998}
-
zhaoyangli authored
The builder should use latest version of Xcode 12. Also carried a luci-scheduler.cfg format change in this CL, from a recent generator update. Bug: 1108147 Change-Id: Ibd0ceb9966c7974fe8d01e96be2e8f8a5a9d8b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311722 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#790997}
-
Maksim Ivanov authored
Provide test coverage for the following scenarios in the chrome.certificateProvider extensions API: * empty certificate chain; * empty algorithm list; * an extension subscribing to both legacy and non-legacy events simultaneously. Bug: 1067683 Change-Id: I074967716aba5c91b6b6e946345f84a4767bd722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252187 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790996}
-
Anders Hartvoll Ruud authored
If the calls to MatchResult::Finish are not correct, we can end up rules that appear to exist in the wrong origin. In CollectPseudoRulesForElement, there is an option _not_ match UA/User rules, but it didn't call the Finish* functions for skipped origins. In PseudoStyleForElementInternal, there is a call to FinishAddingAuthorRulesForTreeScope with _may_ take place without the other finishers being called first. Since no further rules are added anyway, we can simply remove this call. Change-Id: I81e54b267eba6098d9037d2d403047bc3da25dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310338Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#790995}
-
Peter Wen authored
Remove //components* from allowlist. Bug: 1082904 Change-Id: Icf4100c9e9e2a4ea7c843ea6d8cfa148b1fa7b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314298 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790994}
-
Rohit Rao authored
Updates the HARMFUL_ACCESS() macro to use EXPECT_DEATH_IF_SUPPORTED, which is a no-op on platforms where EXPECT_DEATH is unsupported. This effectively disables death tests when run on iOS, allowing base_unittests to pass when run under ASAN. BUG=None Change-Id: I700210e3a96e3cf8b10c786184146c4269bc3f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313117Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#790993}
-
W. James MacLean authored
TBR=thibaudm@chromium.org Bug: 1107923 Change-Id: I73a80f3986a8b4ee7e655c42057a6d47c014a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313960Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#790992}
-
Mehran Mahmoudi authored
This shows a snackbar when the user interacts with the paint preview player on startup. It also implements the 'frustration detector'. It triggers when the user taps in areas that are not links, or longpresses. This will lead to showing the snackbar again. Bug: 1106430 Change-Id: I3aa94f055a730630058bd204d0810e81668b7a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302938 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#790991}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/747e80a9b369..433670b576c5 $ git log 747e80a9b..433670b57 --date=short --no-merges --format='%ad %ae %s' 2020-07-22 rharrison Add usage of main from chromium when part of a chromium build 2020-07-22 dsinclair Add return to simple test 2020-07-22 sarahmashay [validation] Add a disabled test for assignment statement. 2020-07-22 dneto [spirv-reader] Support OpAny, OpAll, OpIsInf, OpIsNan 2020-07-21 dsinclair [spirv-writer] Emit select intrinsic. 2020-07-21 dsinclair Add type determination for the select intrinsic. 2020-07-21 dneto [spirv-reader] Add README.md 2020-07-21 dneto [spirv-reader] Support function call returning void 2020-07-21 dj2 [hlsl-writer] Add assignment statement. 2020-07-21 dj2 [hlsl-writer] Add switch statement support 2020-07-21 dj2 [hlsl-writer] Emit case statements. 2020-07-21 dj2 [hlsl-writer] Emit unary operators. 2020-07-21 dj2 [hlsl-writer] Emit break, return and continue. 2020-07-21 dsinclair [hlsl-writer] Add binary operator emission. 2020-07-21 dsinclair Parse void function call. 2020-07-21 dsinclair [hlsl-writer] Add emission of identifiers 2020-07-21 dj2 Emit call statements from the various backends. 2020-07-21 dj2 Type determine the call statement. 2020-07-21 dj2 Add a call ast statement. 2020-07-21 dneto [spirv-reader] Support select over scalars and vectors 2020-07-20 dneto Add missing Doxygen comments on two methods. 2020-07-20 dneto [spirv-reader] Support function calls, except returning void 2020-07-20 dsinclair [hlsl-writer] Scaffold the HLSL backend. 2020-07-20 dsinclair [msl-writer] Emit storage buffers. 2020-07-20 dsinclair [msl-writer] Add import emission. Created with: roll-dep src/third_party/tint/src Bug=tint:123 Change-Id: I5ba160dfbd1fabd4390a55b833bcfd6b255f7530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314116 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790990}
-
Takumi Fujimoto authored
Change-Id: I4595a84b9fbf5421e43311005d1a7aa634f66ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309006 Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#790989}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85f04135. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" e0092d05 "Reland "[COOP] access reporting [5/N] Plumb report type."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I34cd10a9c6ea32fec940c57e94327d96525a1c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314136Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790988}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I5fa451c2356bcf66cd8badb7daed2817cf13535b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790987}
-