GitLab

Adds a couple of pixel-based compositor unittests. One to test that opacity is handled correctly, and one to check that MoveToFront and MoveAbove really do change the compositor output as expected.

Noteworthy changes are in layer_unittest.cc. Most of the changes below are due to moving compositor testing code into ui/gfx/compositor/test.

Depends on http://codereview.chromium.org/8463024/ and http://codereview.chromium.org/8590019/

BUG=None
TEST=compositor_unittests

Review URL: http://codereview.chromium.org/8533019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110657 0039d316-1c4b-4281-b951-d872f2087c98

IsRunningOnChromeOS() turned out to be unnecessary.
CrosLibrary::EnsureLoaded() was returning true before crrev.com/110516,
as ScopedStubCrosEnabler was used in LoginUtilsTestBase.

BUG=chromium-os:23154
TEST=run linux_chromeos try bot


Review URL: http://codereview.chromium.org/8561004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23058
TEST=None

Review URL: http://codereview.chromium.org/8570026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100292


Review URL: http://codereview.chromium.org/8585047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/8528048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110653 0039d316-1c4b-4281-b951-d872f2087c98

R=stevenjb@chromium.org
BUG=104650
TEST=none


Review URL: http://codereview.chromium.org/8594001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compositor_unittests

Review URL: http://codereview.chromium.org/8585034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110650 0039d316-1c4b-4281-b951-d872f2087c98

- Send the binary sha256 hash.
- Cancel requests that timed out.

BUG=102540
TEST=Run DownloadProtectionServiceTest. Also, if you have SafeBrowsing enabled you should see a server request for every binary download that doesn't match our whitelist.


Review URL: http://codereview.chromium.org/8586011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110649 0039d316-1c4b-4281-b951-d872f2087c98

The new ClientControlDispatcher and ClientEventDispatcher manage control 
and event channels.


Review URL: http://codereview.chromium.org/8574025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110648 0039d316-1c4b-4281-b951-d872f2087c98

It's going to be a bit of work to get the component-extension file picker working on non-ChromeOS platforms.  Until then, disable the SelectFileDialogExtensionBrowserTest -- it won't work until a lot more plumbing is ready in the local filesystem API and mount point providers.

BUG=97424
TEST=linux_aura and linux_chromeos_aura both compile and work on my machine

Review URL: http://codereview.chromium.org/8589030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98323
TEST=None


Review URL: http://codereview.chromium.org/8570014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110646 0039d316-1c4b-4281-b951-d872f2087c98

- Create ShellAcceleratorController that manages global keyboard accelerators and also processes several accelerators as a target.
- Create ShellAcceleratorFilter, which is used by DesktopEventFilter to handle accelerators.
- Add a function to Shell for accessing ShellAcceleratorController.

BUG=97255
TEST=Manual


Review URL: http://codereview.chromium.org/8465021

TBR=mazda@chromium.org
Review URL: http://codereview.chromium.org/8602003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110643 0039d316-1c4b-4281-b951-d872f2087c98

Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c

BUG=None
TEST=base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110021

Review URL: http://codereview.chromium.org/8505033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110640 0039d316-1c4b-4281-b951-d872f2087c98

Rename the PrintPreviewUITest unit test to PrintPreviewUIUnitTest, because there exists a UI test with the name PrintPreviewUITest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8586046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110639 0039d316-1c4b-4281-b951-d872f2087c98

Revert 110626 - Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045
Review URL: http://codereview.chromium.org/8588045

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/8558008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110638 0039d316-1c4b-4281-b951-d872f2087c98

- Create ShellAcceleratorController that manages global keyboard accelerators and also processes several accelerators as a target.
- Create ShellAcceleratorFilter, which is used by DesktopEventFilter to handle accelerators.
- Add a function to Shell for accessing ShellAcceleratorController.

BUG=97255
TEST=Manual


Review URL: http://codereview.chromium.org/8465021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=74970
TEST=status_tray_chromeos_unittest

Review URL: http://codereview.chromium.org/8476003

TBR=leandrogracia@chromium.org
Review URL: http://codereview.chromium.org/8596003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110636 0039d316-1c4b-4281-b951-d872f2087c98

This is in the form of static RegisterHost/UnregisterHost functions in the RenderProcessHostImpl class.

BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8597005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104588
TEST=manual, see bug.

Review URL: http://codereview.chromium.org/8574079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110634 0039d316-1c4b-4281-b951-d872f2087c98

I plan to use the CPU Usage functions in other non-Youtube related perf
tests, so moving these helper functions from the Youtube perf class to the
base perf class.  Also some minor style edits to the Youtube perf test
code.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8585050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72754


Review URL: http://codereview.chromium.org/8536003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8567022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110631 0039d316-1c4b-4281-b951-d872f2087c98

This time without breaking the windows build!

Patch by robert.nagy@gmail.com:
http://codereview.chromium.org/8499029/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110629 0039d316-1c4b-4281-b951-d872f2087c98

Synchronously close launcher widget so that it will not access LauncherModel after Launcher is destructed.

BUG=104672
TEST=Verify aura_shell_unittest should pass ASAN.


Review URL: http://codereview.chromium.org/8589035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110628 0039d316-1c4b-4281-b951-d872f2087c98

It hasn't triggered in 1000+ valgrind runs.

BUG=87245
TBR=glider

Review URL: http://codereview.chromium.org/8601001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110627 0039d316-1c4b-4281-b951-d872f2087c98

Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045
Review URL: http://codereview.chromium.org/8588045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110626 0039d316-1c4b-4281-b951-d872f2087c98

The new HostControlDispatcher manages reading and writing to and from control 
channel on the host side. Similarly HostEventDispatcher is responsible for
reading and, in future, writing to and from the event channel.


Review URL: http://codereview.chromium.org/8468022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96713
TEST=none


Review URL: http://codereview.chromium.org/8585006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110623 0039d316-1c4b-4281-b951-d872f2087c98

I chose to use the local ContentView class to implement BubbleDelegateView.
SpeechInputBubbleImpl didn't fit well as a BubbleDelegateView, because:
-Instances are expected to outlive Widget closure or hide (not implemented).
-SpeechInputBubbleBase::Show would cause a naming conflict.
-SpeechInputBubbleController interactions made that approach difficult.

BUG=98323
TEST=SpeechInputBubbles function as before.

Review URL: http://codereview.chromium.org/8565003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8561007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104690
TEST=none

R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8596002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110616 0039d316-1c4b-4281-b951-d872f2087c98

Define the public interface for content browser RenderProcessHost. This interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.

The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. 
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost  class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.

Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.

BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98

This allows XHRs from the background page to file:/// URLs to succeed. XHRs from
content scripts still fail, since they're running in a regular renderer process,
and there is currently no mechanism for only whitelisting the isolated world
within it for the file: scheme.

Also re-enable ExtensionApiTest.CrossOriginXHRContentScript since it doesn't
appear to have flaked recently.

BUG=104547,96725
R=aa@chromium.org


Review URL: http://codereview.chromium.org/8587052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=74970
TEST=status_tray_chromeos_unittest

Review URL: http://codereview.chromium.org/8476003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110613 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10466

Review URL: http://codereview.chromium.org/8574078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110612 0039d316-1c4b-4281-b951-d872f2087c98

Presubmit checks now consider the presence of wstring to be an error, so
switching all wstrings in courgette_tool to FilePath's as evanm had
already called out in a TODO.

BUG=chromiumos:22693


Review URL: http://codereview.chromium.org/8498032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110611 0039d316-1c4b-4281-b951-d872f2087c98

[I think the Windows shared builders just need to be clobbered.]

[Committing for pbrophy@adobe.com. Original review:
http://codereview.chromium.org/8138008/ .]

This change supports audio capture from the microphone and supplies the data
through a Pepper interface. Its enumeration is limited to the default audio
device that uses mono 44.1kHz.

TBR=tony@chromium.org

Review URL: http://codereview.chromium.org/8574029

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8569003

TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8561003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110609 0039d316-1c4b-4281-b951-d872f2087c98

- Fix HtmlDialogBrowserTest.SizeWindow for Linux + Aura + Chromeos==0.
- Remove minimum_size_ from auralWindow and add an OnBoundsChanging to aura::WindowDelegate so that a delegate can apply bounds constriant;
- NativeWidgetAura uses OnBoundsChanging to apply Widget's minimum size;
- Remove minimum_size_ member from Widget because it is only used for widget with no frame (i.e. no non_client_view_) and such widget should have no minimum size;

BUG=104412
TEST=Verify the HtmlDialogBrowserTest.SizeWindow should pass for Linux + Aura + Chromeos==0.


Review URL: http://codereview.chromium.org/8574049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110608 0039d316-1c4b-4281-b951-d872f2087c98

There will be a followup patch to finish the conversion for GpuCommandBufferStub.

BUG=none
TEST=compiles and passes try bots

Review URL: http://codereview.chromium.org/8572047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110607 0039d316-1c4b-4281-b951-d872f2087c98