- 24 Nov, 2015 40 commits
-
-
ssid authored
This CL does a refactoring of the dependencies and do not change any behavior. The diff between the ninja files is presented in link: http://pastebin.com/aG6eq5cb. The test_support_gpu.gypi included allocator.gyp for no reason, and the only other target that uses this file is content_browsertests, which already includes allocatpor.gyp with same conditions. So, removing this dependency here. target:browser_ui - depends on allocator.gyp in windows targets that depend on browser_ui: chrome_android_core: not used in windows Dependency on allocator.gyp exists already for: All, browser (explained below) target:browser - depends on allocator.gyp in windows targets that depend on browser: chrome_android_core: only android chromevox_tests: added dependency to allocator.gyp for windows Dependency on allocator.gyp exists already for: All, interactive_ui_tests, browser_tests, performance_browser_tests chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests test_support_sync_integration's executables: sync_integration_tests, browser_tests, sync_performance_tests test_support_common's executables: interactive_ui_tests, browser_tests, performance_browser_tests test_support_unit's executables: unit_tests target:renderer - depends and exports dependency on allocator.gyp in windows targets that depend on renderer: chrome_android_core: not used in windows chromevox_tests: added dependency to allocator.gyp for windows chrome_child_dll - added dependency. Dependency on allocator.gyp exists already for: interactive_ui_tests, browser_tests, performance_browser_tests sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests chrome_app_unittests test_support_common - explained earlier. target:browser_extensions - depends on allocator.gyp in windows targets that depend on browser_extensions: apps - browser (explained above) browser_ui (explained above) browser_chromeos browser (explained above) browser_tests apps - browser (explained above) target:web_cache_browser - depends on allocator.gyp in windows All the targets that depend on web_cache_browser already have dependency on allocator.gyp: browser*, components_unittests extensions_browser extensions_unittests, browser_extensions*, apps* media_router browser_ui*, browser*, native_app_window - browser_ui* javascript_dialog_extensions_client - browser_ui* media_router_test_support browser_tests, test_support_unit*, unit_tests app_shell_lib extensions_browsertests, app_shell, app_shell_unittests extensions_test_support extensions_unittests, extensions_browsertests, app_shell_unittests test_support_common* * - see previous sections for why it is fine for the target to not depend on allocator.gyp BUG= Review URL: https://codereview.chromium.org/1462853002 Cr-Commit-Position: refs/heads/master@{#361381}
-
ianswett authored
Deprecate FLAGS_quic_read_packets_full_recvmmsg. Merge internal change: 107932700 https://codereview.chromium.org/1467453007/ removing a redundant way of checking if QUIC has pending crypto data. Merge internal change: 107932405 Make QuicPacketCreator be able to serialize packet itself when it does not have room for next stream frame. No functional change expected. For QuicPacketCreator, add DelegateInterface class, Flush function, move SerializePacket from public to private. For QuicPacketGenerator, add OnSerializedPacket function, remove SerializeAndSendPacket. Merge internal change: 107814957 https://codereview.chromium.org/1459343009/ These packets got reformatted at some point, maybe before the clang-format off annotation was added. Merge internal change: 107790487 Get rid of unnecessary CompareSpdyHeaderBlocks method, use operator== instead. No behavior change. Merge internal change: 107784612 minor changes to batched write to make DCHECK happy. Behind FLAGS_quic_batch_writes Also includes a test fix to update bytes on the correct stream to get the no-op we intended (rather than a no-op we didn't intend) Merge internal change: 107783952 https://codereview.chromium.org/1472573002/ Deprecate FLAG_reset_cubic_epoch_when_app_limited. Merge internal change: 107711408 https://codereview.chromium.org/1467453006/ Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame. No functional change expected. Also move CreateStreamFrame from public to private in QuicPacketCreator. Merge internal change: 107709890 https://codereview.chromium.org/1464153002/ Add WritePushPromise() method in QuicHeadersStream for server push. Merge internal change: 107699435 https://codereview.chromium.org/1471583002/ Clear the connection's send alarm when a new ack is received. Flag protected by FLAGS_quic_respect_send_alarm. Merge internal change: 107697347 https://codereview.chromium.org/1466153002/ Remove the LOG(DFATAL) from QuicTestClient::address(), since it appears to be implemented. Changing from QuicPriority to SpdyPriority. Merge internal change: 107687942 https://codereview.chromium.org/1468773002/ Replacing EffectivePriority with Priority for QUIC. The only place we had changing priority was "if the response headers were serialized and not sent" After we moved to having a separate headers stream we never utilized the QuicWriter's header buffer, instead passing headers directly to the QUIC layer which serialized them and sent them with their own special priority. Removing the idea of mutable priority enables having the write blocked list track stream priorty, removing SPDY-specific logic from our shared code and moving us closer to the new H2 style write scheduler logic. Merge internal change: 107610692 https://codereview.chromium.org/1471573002/ Let QUIC streams write 16k before ceding. Behind FLAGS_quic_batch_writes. Changing our round robin logic to prompt a given stream until it has finished ~16k (rounding up to the max quic packet payload). Merge internal change: 107595145 https://codereview.chromium.org/1472563002/ Removing unused code to convert QUIC from SPDY3 to SPDY4 Now that QUIC version 24 is gone, we shouldn't need to worry about converting headers from SPDY3 to SPDY4 as it should all be SPDY4 Merge internal change: 107581674 https://codereview.chromium.org/1463303002/ Cleanup: clang-formatting gfe/quic/quic_framer* to comply with Chromium style guide. clang-format -i --style="{BasedOnStyle: Chromium, Standard: Cpp11}" ./quic_framer* Merge internal change: 107514106 https://codereview.chromium.org/1466693002/ QUIC proof source: allow construction with an |SSLContext| provider. To support |SSLContext| swaps, the long-lived |ProofSourceChromium| object must have a means of retrieving the new context. The simplest way to do that seems to be to pass in a getter method: the alternative of calling |SSLGlobalData::ssl_context| is unavailable due to circular dependencies. n/a (Refactor. No functional change expected.) Merge internal change: 107509393 https://codereview.chromium.org/1463603002/ Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change. Chromium doesn't have the same support for custom hash functions. Makes it hard to port cl/106938391. Merge internal change: 107505890 https://codereview.chromium.org/1465583002/ Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed, the stream would attempt to mark itself write blocked leading to a crash in debug mode. Merge internal change: 107452913 https://codereview.chromium.org/1458003004/ Deprecate FLAGS_quic_count_unfinished_as_open_streams. Merge internal change: 107422215 https://codereview.chromium.org/1457233003/ Convince ASAN we're really not touching the factory pointers at the same time by adding explicit locks n/a (test only) Merge internal change: 107412764 https://codereview.chromium.org/1459163002/ R=rch@chromium.org BUG= Review URL: https://codereview.chromium.org/1470713003 Cr-Commit-Position: refs/heads/master@{#361380}
-
wangxianzhu authored
Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ ) Reason for revert: This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer. Original issue's description: > Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() > > To ensure layer is set needsRepaint(). > > BUG=536999 > TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled > > Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3 > Cr-Commit-Position: refs/heads/master@{#361179} TBR=chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536999 Review URL: https://codereview.chromium.org/1475483003 Cr-Commit-Position: refs/heads/master@{#361379}
-
bnc authored
|using| directives should not be global, but they should be used on a per-file bases. Therefore they should not be placed in header files. Review URL: https://codereview.chromium.org/1458163002 Cr-Commit-Position: refs/heads/master@{#361378}
-
lfg authored
Check for the isolate-extensions flag as well as --site-per-process. BUG=532666 Review URL: https://codereview.chromium.org/1469153003 Cr-Commit-Position: refs/heads/master@{#361377}
-
pbos authored
Also using a no_sanitize list for SANITIZER_HOOK_ATTRIBUTE instead of separate attributes per tool. BUG= R=glider@chromium.org Review URL: https://codereview.chromium.org/1474733002 Cr-Commit-Position: refs/heads/master@{#361376}
-
ochang authored
https://pdfium.googlesource.com/pdfium.git/+log/8840ec9..3647692 R=thestig@chromium.org BUG=555784,558840 Review URL: https://codereview.chromium.org/1466223003 Cr-Commit-Position: refs/heads/master@{#361375}
-
kbr authored
Re-enable conformance2/textures/misc/tex-storage-compressed-formats.html. This test is now passing. Suppress const-array-init, tex-image-and-sub-image-3d*, and floor-div-cos-should-not-truncate failures. BUG=295792, 560555, angleproject:1179, angleproject:1198 TBR=zmo@chromium.org Review URL: https://codereview.chromium.org/1471943002 Cr-Commit-Position: refs/heads/master@{#361374}
-
bajones authored
BUG=295792 NOTRY=true Review URL: https://codereview.chromium.org/1465993003 Cr-Commit-Position: refs/heads/master@{#361373}
-
droger authored
Review URL: https://codereview.chromium.org/1471743002 Cr-Commit-Position: refs/heads/master@{#361372}
-
estark authored
As a step along the way to componentizing SecurityStateModel, this CL introduces a SecurityStateModelClient interface and a ChromeSecurityStateModelClient implementation. The client has just a couple methods for now but will expand such that the client will eventually provide everything from //content and //chrome that the model needs. BUG=515071 Review URL: https://codereview.chromium.org/1470813002 Cr-Commit-Position: refs/heads/master@{#361371}
-
maruel authored
https://chromium.googlesource.com/external/swarming.client.git/+log/05e17879accc..df99a00d96fa $ git log 05e17879a..df99a00d9 --date=short --no-merges --format='%ad %ae %s' 2015-11-24 maruel Ignore .pyc in client/. R=tandrii@chromium.org BUG=chromium:555827 Review URL: https://codereview.chromium.org/1470113003 Cr-Commit-Position: refs/heads/master@{#361370}
-
https://codereview.chromium.org/1452353002Nico Weber authored
That change added gfx_geometry as a dep in .gyp files, but forgot to do the same for .gn files, which broke the Windows component builders. (The Linux component build seems to inline this function, I guess.) Due to crbug.com/497970, this breakage went undetected for pretty long. BUG=486089,552545 TBR=christhr Review URL: https://codereview.chromium.org/1471263002 . Cr-Commit-Position: refs/heads/master@{#361369}
-
dongseong.hwang authored
Revert of webgl: use immutable texture for the default FBO. (patchset #2 id:20001 of https://codereview.chromium.org/1449043005/ ) Reason for revert: following test is broken. WebglConformance.deqp_functional_gles3_readpixel Original issue's description: > webgl: use immutable texture for the default FBO. > > Use immutable texture for the default FBO like chromium compositor. > > In theory, it speeds up drawing speed, because immutable texture skips texture > validation on drawing call. > > In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization. > > BUG=557848 > TEST= > WebglConformance.conformance_renderbuffers_framebuffer_state_restoration > WebglConformance.conformance_textures_misc_texture_size_cube_maps > WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1 > > Committed: https://crrev.com/fb9d8e245ac84c6c0806e86e7884b4775a84b4b5 > Cr-Commit-Position: refs/heads/master@{#361335} TBR=kbr@chromium.org,adrian.belgun@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557848 Review URL: https://codereview.chromium.org/1474763002 Cr-Commit-Position: refs/heads/master@{#361368}
-
hongchan authored
NOTE: This is the second attempt of https://crrev.com/1140723003/ TODO: 1. Edit core/frame/UseCounter.h accordingly. 2. Add UMA metric in OfflineAudioContext.idl. Adds suspend() and resume() feature in OfflineAudioContext to support the synchronous graph manipulation with the render block precision (k-rate) in the non-realtime audio rendering. The benefit of being able to suspend/resume the context with the render block precision is: 1) The audio graph can be modified in a time-accurate way, independent of the hardware. Without this, setTimeout, completion events, or state change events are needed to manipulate the graph, and the results depend on when the events are fired and on how fast the hardware is. 2) Makes an OfflineAudioContext more symmetrical to the AudioContext, which already supports suspend/resume. (There are minor difference required by the difference between offline and online contexts.) This feature also can be used in Blink layout tests to verify the behavior of audio rendering. With this feature in the implementation, several flaky web audio layout tests can be fixed. http://webaudio.github.io/web-audio-api/#the-offlineaudiocontext-interface https://github.com/WebAudio/web-audio-api/issues/302#issuecomment-106101885 BUG=497933, 545686 TEST= webaudio/offlineaudiocontext-suspend-resume-basic.html webaudio/offlineaudiocontext-suspend-resume-eventhandler.html webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html webaudio/offlineaudiocontext-suspend-resume-promise.html webaudio/offlineaudiocontext-suspend-resume-sequence.html Review URL: https://codereview.chromium.org/1405413004 Cr-Commit-Position: refs/heads/master@{#361367}
-
agrieve authored
Necessitated adding a "write_asset_list" arg for creating the assets_list file. BUG=547162 Review URL: https://codereview.chromium.org/1435333008 Cr-Commit-Position: refs/heads/master@{#361366}
-
yzshen authored
This includes: - AssociatedBinding - AssociatedGroup - AssociatedInterfacePtr - AssociatedInterfacePtrInfo - AssociatedInterfaceRequest BUG=546067 Review URL: https://codereview.chromium.org/1465293002 Cr-Commit-Position: refs/heads/master@{#361365}
-
eranm authored
Review URL: https://codereview.chromium.org/1468173007 Cr-Commit-Position: refs/heads/master@{#361364}
-
fgorski authored
Currently code dchecks on the existence of the offline page for a given bookmark, which might not be the case. Removing DCHECK and only continuing execution if the offline page exists. BUG=560518 R=jianli@chromium.org Review URL: https://codereview.chromium.org/1473043002 Cr-Commit-Position: refs/heads/master@{#361363}
-
sergeyu authored
Previously It2Me host was stopped asynchronoulsy, which makes the shutdown more complicated. Now it's synchronous and is significantly simpler. Also removed ChromotingHost::RejectAuthenticatingClient() which is no longer needed. Review URL: https://codereview.chromium.org/1458323002 Cr-Commit-Position: refs/heads/master@{#361362}
-
agrieve authored
BUG=559284 Review URL: https://codereview.chromium.org/1469943002 Cr-Commit-Position: refs/heads/master@{#361361}
-
zea authored
Also fixes up the GCM error code logging (using the wrong enum that relied on positive net error codes, while GCM was sending negative) BUG=556773 Review URL: https://codereview.chromium.org/1471103002 Cr-Commit-Position: refs/heads/master@{#361360}
-
agrieve authored
This is the case for ContentShell.apk BUG= Review URL: https://codereview.chromium.org/1469113004 Cr-Commit-Position: refs/heads/master@{#361359}
-
sdefresne authored
The pref data_reduction_proxy::prefs::kDataReductionProxy should have been part of data_reduction_proxy::RegisterPrefs() to avoid having all embedder register it manually just before call said function. BUG=557814 Review URL: https://codereview.chromium.org/1463973003 Cr-Commit-Position: refs/heads/master@{#361358}
-
peter authored
It's one very trivial function that only has a single call-site. It doesn't need its own file. BUG= Review URL: https://codereview.chromium.org/1474533004 Cr-Commit-Position: refs/heads/master@{#361357}
-
jochen authored
That way, we don't have to mess with the hidden values in the dtor. BUG=558975 R=haraken@chromium.org,sigbjornf@opera.com Review URL: https://codereview.chromium.org/1472823002 Cr-Commit-Position: refs/heads/master@{#361356}
-
peter authored
BUG= Review URL: https://codereview.chromium.org/1468043003 Cr-Commit-Position: refs/heads/master@{#361355}
-
alph authored
BUG=528489 Review URL: https://codereview.chromium.org/1468163003 Cr-Commit-Position: refs/heads/master@{#361354}
-
estark authored
BUG= Review URL: https://codereview.chromium.org/1473553002 Cr-Commit-Position: refs/heads/master@{#361353}
-
chongz authored
Also changed the API for the prefixed version to maintain compatibility between the two. This is an interop issue, Firefox bubbles the event while Safari does not, but I think we should match Firefox. See http://www.w3.org/TR/page-visibility/#sec-processing-model BUG=501821 Review URL: https://codereview.chromium.org/1435893003 Cr-Commit-Position: refs/heads/master@{#361352}
-
fs authored
Rename SVGPathTraversalStateBuilder.{cpp,h} to SVGPathQuery.{cpp,h}, and similarly rename the class itself. Move the query methods in SVGPathUtilities (getSVGPathSegAtLengthFromSVGPathByteStream, getTotalLengthOfSVGPathByteStream, getPointAtLengthOfSVGPathByteStream) to that class, shortening their names in the process. Open-code the SVGPathParser driver to allow the general SVGPathConsumer interface to be simplified - incrementPathSegmentCount and continueConsuming are only used for path queries. BUG=467592 Review URL: https://codereview.chromium.org/1471943003 Cr-Commit-Position: refs/heads/master@{#361351}
-
torne authored
JUnit/Robolectric tests run on the host without native code and so can't set the application context the usual way. Provide a test-only method to set only the Java-side context for this purpose. Move the assertion about not changing the set context to initApplicationContext because the JUnit tests will use a different mock context for each test case. BUG=552419 R=dgn@chromium.org Review URL: https://codereview.chromium.org/1474723002 Cr-Commit-Position: refs/heads/master@{#361350}
-
spang authored
The early return after PostTaskAndReply() in GLSurfaceOzoneSurfaceless::SwapBuffersAsync was erroneously removed in f960a950 ("Split up synchronous & asynchronous swap buffers APIs"). This adds it back. It also removes the else after return; that's against the style guide. BUG=560553 TEST=boot chrome on veyron_jerry Review URL: https://codereview.chromium.org/1475683002 Cr-Commit-Position: refs/heads/master@{#361349}
-
hpayer authored
Add repeat_delay_ms and repeat_count as configurable parameters to the infinit scrolling benchmarks. Twitter gets stuck most of the time when we scroll continuously. Non-continuous scrolling fixes the issue. BUG= Review URL: https://codereview.chromium.org/1471233002 Cr-Commit-Position: refs/heads/master@{#361348}
-
primiano authored
This reverts commit 587e7058 (crrev.com/1447213002) Reason for the revert: broke all Android perf bots. More context in crbug.com/560813. This CL is causing a null pointer deref in the browser whenever a renderer kill is detected: Thread 0 (crashed) 0 libchrome_public.so!breakpad::CrashDumpManager::Observe [crash_dump_manager_android.cc : 194 + 0x0] Found by: given as instruction pointer in context 1 libchrome_public.so!content::NotificationServiceImpl::Notify [notification_service_impl.cc : 123 + 0xd] Found by: call frame info 2 libchrome_public.so!content::RenderProcessHostImpl::Cleanup [render_process_host_impl.cc : 1790 + 0x1] Found by: call frame info 3 libchrome_public.so!content::RenderWidgetHostImpl::~RenderWidgetHostImpl [render_widget_host_impl.cc : 257 + 0x9] Found by: call frame info 4 libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 266 + 0x5] Found by: call frame info 5 libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 277 + 0x3] Found by: call frame info 6 libchrome_public.so!content::RenderWidgetHostImpl::Destroy [render_widget_host_impl.cc : 1465 + 0x7] Found by: call frame info BUG=560813,510327 NOTRY=TRUE TBR=skyostil@chromium.org,yfriedman@chromium.org,wnwen@chromium.org Review URL: https://codereview.chromium.org/1474543003 Cr-Commit-Position: refs/heads/master@{#361347}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1471253002 Cr-Commit-Position: refs/heads/master@{#361346}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b787e6bc..0164a63f Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1469803005 Cr-Commit-Position: refs/heads/master@{#361345}
-
https://codereview.chromium.org/1471123002Nico Weber authored
Also remove a few Windows newlines :-/ BUG=560836 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1470093004 . Cr-Commit-Position: refs/heads/master@{#361344}
-
agrieve authored
* Now targets all devices by default rather than failing * Allows --device flag to target a specific device BUG= Review URL: https://codereview.chromium.org/1469143002 Cr-Commit-Position: refs/heads/master@{#361343}
-
philipj authored
https://url.spec.whatwg.org/#api This changes the generated code, but ought not be observable, as any call to `new URL(x, urlObject)` will now instead behaves as `new URL(x, urlObject.toString())`. BUG=460722 Review URL: https://codereview.chromium.org/1464133002 Cr-Commit-Position: refs/heads/master@{#361342}
-