- 28 Jul, 2020 40 commits
-
-
Yuke Liao authored
The breakage was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2315863 lacros-chrome is built on Linux, but doesn't use x11, so this CL fixes the assumption. Bug: 1110072 Change-Id: I85293dd604a390d8cc97e5f03f637db40d1d5812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321237Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792423}
-
Jia Li authored
1. Added a Finch flag to enable/disable ML service. 2. Decoupled model storing and model loading in PredictionManager::UpdatePredictionModel to support async model loading. A model is now stored before it is validated and loaded, and will be removed if model fail to load. Bug: 1099371 Change-Id: I3d2e06e769601f5fcfde06f1d2af72f69f478e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319050Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#792422}
-
Nina Satragno authored
Stop and clear lottie animations when changing the animation-url. This prevents a visual glitch where the previous animation might show for a few frames while the new one loads. Fixed: 1104241 Change-Id: Id2015c8a374180eda33a8fd870611f224cae4e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317814 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#792421}
-
Jonathan Ross authored
Some alpha blending media tests are flaky with SkiaRenderer. In both Vulkan and GL. This change adds a Skip expectation for GL. This change also updates the note for the Vulkan expectations to refer to this being a bug and not just lack of rebaselines. TBR=backer@chromium.org TEST=vulkan_native_blink_web_tests, skia_renderer_gl_blink_web_tests media/alpha-video-playback.html Bug: 1094635 Change-Id: Id8cab6764c88f7d21e889ca7dd8554e43de3554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324486Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#792420}
-
Mario Bianucci authored
Start forwarding points from the browser process directly to viz via the UI compositor when delegated ink trails are being drawn. This CL gets the point to Display, the next CL will start storing the points and using them as they arrive. This CL only supports aura, follow up CLs will add support for Android and Mac. Bug: 1052145 Change-Id: Ic36d45bd960d358ececaf0312ce801da33686966 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259015Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792419}
-
Tim Song authored
BUG=1057204 Change-Id: Ie829a462889890d9fe57d47f9043a46759a26b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150077 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792418}
-
Sam Sebree authored
This change uses native_theme_base.cc and controls_refresh.cc to update the styling for the button native controls in dark mode. Bug: 1099624 Change-Id: Ib907a5a5887266c1bff3903b1b1c571e4dbc7aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311419 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792417}
-
Kevin Marshall authored
This reverts commit ed6fd705. Reason for revert: New WebRTC test failure on WebKit Mac10.13 test bot started after the new roll. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/31755 Original change's description: > Roll WebRTC from 0bb26390604e to 24a53a05a52d (3 revisions) > > https://webrtc.googlesource.com/src.git/+log/0bb26390604e..24a53a05a52d > > 2020-07-28 dminor@webrtc.org Fix division by zero in I420Buffer::CropAndScaleFrom > 2020-07-28 hbos@webrtc.org [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > 2020-07-28 sakal@webrtc.org Delete dead code from JNI audio header. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/webrtc-chromium-autoroll > Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1071733 > Tbr: webrtc-chromium-sheriffs-robots@google.com > Change-Id: I7f2478c5f1258a935467101742f6bd5cb5f68f56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323241 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#792358} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieced76c106cffe3dc7207eed3937356c3df51e5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1071733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324887Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792416}
-
Anastasiia N authored
On Chrome OS we should not change accounts using AccountsMutatorImpl. All methods except UpdateAccountInfo should be NOTREACHED. Bug: 1068240 Change-Id: Ib25550b82e8b81d7b58c0995a6809e148c4e3b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317351 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#792415}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595937363-e1ba3bb5d536598606cbf11f12f7443f2b2cf4cf.profdata to chrome-mac-master-1595959156-afb0fd7058e155b7eeff3c31fa05c2b8de5863d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6e6972596a12f618cd29105216a3fca636c13de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324483 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792414}
-
Dana Fried authored
Forgot to add field trial entry, but need to start testing. Bug: 1109256 Change-Id: Id4abe245625c4475885b3e899487bd9a1b25cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315798 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792413}
-
zhaoyangli authored
Makes test runner run XCTest based unit tests with correct test app, by testing args passed to test runner. Use xctest arg to determine runner type only, but not parser type anymore in test runner, except for special handling for WebRTC xctests with a TODO. Related CLs: - GN building the arg to test runner: crrev/c/2314134. - GN config change in some iOS FYI builders: crrev/c/2315638. Bug: 1001667, 1006881 Change-Id: I3fcd69f21641894f12e315898ce29059449b1b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315245 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792412}
-
Nina Satragno authored
The FIDO spec has renamed the uvToken parameter to pinUvAuthToken. The semantics haven't changed for our implementation, so simply renaming should be enough. Fixed: 1110106 Change-Id: I46a05f35c404acce842cc5341a8ec117f9d2af84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321548 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#792411}
-
Solomon Kinard authored
.gyp files were removed years ago for performance reasons. Bug: None Change-Id: I01fded482a7cde8dd0732e0724ff54316afebb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323961 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792410}
-
Mikel Astiz authored
The class has no dependencies to ProfileManager. R=nyquist@chromium.org Bug: None Change-Id: I67b998477a0dcff2970404f115d4118d018b9cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315153Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792409}
-
Josh Nohle authored
The method returns true if the CryptAuth app handler has been added to the GCM driver. This is particularly important to know when fetching Instance ID data (see crbug.com/1006280). Child CLs will utilize this method to confirm that the manager is listening before registering with GCM or fetching Instance IDs. --- This is ClientAppMetadata change-detection CL [1/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: Ifb08bc479b96e0ace0f85d27041a8259b9b29967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319327Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#792408}
-
Jonathan Ross authored
These tests began failing on GPU Windows 10 NVIDIA Quadro P400 bots. Originally this was seen just for no-use-gl, but the d3d11 angle versions are also failing. Extending the suppressions. TBR=ynovikov@chromium.org TEST=webgl2_conformance_d3d11_passthrough_tests conformance2/textures/misc/tex-3d-mipmap-levels-intel-bug.html deqp/functional/gles3/shadertexturefunction/texturesize.html conformance2/textures/misc/tex-mipmap-levels.html Bug: 1106078 Change-Id: I9e688fa581483c04bec4dcd897e0e2d3dc6f11f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323886Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#792407}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/469c2061cd49..cfacaaffd1fe 2020-07-28 tommek@google.com Adding support for the additional fixed sample mask in MSL (#1120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I285d90bb26edd9cd346280bd51be33cc23253eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322589Reviewed-by:
-
Richard Townsend authored
Improves checks around deferred parser scheduling to make sure that PumpTokenizer does not operate when the parser's stopped, improves parser termination to deschedule any pending pumps, and expands test coverage. Bug: 901056, 1106314 Change-Id: I03787e9a9e440fc9ce92d98040b1cdce3ea1ddc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302612 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
-
Yicheng Li authored
Add an InSessionAuthDialog class with a debug view, which currently is a text prompt and two buttons. The InSessionAuthDialog will show this debug view if the runtime flag show-auth-dialog-dev-overlay is set, and will show nothing otherwise. InSessionAuthDialog will be called by an AuthDialogController class (to be added in a follow-up CL).ash: Add a barebone AuthenticationDialog class Bug: b:156258540 Change-Id: Ib764399702ca557014b24faadf7855c4f9f39b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298527 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792404}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I1f750eadc953115462fcd276ec3ffb3bfb9808ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321052 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792403}
-
Robert Sesek authored
Change-Id: I780524c08cecbd6d6511db456ded0e3676cefc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308132Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792402}
-
Evan Stade authored
Bug: 1007823 Change-Id: Ia2aea90862946a5a6a8f95a9e5da76ed0241d876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324207 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#792401}
-
Ahmed Fakhry authored
In guest mode, Night Light used to be initialized from user prefs before NightLightClient was created, which made it miss getting the initial value of the ScheduleType. Therefore it never triggered a request to get the geoposition to update the correct sunset/sunrise times, and as a result the default 6pm to 6am were used. This made AutoNightLight always turn on for guest mode after 6pm, and since it's ephemeral, it doesn't have any cached geolocations. This CL fixes the order, however, getting the updated geoposition takes a second, so NL might turn on briefly for a second before it turns back off once the correct sunset/sunrise times are set. Hence, this CL also makes sure a stale AutoNightLight notification will be dismissed without affecting whether it should show again in the future. BUG=1106586 TEST=Added a new test. Change-Id: Ifbf0728ef5362bfbe88d50465943dce9fc0444fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321719 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#792400}
-
Rakib M. Hasan authored
expectations files to warning wpt_expectations_updater.py does not account for renamed or deleted generated tests when cleaning up affected tests from expectations during WPT imports. The wpt-importer only cleans up expectations for physical tests that were renamed or deleted in a CL. We will temporarily change this linter condition to a warning, until we can detect renamed or deleted generated tests in expectations for CL's. TBR=robertma@chromium.org Bug: 1110003 Change-Id: I4fcfddc5528d8591d56e10f84c752e7e460b706b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321057Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#792399}
-
Peng Huang authored
When context is lost, we may not end access of image_contexts_. So we should check context lost as well. Bug: 1110146 Change-Id: Ie233da02a67ac7e0ac3d3b63896f601d3e1780f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321544 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792398}
-
James Cook authored
Naming conventions for lacros are: * foo_ash runs in ash-chrome * foo_lacros runs in lacros-chrome * foo_chromeos runs in both We're going to use this positioning code in both, so rename to use _chromeos. WindowSizer itself has methods with Ash in their names, for historical reasons. Rename those as well. Fixing those methods is out of scope for this CL -- crbug.com/846736 tracks the cleanup work. Bug: 1109050 Change-Id: I263df5f0f2740b4560a78c08b2bcc56e1abefcf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321242 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#792397}
-
Michael Crouse authored
The rebuffer event will be observed based on a renderframe host rather than navigation handle. The navigation handle will have expired so we will need to support a GURL-based API rather than a navigation handle one. A future change will update the LiteVideoObserver to maintain a map of GURL to renderframe host and plumb the stop throttling update to the blocklist. Bug: 1101563 Change-Id: Idec5588a6a948c19a0318f08e555cb857404d584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316852 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
-
David Maunder authored
We should not be enabling the server fetcher for an incognito tab model due to privacy constraints. Bug: 1108571 Change-Id: I30b99d0fff8b85e3333f8c50f5bd8157f957e2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315241Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#792395}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/429aa812a02d..88f0ae369fef $ git log 429aa812a..88f0ae369 --date=short --no-merges --format='%ad %ae %s' 2020-07-28 rharrison Get 'gn gen --check' passing 2020-07-28 idanr Fix Tint ninja build 2020-07-27 dsinclair Remove StatementList. 2020-07-27 dsinclair [spirv-reader] Update to create BlockStatements 2020-07-27 dsinclair [wgsl-reader] Update to create BlockStatements 2020-07-27 dsinclair Convert LoopStatement to use BlockStatement. 2020-07-27 dsinclair Convert IfStatement and ElseStatement to use BlockStatement. 2020-07-27 dsinclair Convert CaseStatement to use BlockStatement. 2020-07-27 dsinclair Convert Function to use BlockStatement. 2020-07-27 dsinclair [spirv-writer] Add BlockStatement emission. 2020-07-27 dsinclair [msl-writer] Emit BlockStatement. 2020-07-27 dsinclair [wgsl-writer] Add emission of BlockStatement. 2020-07-27 dsinclair [ast] Add BlockStatement 2020-07-25 dsinclair [msl-writer] Emit intrinsics. 2020-07-25 dsinclair Remove KillStatement 2020-07-25 dsinclair [spirv-reader] Convert from KillStatement to DiscardStatement 2020-07-25 dsinclair [wgsl-reader] Add `discard` parsing. 2020-07-25 dsinclair [wgsl-writer] Add DiscardStatement support 2020-07-25 dsinclair [msl-writer] Emit DiscardStatement. 2020-07-25 dsinclair [spirv-writer] Add DiscardStatement support. 2020-07-25 dsinclair [ast] Add DiscardStatement AST node. 2020-07-24 sarahmashay [validation] Add a disabled test for re-assigning a constant. 2020-07-24 dsinclair Fixup some doc and compile issues. 2020-07-23 sarahmashay [validation] implement invalidate assignment to a different type. 2020-07-23 dsinclair Handle review feedback. Created with: roll-dep src/third_party/tint/src BUG=tint:123 Change-Id: I35c7a59699ac95f9012b2ecf353f26ad1e7cb0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323587 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#792394}
-
Greg Guterman authored
Change-Id: I87af37a90ce2d6bb286095ef848636639845c984 Bug: 1095060 Ignore-CQ-Freeze: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324802Reviewed-by:
-
Jan Wilken Dörrie authored
This change creates and registers the zxcvbn data component. Bug: 1104878 Change-Id: I0cb23e5253b5f030c6652234ef51082f7d9d6057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323331 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#792392}
-
liberato@chromium.org authored
This CL introduces media::Tuneable, which creates a tuneable parameter based on a finch field trial parameter. It caches the value to avoid redundant string conversions, and also has handy helpers for types that aren't supported by field trial params (base::TimeDelta). Change-Id: I8b1a6ec3ab0d7f5e36f8ebd496ae2c44e8cd414b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164227Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792391}
-
Mark Pearson authored
Retire: History.InMemoryDBKeywordURLPopulate History.InMemoryDBKeywordTermsPopulate Revive: History.InMemoryDBPopulate History.InMemoryDBItemCount Bug: 969934 Change-Id: If7391c4c16358d5dae54fe24175992e394aaf674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321832Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#792390}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ee5f2f1d331..7ab4564696a7 2020-07-28 johnkslang@users.noreply.github.com Merge pull request #2359 from dneto0/fix-warn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: Id285fbebd3d0110053edf5bc4e2127dec3374ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323243Reviewed-by:
-
Matt Jones authored
The only user of the onHideLayout signal was the OverlayPanel which has an alternate signal through SceneChangeObserver (which it now uses). The SceneOverlay method has been removed. Bug: 1100332, 882508 Change-Id: If2b476eb567451db5803bb0922f9ea2e3a0244ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320076 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#792388}
-
Wez authored
Change-Id: Ia6faa76726505fbaab87f5a76c3c98cbd2c6512d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323294 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792387}
-
OlivierLi authored
This allows selective activation of hang watching on the different supported threads. Bug: 1034046 Change-Id: Iac18db82d162cc88b4ca78134b74cfec96340e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288196Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792386}
-
ckitagawa authored
The overscollRefreshTest stopped crashing for a while, but then returned. I suspect a stale Assert.fail callback was to blame. This harness has been largely refactored so we will get a much clearer stack trace if there is actually a problem and there are no longer Assert.fail callbacks. Bug: 1093083 Change-Id: Icb804887c5ba77113fc7d0efaa479e807ccc84ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324362Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792385}
-
Mike Wittman authored
Adds a simple builder to create in-memory ELF images to support more comprehensive unit tests, and adds tests for scenarios which were previously untested. The ELF images produced by the builder have been validated by dumping their contents using eu-readelf. Currently the builder and tests only cover the relocatable case where virtual addresses in the file are the same as the corresponding file offsets. The builder and tests will be extended in follow-on CLs to support relocatable images loaded at an offset, and non-relocatable images. Also corrects a comment in the .cc which wrongly implied position independent code is not used within non-Fuchsia non-Android ELF files. Bug: 1105170 Change-Id: I35ae76beeb2ddb50602b0d28757673671990bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304664 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#792384}
-
