- 27 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/befe11cae7c1..ec788be8b577 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from df5ed61ddbca to 3f851efa2adc (5 revisions) 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6a8a74986c35 to 3b2cd31c7400 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Test: Test: Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSOTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdateTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPITest: Test: Manual script execution and building in AOSP Change-Id: Ibbaaa2cf381fc4a4792d4b500510eee5e313998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791773}
-
Maksim Sisov authored
Disables/enables tests for Ozone/Linux or non-Ozone/X11 ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I48797083cecf61929e10381d740590fc4584137d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315027 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791772}
-
Andrey Zaytsev authored
The 10 minute timeout logic follows: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit?ts=5ef0c30f#slide=id.g8a1bab3ac0_6_125 Bug: 1070620 Change-Id: I876c0b2981321d278747ad3eaaca09890a80cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317228 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#791771}
-
David Jean authored
Bug: 1109663 Change-Id: I6e61cb1d71e654ff359bf9a1d429719a2a920ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317877 Commit-Queue: David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#791770}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/browsing_data. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=dullweber@chromium.org Bug: 1106699 Change-Id: Idea748f489836737cfd60e5e8c4ad98662103680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315354 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#791769}
-
arthursonzogni authored
There are 4 tests with the reporting installed in the opener window. The expectation was wrong, because we expected the url to be the openee URL. Bug: chromium:1090273 Change-Id: I7b217d7548c8f5a2d41e5f879d11447c4a25f5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317211 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791768}
-
Andrey Zaytsev authored
Tested manually, including updates by hardcoding the Chrome app id values. Bug: 1070620, 1107387 Change-Id: I0631df830ff20c000c57235eab1dbd300645db24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307330 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Wei Lee authored
This CL abstracts the file system entry so that we can have two kinds of implementation: 1. Implementation which is used by chrome.filesystem and File and Directories API 2. Implementation which is used by NativeFileSystem API Bug: 980846 Test: Check CCA works normally as a Chrome app Change-Id: I87d1c121951152e0975f10d8b43787f6a279f186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237545 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#791766}
-
Daniil Lunev authored
Adds the purpose of the device Corresponds to the following platform CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2241226 BUG=b:151176984 TEST=unittest Change-Id: I55dc88271c3c90cf4bf85db3d0b9c7fe4f641e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298759 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791765}
-
Yuki Shiino authored
Improves the progress print so that the intention will be a little clearer; when the bindings code generation finishes, leave the last message on the console. When https://crrev.com/c/2081633 will land, the bindings code generation will be very long (a few minutes). It could make Chromium developers wonder if a build completely stops. Hope that printing the progress would prevent such a concern. Bug: 839389, 1108111 Change-Id: If556010d2d3469c5e0ded6d9b96fa6a5ffc26764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313816Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791764}
-
Antonio Sartori authored
This CL implements the check of whether a string is a valid 'csp' attribute according to https://w3c.github.io/webappsec-cspee/#iframe-csp-valid-attribute-value in the network CSP parser. The check is still incomplete, since it relies on the Subsume algorithm that will be implemented in future CLs. This function will be used by the AncestorThrottle. Bug: 1094909 Change-Id: Id325b203ba4269e542fd7b9b144da55c3e4e52d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315683 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791763}
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of frame.h by 6.61MB. - frame.h should use user_activation_notification_type.mojom-blink-forward.h instead of frame.mojom-blink.h. - user_activation_state.h, which is included from frame.h, should use user_activation_notification_type.mojom-forward.h instead of user_activation_notification_type.mojom-shared.h. This CL has no behavior changes. Bug: 242216 Change-Id: Iae968c3a820a3d327ff46bf017dbd72dc77c3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319496Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#791762}
-
Adrienne Walker authored
It is too fiddly to try to estimate the sizes of idb keys and values and try to hope that they are the same size that mojo will use when serializing. However, even if getAll is not recommended, it is not spec complaint to throw an error when getAll is trying to return too much data. By chunking the results from getAll across multiple mojo messages, we can always have getAll succeed for any size and not have to try to explain this edge case to users or try to guess how big sizes are. Bug: 1103849 Change-Id: Ic187b0bbfaefda15e9a50a845ba9bcf34f111faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305003 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791761}
-
David Jean authored
Bug: 1109644 Change-Id: Idc8fa6d46d7b147d1c5704546a66b812ee85900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317953 Commit-Queue: David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
-
Ewann authored
This Cl makes the bottom toolbar visible when initiating a drag down to close a modal setting view. Bug: 1106665 Change-Id: I2011d4e8f07c197c7c876bfc1dbbc40226d25f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308713 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#791759}
-
Jonathan Mengedoht authored
Add lookup logic for ChangePasswordUrlService, implement Callback for the gstatic fetch and test the url lookup logic. Bug: 1086141 Change-Id: I6992cc891d2e43f9e0091f82c53b624f8f277ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285125 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791758}
-
Roman Sorokin authored
Flaky test TBR=apotapchuk@chromium.org Bug: 1109651 Change-Id: I751e66813be2200ada35d9c600c4b03b40822b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317955 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791757}
-
Monica Basta authored
The profile color will be used by different screens (Sign in promo, local profile customization, may be sync promo) that belong to the profile creation flow. This CL provides the pipeline to request the new profile color from native and passing it to the sign in promo component. A smarter profile color picking will be implemented in the future. Bug: 1063856 Change-Id: I7f066656897ff1da6292414bba53e34613368dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310671 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791756}
-
Ewann authored
based on: https://crrev.com/c/2300383 This CL updates the link label used to display the TOS string to an UITextView. A sublcass is needed to override the |canBecomeFirstResponder| method. On iOS 13,we can't override |canBecomeFirstResponder| or the whole string will responds to a tap. On iOS 12, the whole string responds to a tap if we use this current implementation. Bug: 1102996 Change-Id: Id9c9e3089d07a056c365043e1d60b1b558586ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302900 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#791755}
-
Friedrich Horschig authored
Instead of using the factory directly in the fragment, the parent activity will now check whether the newly attached fragment has a known component and creates it using the factory. The functionality and visible behavior is unchanged. Bug: 1101256, 1092444 Change-Id: If430d33d9c895eeed1503253ff5a279cfeae394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315149 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Theodore Olsauskas-Warren authored
Bug: 1105386 Change-Id: I90e63a857b9f2fb3f4be7ea339fd168f71125a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317226Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#791753}
-
Rainhard Findling authored
* This CL aligns the Chrome cleaner child element behavior in the 'safe' states with the latest mocks. Bug: 1087263 Change-Id: Ie4c36cf6d45c80f421b191758aeadadab8d04280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282401Reviewed-by:
-
Hirokazu Honda authored
GpumemoryBuffer based VideoFrames are input to VideoEncodeAccelerator in ARC++ and also Zero-Copy case. This adds a test case where the input VideoFrames is GpuMemoryBuffer based one and its pixel format is NV12. Note that our product code strongly assumes the pixel format is NV12 in Zero-Copy path. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: Ifb894b39c40a2229209c3dd5884a16d7b033e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260133 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#791751}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib6c3a73c6edec1a92d0b7d7c71fe4aba3bb8d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319973Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0b2923dc9d6..f4f0170b8694 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I2697459f26ffe030be08da4f206d27515d49b496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791749}
-
Kenichi Ishibashi authored
This also changes the type of |origin| from GURL to url::Origin to avoid unnecessary GURL -> url::Origin conversion. Bug: 1055677 Change-Id: Ie9d00e944f0954a1efc23c9e144087f04486a289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319810Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Mikel Astiz authored
No behavioral changes: this patch moves BookmarkLoadDetails into a dedicated file and bookmark-loading logic is moved from BookmarkStorage to ModelLoader. Even prior to this patch, class BookmarkStorage only implements the saving parts, and there's little reason for the loading logic to coexist in the same file (since actual encoding/decoding takes place in BookmarkCodec, yet another class and file). While moving the code around, the presubmit warning surfaced two UMA metrics that were instrumented but were not listed in histograms.xml. Change-Id: I5629d10694068574322458e72c38970992410a88 Bug: 1108803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315892 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Roman Sorokin [CET] authored
This reverts commit 46a70005. Reason for revert: fails on multiple builders (https://crbug.com/1109637) Original change's description: > Re-enable flaky TranslateIframe test and add extra debug information > > This test has been disabled in https://crrev.com/c/2303433 due to it > being flaky. However its stack trace matches the one observed recently > in production code (crbug.com/1107103) so we're re-enabling it now and > adding some extra debugging information in order to help us fix the > issue, as it hasn't been possible to reproduce it locally so far. > > Bug: 1107103 > Change-Id: Ifeee8483c83e72b52a232b71ef2437ecab6bf305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316101 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Auto-Submit: Mario Sanchez Prada <mario@igalia.com> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791714} TBR=dmazzoni@chromium.org,hajimehoshi@chromium.org,mario@igalia.com Change-Id: I2f2cde72fa5c6e39dacaf819d96ac30bf22ef34f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107103 Bug: 1109637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317951 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Noel Gordon authored
A volume label can be the first part of a breadcrumb path - that label can contain a '/' which the breadcrumb uses as the path separator when splitting a path into it parts (components). Volume labels like "Nexus/Pixel (MTP)" break the breadcrumb's '/' path splitter (see bug). Escape the path '/' splitter in location line, before sending the path to the breadcrumb. The breadcrumb can then correctly split the path on '/' and compute its parts. When presenting the parts in the breadcrumb UI, window.unescape() them first to undo location line escaping. Add a new unit test fixture testBreadcrumbRendersEscapedPathParts() to test the breadcrumb path character unescaping behavior. Bug: 1094105 Change-Id: I25f7622d31a72458412a0a5271ffb3aa1d5b69ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317246Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791745}
-
Hitoshi Yoshida authored
In concept, we would like constant dictionaries' getters to return constant references. However, it can be harmful for developers to make some sorts of types, e.g. interfaces, constant. This CL makes it to return a non const reference for those types. Bug: 839389 Change-Id: I33d4e378e278baf5620c3d8cac39b65a0e590cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301712 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791744}
-
Roman Sorokin authored
on linux-chromeos-chrome TBR=pmarko@chromium.org Bug: 1109635 Change-Id: I68d32a42daf98d1791154eee54516e47703e116a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317790Reviewed-by:
-
Mikel Astiz authored
Overriding HistoryService and BookmarkModel after the profile has been created is problematic and known to cause hard-to-debug test flakiness. Instead, this patch adopts TestingProfile::Builder for tests in chrome/browser/history/android. For convenience, and in particular to avoid having to include components/sync_preferences/pref_service_syncable.h in each test file, TestingProfileManager is now extended with a new overload for CreateTestingProfile(). Change-Id: I209697d2f8dafa6529b5b1e0e394fb5ba064a84a Bug: 1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315681 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Bug: 800764 Change-Id: I539c963f57850f888b6d5d36639206e606f2f500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315482Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791741}
-
Hitoshi Yoshida authored
After shipping the new code generator for IDL dictionaries, some tests fail with accessing missing dictionary members. This CL fixes them. Bug: 839389 Change-Id: I0d09a4c73edaf5f3195872f21cefe93a65970a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#791740}
-
Alice Wang authored
This CL moves GoogleServiceAuthError from sync package to the signin component package and mirrors the fields in the native class, so that we can use it when implementing IdentityManager.Observer#onAccountsInCookieJarUpdated. Bug: 1093741 Change-Id: I2b0c9b1824e032284f6d3511d38513b6849d3838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307332Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595807480-d008dd705c9cf90df13ad0e43c19aa435d2837a8.profdata to chrome-mac-master-1595829164-c22b50893110427f86ce6cde1b20f409df22cb84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Iec516c709f72f7c6d2b2f3fc8fe2dd1b8f3d3386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319977Reviewed-by:
-
Honglin Yu authored
Also roll the edits on mojom in CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2291868 BUG=chromium:1086044 TEST=on device (eve), can call langid function TEST=in the chrome://machine-learning-internal webpage. Change-Id: I8abdeac7e318397069bf7961ad4ae43667df15eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289573Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791737}
-
sauski authored
Extends Access Context service and database to delete access records with timestamps that fall within an observed history deletion time range. Bug: 1101675 Change-Id: I49e0fdfc4d638c6d065d63a188da57ae5ab9ffca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312699 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791736}
-
Jit Yao Yap authored
This CL merges AppListClient::OnFolderCreated() and OnPageBreakItemAdded() into OnItemAdded() which triggers when any AppList item (app, folder or page break) is added. AppListModelUpdater::OnFolderCreated() and OnPageBreakItemAdded() are merged into OnItemAdded() accordingly. Bug: 1101208 Change-Id: I5973eed4778e8fd98d04ce5b36c49bbe476b6bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306039 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791735}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e490afec61da..e5505fa8a8ca 2020-07-27 changhaohan@chromium.org Use filter value autocompletes for backdrop-filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1014289 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92ed0560128115544cde13f9e144ab08d5267a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319969Reviewed-by:
-
