- 27 Aug, 2020 40 commits
-
-
rbpotter authored
Proof of concept CL updating Print Preview to use the new grit_preprocess build rule to generate inputs for rollup, instead of generating a pak file and unpak folder from the grd file. Bug: 1071641 Change-Id: Ic9a15c6c546be979ce68ad4d90537c142163a024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370162Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802281}
-
Omer Katz authored
See comments in the issue for explanation of the crash. Bug: 1114579 Change-Id: Ic8158b53f5de1b0239003202bafb654e6584fad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379757 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#802280}
-
Charlene Yan authored
Bug: 1080383, 10182301 Change-Id: I57a65bfeabfa0a854f0585b0f1571be48bc1a73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377233 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#802279}
-
Eric Willigers authored
Add feature use counters for calls of Navigator methods openTCPSocket, openUDPSocket Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Bug: 1119681 Change-Id: I5570c87d73985429e0475cc9e97bea355c926176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367253 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#802278}
-
Aaron Leventhal authored
Bug: 1091178 Change-Id: Ia6e82b1fcab8f08dbb3dff6186a8ab04e5a4f127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376307 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802277}
-
Guillaume Jenkins authored
The CloudReportingEnabled policy controls whether cloud reports are sent to the Admin Console. It is still an experimental policy on iOS. When testing the CBCM flow via experimental settings, that policy was never allowed in the list of experimental policies, so it was ignored. That prevented testing cloud reporting. This change simply adds the CloudReportingEnabled policy to the list of allowed experimental policies if a CBCM enrollment token is provided via the experimental settings. This change also clarifies comments and variable names around policy about:flags to make it easier to understand what's going on. Bug: 1122005 Change-Id: Iec6ecf7b4ef7a2a8bed60dbd82b73a474a70cd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377896Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#802276}
-
Stepan Khapugin authored
Adds a blurred background, uses localized strings, supports dark mode. Bug: 1072408 Change-Id: I3806765e99ec6d93776bea7e932426a4cff238c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353256Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802275}
-
Etienne Bergeron authored
This CL is boosting the thread priority to avoid loading the DLL at background priority. https://bugs.chromium.org/p/chromium/issues/detail?id=973868#c43 Noticed in crash/4f4d3d0215060b7e The following stackframe is the cause of the priority inversion: LoadLibraryExW [...] CDeviceMoniker::BindToObject media::VideoCaptureDeviceFactoryWin::CreateDeviceFilterDirectShow media::VideoCaptureDeviceFactoryWin::GetDevicesInfoDirectShow media::VideoCaptureDeviceFactoryWin::GetDevicesInfo media::VideoCaptureSystemImpl::GetDeviceInfosAsync video_capture::DeviceFactoryMediaToMojoAdapter::GetDeviceInfos video_capture::VirtualDeviceEnabledDeviceFactory::GetDeviceInfos bluetooth::Socket::Disconnect [...] base::internal::WorkerThread::RunWorker() base::internal::WorkerThread::RunBackgroundDedicatedCOMWorker() R=joenotcharles@chromium.org, Bug: 973868 Change-Id: I8f3d6b2cb8f94731148f827ffda4a201ebf9543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378395Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802274}
-
Himanshu Jaju authored
This is a reland of 48f89230 Original change's description: > Handle click on success notification. > > Handles action on success notification as follows: > - Copies text to clipboard > - Copies image to clipboard > - Opens downloads folder for multiple files > > Bug: 1085069 > Change-Id: Ie26712e0195a261cade102a74037611f11fa5dab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375250 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802213} Bug: 1085069 Change-Id: Icf6eeea97adb4aa2a03b27a53b9fd633c02115b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379778Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#802273}
-
Ryan Hansberry authored
Change-Id: I475a14e26cf0a8ca60858b5d1388b1daad0dff1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380310Reviewed-by:
-
Dave Tapuska authored
Emil you will be sorely missed. Thanks for all your contributions, stories and mentoring fellow peers. Change-Id: I0b4fb622bf6038346c76cdf3c11fcb74c2474c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379952 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802271}
-
Dirk Pranke authored
Apparently the 'chrome_sizes' step is only run on the internal official builders, and so we've only just now realized that one of my generic_wrappers changes {#799880} broke things on Windows. I didn't realize that code path was even running on Windows yet. This CL should fix it. Bug: 1122334, 816629 Change-Id: If564ac2db13402358f39849be26c050d7511b388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378458 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#802270}
-
Klaus Weidner authored
In SurfaceControl mode on Android 11 (R), the transitions into and out of WebXR mode with DOM Overlay active were leaving unexpected stale ChromeNativeWindowSurface/ChromeChildSurface pairs in SurfaceFlinger. This change skips recreating the surface if it's transitioning from TRANSLUCENT to TRANSLUCENT where the same surface can be reused. Bug: 1122103 Change-Id: I65d2cf3b69467468824b2c03b554e94849032c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378653Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802269}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f48854dae26..ec3650f56ca2 2020-08-27 srisser@google.com Add getPhysicalDeviceFeatures2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0ba22fe2ca4134e09cb5de865fc17644a23f8e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802268}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3467211f5c0..ecf0d2c0f651 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gogerald@google.com,hkamila@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gogerald@google.com,hkamila@google.com Change-Id: I7cd5223c08589a42d13ad18a7d7affea95cfa16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380014Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802267}
-
Tom Anderson authored
This is needed after [1] changed the libwayland-client symbols file. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674 R=msisov Change-Id: Iffada22847663b5a9ca3973d45f7a0a2c93fedd5 Bug: 1116384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380370 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802266}
-
Dean Michael Berris authored
This change updates the responsibilities for the performance regression sheriffs given the new automated process for triage and bisection. This removes the need to proactively poll the alerts page in the Chromperf Dashboard, and instead moves the sheriffing rotation to a reactive model handling Monorail issues. R=tdresser@chromium.org Change-Id: Icb6e58052bd1c7480b57c341438a23b560120000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378408 Auto-Submit: Dean Berris <dberris@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#802265}
-
Hongchan Choi authored
* Security Review (googler-only): https://groups.google.com/a/google.com/g/web-audio-team/c/Xlj3LL6ywPE/m/OlbhlGFLBgAJ * Platform Architecture Review: https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/sxpZizgpDFM/m/6X0jJTg9AwAJ This CL changes the threading model of AudioWorklet: 1. An AudioWorklet spawned from an AudioContext from a top-level document will run on a real-time priority thread. (RealtimeAudioWorkletThread backed by per-process singleton) 2. An AudioWorklet spawned from an AudioContext from a sub frame will run on a DISPLAY priority thread. (SemiRealtimeAudioWorkletThread backed by per-process singleton) Note that the RT thread flag can override the logic and will match the RealtimeAudioWorkletThread even for a sub frame. 3. An OfflineAudioContext will use a background priority thread for the worklet script processing. (OfflineAudioWorkletThread backed by per-process singleton) 4. In a frame, AudioWorklets with same thread type will share a single backing thread based on its RT constraint and the frame level. In other words, the maximum number of backing threads is 3. (Realtime:REALTIME_AUDIO, SemiRealtime:DISPLAY, Offline:BACKGROUND) Confirmed the repro case in 1051922 is fixed with the patch. Bug: 813825,1051992,1090245 Test: audio_worklet_thread_test.cc Change-Id: I6f5994a5114839d5a25ae99bc18474db44789bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353531 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802264}
-
Rouslan Solomakhin authored
Before this patch, the secure payment confirmation UI was available only through a Chrome flag that unilaterally changed Chrome's Web Payment UI to be the secure payment confirmation dialog, regardless of which payment method the merchant requested. This patch makes the secure payment confirmation UI controller implement the existing PaymentRequestDialog interface, so it can be used interchangeably with the existing browser payment sheet. The controller also implements InitializationTask::Observer interface in order to observe when PaymentRequestState has found all payment apps on device and PaymentRequestSpec has the finalized total amount. Also in this patch: real values from PaymentRequest are displayed in the secure payment confirmation UI. Also in this patch: WebAuthn result is serialized into JSON stringified string, which is sent to the renderer process for the merchant. The byte arrays are base64-encoded into strings. After this patch, secure payment confirmation UI is used only when secure payment confirmation method was requested and it is the only payment method being requested. Bug: 1121745, 1121687, 1121689 Change-Id: I3e77f693513ef620a7c296d2744e609297703aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378271 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#802263}
-
Ben Wagner authored
Move anchor search logic from ElementFragmentAnchor::TryCreate to TreeScope::FindAnchor. This changes 'FindAnchor' to take a URL fragment instead of a name and search for the anchor as was previously done in TryCreate. Moving the logic consolidates the lookup behavior which would otherwise need to be shared between all the callers of FindAnchor ElementFragmentAnchor::TryCreate AXNodeObject::InPageLinkTarget NGFragmentPainter::AddURLRectIfNeeded PrintContext::CollectLinkedDestinations ObjectPainter::AddURLRectIfNeeded The last three of which share additional logic which may need to be factored separately. Note that this also handles the special empty or "top" anchors (which have a destination at the top of the page). Tests are added for the parts of scrolling, printing, and accessibility which use FindAnchor to ensure that they work properly with codepoints outside 7 bit ASCII and the implicit "top" and "" anchors. Accessibility tests updated now that '#' is correctly an internal link. Bug: chromium:985254, chromium:1117212 AX-Relnotes: Anchors with non-ASCII characters now work as expected. AX-Relnotes: "#top" and "#" anchors link to the top of the document. Change-Id: I23830fa47f857cbc0f41f857748c8615cf5a63b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357250 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802262}
-
Mila Green authored
Since on macOS there is no meta installer, the flow to installing an updater is the following: 1. Chrome (or other app) is drag installed. 2. It tries to register itself with the updater. It does that by running its bundled updater, with the --register --app-id=... --version=... command. This is done over RPC, so if there is an updater on the system, it will get the call. If registration is successful, no other action is needed. 3. If no updater is present, the bundled updater will: 3.1. Install itself 3.2. "wake" itself, so that it is promoted. 3.3. Register itself for updates 3.4. Register the app (Chrome, etc.) for updates. Bug: 1109231 Change-Id: I6e3f31ffbb6eaa6334bd9caa708b3b37f883d674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350191 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#802261}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7d194407e8b0..0c589cca4eff 2020-08-27 wolfi@chromium.org [Frametree] Add icons to links in FrameDetailsView 2020-08-27 tvanderlippe@chromium.org Typecheck bindings/DebuggerLanguagePlugins.js with TypeScript 2020-08-27 szuend@chromium.org [ts] Type-check sdk/CPUProfilerModel.js with TypeScript 2020-08-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-27 tvanderlippe@chromium.org Typecheck services/ServiceManager.js with TypeScript 2020-08-27 changhaohan@chromium.org Add UMA for showing sidebar panes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093247,chromium:1119895 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec721820c907d781b53acdd90d7b31225aaf599e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379970Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, payment credential was not being stored, so Web Payments could not invoke secure payment confirmation. This patch stores the payment credential in SQLite database. After this patch, Web Payments can invoke secure payment confirmation for the credential that is stored in the SQLite database. Bug: 1121336 Change-Id: Iffbb93a50095d961b5191b3b6c936ee052b5bf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375892 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802259}
-
nohe@chromium.org authored
This adds a private file api to handle copying images to the system clipboard. This is extended so when users click the copy button in the Chrome OS files app, the file is copied to the system clipboard and can then be pasted to different types of applications. This change will present a similar solution to that of copying an image in the browser to the system clipboard via the right click > copy image. This feature is currently experimental and will be added behind a flag in the frontend. Bug: 827333 Change-Id: I85b98b4f35151d0146a0c79b93976822c663651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317029 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802258}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a8327d441549..3d3b531b64fa 2020-08-27 jonaso@webrtc.org Add WebRTC-IceFieldTrial send_ping_on_selected_ice_controlling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic1e6f8ba1445628fecea287d0da6d9078b622906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380013Reviewed-by:
-
Benoit Lize authored
It is only used to get an estimate of the content area size. Move this to TabUtils, delete the rest. Change-Id: I97cb80556a318730d4bd3a0651eecb824b755614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368358Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802256}
-
Peter Kasting authored
* Sets dialog margins correctly. * Sets body text context correctly. * Replaces Grid with Box since no one likes GridLayout; this fixes bug 1119305 as a side effect since BoxLayout lays out StyledLabel at times/widths more like what it wants. * Uses "v* = AddChildView(std::make_unique<V>(...));" idiom. * Lays out the "checkbox" contents more like a real checkbox: with the border around the outside of everything. This removes the need for a label vertical alignment hack and corrects the excessive spacing between checkbox and label. * Makes Checkbox overrides of public methods public; this was necessary anyway to do the above. Bug: 1119305 Change-Id: Ia7afa6ffeaeeab9ad407acbacaacc937f1fb842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377066 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#802255}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/09ec5ae5729e..b90423b45298 2020-08-27 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-26 bhanumaiya@google.com zork: add factory branch builder 2020-08-26 bhanumaiya@google.com Fix lint issues in config/chromeos_config.py 2020-08-26 vapier@chromium.org cros lint: disable old-division with --py3 2020-08-26 ahassani@chromium.org Revert "cros_update: Delete it." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iac4f56a59ec9f1654feece31a2705a2d8dfe229a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380016Reviewed-by:
-
Findit authored
This reverts commit fb578abb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 802242 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZiNTc4YWJiNDExMTA5ZDQ1ZDU3MDJhMGI0Yjk5ZTE0YzVlMzNmMWUM Sample Failed Build: https://ci.chromium.org/b/8870798522002653936 Sample Failed Step: compile Original change's description: > [Nearby] Refactor NearbySharingService Send* methods > > Instead of SendText and SendFiles methods this now has one unified > SendAttachments methods to make it easier to handle Attachments coming > in from the UI. Also hooks it up through the DiscoveryManager all the > way to NearbySharingService. File URLs coming from the ShareSheet on > ChromeOS are converted to FileAttachments. > > Bug: 1085067 > Change-Id: I61ce93842920ffa303ee71f4373c237b113948bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378026 > Reviewed-by: Alex Chau <alexchau@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802242} Change-Id: Ib83a828cb16f771dc3d7b17b1aea5469949040be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380193 Cr-Commit-Position: refs/heads/master@{#802253}
-
Charlie Hu authored
This CL uses PolicyValue::CreateType(T) to replace PolicyValue::PolicyValue(T, Type) constructor call. Change-Id: I6219a5446620785a596210b25509b28a2052730f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375765 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802252}
-
Aaron Leventhal authored
- Do not use author-supplied names of embedded controls - Use the value from the embedded controls See https://github.com/nvaccess/nvda/issues/1282 Bug: 1121637 Change-Id: Ia4d175052c8279d10eec2d2e30f5d784c0b66d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374514 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#802251}
-
Orin Jaworski authored
This CL prevents Pedals from attaching (or moving to) matches with entity type because entities with unrelated buttons are confusing. Bug: 1122202 Change-Id: I02babd21cc2b86e2a9411f20a6d5c21bf2ee910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378762 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802250}
-
Morten Stenshorne authored
Forgot to add support for rendered legends in LayoutObject's ContainingBlock(); only did it for Container(). We were also missing support for AncestorSkipInfo. Not sure if it's causing any problems, but it would be pretty scary to leave it like that. Bug: 875235, 786475 Change-Id: If7d8e6a299cce1def02164b33305b29414e978cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377870 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802249}
-
Ganggui Tang authored
This reverts commit 48f89230. Reason for revert: Compile failure, https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/99068? Original change's description: > Handle click on success notification. > > Handles action on success notification as follows: > - Copies text to clipboard > - Copies image to clipboard > - Opens downloads folder for multiple files > > Bug: 1085069 > Change-Id: Ie26712e0195a261cade102a74037611f11fa5dab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375250 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802213} TBR=knollr@chromium.org,himanshujaju@chromium.org,vecore@google.com Change-Id: I8da2ef7a5a9845370134e1febe8d69ed11db84d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380073Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#802248}
-
George Steel authored
Previously, we compared the zoomed property values (as stored in ComputedStyle) for speed when deciding whether to start a transition. When zooming, the comparison now calculates computed values using the serialization logic (which unzooms the values) and compares them as CSSValues. The fast PropertiesEqual comparison is still used in the absence of zoom changes. Bug: 1030239 Change-Id: I39fded593e7bed5c2eca6ec48b90d5aaec63857c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369433Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802247}
-
George Steel authored
Prevents event from being fired when the CSS of finished animations is cleaned up. This behaviour now matches the spec and firefox. Bug: 1122071 Change-Id: I18f0aa22512d304312cbd2908b18bedebff05c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378457Reviewed-by:
-
Edward Jung authored
interstitial Improve the suggestion by asking the user to check for typos in the URL. Bug: 1109671 Change-Id: Ie3a8c21255ce858b26f2bd8b8ffea3b123ac0970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376824Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#802245}
-
George Steel authored
Eliminates false positive count due to cleanup of style by js after transitions finish. Bug: 934700 Change-Id: Id901f4b19f5e858f1e218b28688923436a876933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376377Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Matt Jones authored
This patch changes the concept of height that the bottom sheet is allowed to scroll through. Instead of using the container height and applying the toolbar shadow in various places, we now factor the shadow into the maximum offset that the sheet can scroll. With this, both clients that use "wrap content" and fixed ratios behave correctly on large and small screens. Bug: 1115770 Change-Id: I43fc0083d7b2c3639e017237b9695fe2b7884a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372811 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802243}
-
Richard Knoll authored
Instead of SendText and SendFiles methods this now has one unified SendAttachments methods to make it easier to handle Attachments coming in from the UI. Also hooks it up through the DiscoveryManager all the way to NearbySharingService. File URLs coming from the ShareSheet on ChromeOS are converted to FileAttachments. Bug: 1085067 Change-Id: I61ce93842920ffa303ee71f4373c237b113948bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378026Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
-
