- 14 Dec, 2017 40 commits
-
-
Hajime Hoshi authored
We plan to deprecate kUnspecedTimer / kUnspecedLoading / kUnthrottled and introduce kInternal* for internal usages. This CL introduces kInternalTest for tests or mock objects and replaces the current task types with kInternalTest. Doc: https://docs.google.com/document/d/1n9qNbP0H28J4DIzorydemc36b1xy-8-5zEADsoJfMxU/edit# Bug: 794123 Change-Id: If4e616d9b770ff0e5be88261e68c3fd572d05783 Reviewed-on: https://chromium-review.googlesource.com/822792 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524024}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I5a509bbf7a893b336b610ac0c95e5bdf768694b6 Reviewed-on: https://chromium-review.googlesource.com/826108Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524023}
-
Tomasz Mikolajewski authored
1. Remove mtomasz from OWNERS. 2. If the last one, then add fukino@ and yamaguchi@. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b7c36f45575aad15a08e63ba7d7c52d6f8d3000 Reviewed-on: https://chromium-review.googlesource.com/816644Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#524022}
-
Jun Choi authored
Changed UTF8 encoding check function in CBOR decoder to include bytes after first embedded NULL byte. Failed cluster fuzz test case : \63\00\00\A6 Bug: 793587 Change-Id: If519678d29568451c121617a2b02079345a14307 Reviewed-on: https://chromium-review.googlesource.com/818731 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524021}
-
Max Morin authored
RenderFrameAudioInputStreamFactory is intended to be exposed to the renderer. The AudioInputStreamHandle class is introduced to bundle a stream and its client. When moving to the audio service, the AudioInputStreamHandle will stay in content/ while the MojoAudioInputStream will be in the audio service. This diagram shows how we want the stream setup to look in the near future: https://docs.google.com/drawings/d/1pSYEqiG46N0OD6rJhfTpohyn2ZkSWsp3ZIHe2PDh0Us/edit Bug: 653871 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4ff52dbc4797b595e3dd791d1bafa9325a0af9d2 Reviewed-on: https://chromium-review.googlesource.com/771196Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524020}
-
Scott Violet authored
EasyResizeWindowTargeter may be used to shrink the region of a window you can interact with (the shelf uses this in certain modes). For mus we only support this with a hit-test mask. This patch wires up EasyResizeWindowTargeter to use a hit-test mask when necessary. BUG=775223 TEST=covered by test Change-Id: I3e1b494e890f0f8366ce4a8a1fc64f839a61542f Reviewed-on: https://chromium-review.googlesource.com/826032 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524019}
-
Xiaohan Wang authored
Given read can be done asynchronously, if decoder Reset() if called while there are outstanding reads, Reset() could be called before Decode() causing out-of-order issues. This CL adds a Flush() call on MojoDecoderBufferReader such that decoder Reset() will only be called after all outstanding decodes have been processed. BUG=792281 TEST=Add even more tests Change-Id: Iaaf5073fcda6c78f85c0d624f1ad11566c8c726f Reviewed-on: https://chromium-review.googlesource.com/823574 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524018}
-
Luciano Pacheco authored
Convert and merge FrameHostMsg_SmartClipDataExtracted now using Mojo callback directly. Bug: 786836 Change-Id: If2925e9e019854558f8c97cf51e6b0d32b521345 Reviewed-on: https://chromium-review.googlesource.com/804804Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
junweifu authored
Load com base functions dynamically at runtime with core_winrt_util. Text Detection only support Latin-1 text as documented in specification[1], the service can't be connected if the language isn't supported on the system. Create OcrEngine interface that provides optical character(OCR) functionality. Add unittest to test the result of Creating OcrEngine. [1] https://wicg.github.io/shape-detection-api/text.html#text-detection-api BUG=790931 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I4e171aad11a50197c7cfb64547defa24d0988f3e Reviewed-on: https://chromium-review.googlesource.com/813237 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524016}
-
Hiroki Nakagawa authored
Bug: 794837 Change-Id: I429e94757e3d486b32c1ec204ed027f18f0ae1e5 Reviewed-on: https://chromium-review.googlesource.com/826830Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524015}
-
Victoria Su authored
Implemented :any-link by firstly editing pseudo names for :-webkit-any-link then using the previous name for :any-link. This feature has a use-counter. There are also web platform tests for :any-link and :-webkit-any-link and unit tests for the use-counters. Design doc: https://docs.google.com/document/d/1BzEliD8e8AaAbEiU5lVyaJT341DQrZwktXz59C5HrUE/edit?usp=sharing Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dJkNHglu1Z0/eodHxUDdAgAJ BUG=788265 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia17e65588496e561e45fae3216183d93e25ffed4 Reviewed-on: https://chromium-review.googlesource.com/807834 Commit-Queue: Victoria Su <victoriaytsu@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#524014}
-
Yutaka Hirano authored
We've been using IPC::Message in URLLoaderClientImpl to implement the "deferred loading" feature. This CL replaces it with custom containers having callback parameters, in order to remove IPC messages defined in resources_messages.h. Bug: 788241 Change-Id: I3b5863aa2604c2f3d56c3c0481d88ef865f91b28 Reviewed-on: https://chromium-review.googlesource.com/826882Reviewed-by:
-
Thiemo Nagel authored
Revert of "Cache the brand code to avoid hundreds of repeated reads." commit 04749717. https://codereview.chromium.org/2890943005 Disabling RLZ is communicated through an empty brand code. Thus the value of the brand code must not be cached before RLZ is initialized. BUG=793162 TEST=none Change-Id: I7f9e223a9a39d19408f364f6aad95cb8c86f6d79 Reviewed-on: https://chromium-review.googlesource.com/824363Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524012}
-
rhalavati@google.com authored
Typo corrected in ADBClientSocket's network traffic annotation. Bug: 656607 Change-Id: I627e41fc48b778e6b8b2ba423707984a02002f71 Reviewed-on: https://chromium-review.googlesource.com/824242Reviewed-by:
-
James Cook authored
Ensure that code associated with the UI Service, which is used on both chromeos and linux-ozone, uses files and functions named *mus*. Reserve *mash* for chromeos-only code that runs under --mash and uses the ash window manager. Bug: 722527 Test: chrome, chrome --mus, and chrome --mash run with target_os="chromeos" and linux-ozone still compiles (I can't run linux-ozone due to xkb issues) Change-Id: I452e80dffb16d6445f40757d1198ff98233bb528 Reviewed-on: https://chromium-review.googlesource.com/822455 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524010}
-
Yoichi Osato authored
Since this patch, we use ShapeResult.Direction() to get appropriate CharacterRange to paint RTL text such as: <div id="d1">אבג</div> <script> getSelection().setBaseAndExtent(d1.firstChild, 0, d1.firstChild, 1); </script> Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id858f508c41b7231e73b25ef11933f88b2b2993e Reviewed-on: https://chromium-review.googlesource.com/821797 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524009}
-
François Degros authored
Replaced several of scoped_refptr's assignment operators by a unified assignment operator. This works beautifully in tandem with scoped_refptr's different constructors, and it removes some duplicated and tricky code. It is exception safe, and works fine in case of self assignment. We still need to keep operator=(T*), despite the implicit conversion constructor scoped_refptr(T*). There is code assigning rtc::scoped_refptr<T> to scoped_refptr<T>, and we want to keep this code compiling and working as is. rtc::scoped_refptr<T> has an implicit conversion operator to T*. C++ allows one implicit conversion, but not two, to be chained in a row. Marked scoped_refptr's move and swap operations as noexcept. This allows std::vector<scoped_refptr<T>> to use scoped_refptr's more efficient move operations instead of copy operations. This avoids extraneous calls to T::AddRef() and T::Release() when vector is reallocating its internal buffer. Change-Id: Id6f360f8acab827133fe5bef829a7a2e308b87fd Reviewed-on: https://chromium-review.googlesource.com/802338Reviewed-by:
-
Kunihiko Sakamoto authored
This fixes a bug introduced by crrev.com/c/824172. Bug: 778352 Change-Id: Id1dbc552ed5a94a0b5fadddec0b5bea50c3a7597 Reviewed-on: https://chromium-review.googlesource.com/826662Reviewed-by:
-
Xianzhu Wang authored
We planned to launch root-layer-scrolls before SPv175, so now begin to test the SPv175+RLS configuration. Bug: 793675 Change-Id: Ic8c83e7ff694b09f19277181172de31df1fb81dc Reviewed-on: https://chromium-review.googlesource.com/819574 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524006}
-
Jiaquan He authored
This commit: - hides the AppListModel and SearchModel in chrome; - creates ChromeAppListUpdater to own AppListModel and SearchModel; - forces model accesses to go through ChromeAppListUpdater; - fixes lint errors in affected files. Bug: 733662 Change-Id: I6ae6253516fa9be73e9f84d9aadeb3285ed7d19c Reviewed-on: https://chromium-review.googlesource.com/809495Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/9cfb34e845c8..97e6e42e3e39 $ git log 9cfb34e84..97e6e42e3 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 simonhatch Dashboard - Small refactor. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I12a74d31015cb0d95008e222b8527a1e812c040c Reviewed-on: https://chromium-review.googlesource.com/826132 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524004}
-
Xiaocheng Hu authored
When spellchecking is globally disabled (via context menu or settings), all spelling markers should be removed. Currently, the marker removal logic is duplicated at two places. This patch unifies the logic and ensures that the removal is done exactly once for each frame. This is also a preparation patch for removing Blink-side maintenance of the global spellcheck enabled status. All-in-one patch: crrev.com/c/821496 Removal plan of Blink-side status: https://goo.gl/grtURZ Bug: 710097 Change-Id: I84d33cef5db2aa6ffeb1b66568dee037cba4a737 Reviewed-on: https://chromium-review.googlesource.com/826259Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524003}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I2d539f31a7269f02246d1245e338d5aaf73e9179 Reviewed-on: https://chromium-review.googlesource.com/826445Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524002}
-
xzhan96 authored
Reason for reland: Fix the flaky build errors by adding a needed dependency in third_party/WebKit/Source/platform/BUILD.gn Original change's description: > Merge all native enums RequestContextFrameType into single mojo enum > > This CL creates blink.mojom.RequestContextFrameType enum type and uses > it to replace existing native enums content::RequestContextFrameType and > blink::WebURLRequest::FrameType. > > This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo, > and finally to remove content::ExtendableMessageEventSource, which is an > incremental step toward Onion Soup: having less dependence on content types > for service worker. > > BUG=782528 > > Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd > Reviewed-on: https://chromium-review.googlesource.com/791916 > Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523699} TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org Change-Id: Ie1a0dc3567cdde59655995c3a06c95ddeac027ea Reviewed-on: https://chromium-review.googlesource.com/823824Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524001}
-
Gyuyoung Kim authored
The issue 233174 was filed 4 years ago though, it hasn't been started yet. This CL makes the return value const, then change some arguments of callers to const according to the change of return value type. Bug: 233174 Change-Id: Ib08dc2b7dff417bf99da5a82fc1994131fec399e Reviewed-on: https://chromium-review.googlesource.com/821338Reviewed-by:
-
Devlin Cronin authored
Remove the Extension::State parameter in ExtensionServiceTestWithInstall::UninstallExtension. The burden of verifying the extension's state prior to uninstallation should be part of the calling tests, rather than part of the UninstallExtension method, in order to reduce complexity and improve predictability. Bug: 794205 Change-Id: Ia00758b58e20786d43799ea33a2dd72cfa42c565 Reviewed-on: https://chromium-review.googlesource.com/823011Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523999}
-
Blake O'Hare authored
The floating keyboard should not cause the shelf to disappear. Although the regular full-width keyboard should. This CL does 3 things: - Uses the keyboard's occluding bounds rather than visual bounds. This describes the area that is not accessible due to the keyboard covering it. This will be empty bounds in the case of a floating keyboard. - Uses keyboard availability event rather than checking if bounds are empty to determine if the keyboard is available. - Uses the is_locked attribute on the state descriptor object rather than checking the GetInstance()'s value directly. There are too many places where code is querying the static instance directly for the keyboard's current lock state and so we'd like to...lock those down. Bug: 786290 Change-Id: I8aba795b7228a14d00a8aaf218d4f56fb1006091 Reviewed-on: https://chromium-review.googlesource.com/816483Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523998}
-
Yuzu Saijo authored
This CL changes the browser type for leak detection fyi bot. Bug: 763280 Change-Id: I0ffe2e1ec2f463037dc5ecb9f40ca4a4a806ff5e Reviewed-on: https://chromium-review.googlesource.com/818671Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#523997}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/ece125358ba2..9af765dd2e44 $ git log ece125358..9af765dd2 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 jmadill Vulkan: Roll loader/validation layers SDK. (1/2) 2017-12-07 jmadill Vulkan: Remove loader/layers from GYP build. 2017-12-13 jmadill Vulkan: Add packed RenderPass descriptions. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3d07165d61ac98b92373657b57318c17534e8321 Reviewed-on: https://chromium-review.googlesource.com/825996Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523996}
-
Kenneth Russell authored
This was an inadvertent change not documented in http://crrev.com/523031 and broke the test suite on this bot. Since it's difficult to remove the --test-launcher-filter-file argument which is currently being ignored, leave that as is for the moment. BUG=794749 NOTRY=true Change-Id: Ib0bd2cb9cbfe3f7d72281369bdd1e991e1b591f6 Reviewed-on: https://chromium-review.googlesource.com/826464 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#523995}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/4b6b02f390d2..9cfb34e845c8 $ git log 4b6b02f39..9cfb34e84 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dtu [pinpoint] Rearrange Job page. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iee6631b439eb57f7b96fec9acca29317e09225b7 Reviewed-on: https://chromium-review.googlesource.com/826487 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523994}
-
Yuri Wiitala authored
GLRendererCopier modifies the GL state, making it inconsistent with that known to GLRenderer. This change adds a RestoreGLState() call in GLRenderer to restore consistency. Bug: 792734 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic4d08997fcba38a5edcd31ae8509b65ad2e2d6a8 Reviewed-on: https://chromium-review.googlesource.com/812957 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#523993}
-
Katie Dektar authored
This fixes a bug where in gmail selecting text in an open draft also selected text behind that pop up window. The bug was occuring because the hittest was returning a node that was behind the open dialog/window, and select-to-speak walked up its tree to find a higher level root with which to build the nodes to speak. The bug only showed up on high density screens because then DIP and PX were significantly different. On 1:1 screens it could not be found. A test is added which fails without this one-line change but passes with it. Bug: 792545 Change-Id: I21519b6cfaae97cb11c711b11b7a6b3e4b6fe017 Reviewed-on: https://chromium-review.googlesource.com/826043 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#523992}
-
John Z Wu authored
If you quit the app in iOS multitasking, it DCHECKs in a few places. This makes it impossible to write integration tests. This happens because, in our current setup, ObjC classes stay around longer than C++ classes. More specifically, CWVWebViewConfiguration stays around longer than WebViewWebMainParts. Since any client may retain CWVWebViewConfiguration for any reason, we cannot rely on dealloc to clean things up. Instead, a |shutDown| method is used to tear things down in the proper order. Bug: 733452 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c7b3e2f5fc81ee9d67e3a8a499301e4c814726e Reviewed-on: https://chromium-review.googlesource.com/825444 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523991}
-
Zhuoyu Qian authored
This patch makes ItemPosition and ItemPositionType to be enum classes for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Idd1a687d1e8bb07cdf12398fd84045ab7ef3ede3 Reviewed-on: https://chromium-review.googlesource.com/821801Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#523990}
-
Darren Shen authored
As per [1], CSSVariableReferenceValue now has a constructor. We can get rid of our hacky helper to create CSSVariableReferenceValues. [1] https://github.com/w3c/css-houdini-drafts/issues/514 Bug: 545318 Change-Id: I1f540514e9a75fb315dc7db16bc99e70ffe911ef Reviewed-on: https://chromium-review.googlesource.com/822318Reviewed-by:
-
Weidong Guo authored
Bug: 781747 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I128f64943031087f08bdf3f64c743bcbb7784694 Reviewed-on: https://chromium-review.googlesource.com/820094 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523988}
-
Tetsui Ohkubo authored
By using policy settings, administrator can enforce devices to allow or disallow notifications from specified URL origins. The enforced permissions are properly shown on chrome://settings, however, they were not reflected in notification center settings of Chrome OS. This CL changes the view to show disabled icon and make the row dim for such notifier sources, making it clear for users that they can't change the setting. Screenshot: http://screen/gTg2H5OWxaK UX Mock: https://crbug.com/771269#c11 TEST=manual BUG=771269 Change-Id: Iee0032ef85a4c132860f15c0f926551810543466 Reviewed-on: https://chromium-review.googlesource.com/810248 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#523987}
-
Erik Luo authored
Today's previews might not always wrap when they should. Example: `Object.keys(window.performance.timing.__proto__)` Bug: 781498 Change-Id: I763f55a8802773811b67c2f91eee96b3cb7e003b Reviewed-on: https://chromium-review.googlesource.com/818079 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523986}
-
Pedro Amaral authored
Removing unused metric Bug: 794038 Change-Id: I53c4c6cfd09db60946bd4e02119ba0363c77b266 Reviewed-on: https://chromium-review.googlesource.com/823174Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#523985}
-
