GitLab

This follows what Sensor::OnSensorReadingChanged() already does, but which
we were missing in the AmbientLightSensor override.

Platform sensor initialization happens before the sensor infrastructure on
the Blink side transitions reaches Sensor::NotifyActivated() and transitions
to the SensorState::kActivated state.

In practice, this means we can start receiving readings too early, and in
the Ambient Light Sensor case it meant setting |latest_reading_| to an
actual value but never emitting a "reading" event, so users would never get
notified of the first reading after starting the sensor (which also
contradicts the spec).

To make it worse, we have privacy measures in place that require illuminance
readings to differ by a certain threshold before we emit a reading event, so
if the user's surroundings did not change no reading event would ever be
emitted at all, even though accessing the "illuminance" attribute in JS
would actually return a rounded version of the first reading the platform
sensor sent during initialization.

Bug: 606766, 1046902
Change-Id: Id9e8844b5e4a199686024795befaa3539530cf0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030889
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736902}

Adds two assertion to BrowserFragmentImpl.OnCreate.

1. that mBrowser is null, otherwise we're creating a new one. I believe this
   is valid as onCreate() is only called once.
2. that mContext is not-null. My understanding is onCreate() is always called
   after onAttach(), so that mContext should not be null.

BUG=none
TEST=covered by tests

Change-Id: Ic863a8a63406357a867453690be706e55039cb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030049Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736901}

SkCreateTypefaceFromCTFont is deprecated

Change-Id: Iefebf57aeb18b18e71fe5b7c0d8d0d644b86b1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028969Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#736900}

The channelCount and channelCountMode for a convolver node is no
longer fixed.  The count can be 1 or 2 and the mode can be set to any
valid value other than "max".  This is basically the same constraints
as for a StereoPannerNode.

Also see https://github.com/WebAudio/web-audio-api/issues/2050
Feature: https://www.chromestatus.com/feature/6248507407073280

Bug: 1021552
Change-Id: I1cd814376d88ff4a525bae1f5e608ca4b989ac07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988714
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736899}

A subsequent patch will add Finch so I've added
FeatureListCreator to encapsulate UMA & Finch setup.

Bug: 1025781
Change-Id: I6c2a71e714733caf94cddc9d8dcf3875789a8298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932543Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736898}

Bug: 1046312
Change-Id: Id5e00d4a829ed9425188c5afb0b1e47c98a3f64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023492Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#736897}

The current downstream manifest merger has a bug. This is a temporary
workaround, once the downstream manifest merger is fixed, we should revert
this change.

Bug: 1045352
Change-Id: I0cded150604888443fadc53b458426525d200894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028853
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736896}

https://skia.googlesource.com/skia.git/+log/0ec7b8485455..3e98c0e1d115

git log 0ec7b8485455..3e98c0e1d115 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 brianosman@google.com Use separate SKSHAPER_DLL define to activate shared library logic
2020-01-30 rmistry@google.com Turn off failure comments from G3 bot
2020-01-30 bsalomon@google.com Avoid using kClamp domain in GrMatrixConvolutionEffect::MakeGaussian.
2020-01-30 brianosman@google.com Fix skshaper in component builds
2020-01-30 mtklein@google.com finish up 2pt conicals
2020-01-30 benwright@google.com [fuchsia] Replace system-temp with isolated-temp.

Created with:
  gclient setdep -r src/third_party/skia@3e98c0e1d115

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I941d0cfd80559e0c9c337c70929395cd88856eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031128Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736895}

As Android doesn't know about Chrome OS System UI, it can place the
PIP window at an incorrect position.
There were CTS concerns that disallow Chrome to adjust PIP initial
bounds, but we decided to workaround this on the Android side.

BUG=b:147790853
BUG=b:147791406
TEST=Manually confirmed PIP windows were located at the correct position
TEST=with hotseat on
TEST=android.server.am.ActivityManagerPinnedStackTests
TEST=#testEnterPictureInPictureSavePosition

Change-Id: Ibe962fc105584a1d457a3e3075e2dcabc23db129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022582
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Mitsuru Oshima (slow in TOK) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736894}

https://android.googlesource.com/platform/external/perfetto.git/+log/8d2b593996f3..65080795f53f

git log 8d2b593996f3..65080795f53f --date=short --first-parent --format='%ad %ae %s'
2020-01-30 eseckler@google.com startup writers: Release unique_ptr/lock correctly in ReturnTraceWriter
2020-01-30 eseckler@google.com startup writers: Add missing weak_ptr check
2020-01-30 eseckler@google.com Merge "startup writers: Make sure ReturnToRegistry() runs on right thread"
2020-01-30 taylori@google.com Merge "perfetto-ui: Mark an area selection"
2020-01-30 taylori@google.com Merge "perfetto-ui: Draw area selection as a box"
2020-01-30 fmayer@google.com Merge "Make heap_graph_missing_packet kError."

Created with:
  gclient setdep -r src/third_party/perfetto@65080795f53f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I591724c1457650c837cffe1a62efe08b7bf568a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031127Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736893}

These are all straightforward.

Bug: 1011446
Change-Id: I6dacfff7d45b9f344be7c5533e1d810cb8332b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007888
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736892}

Before this CL, date/time sections showed a combined date/time label and
popup. To address UX feedback, this CL splits the UI into dedicated date
and time sections, each with their own popup.

This also addresses a feature request where the granularity of the time
section needed to be configured, a feature not supported by the standard
android time picker.

Finally, this CL moves date/time logic to native, i.e., native code
now ensures that start > end, etc.

Bug: b/147577012
Change-Id: Id0eb0661ce3351dc8b8536fca96354752f523375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013053
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736891}

This reverts commit 4b79ed37.

Reason for revert: Causes crashes on Chrome OS - see https://crbug.com/1047222.

Original change's description:
> Reland "[Structured metrics] Add metric collection and upload logic."
> 
> This is a reland of 2fe77415
> 
> Original change's description:
> > [Structured metrics] Add metric collection and upload logic.
> > 
> > This is the final CL for the core of the structured metrics system. It
> > ties together the KeyData class (for managing keys and computing hashes)
> > with the metrics provider, and implements logic to:
> > 
> >  1. Hash and store incoming structured metrics events.
> >  2. Provide stored metrics events for upload.
> > 
> > It also adds integration tests for the system, checking that an event
> > created through the public API is correctly prepared for upload.
> > 
> > Other misc changes:
> > 
> >  - Some minor refactoring of event_base.{h,cc} and equivalent changes
> >    to events_template.py, to fix some bad style.
> >  - Added a missing RemoveObserver call to the metrics provider dtor.
> > 
> > Bug: 1016655
> > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386
> > Commit-Queue: Tony Yeoman <tby@chromium.org>
> > Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735748}
> 
> Bug: 1016655
> Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913
> Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> Commit-Queue: Tony Yeoman <tby@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736590}

TBR=amoylan@chromium.org,tby@chromium.org

Change-Id: I06ea1c7935600f26a7afbd2ec81a4c0f11277a70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1016655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030968Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736890}

This change:
1) Removes the can_close parameter to chrome::ShowWarningMessageBox()
2) Removes the code supporting that parameter, making close always possible
   on message boxes
3) Renames SimpleMessageBoxViews to MessageBoxDialog, to indicate that it
   is a dialog rather than a View

Bug: 1011446
Change-Id: Ia4e0ba79ad170bc7837d48eb380ff752236c05ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028667Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736889}

This code is not build and not used. The README.txt says this is a
proof-of-concept, but as far as I can tell this has never been used
and is not maintained (since it is not build).

Bug: none
Change-Id: I42217423cd0e83189c8f59097ea876df036ca0f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027529Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736888}

With AMD GPU, vulkan cannot submit a command buffer with waiting on
a semaphore which is signaled by GL. It is a driver bug reported at
https://gitlab.freedesktop.org/mesa/mesa/issues/2433 . So disable
GL_EXT_memory_object_fd and GL_EXT_semaphore_fd extensions. Without
those extensions, chrome will fallback to copy pixels from vkimage and
gl texture instead of sharing the same backing memory object.

Bug: 1046462
Change-Id: I231af9a626d692dbde89d9cd2f8a4bdc5ddf6eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027889Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736887}

Previously if a http response has both Document-Policy and
Require-Document-Policy header and they are incompatible, the document
will be blocked, which is not the correct behavior. This CL corrects
the behavior of document policy under such condition.

Bug: 993790
Change-Id: I5fc6b5c213fa7d56d473a8ea7e10235dd418ba42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015443
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736886}

Reason: failing, see linked bug.

Bug: 599650
TBR: mcasas
Change-Id: Iec795ad764a0a2d78dfb77e3b5f752b857da6bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030171
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736885}

This is part of an ongoing effort to simplify heap collections
and limit the types they can support (specifically, this CL
removes the only existing non-member usage of HeapListHashSet).

Bug: 1047147
Change-Id: I1c5de9f3a97588c22946eed03048159fd720b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024896Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736884}

Bug: 1045381
Change-Id: I285a44d32d47522786b1676b708b0723f336295b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031144Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736883}

https://webrtc.googlesource.com/src.git/+log/d69935c114aa..5dca3f1336a6

git log d69935c114aa..5dca3f1336a6 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 peah@webrtc.org Add floating point support for writing and reading wav files
2020-01-30 philipel@webrtc.org Remove unused NextFrame function from FrameBuffer.

Created with:
  gclient setdep -r src/third_party/webrtc@5dca3f1336a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iae37805d25be988d08bcebd60fc954b7d7dd2e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031125Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736882}

Follows the componentization of the production class.

Bug: 1030692
Change-Id: Ie64cabaa924d06502cd9eb7ad84097c579c554c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029510Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736881}

Remove unused locale_set from method
LanguageSettingsPrivateGetLanguageListFunction::Run

Bug: 1046955
Change-Id: Ie913d5700ea9f4bf71d3824b14f8fbb0f754f942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028933Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Bruce Long <brlong@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#736880}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b8c0752438c0..9f95ca93ba65

git log b8c0752438c0..9f95ca93ba65 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 dneto@google.com Better help for glslc -S (#978)

Created with:
  gclient setdep -r src/third_party/shaderc/src@9f95ca93ba65

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I6c1ecae8412a2ed811a0fb2b4182a1d42334f562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030591Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736879}

This change:
1) Removes ConfirmBubbleModel::GetButtons(), because every user had both
   buttons. Design-wise this makes sense - a ConfirmBubbleModel represents a
   yes/no choice, so having one or both of the buttons absent doesn't make much
   sense.
2) Removes ConfirmBubbleModel::BubbleButton, which duplicates ui::DialogButton
3) Removes ConfirmBubbleViews::IsDialogButtonEnabled() - because of point (1),
   this always returned true.

Bug: 1011446
Change-Id: I04bf65b7145ce00d70887feef1d0a6d218255697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028217
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736878}

BUG=None
TEST=Build locally.

Change-Id: Ibf130dcb59c094cedb6fc94ed62f74d97a299616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029406
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736877}

Bug: 1043828
Change-Id: I41db446ceec894c06b15c40a673f290f8ba2e533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030886
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736876}

The original is (flakily) timing out on Mac - most likely because of the
many readbacks. Split the test in smaller, reasonably logical, chunks to
hopefully avoid timing out.

Bug: 1041846
Change-Id: I43a543cd2dbc58fd9a1f412f9f77e2fb0eadc921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030765
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736875}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3941f82d7c3f..096422a54f2c

git log 3941f82d7c3f..096422a54f2c --date=short --first-parent --format='%ad %ae %s'
2020-01-30 szuend@chromium.org Prepare NetworkPersistenceManager for source map asyncification

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@096422a54f2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I72a503d0580be46e7f4b942cca8ed0fcb913a802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736874}

We currently use aapt(1) to generate an R.txt file so that we can compile our
resources and java targets concurrently. This cl replaces aapt with a custom
res/ parser that extracts resource java constant names to output a dummy R.txt
file. This new implementation has a significant speedup over aapt (60% on
average).

Bug: 820460
Change-Id: I7c912390a7789385a84a4102aee6bdb70011b248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015609Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736873}

Bug: 1004546
Change-Id: Id95038ced72c34c5a46d71dde8183d34e02798d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030965
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736872}

There was a case missing from the feature policy boolean value
'less-than' comparator which resulted in an a < b comparison sometimes
returning the wrong value. Tests added for all cases for bools and
doubles.

Change-Id: If873ca2b173b5a3b60a3091c030c1482b6b6bcbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028628Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736871}

Bug: 1028242
Change-Id: I5a9eeb935c71a83bbafe1a0bdea9374473dd8366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028738Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736870}

The main purpose is to replace the default CacheType argument with a
normal one. The callers are already passing this parameter explicitly in
the vast majority of cases, as it is really helpful to know whether the
operation will be persisted across platform instances.

For ClearCachedMetadata(): all callers are passing the parameter
explicitly. We will continue to need both modes (clearing on disk for
privacy reasons, clearing from memory to free up some memory). Making it
non-default is trivial.

For SetCachedMetadata(): the documentation says that is should always
persist, hence it seems that this was the intention initially. The
kCacheLocally is used only in tests. Making a test-only carveout with
DisableSendToPlatformForTesting(). The reason for not persisting in
those tests is not clear to me, perhaps this makes the tests run faster?

Increasing the size of the class is slightly unfortunate, I could not
find an elegant solution to overcome this. Though the size of these
objects is small compared to all of the serialized data, so it feels OK.

Bug: 1045052
Change-Id: Ifec42fbd66498c6860b32d86a25d3e857a97b4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019246Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736869}

Adds message in transparency panel when CrostiniAnsiblePlaybook policy
is set for user.
If CrostiniAnsiblePlaybook policy is set and Crostini reporting is
enabled the new message is set, when only reporting is enabled then old
message for Crostini reporting is set.

TEST: deployed to DUT and tested using YAPS
Bug: 1018775
Change-Id: Ia4df50c3acf69fcc613a8888752706c1e0e6ed0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000624Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736868}

This CL marks
virtual/omt-service-worker-startup/http/tests/serviceworker/update-served-from-cache.html
and its non-virtual tests flaky.

TBR=bashi@chromium.org
NOTRY=true

Bug: 1047208
Change-Id: Ic630ad8f072858653e3f199cef41a4a41730da33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031184
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736867}

BookmarkModel is expected to have a unique GUID per bookmark.
BookmarkModel does not currently have [D]CHECKs to enforce this, but
it does get verified upon loading of bookmarks from storage.

Upon sync's initial merge, the presence of duplicate GUIDs locally is
specially problematic, in particular if GUID-based merging logic
is enabled (currently disabled by default). This is because local nodes
may end up untracked, which violates the invariant for bookmark sync
to work (and may later run into [D]CHECKs).

Change-Id: I76f6139ae341fe1ed4e1f37cc37d96704be0910d
Bug: 978430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030764
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736866}

python client is being deprecated.

Bug: 984869
Change-Id: Ia0613c0bec75ab752554900eff3928115cd69988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030384
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736865}

Replaced with direct use of the setters.

Bug: 1011446
Change-Id: Ia054462bbe3e1585430b3fe4102c694366a78827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028197Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736864}

This reverts commit 248bfd1f.

Reason for revert: Broke some Android WebGL video tests

BUG=1047201

Original change's description:
> Don't create manager objects in ContextGroup when using the passthrough decoder
> 
> These objects are not used when the passthrough command decoder is in
> use.  This saves several GPU memory allocations in TextureManager for
> default and black textures.
> 
> Saves ~2 MB per context.
> 
> BUG=1046613
> BUG=1030835
> 
> Change-Id: I66c6acf28580742bc313d8cf79de80f7f7d98305
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028291
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736631}

TBR=zmo@chromium.org,geofflang@chromium.org,sandersd@chromium.org

Change-Id: I82ca36bd0b449e743ef819fbfe6ad161b219a8d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046613, 1030835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031164Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736863}