- 25 Feb, 2020 40 commits
-
-
Guido Urdaneta authored
This copier is currently defined in two places and it is expected to be used in upcoming code for insertable streams. Bug: 1052765 Change-Id: I25d7bed81a4c4ab823ecbbc3614aa17e4c8ac957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069331Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#744198}
-
Eric Willigers authored
The HostedOrBookmarkAppTest suite previously only tested hosted apps. The TODO to test bookmark apps is now done. Work remaining: we should also test web apps, with the DesktopPWAsWithoutExtensions flag enabled. Bug: 1055236 Change-Id: Ia15cf274810088194c05aea27dfa5abbe734f376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069966Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744197}
-
Dominic Mazzoni authored
PrintCompositorImpl generates a PDF for each individual page and then a single composite PDF. The previous patch mistakenly passed the accessibility tree to the individual page PDFs, which aren't ultimately exported. Pass the accessibility tree to the composite PDF document instead. The accessibility tree isn't available when DocumentInfo is created, so instead we now create the SkPDFDocument before compositing the first page rather than in the DocumentInfo constructor. Bug: 607777 Change-Id: I2164f94b81aa858f542b1df9012896338b507361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063897Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744196}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8fd825d3f61e..8fd9dd39e888 git log 8fd825d3f61e..8fd9dd39e888 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 dberris@chromium.org Pinpoint: Link to task isolate on failure Created with: gclient setdep -r src/third_party/catapult@8fd9dd39e888 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055568 Tbr: rmhasan@google.com Change-Id: I388120565deaa79b776a081aedf62fc4d171b89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744195}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/507ea2e59059..91bad2aad3c7 git log 507ea2e59059..91bad2aad3c7 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@91bad2aad3c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6dc8ff07fb64a3e0f462dd7cef82a650ec8b2d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070988Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7355fb43933..42a3e0ed288b Created with: gclient setdep -r src-internal@42a3e0ed288b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibbfdf909e143533de3c5d1110c04873e42ec807b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744193}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d927b63a311..86167236d486 git log 6d927b63a311..86167236d486 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f0bb4f52..2ea72065 (312 commits) Created with: gclient setdep -r src/third_party/skia@86167236d486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I5452b1794d75544c1cd284ccf7ebd21f44652409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070984Reviewed-by:
-
Tal Pressman authored
Bug: 1049056 Change-Id: Iee30a69b0cba2b2fd5bf6ff8a67e0c5bbbfddf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071436Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744191}
-
Yutaka Hirano authored
No-Try: True Bug: 1048597 Change-Id: I19e805b88ea62c4a96ac9fb7e72629ce6a3f6d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071458 Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#744190}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fbc5df5. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ifec27d6141da0dd5c1c9b3d1aa916b34120d549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070861Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744189}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/42c29073d348..507ea2e59059 git log 42c29073d348..507ea2e59059 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-25 khamu@microsoft.com High contrast fix on Console view pane Created with: gclient setdep -r src/third_party/devtools-frontend/src@507ea2e59059 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic0bf6c291ec5cfbeb7cf5f6671e9fe62cac206eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070983Reviewed-by:
-
Louis Collard authored
The project that makes use of these is still ongoing. Bug: 1043705 Change-Id: I182e1521ff49db747b457a09b73ef34042c06397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060216Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Louis Collard <louiscollard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744187}
-
Donn Denman authored
This enables the ContextualSearchDefinitions feature for all builds. We've pushed this to 1% Stable on M77 and the metrics look good, so default-enabling for M82 (will revert if the experiment has snags). BUG=943885 Change-Id: Id35ce0f8ff4bca54163efb0f1231e1b2e61f7c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070962Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744186}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Id7fb563e7ccd9416243df85b89afe0114eabfdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071753Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744185}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd7c149eef90..a7355fb43933 Created with: gclient setdep -r src-internal@a7355fb43933 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1015932,chromium:1050094,chromium:1054245,chromium:1055510 Tbr: jbudorick@google.com Change-Id: Idb405b6192d640647a8162dd07519d3c00bcc00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071280Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16b67309ba83..d687305d5181 git log 16b67309ba83..d687305d5181 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 joelaf@google.com Merge "Add a gn arg to skip buildtools checks" Created with: gclient setdep -r src/third_party/perfetto@d687305d5181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I330844aee0bb75c8bf37485ce4f9454efe9043e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071383Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17069c35..a70326ca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib55a56b794afc9abbca05416cedb19f98bb4229f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744182}
-
Kenichi Ishibashi authored
TBR=nhiroki@chromium.org Bug: 1049454 Change-Id: Ida976191f48f89e064807b1212ad621e84edc032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066381 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744181}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8b55bbfaabd..6d927b63a311 git log a8b55bbfaabd..6d927b63a311 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6d927b63a311 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ic96a7083d5e11a031ae7451a25dbb620c676814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070982Reviewed-by:
-
Jason Lin authored
Bug: 1048451 Change-Id: Ic8e0eadc059a1648c484ad592f9a85bbfec979fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045619Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#744179}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ief5104ec16e068219949abeee7a1862f4a0927b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071238Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744178}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b3a40936b9f0..42c29073d348 git log b3a40936b9f0..42c29073d348 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 khamu@microsoft.com High contrast in text button Created with: gclient setdep -r src/third_party/devtools-frontend/src@42c29073d348 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I27234f88a297c5c73acb30ba2b1605352793487f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071379Reviewed-by:
-
Dong Hwi Lee authored
Name changes: - Collapse -> Fold (name borrowed form wikipedia/Code_folding) - Collapsible -> Folder - Collapsed -> Folded - Expanded -> Opened - collapse-button (in CSS) -> fold - expand-button (in CSS) -> open Improvements: - Remove createButton (only referenced by createCollapsibleButton). - Remove 'text' class as it's not actually used. Change-Id: I29899a9293be47764f1963f7683cdd313622deef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070968 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744176}
-
Eric Willigers authored
CreateWebApplicationWindow checks for disposition NEW_POPUP. AppBrowserControllerBrowserTest.WhiteThemeForSystemAppPopup now passes even when DesktopPWAsWithoutExtensions is enabled. Bug: 1055645 Change-Id: Ifb15712c7bcebffba813f82ca7b7009618b31aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071438Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744175}
-
Koji Ishii authored
No browsers have implemented the spec behavior for over a decade, but CSSWG did not agree to match implementations. https://github.com/w3c/csswg-drafts/issues/1518 TBR=ikilpatrick@chromium.org Bug: 1052201 Change-Id: Ic349cfe2f881cdce3ee9ddbfc17995983cfc6ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071180 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744174}
-
Zhuoyu Qian authored
This CL update the function DeleteOriginDataOnFileTaskRunner to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: Ieb797f641079f715ac2cd94e6ec3a86aa0c1c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007322 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744173}
-
Hirokazu Honda authored
GAVDA.InitializeResult is an important metrics to know the failure rate of ARC++ video decoder path. This extends the expiry by two years. Bug: 1053013 Test: None Change-Id: I6e69dd7dbc245c2749c1e0aca4f31c8d6cb53643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060363Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744172}
-
Nico Weber authored
Bug: 1039697 Change-Id: I18ede84f1632aedb29a0a34730e884fafc9cc4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071508 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Lan Wei authored
Disable OobeZeroTouchInteractiveUITest.EndToEnd test on ChromeOS because OobeZeroTouchInteractiveUITestImpl/OobeZeroTouchInteractiveUITest.EndToEnd fails on Builder Linux Chromium OS ASan LSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 TBR=antrim@chromium.org Bug: 1054935 Change-Id: Ied762f5ff39e3b09a2eef83db2dc94a193a78c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071579Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744170}
-
tby authored
I've also fixed the units on one of our histograms being "units". Bug: 1052900 Change-Id: I770f0d3b2acf92156b61bc1c8366f92d04fb66c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068399Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#744169}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 664386 Change-Id: I4f53ada54759ec779f9e952a320925c845c8d248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071437Reviewed-by:
-
Kenichi Ishibashi authored
The feature is fully launched. Remove the virtual tests. Bug: 692909 Change-Id: Idb53d4683720c288c3c25a48118790f193581142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068067Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744167}
-
Leon Han authored
@Test(expected = InvalidNdefMessageException.class) indicates the test will and must throw an InvalidNdefMessageException, once the first exception gets thrown, the following code won't run and the test just goes to the end. So if a test would possibly throw more than one exception, it cannot use this mechanism. Instead we use a pattern like XXX xxx = null; try { xxx = getXXX(); } catch (XXXException e) { } assertNull(xxx); to confirm something went wrong inside getXXX(); Bug: 520391 Change-Id: Ibb681cbef1e0717ed695d7d7f2b9931739e6714c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071715 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#744166}
-
bttk authored
When observing user actions in Java code, native libraries may not be immediately available to record these actions. This change allows for deferred recording of user actions. Bug: 1048429 Change-Id: I66a151c163597622fdf08f9a7312f8c800da0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040053 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#744165}
-
Victor Costan authored
This is a reland of 64e434bf This CL skips the diff hunk in appcache_group.cc from https://crrev.com/c/2071069 that caused failures in the WebKit ASAN builder. NOLINTNEXTLINE is added before the trouble lines, so other developers won't be tempted to apply the same clang-tidy fix. The CL was tested by reproducing the failure reported in https://crrev.com/c/2070838 on an ASAN build, then undoing the problematic change, and verifying that the failure does not reproduce. To avoid a similar issue in this CL, all LayoutTests under http/appcache/ were run under ASAN. Original change's description: > AppCache: Fix clang-tidy warnings. > > This CL fixes all currently-enabled clang-tidy warnings in > //content/browser/appcache. The main benefit here is to prevent > distractions while pursuing further refactoring in AppCache. > > This CL introduces no functional changes. > > Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744051} Change-Id: I01e31ce2111d3b06bb45b238847a5ffa318f5034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071069Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5d977fae3b7..a8b55bbfaabd git log b5d977fae3b7..a8b55bbfaabd --date=short --first-parent --format='%ad %ae %s' 2020-02-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a8b55bbfaabd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id3441ca9342c44e31aafba5d03f82155849dc2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071283Reviewed-by:
-
yilkal authored
This cl saves the last reset time in AppTimeController in user pref. The value is saved every time the |AppTimeController:: reset_timer_| fires; the timer fires once every 24 hours. Last reset time value is read from the PrefService when AppTimeController is constructed. It is used to check if the reset time has been crossed while the device was off. Bug: 1050876 Change-Id: I11d189256a403b3c6f452905e2ccfc50f1660873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067242 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#744162}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9b2c573d..17069c35 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34552928b047c37bab02cefecab709bdf3cfbd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071595Reviewed-by:
-
Jonah Chin authored
This is a reland of 2a3b1189 To fix the perf regression from the original CL (as seen in crbug.com/1054408): In Canvas2DLayerBridge::GetPaintCanvas, avoid the call to GetOrCreateResourceProvider() to skip the IsValid/ContextLost checks. GetPaintCanvas is used in a hot code path that is called by each javascript command, so checking the context every time we fetch the recording canvas results in unnecessary and expensive work. The context does not need to be valid at this point, since only the recording canvas is being used. TBR=fserb@chromium.org Original change's description: > Add a PaintRecorder to CanvasResourceProvider > > This CL is the first step in creating a PaintRecord backed resource > provider for canvas OOP-R. > > Changes of ownership: > - PaintRecorder entirely moved from Canvas2DLayerBridge to > CanvasResourceProvider. > - Management of needs_flush_ for MemoryManagedPaintRecorder moved to > CanvasResourceProvider. > - RestoreCanvasMatrixClipStack logic centralized to CanvasResourceHost > and can be accessed via callback > - Backing SkiaPaintCanvas now private to CanvasResourceProvider with no > external access. Any users of the backing SkiaPaintCanvas in > Canvas2DLayerBridge had their functionality moved to > CanvasResourceProvider (ie. new RestoreBackBuffer() function) > > Updates to test files: > - Addition of explicit FlushCanvas() calls in tests that used to expect > SkiaPaintCanvas to immediately update. > - Some tests expected the CanvasResourceProvider to be created on first > draw. This expectation has been changed since the > CanvasResourceProvider now gets set up on SetCanvasResourceHost(). > > Other new functionality: > - Display Item List now has a bit that tracks if it contains any draw > operations. This is used to see if there are draw ops to flush. > > Bug: 1019288 > Change-Id: I717b18e22d6699dc876d8f8121a25d147738579d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891292 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743002} Bug: 1019288 Change-Id: I4ad88fbaeff89cff665ea53038091ec2a814eac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067557 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744160}
-
Tanya Gupta authored
Bug: 1055288 Change-Id: Icbc384fbe92965eff27722c8ac095629a85a793b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070974Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#744159}
-
