- 26 Jun, 2020 40 commits
-
-
Sorin Jianu authored
After this change, the RequestSender is choosing between x-cup-server-proof and etag value, and gives priority to the x-cup-server-proof value if it is non-empty. The values for both headers is read by the network stacks, and made them available to the RequestSender, which implements the validation mechanism in one place. It's impractical to unit test this code, since the RequestSender hardcodes the production public key and it can only transact CUP with a production backend. Bug: 606958 Change-Id: I5b0f2e9f2ba1e75ca4fd4c4becde848846541bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266918Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782987}
-
Samuel Huang authored
Previously, running SuperSize-archive on .apk files without native code (.so files) would lead to failure. The workaround was to specify the --java-only flag, but this was non-ideal. This CL fixes the above, so SuperSize can archive .apk files normally without the flag. This change is also propagated to Trichrome .ssargs generation (for WebView in particular). Bug: 1040645 Change-Id: I19f5fe1f03ea74f789fd8fd12a072fe073df4021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269878Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#782986}
-
Philip Rogers authored
This patch replaces "Lenna" images with images of Grace Hopper. Bug: 1099702 Change-Id: I32cf958bd2b6fbef5388da24de846a90ac0af9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270110 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782985}
-
Nohemi Fernandez authored
Clean up signin_interaction/ directory, which was part of the old sign-in architecture. Bug: 971989 Change-Id: I099c0247d69861c6836672840dc5ddb66bad4299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270201 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782984}
-
Mihai Sardarescu authored
We are preparing to enable by default the feature kUseNSURLSessionForGaiaSigninRequests. This CL enables the tests of the bridge that were deemed flaky. Fixed: 1065349 Change-Id: I5408f4ed70463503fd00cf06cc6e6f649cdfa00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247771 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782983}
-
Sylvain Defresne authored
The variable is now configured from BUILD.gn so should not be overridden when adding configuration/platforms to the Xcode project. Bug: 1094890 Change-Id: I06cef502ebcc3f19b68b91c54e2588b38f411524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270068 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782982}
-
Rouslan Solomakhin authored
Before this patch, Web Payment would enable Trusted Web Activity (TWA) features only in production TWAs. This patch adds a test controller method to set the TWA package name. After this patch, the cross-platform tests for Web Payment can simulate being in a Trusted Web Activity be calling test_controller()->SetTwaPackageName("com.example.app"). Bug: 1061503 Change-Id: I5abb67c0a0ca514b8ed739ecd5cf85fdc05ef27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270338Reviewed-by:Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782981}
-
Morten Stenshorne authored
If there's no class C breakpoint (i.e. non-zero gap) between the outer block-end edge of the last child and the inner block-end edge of its container, we really don't want to break there. We also don't want to break *inside* the block-end border/padding area. Only allow breaking here if there are no real preceding breakpoints. Bug: 829028 Change-Id: If922143923446060702eec5cfb8f7b2fbed06a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264296 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782980}
-
Benoit Lize authored
This reverts commit 08f75150. Reason for revert: Fixed accounting on POSIX. Original change's description: > base/allocator: Report the size of mapped PageAllocator space when crashing. > > PartitionAllocator can occupy a lot of address space, as freed pages for > normal buckets are never unmapped, and these are not shared across > buckets. This is a known issue, tracked in the linked bug. > > However the reporting currently in place only looks at a single > partition when reporting that an OOM is likely due to too many mapped > pages. It does not look at all PageAllocator allocations. This commit > adds a crash key reporting the total amount of mapped PageAllocator > pages to crash reports, to allow distinguishing between "true" OOM and > address space exhaustion. > > For instance, on Windows 32, an address space exhaustion crash would > happen with a reasonable committed set, remaining system commit limit, > and a large amount of mapped pages. All these data points are available > in crash reports, except for the last one, which this commit adds. > > Bug: 421387 > Change-Id: If3eac64489b61297cb5da6da328cfc70fecc4c8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264438 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782459} Bug: 421387 Change-Id: Ib6e377d978f3a9905224e3d0fa9944b741d4a4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270318Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782979}
-
Philip Rogers authored
Change-Id: I804e2b4aceffb94c551e7829da35254cdcf9fceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270108Reviewed-by:
-
Richard Knoll authored
Updates the VectorIterator interface to be compatible with the clarified IIterator API. The return value should be S_OK if we just moved past the last item, and E_BOUNDS if the iterator was already past the end before. See updated docs: https://docs.microsoft.com/en-us/previous-versions/br205830(v=vs.85) Bug: None Change-Id: Ifac585ca1dcfbf967afc801a64c97fa17ee2ef79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124831Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782977}
-
Adam Rice authored
Serialising and deserialising exceptions is now supported directly, so transferable streams do not have to work around the lack of support. Remove the workarounds. Change the semantics so that failures to serialise are not hidden by implicit conversion to undefined. Instead the cancel() or abort() method will return a rejection, and the stream will be errored. Update the http/streams/transferable/reason.html web test to reflect the new semantics. BUG=894838 Change-Id: I44c5bd968b4544df2706269900ca8461eabfa00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257655Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#782976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b60d96652beb..4b4651dbc255 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: droger@google.com Change-Id: I90716949ed12ea5fafa0b96ec68e3e2a60f7f957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782975}
-
Andrew Grieve authored
This is step #1 to merging chrome_public_apk and chrome_public_modern_apk. Bug: 1097998 Change-Id: I8546aa16eecdbd45c40413cd89e98516932cd033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259574 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#782974}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2cb77d1ab967666df93c33662a3417e340c9a828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782973}
-
Alice Wang authored
This CL redirects the web sign-in flow to the continue_url from Gaia once the sign-in is finished. Bug: 1092399 Change-Id: Ie51cfdab614c5c414abb2dee40759803c8d29491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264557Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782972}
-
Robert Ma authored
This adds a new build archive mojojs.zip that includes all *.mojom.js needed for running these web platform tests. Design doc and the tracking issue are Google-internal: https://docs.google.com/document/d/1mz3KAQLadAspB1Fv3e14Fv4nVVvkAH455WhZvMr5gnU/edit?usp=sharing Bug: 1094512 Change-Id: I52a226e422c99d86caad8430ddae704f1ae75910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247061Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#782971}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/839fddf46af2..bf571219978d 2020-06-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-26 mathias@chromium.org Add e2e test for global evaluation in Console 2020-06-26 sigurds@chromium.org [coverage] Show coverage summary for filtered items If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1061385,chromium:1099603 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20ddd3d5583217280c001a8d72482c07bf662e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270435Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: Ia2469a3d28fee4ada852421db9605d3af02f6b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255429 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#782969}
-
Etienne Pierre-Doray authored
This reverts commit b753ed10. Reason for revert: Test should be safe to re-enable after fix: https://chromium-review.googlesource.com/c/chromium/src/+/2248726 Original change's description: > perf: Disable blink_perf.owp_storage/idb-put.html on win-10-perf. > > Bug: 1095596 > No-Try: True > Tbr: wenbinzhang@google.com > Change-Id: Ia97f92057ff54f66464412bd4412065cf0759b00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246689 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778751} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1095596 Change-Id: Ia6a40d2753b88f2eaabd1121d762829f26e372d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252747Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#782968}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3330d56fbe19..c9f311e46255 2020-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7a1af5878594 to efaae24d0006 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I357faee48e7248631ffae1c84a42a4736e872287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270429Reviewed-by:
-
Roman Aleksandrov authored
Fixed: 1089197 Change-Id: I85f7dd3f27d7d65302ed3b170a49662503e5ce33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259917 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#782966}
-
Rohit Rao authored
BUG=1099662 Change-Id: Id928889626fbc39b050c672fa69eb0b7c62f5bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270339 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782965}
-
Sylvain Defresne authored
When using new build system, Xcode requires codesigning information in the Xcode project to build and run the app (even if they are not used since the build is done via ninja). Add support for collecting those information when running "gn gen" (this requires adding a new exception to exec_script but this cannot be done at build time since the information is used to generate the Xcode project when passing --ide=xcode to gen step of gn). Bug: 1094890 Change-Id: I63dabb836355fb7e2324580d5610872ea4fc33f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267099Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/54544ec92add..c403081641a8 2020-06-26 philipp.hancke@vonage.com sdp: use exact match in parseMediaDescription If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1bf68376101972392aa50200d33bb9634df5d016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270433Reviewed-by:
-
Marc Treib authored
third_party/cacheinvalidation is not actually used anymore, and will be deleted soon. Bug: 1099672 Change-Id: Ife72947a7c50f87eae0d39986fcaea134d2352e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270145 Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#782962}
-
Mirko Bonadei authored
This reverts commit 50f3c4a3. Reason for revert: Breaks ChromeOS (crbug.com/1099701). The fix should be easy but let's revert while I look into it. Original change's description: > Restrict absl_source_set visibility in favor of the component. > > Since the absl component build has landed, this CL restricts access > to the absl source_sets in favor of a direct dependency on the > component target. > > For now there is an allowlist but based on the outcome of > https://groups.google.com/a/chromium.org/forum/#!topic/cxx/cNZPHgfhNP4 > it might be lifted. > > Bug: 1046390 > Change-Id: I171ff8352e10241ca5dd3703d15e189a5ff534b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260532 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782940} TBR=thakis@chromium.org,mbonadei@chromium.org Change-Id: I553f5d25ad8bae1424b4530e53c4e3e024e9f006 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270465Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782961}
-
Luke Zielinski authored
TBR=robertma@chromium.org Bug: 1099689 Change-Id: Iba3b63a779a1e2d50716e0a37863177c4546d3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270342Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782960}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2a6cc4f8fb40..ff90599cdf60 2020-06-26 cwallez@chromium.org Replace TextureCopyView::arrayLayer -> origin.z in backends If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1728cf8a0c7a2d567bef4b101bd0620b947e4100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270426Reviewed-by:
-
Alice Wang authored
This CL migrates the usage of SigninTestUtil in signin integration tests to AccountManagerTestRule. Bug: 1092474 Change-Id: Ie21d8409ad9359a55919221c99adbba566cc0881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267317Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782958}
-
Rakib M. Hasan authored
Several fixes have landed in the most recent version which may resolve test failures. Bug: 1096572 Change-Id: I1ec878a40a49137b38690a7a4ea234362ca42a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268307Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#782957}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593151085-57fe35f0746eacbd2632836a414f4d24425341a7.profdata to chrome-mac-master-1593172332-f17aa6b42592bba9619dfbc84b45f66eb92ffb6a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If7b5a732635d1ae8eac801fc7d3462b45dfbff3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270434Reviewed-by:
-
Rainhard Findling authored
This CL changes any issues the ICU syntax presubmit check may find from an error to a warning. The reason for this are false positives: the current ICU syntax check flags some more rare ICU plural syntax variants as invalid while they are actually correct (e.g. explicit numeral statements beyond 1). The long-term solution for this is to improve the ICU syntax check to correctly recognize such syntax variants. For now, this CL prevents CQ errors for CLs containing such syntax. Bug: 1081730 Change-Id: I882a4e6f5ae11a0a5361782589b1705d652531b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270221Reviewed-by:
-
Johannes Kron authored
Add the histograms Media.RTCVideoDecoderInitializationLatencyMs and Media.RTCVideoDecoderReinitializationLatencyMs that tracks the initialization and reinitialization latencies of the hardware video decoder that is used in the RTC pipeline. Bug: 1061040 Change-Id: I25626b6b0473bde0a21a5b6c826a1eabdc1c0cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270437Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
If there's something unbreakable inside a container at a fragmentainer boundary, and there are no possible breakpoints, it will overflow the fragmentainer. This was already working, but in such cases, the container should then also overflow the fragmentainer (and consume the amount of space that it overflows). This will also effectively make us refuse breaking inside the block-start border or padding area (since that's included in the intrinsic block-size, which is unbreakable). The fieldset layout algorithm is still able to handle breaks inside borders and padding (and had tests for it), but since this will no longer happen, some tests had to be updated. The algorithm should also be fixed (only a TODO for now), to no longer support such breaks (mostly about removing a little code). There's also a fieldset-specific regression introduced by this CL: crbug.com/1097012 . This is about fieldset block-end padding and how the fragmentation machinery gets confused by it. This affects two unit tests. Rather than disbling them, I thought it was better to update with incorrect expectations (with a TODO), since the tests are probably still useful, even with this bug. Bug: 829028, 875235 Change-Id: I833faf7bc84328d36c9ccd640478badfd6278492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263353Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Sylvain Defresne authored
There is now only a single project generated from gn, so update the documentation to remove reference to the workspace (and remove old warnings against opening the project directly). Bug: none Change-Id: I8d19c078159154c740e9c7fae5b72b62b1997ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267097 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782952}
-
Miguel Casas authored
DrmDisplay::SetColorSpace() ends up setting the de/gamma ramps instantly via HardwareDisplayPlaneManager(Atomic)::CommitGammaCorrection(). When transitioning SDR-HDR or viceversa, this causes a glitch because the de/gamma ramp is committed separately from the page flip containing the new content. This CL fixes that by adding a parameter |on_next_commit| to DrmDisplay::CommitGammaCorrection() and wiring it down to the appropriate HardwareDisplayPlaneManagerAtomic where, if set, the code stores the new gamma/degamma ramps and pushes them on the next Commit(). Bug: b:158781255 Change-Id: I89ad16f15d40f1c9674ce78f68400b74d506b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264771Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#782951}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1c518aa4d4fde49899293f7681099573678c976d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270109Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. By this CL, ClearBrowsingDataFragmentBasic class uses |IdentityServicesProvider#getIdentityManager| function by passing profile via |Profile#getLastUsedRegularProfile| function. Note: This is only code clean up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ib961204a5133e49da4f9af3a92b0331baacea1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266473 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#782949}
-
Sreeja Kamishetty authored
In IsInactiveAndDisallowReactivation, we currently log a DumpWithoutCrashing to monitor crashes from wild. But, we could receive this from a compromised renderer sending an IPC from a speculative state. This CL kills the renderer process in that case when we try to ignore such events Bug: 1085430 Change-Id: I9b5f482207207ed34e5dc1a3b95c7c762d167d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213818 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782948}
-
