GitLab

Currently, this metric on cocoa tracks opening the user menu from the
icon or bubble, but on Views only from the icon. We want to also track
opening the new User Menu in Views with this stat.

BUG=NONE

Review URL: https://codereview.chromium.org/702483002

Cr-Commit-Position: refs/heads/master@{#302469}

Also, renaming valid_params and valid_parameters when validating bisect options
to required_params and required_parameters respectively to better reflect what
they actually are.

Fixing some runtime errors introduced by the refactoring to use ArgsParser
instead of OptionsParser.

BUG=424688

Review URL: https://codereview.chromium.org/697713003

Cr-Commit-Position: refs/heads/master@{#302468}

Recognize input type="password" for CVC field

BUG=429343

Review URL: https://codereview.chromium.org/694073002

Cr-Commit-Position: refs/heads/master@{#302467}

Restricts Plugin Power Saver to small content that's cross-origin.

Also handles the temporary whitelist for cross-origin as described by
thestig@ in the design doc.

Design doc: http://goo.gl/iDix3p

BUG=403800

Review URL: https://codereview.chromium.org/680193002

Cr-Commit-Position: refs/heads/master@{#302466}

Updates to address formats and sub-region names.

BUG=NONE

Review URL: https://codereview.chromium.org/687213004

Cr-Commit-Position: refs/heads/master@{#302465}

BUG=

Review URL: https://codereview.chromium.org/691163002

Cr-Commit-Position: refs/heads/master@{#302464}

Syntax of Privacy preferences within Advanced section follows the format at:
https://support.google.com/chrome/answer/2392969
https://support.google.com/chrome/answer/2392971
https://support.google.com/chrome/answer/2392709

Note that this UI text is used by src/chrome/common/localized_error.cc.
However, native code does not have access to internal Android strings like
IDS_PREFERENCES, IDS_PREFS_SECTION_ADVANCED, IDS_PREFS_PRIVACY,
IDS_NETWORK_PREDICTIONS_TITLE.  Therefore unfortunately these strings must be
hardcoded.

TBR=cpu
BUG=422314

Review URL: https://codereview.chromium.org/650903004

Cr-Commit-Position: refs/heads/master@{#302463}

Create a platform-independent ToolbarActionViewController
and platform-independent ExtensionActionViewController, and
wire the controller into the cocoa implementation. Add
platform specific implementations as needed.

BUG=422976

Review URL: https://codereview.chromium.org/670463004

Cr-Commit-Position: refs/heads/master@{#302462}

Fix two potential crashes in ExtensionToolbarModel.

Review URL: https://codereview.chromium.org/684373004

Cr-Commit-Position: refs/heads/master@{#302461}

Revert of Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/686683005/)

Reason for revert:
Undo the revert, it wasn't the cause of the test failures.

Original issue's description:
> Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/)
>
> Reason for revert:
> Common CL assumed to be causing Android Tests to fail:
>
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593
> and
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875
>
> Original issue's description:
> > Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
> >
> > TBR=machenbach@chromium.org
> >
> > Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4
> > Cr-Commit-Position: refs/heads/master@{#302437}
>
> TBR=machenbach@chromium.org,v8-autoroll@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/56957b6e401489d556fe87e5ca77b1e36170314f
> Cr-Commit-Position: refs/heads/master@{#302458}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/680393004

Cr-Commit-Position: refs/heads/master@{#302460}

The UserManager will now set the ProfileInfoCache's "signin required" bit to false after the browser's opened rather than before, so that it can be read during startup.

BUG=420762

Review URL: https://codereview.chromium.org/694593002

Cr-Commit-Position: refs/heads/master@{#302459}

Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/)

Reason for revert:
Common CL assumed to be causing Android Tests to fail:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593
and
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875

Original issue's description:
> Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4
> Cr-Commit-Position: refs/heads/master@{#302437}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/686683005

Cr-Commit-Position: refs/heads/master@{#302458}

dpks-query is spamming stderr when the packages we query are not found.
Silencing stderr for dpkg-query.

BUG=429719
NOTRY=true

Review URL: https://codereview.chromium.org/695373002

Cr-Commit-Position: refs/heads/master@{#302457}

This patch adds support for copying the Chromium library from the APK file
to a separate file.

This patch is largly based on https://codereview.chromium.org/673093005/.

BUG=390618

Review URL: https://codereview.chromium.org/684163002

Cr-Commit-Position: refs/heads/master@{#302456}

R=tbreisacher@chromium.org
BUG=none
TEST=http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/

Review URL: https://codereview.chromium.org/695013002

Cr-Commit-Position: refs/heads/master@{#302455}

#include <utility> in render_process_host_impl.cc is not necessary anymore.

Review URL: https://codereview.chromium.org/695203002

Cr-Commit-Position: refs/heads/master@{#302454}

BUG=424024
TEST=
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/702503002

Cr-Commit-Position: refs/heads/master@{#302453}

SHGetPathFromIDList was being treated as if it returned an HRESULT when
it actually returns a BOOL.

Warning was:

src\chrome\utility\importer\ie_importer_win.cc
(200) : warning C6215: Cast between semantically different integer types:  a Boolean type to HRESULT.

R=isherman@chromium.org

BUG=427616

Review URL: https://codereview.chromium.org/695553003

Cr-Commit-Position: refs/heads/master@{#302452}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/66cad76..37dd331

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/697133002

Cr-Commit-Position: refs/heads/master@{#302451}

This CL replaces the mistyped //chromeos/resources and
//chromeos/strings dependency (introduced by r302142) with
//ui/chromeos/resources and //ui/chromeos/strings.

BUG=None
TEST=Run `gn gen --args='os="chromeos" ...`

Review URL: https://codereview.chromium.org/698033002

Cr-Commit-Position: refs/heads/master@{#302450}

- Modify rtcd usage to match the conditions in armcpu.c.
- Make gyp and gn consistent.

TBR=sergeyu
BUG=webrtc:3906

Review URL: https://codereview.chromium.org/636083002

Cr-Commit-Position: refs/heads/master@{#302449}

BUG=429687

Review URL: https://codereview.chromium.org/696333002

Cr-Commit-Position: refs/heads/master@{#302448}

BUG=427580

Review URL: https://codereview.chromium.org/688593003

Cr-Commit-Position: refs/heads/master@{#302447}

BUG=130404
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/696313002

Cr-Commit-Position: refs/heads/master@{#302446}

BUG=

Review URL: https://codereview.chromium.org/694233002

Cr-Commit-Position: refs/heads/master@{#302445}

This patch disables temporarily TCs related to lisItemRole
because name attribute for it is added at crbug.com/347865.
After code from Blink is updated, TCs will be enabled again.

BUG=347865

Review URL: https://codereview.chromium.org/696133002

Cr-Commit-Position: refs/heads/master@{#302444}

My previous CL https://codereview.chromium.org/678553002/ did not handle this
case correctly.

BUG=412383

Review URL: https://codereview.chromium.org/686353002

Cr-Commit-Position: refs/heads/master@{#302443}

This works around a blue-screen bug with eglPostSubBuffer.

BUG=429200

Review URL: https://codereview.chromium.org/693953002

Cr-Commit-Position: refs/heads/master@{#302442}

R=mkearney@chromium.org
TBR=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/696343003

Cr-Commit-Position: refs/heads/master@{#302441}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f1b471a..66cad76

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/694333002

Cr-Commit-Position: refs/heads/master@{#302440}

Since the RTCPeerConnectionHandler now uses a separate thread for API-calls to libjingle (https://codereview.chromium.org/675013005/) the DtmfSenderHandler must also handle events on the signaling thread.

This cl also fix a problem where a remote video source falsly DCHECKs that an event have been missed.

TEST=out/Debug/content_browsertests --gtest_filter=WebRtcBrowserTest.MANU* --run-manual
BUG=369796

Review URL: https://codereview.chromium.org/699613002

Cr-Commit-Position: refs/heads/master@{#302439}

This patch removes both the WarningService accessors from
ExtensionSystem and also the ExtensionWarningBadgeService instance
that it created as this can be built automatically for every
BrowserContext simply by declaring so in its new factory.

BUG=

Review URL: https://codereview.chromium.org/698623002

Cr-Commit-Position: refs/heads/master@{#302438}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/696283002

Cr-Commit-Position: refs/heads/master@{#302437}

Remove the ability to engage split view mode with the
use of a bezel gesture, and remove BezelController
which is currently only used for this purpose.

BUG=429184
TEST=WindowManagerTest.TitleDragSwitchBetweenWindowsInSplitViewMode renamed to WindowManagerTest.ReplaceWindowsInSplitViewMode and modified,
WindowManagerTest.BezelGestureToSplitViewMode removed,
WindowManagerTest.BezelGestureToSwitchBetweenWindows removed

Review URL: https://codereview.chromium.org/694883002

Cr-Commit-Position: refs/heads/master@{#302436}

BUG=401729

Review URL: https://codereview.chromium.org/697653003

Cr-Commit-Position: refs/heads/master@{#302435}

We are trying to track down a negative error code (-50) but the current implementation logs negative values as zero. This patch maps all -50 error codes into one bin and all other error values into a second (unspecified/trash) bin.

BUG=428706

Review URL: https://codereview.chromium.org/702453003

Cr-Commit-Position: refs/heads/master@{#302434}

This allows autoconnect to policy pushed networks without the user having to manually trigger a successful connect once.

BUG=424036

Review URL: https://codereview.chromium.org/647783005

Cr-Commit-Position: refs/heads/master@{#302433}

Also make a global more const.

BUG=82385

Review URL: https://codereview.chromium.org/699453002

Cr-Commit-Position: refs/heads/master@{#302432}

We currently have code that ensures that if the last used profile is Guest, we should
open the User Manager. This doesn't work if, for example, you download a file
in the Guest browser, and then click on it top open it. In this case, it's fine
to open a new Guest browser window, as one already exists (and opening the User
Manager is a very weird experience)

BUG=423118
TEST=Start Chrome with --enable-new-avatar-menu. From the avatar menu, choose "Switch person"
and launch a new Guest browser. In the Guest browser, download a file, and then click on
it from the dwonload shelf at the bottom of the browser. The file should open in a
new tab of the Guest window.

Review URL: https://codereview.chromium.org/691063002

Cr-Commit-Position: refs/heads/master@{#302431}

This required for the new CertDatabaseService
  https://codereview.chromium.org/419013003/
which will (at least temporarily) depend on net/.
Without this change, that would lead to a cyclic dependency between net/ and cert_database/ .

This makes several tests in client_cert_store_chromeos_unittest, like cross-reading between user slots and the system slot, unnecessary.
These are already covered in the unit tests for NSSProfileFilterChromeOS.
This also removes this knowledge about users and the system slot from net/, which are Chrome/ChromeOS details that don't belong into net/.

BUG=413219

Review URL: https://codereview.chromium.org/663583006

Cr-Commit-Position: refs/heads/master@{#302430}