GitLab

This should work fine now that Chrome and sandbox tests behave in an
ASan-friendly way.

This effectively reverts r313452 and r312495

BUG=382867
TBR=thakis@chromium.org,scottmg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/903553004

Cr-Commit-Position: refs/heads/master@{#314790}

Revert of Roll src/third_party/WebKit 4b9569f:fa53a39 (svn 189384:189535) (patchset #1 id:1 of https://codereview.chromium.org/901853002/)

Reason for revert:
Broke Mac GN builds

Original issue's description:
> Roll src/third_party/WebKit 4b9569f:fa53a39 (svn 189384:189535)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/4b9569f..fa53a39
>
> TBR=dcheng@chromium.org,apavlov@chromium.org
>
> Committed: https://crrev.com/e4b735f7acc2ae3ae1c891470f2a703fe8608724
> Cr-Commit-Position: refs/heads/master@{#314785}

TBR=dcheng@chromium.org,blink-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/881083003

Cr-Commit-Position: refs/heads/master@{#314789}

Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation (patchset #2 id:60001 of https://codereview.chromium.org/860333003/)

Reason for revert:
Crashes on the assert that biplanar NV12 is tightly packed.

BUG=455618

Original issue's description:
> Mac Video Capture: Add support for pixel format NV12 for AVFoundation
>
> BUG=346634
>
> Committed: https://crrev.com/40c2c94fbd52f9748ee082573e07404ae2621b9b
> Cr-Commit-Position: refs/heads/master@{#313886}

TBR=perkj@chromium.org,tommi@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=346634

Review URL: https://codereview.chromium.org/886933006

Cr-Commit-Position: refs/heads/master@{#314788}

This change removes market specific search provider configuration for Bing. Using a single provider for all markets will allow the Bing server to make the market determination, providing a more consistent user experience regardless of entry point. This will additionally simplify Bing's configuration for any future changes that may be needed.

It also adds Bing to markets where it was previously excluded, moves the suggestion URL to https, and updates URL parameters used for reporting purposes.

Review URL: https://codereview.chromium.org/895223002

Cr-Commit-Position: refs/heads/master@{#314787}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/893363002

Cr-Commit-Position: refs/heads/master@{#314786}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b9569f..fa53a39

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/901853002

Cr-Commit-Position: refs/heads/master@{#314785}

Review URL: https://codereview.chromium.org/903453002

Cr-Commit-Position: refs/heads/master@{#314784}

NOTRY=true

Review URL: https://codereview.chromium.org/880193003

Cr-Commit-Position: refs/heads/master@{#314783}

This removes the latest comments of "Dependencies of" and sort up these
dependencies lists, so it will be easier for people coming up later and
adding new entries, they will know exactly where to put them and it will
be much easier to review them as well.

BUG=None
TEST=components_unittests, components_browsertests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/891273003

Cr-Commit-Position: refs/heads/master@{#314782}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63af144..528f97f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899973004

Cr-Commit-Position: refs/heads/master@{#314781}

Also add an ASan test to sbox_integration_tests on Windows

BUG=382867

Review URL: https://codereview.chromium.org/868253011

Cr-Commit-Position: refs/heads/master@{#314780}

Pass the list of languages to HistoryService::Init() in order to
remove a dependency on prefs::kAcceptLanguages and on Profile.

BUG=453790
R=droger@chromium.org

Review URL: https://codereview.chromium.org/870143004

Cr-Commit-Position: refs/heads/master@{#314779}

To reduce debug logging spam, this increases the warning threshold for
posting "super long" delayed tasks to 14 days (was ~18 minutes before).
Also, make the logging message more readable by printing values in terms
of seconds rather than microseconds.

BUG=450045

Review URL: https://codereview.chromium.org/897173004

Cr-Commit-Position: refs/heads/master@{#314778}

BUG=410766
TEST=FileManagerJsTest.MetadataCacheItem

Review URL: https://codereview.chromium.org/900173002

Cr-Commit-Position: refs/heads/master@{#314777}

Revert of Fix the histograms whitelist for the OOP PDF plugin. (patchset #1 id:1 of https://codereview.chromium.org/897863003/)

Reason for revert:
Introduced 2 new static initializers:

pepper_uma_host.cc (anonymous namespace)::kWhitelistedPluginBaseNames
pepper_uma_host.cc __init_array_end+0x5e8

Original issue's description:
> Fix the histograms whitelist for the OOP PDF plugin.
>
> BUG=405305
>
> Committed: https://crrev.com/ad1fecf3841f539281c8d6ff3a873bfc9c11571d
> Cr-Commit-Position: refs/heads/master@{#314764}

TBR=raymes@chromium.org,thestig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=405305

Review URL: https://codereview.chromium.org/901863002

Cr-Commit-Position: refs/heads/master@{#314776}

Cr-Commit-Position: refs/heads/master@{#314775}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7404c09..63af144

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899653004

Cr-Commit-Position: refs/heads/master@{#314774}

BUG=451321

Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6
Cr-Commit-Position: refs/heads/master@{#314231}

Review URL: https://codereview.chromium.org/889283002

Cr-Commit-Position: refs/heads/master@{#314773}

Adding some flags to make audio debugging easier. Now we can separate audible audio from inaudible, and dump the tokens in their original encoded form.

rkc@ for copresence review.
andrew@webrtc for wav_file review.

Review URL: https://codereview.chromium.org/892423002

Cr-Commit-Position: refs/heads/master@{#314772}

Previously, it was unsafe to pass a char* because it would be implicitly
converted to a string with a very short lifetime. Now, you can safely
pass a char* as long as the memory pointed to by the char* outlives the
Replacements (which is always true for string literals).

All existing usage of Replacements should continue to work as usual.

Updated every call to Replacements Set*Str methods that that could be
simplified by the new StringPiece API (for example, passing string
literals directly, instead of copying them into a string object).

Internally, renamed StdStringReplacements to StringPieceReplacements.

BUG=454274

Review URL: https://codereview.chromium.org/889463003

Cr-Commit-Position: refs/heads/master@{#314771}

This is possible now that JSONStringValueSerializer takes a StringPiece.

BUG=455068

Review URL: https://codereview.chromium.org/891473004

Cr-Commit-Position: refs/heads/master@{#314770}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a9d9de4..7404c09

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/902773002

Cr-Commit-Position: refs/heads/master@{#314769}

TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/902493004

Cr-Commit-Position: refs/heads/master@{#314768}

Resource message requests can be relatively expensive, particularly in
the induced work on the browser IO thread. Currently, there is no bound
on the rate with which such requests are dispatched from the renderer.
This leads to situations where the browser IO thread is flooded with
requests, potentially causing scroll jank and otherwise undesirable
stalls in the browser pipeline.

Introduce a ResourceMessageThrottler which intercepts and defers a given
resource message stream, depending on the state of the RendererScheduler.
When the RendererScheduler indicates that high priority work is
imminent/likely, requests will be throttled according to a configurable
dispatch rate.

Hook this throttling mechanism up to the ResourceDispatcher, limiting
the number of resource message requests/second during user interaction
to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.

See goo.gl/H42AgQ for more design details.

Note: This change originally landed in
https://crrev.com/acfb4199abf841a1577c3968579c43b0232a53b7, but was
reverted due to issues with enforced ThreadChecker validation in
RendererSchedulerImpl. The ThreadChecker validation fix has been split
into a separate patch.

BUG=440037,402136

Review URL: https://codereview.chromium.org/847883002

Cr-Commit-Position: refs/heads/master@{#314767}

BUG=449357

Review URL: https://codereview.chromium.org/896093002

Cr-Commit-Position: refs/heads/master@{#314766}

When 'scroll-blocks-on: scroll-event' is applied anywhere in the scroll ancestor tree where is a scroll event handler, force the scroll to be executed on the main thread.  Note that this is still experimental.  We'll be at least adding a timeout mechanism to this to mitigate the risk of improper usage.

When 'scroll-blocks-on: wheel-event' is NOT applied (it's on by default), ignore the existence of wheel event handlers (allowing scrolling to run freely on impl).

When 'scroll-blocks-on: start-touch' is NOT applied (it's on by default), suppress sending touch events to blink.  Eventually we'll make this smarter - sending async touch events that don't block scroll.

Depends on blink change https://src.chromium.org/viewvc/blink?view=rev&revision=188230

BUG=347272

Review URL: https://codereview.chromium.org/784463002

Cr-Commit-Position: refs/heads/master@{#314765}

BUG=405305

Review URL: https://codereview.chromium.org/897863003

Cr-Commit-Position: refs/heads/master@{#314764}

Renames enable-new-qp-input-view to enable-new-md-input-view. Because QP is a internal code name, we should use md instead.

BUG=422869

Review URL: https://codereview.chromium.org/863093006

Cr-Commit-Position: refs/heads/master@{#314763}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/600d716..4b9569f

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/897093003

Cr-Commit-Position: refs/heads/master@{#314762}

This change is picked from https://github.com/libevent/libevent/commit/ea6b1df

BUG=455089

Review URL: https://codereview.chromium.org/895323002

Cr-Commit-Position: refs/heads/master@{#314761}

Revert of Clean up V4L2 codec-related flags and defines (patchset #3 id:40001 of https://codereview.chromium.org/828063009/)

Reason for revert:
x86 Chrome compile failure due to https://code.google.com/p/chromium/issues/detail?id=455545.

Original issue's description:
> Clean up V4L2 codec-related flags and defines
>
> All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now.
> Generates libv4l2 stub in GN file.
>
> BUG=449883
> TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
> and panther_freon
>
> Committed: https://crrev.com/d5eeecc577f274bb8ed9d1954f263d83b5f00050
> Cr-Commit-Position: refs/heads/master@{#314536}

TBR=piman@chromium.org,wuchengli@chromium.org,henryhsu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449883

Review URL: https://codereview.chromium.org/902773003

Cr-Commit-Position: refs/heads/master@{#314760}

This is a cleanup change in preparation for [ http://crbug.com/450509 ], where
metrics will be logged in non-ChromeOS-only code.

BUG=450509
TEST=compiles
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/887093004

Cr-Commit-Position: refs/heads/master@{#314759}

Add an IsEnabled() method to the EasyUnlockService, and other minor cleanup.

BUG=none
TEST=none
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/889153004

Cr-Commit-Position: refs/heads/master@{#314758}

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/884003003

Cr-Commit-Position: refs/heads/master@{#314757}

Revert of Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". (patchset #1 id:1 of https://codereview.chromium.org/899103002/)

Reason for revert:
Speculatively reverting to try to fix broken Mac 10.8 retina and Nexus 4 layout tests.

Original issue's description:
> Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test".
>
> At this point, "--run-layout-test" is the flag that is actually functional, and using "--dump-render-tree" simply causes the "--run-layout-test" to be appended to the command line.
>
> A subsequent Blink patch will change the scripts in Blink to use "--run-layout-test" instead of "--dump-render-tree".
>
> BUG=453252
>
> Committed: https://crrev.com/7066b52aa7103b402dea27c64ec17d45c373a838
> Cr-Commit-Position: refs/heads/master@{#314664}

TBR=avi@chromium.org,paulmeyer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453252

Review URL: https://codereview.chromium.org/896403002

Cr-Commit-Position: refs/heads/master@{#314756}

Revert of Throttle resource message requests during user interaction (patchset #14 id:300001 of https://codereview.chromium.org/847883002/)

Reason for revert:
The new DCHECKs for CalledOnValidThread are breaking tests everywhere:
https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/6021

Original issue's description:
> Throttle resource message requests during user interaction
>
> Resource message requests can be relatively expensive, particularly in
> the induced work on the browser IO thread. Currently, there is no bound
> on the rate with which such requests are dispatched from the renderer.
> This leads to situations where the browser IO thread is flooded with
> requests, potentially causing scroll jank and otherwise undesirable
> stalls in the browser pipeline.
>
> Introduce a ResourceMessageThrottler which intercepts and defers a given
> resource message stream, depending on the state of the RendererScheduler.
> When the RendererScheduler indicates that high priority work is
> imminent/likely, requests will be throttled according to a configurable
> dispatch rate.
>
> Hook this throttling mechanism up to the ResourceDispatcher, limiting
> the number of resource message requests/second during user interaction
> to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.
>
> See goo.gl/H42AgQ for more design details.
>
> BUG=440037,402136
>
> Committed: https://crrev.com/acfb4199abf841a1577c3968579c43b0232a53b7
> Cr-Commit-Position: refs/heads/master@{#314739}

TBR=alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org,rmcilroy@chromium.org,davidben@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440037,402136

Review URL: https://codereview.chromium.org/897223002

Cr-Commit-Position: refs/heads/master@{#314755}

We should investigate why the binaries generated by gold are bigger.

BUG=396333

Review URL: https://codereview.chromium.org/869043007

Cr-Commit-Position: refs/heads/master@{#314754}

TBR=rvargas@chromium.org
BUG=455536
NOTRY=true

Review URL: https://codereview.chromium.org/876473005

Cr-Commit-Position: refs/heads/master@{#314753}

Non-blocking IO has higher throughput than the previous implementation
that used overlapped IO. 15% increase in throughput for sending to
localhost is observed. There could be additional performance advantage
in WiFi network.

All existing UDP socket tests passed. I added a unit test to do
benchmarking. Also tested this manually with WebRTC and verified that
all UDP send and receive activities are logged correctly.

BUG=442392

Review URL: https://codereview.chromium.org/861963002

Cr-Commit-Position: refs/heads/master@{#314752}

This function used to be used to support multiple backends, and is no
longer used.

BUG=

Review URL: https://codereview.chromium.org/900133003

Cr-Commit-Position: refs/heads/master@{#314751}