GitLab

Show the keyboard switcher icon on the right edge of the navigation bar
when two or more IMEs are enabled and a physical keyboard is connected.

BUG=452543

Review URL: https://codereview.chromium.org/879403003

Cr-Commit-Position: refs/heads/master@{#313660}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9903025..34bc400

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/885783003

Cr-Commit-Position: refs/heads/master@{#313659}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/52f401e..9cc2f26

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890463002

Cr-Commit-Position: refs/heads/master@{#313658}

Multiple friend declaration is causing warning with gcc 4.8.2 (at least).

Review URL: https://codereview.chromium.org/874933003

Cr-Commit-Position: refs/heads/master@{#313657}

For an image that's already optimized, aapt crunch typically increases
the image size. In this case, we now use the original image instead of
the crunched image. 9-patches, however, must always be crunched, since
crunching adds important metadata to the file.

Currently, this saves 50KB, but has the potential to save up to 300KB
once we optimize all the images in the codebase.

BUG=407781

Review URL: https://codereview.chromium.org/867483005

Cr-Commit-Position: refs/heads/master@{#313656}

BUG=452266

Review URL: https://codereview.chromium.org/880423002

Cr-Commit-Position: refs/heads/master@{#313655}

This CL enables using the ALAC codec within the media pipeline.
This does not add ALAC support, as the ALAC codec is not part of the current build.

BUG=441343

Review URL: https://codereview.chromium.org/881603002

Cr-Commit-Position: refs/heads/master@{#313654}

Speculative fix for http://crbug.com/451401.

BUG=451401
R=reed@google.com,jbroman@chromium.org

Review URL: https://codereview.chromium.org/881343004

Cr-Commit-Position: refs/heads/master@{#313653}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d0e8386..9903025

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/863903003

Cr-Commit-Position: refs/heads/master@{#313652}

Changes are:
- Changed layout of grid view.
- Made thumbnails fill entire item area.
- Use check marks to indicate selected items.

BUG=402344
TEST=run browser_tests

Review URL: https://codereview.chromium.org/885653002

Cr-Commit-Position: refs/heads/master@{#313651}

Reason: We don't want to destroy local uncommited changes when running tests.

One solution was to mock bisect_utils.GitRun -- doing that caused the course of the run to change, making it so that there were no results (since git log is used to get a list of revisions, even for the dry run). So if we want to solve this problem by mocking git, we should replace it with a fake RunGit that returns different canned values depending on what the input is.

The advantage of stash/apply is that its simpler, but it's also a little bit slower than the above way.

BUG=

Review URL: https://codereview.chromium.org/847393004

Cr-Commit-Position: refs/heads/master@{#313650}

BUG=452230

Review URL: https://codereview.chromium.org/883123002

Cr-Commit-Position: refs/heads/master@{#313649}

Picked up changes:
197d576 Delete a bunch of gwt test environment-specific things
ae707d0 Remove DomToSaxVisitor and rename some classes
e8b2fcd Add a WebDocument class
52c4790 Support verbose output in jstest
ac006fe Remove ant target "test.dev" and "test.prod"
7db0bf4 Trim trailing spaces in java source code
0338d85 Fix all invalid URLs in tests
2489c81 Fix "Support test.filter for jstests"
442f8ee Reorganize all the code in the project.
2044b6f Support test.filter for jstests
ddb81f8 Disable some tests in PagingLinksFinderTest
82f505c Move PagingLinksFinderTest from test/ to jstest/
2f9ec7d Add a devtools panel to inject extraction script into the inspected window
9962247 Remove BoilerpipeProcessingException and other unused things.
491c7ce Use pre-compiled regexes for many things in PagingLinksFinder
e26e5ff Fix "Move ElementActionTest and TextBlockBuilderTest from test/ to jstest/"
6893a1a Move ElementActionTest and TextBlockBuilderTest from test/ to jstest/
6a97c63 Add util/TextBlockBuilderTest into DomDistillerTestSuite
d331041 Fix ElementActionTest

BUG=440102,440977

Review URL: https://codereview.chromium.org/884323002

Cr-Commit-Position: refs/heads/master@{#313648}

BUG=none
TEST=none
R=piman@chromium.org, tengs@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/887553002

Cr-Commit-Position: refs/heads/master@{#313647}

The third_party/opus/src CL is https://codereview.chromium.org/882843002.

Support MIPS optimizations in opus.

R=henrika@chromium.org,sergeyu@chromium.org
BUG=452984

Review URL: https://codereview.chromium.org/865853005

Cr-Commit-Position: refs/heads/master@{#313646}

Since browser actions that are hidden are now just overflowed to the wrench
menu, we don't really need the show button anymore.

BUG=453152

Review URL: https://codereview.chromium.org/879213005

Cr-Commit-Position: refs/heads/master@{#313645}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b02f7f1..d0e8386

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/881633004

Cr-Commit-Position: refs/heads/master@{#313644}

This patch adds EmitFrames() to VideoEncoder. The method is documented
as indicating that the encoder should produce all the frames that it may
be buffering for analysis.

This patch modifies VideoSender::InsertRawVideoFrame() to call
EmitFrames() when a frames is dropped because the in-flight frames
duration exceeds the target playout delay.

This patch provides an implementation of EmitFrames() for the
VideoToolbox H.264 encoder, which buffers frames for analysis as
described in the bug. It also uses the existing
max_number_of_video_buffers_used field in VideoConfig to set the
upper bound on the encoder's frame window.

BUG=450798
R=hclam, miu, DaleCurtis, Robert Sesek

Review URL: https://codereview.chromium.org/863083002

Cr-Commit-Position: refs/heads/master@{#313643}

Launching Mojo apps on Android is slow because we keep the network cache in
memory, which means we lose it every time we launch MojoShell. After this CL,
we use a disk cache on Android. Note: We still use a memory cache on desktop
because we want to be able to run many instances of mojo_shell in parallel on
desktop for testing.

R=jamesr@chromium.org
BUG=452226

Review URL: https://codereview.chromium.org/883073003

Cr-Commit-Position: refs/heads/master@{#313642}

BUG=69557, 147116, 156816, 371734, 436102, 439948, 444504
TEST=Test each of the URLs listed in the diff (Linux or Windows) and ensure EV status is granted.
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/879183002

Cr-Commit-Position: refs/heads/master@{#313641}

It fails on the official builders.

NOTRY=true
TBR=kjellander@chromium.org
BUG=452623

Review URL: https://codereview.chromium.org/858153004

Cr-Commit-Position: refs/heads/master@{#313640}

If soname is used here, nm cannot find the file if non-default
toolchain is used.

Review URL: https://codereview.chromium.org/884663002

Cr-Commit-Position: refs/heads/master@{#313639}

(1) make the tile of the denyButton adaptive, such that
 "Deny" will show on a mouse lock request instead of "Exit full screen."
(2) add unittest to verify its behavior.

XIB changes:
* Remove the default deny button title IDS_FULLSCREEN_EXIT_FULLSCREEN.

BUG=139944

Review URL: https://codereview.chromium.org/856253002

Cr-Commit-Position: refs/heads/master@{#313638}

BUG=374264

Review URL: https://codereview.chromium.org/884713004

Cr-Commit-Position: refs/heads/master@{#313637}

BUG=452961

Review URL: https://codereview.chromium.org/882093003

Cr-Commit-Position: refs/heads/master@{#313636}

BUG=394382
R=avi@chromium.org

Review URL: https://codereview.chromium.org/874073002

Cr-Commit-Position: refs/heads/master@{#313635}

The CL corrects a bug where clock_gettime was placed in
a DCHECK call and thus not executed on release builds.

Contributed by sheckylin@chromium.org

BUG=chrome-os-partner:35111
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/884313002

Cr-Commit-Position: refs/heads/master@{#313634}

- Don't hide autofill popup on browser height change on Android.

  Android keyboard can show or hide a strip of suggestions when user
  switches between input fields. If the input field triggers showing the
  autofill popup, the keyboard resize will hide it, which causes a UI
  flash.

- Remove redundant Views code to hide autofill popup on window resize.

  Browser process now has a cross-platform way to listen to window
  resize and close the autofill popup. Removed Views-only resize
  listener was also firing on window move. Removing it means that moving
  the window without resizing it will not close the autofill popup. The
  popup stays attached to the field during window move, however.

- Let autofill know when a password popup may be showing. This enables
  autofill agent to hide the popup when the page scrolls.

- Re-enable showing username suggestions on first click on Android,
  which now behaves on par with desktop.

BUG=430318

Review URL: https://codereview.chromium.org/870833002

Cr-Commit-Position: refs/heads/master@{#313633}

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Review URL: https://codereview.chromium.org/873253004

Cr-Commit-Position: refs/heads/master@{#313632}

This CL adds the groundwork for a slide-in pane to be used by the OOP PDF Viewer. It adheres to the principles of Material Design, and will be used as a base for the bookmarks pane (which will display a list of bookmarks) as well as an info pane to show metadata of the PDF.

BUG=110020

Review URL: https://codereview.chromium.org/864753002

Cr-Commit-Position: refs/heads/master@{#313631}

This field is redundant now that we pass a RenderPass* to AppendQuads.

A few tests were passing a different id and the same RenderPass* to
test DelegatedRendererLayerImpl, so I had to adjust the tests to
pass different RenderPass* instead.

R=vmpstr

Review URL: https://codereview.chromium.org/879423002

Cr-Commit-Position: refs/heads/master@{#313630}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

This splits EventFactoryOzone into two parts: EventFactoryOzone and
InputDeviceFactoryOzone. The new InputDeviceFactoryOzone class is now the
device I/O-centric part, and is intended to exist on a low-latency thread.

Hotplug events still originate on the UI thread, but this is not a
problem because hotplug is not latency critical. We're sharing udev
with the display code, so its easiest leave that code alone for now.

This doesn't add a new thread yet. Everything still runs on the UI thread.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/863353003

Cr-Commit-Position: refs/heads/master@{#313629}

The testing team wants to enable 'Roboto' by default and have real users to help report bugs too.

In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on.

Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice).

BUG=448948
TEST=tested on device (Pixel)

Review URL: https://codereview.chromium.org/868753005

Cr-Commit-Position: refs/heads/master@{#313628}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6b67b8..b02f7f1

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/885743002

Cr-Commit-Position: refs/heads/master@{#313627}

The "shadow" App Launcher registry keys are still managed.  The code that
do this are concentrated to the new files app_launcher_installer.* to
facilitate future updates.

This CL also significantly reduces the size of setup.exe, presumably due
to removal of dependencies.

TEST=Windows only. Install and update still work as before.
- Right after fresh install, ensure reg key at user level exists:
Google\Update\Clients\{FDA71E6F-AC4C-4a00-8B70-9958A68906BF}

BUG=297647

Review URL: https://codereview.chromium.org/811283002

Cr-Commit-Position: refs/heads/master@{#313626}

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/866263002

Cr-Commit-Position: refs/heads/master@{#313625}

BUG=

Review URL: https://codereview.chromium.org/884213002

Cr-Commit-Position: refs/heads/master@{#313624}

When shutting down HostProcess config_watcher_ is supposed to be deleted
on the nework thread. Previously ShutdownOnNetworkThread() was deleting
it, but that line was mistakenly removed in crrev.com/302162 . Adding
it back.

Review URL: https://codereview.chromium.org/885693003

Cr-Commit-Position: refs/heads/master@{#313623}

Update ImportController to push all updates to a new 'CommandWidget' class. Add more test coverage.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/880303002

Cr-Commit-Position: refs/heads/master@{#313622}

Add calls to hash generation and comparison code so that files being imported
into Google Drive are actually deduplicated.

BUG=420680
TEST=FileManagerJsTest.DuplicateFinderTest FileManagerJsTest.MediaImportHandlerTest

Review URL: https://codereview.chromium.org/885653003

Cr-Commit-Position: refs/heads/master@{#313621}