- 28 Jan, 2018 25 commits
-
-
Matt Wolenetz authored
SAP-Type-2 sequences may contain a nonkeyframe so far in advance of the range's first GOP's keyframe timestamp that it may appear to belong to the presentation interval of some other range. If we continued to use |last_appended_buffer_timestamp_| when re-determining |range_for_next_append_| upon consulting PotentialNextAppendTimestamp() during buffer removal operations that touched the current |range_for_next_append_|, we could incorrectly append to the earlier range. This change uses the |highest_timestamp_in_append_sequence_| in PotentialNextAppendTimestamp(), enabling correct determination of |range_for_next_append_| when such SAP-Type-2 scenarios are encountered when BufferingByPts. Note: This change continues the direction of the BufferingByPts logic so far: it doesn't move a range's start time earlier if that range contains a nonkeyframe from a SAP-Type-2 GOP before the range's starting keyframe. This greatly simplifies adapting our existing logic to gracefully handle SAP-Type-2, with the known caveat that range start times don't indicate any potentially buffered earlier SAP-Type-2 nonkeyframes. See also https://crbug.com/798935#c10 BUG=798935,804802,795655 TEST=Added SBST.Sap2GopWithNonKeyframeInEarlierRangesInterval, and the CF cases for bugs 798935 and 804802 no longer repro locally with this change. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieff9b086ec9ac73f02a6bfbfa406765b434d9728 Reviewed-on: https://chromium-review.googlesource.com/879408 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#532280}
-
Nico Weber authored
This CL was uploaded by git cl split. R=michaeln@chromium.org Bug: 177475 Change-Id: I3ebd2f2384837724637614391d1894f870662b6f Reviewed-on: https://chromium-review.googlesource.com/889731Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532279}
-
Evan Stade authored
- ui/message_center/mojo/ => ui/message_center/public/mojo/ - ui/message_center/notification.cc, etc. => ui/message_center/public/cpp The public directory contains code that will be compiled into both Chrome and Ash binaries. On CrOS, the non-public directory will only be compiled in Ash. On Linux and Windows, the non-public directory will still be compiled into the browser. This CL doesn't actually enact any of the above, but it sets up separate build targets and begins to get dependencies correct. For example, Notification is now blocked from depending on MessageCenter. Bug: 578868 Change-Id: Ie32e0f4ab114ec292462a7b87c94b1dcee0540da Reviewed-on: https://chromium-review.googlesource.com/887978 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#532278}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c9431a8. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11181 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: Idd9c9173ee2f1dd245f09e4205c7fabe3ae29cb0 Reviewed-on: https://chromium-review.googlesource.com/890068 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532277}
-
Nico Weber authored
Bug: 177475 R=wuchengli@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3a2821e16c61556247324c867daaa008cf7f61d6 Reviewed-on: https://chromium-review.googlesource.com/889788Reviewed-by:
-
Max Morin authored
With the new mojo browser-renderer audio input IPC code, shared memory is shared read only with the renderer. This info is lost on the way to pepper, causing it to try to map the memory with write permissons, even though it's not needed. When the memory enters closed-source code, it does so through PPB_AudioInput_Callback_0_3 or PPB_AudioInput_Callback, so hopefully noone will do something stupid like write to the memory there :). Bug: 805901 Change-Id: I93517b1a7ba7583c4782c029c46cf3bead8d4875 Reviewed-on: https://chromium-review.googlesource.com/889158 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532275}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fbe6620284a5..04fce9c80879 $ git log fbe662028..04fce9c80 --date=short --no-merges --format='%ad %ae %s' 2018-01-28 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I375a7d61fb5a4be192e9cf2fb4923c848f926581 Reviewed-on: https://chromium-review.googlesource.com/890289 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532274}
-
Satoshi Niwa authored
from web_contents_view_aura.cc There is a need to read URL(s) from a pickle in exo for correctly handling a URL when the user drag&drops a filesystem file onto an Arc app. (chromium:767982) See crrev.com/c/867807 for how it will be used in exo. Bug: chromium:767982 Test: out/Default/content_unittests --gtest_filter="DropDataTest.*" Change-Id: I00c827c6af9e20fd38c33b3e4796207cb5dedeb3 Reviewed-on: https://chromium-review.googlesource.com/888278 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532273}
-
Koji Ishii authored
compositing/sibling-positioning.html compositing/reflections/reflection-positioning.html compositing/reflections/reflection-positioning2.html fast/block/basic/014.html fast/block/basic/020.html fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2.html fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks.html fast/block/float/overhanging-float-remove-from-fixed-position-block.html fast/block/float/overhanging-float-remove-from-fixed-position-block2.html fast/block/float/selection-gap-clip-out-tiger-crash.html fast/inline/inline-borders-with-bidi-override.html fast/text/drawBidiText.html fast/text/international/shape-across-elements.html TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I289492e631b399458e0b18a7571f86d227880ed7 Reviewed-on: https://chromium-review.googlesource.com/888279 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532272}
-
Christopher Cameron authored
InProcessCommandBuffer::CreateImageOnGpuThread assumes that its client id is zero, but InProcessGpuMemoryBufferManager uses the constant one. Put the constant in a InProcessCommandBuffer to keep them the same. Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I18f48dff252af04a438e09382277f0a5c7208d44 Reviewed-on: https://chromium-review.googlesource.com/882442Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#532271}
-
Aleks Totic authored
I think that this patch is a good starting point for outline implementation. It implements a basic outline painting algorithm: - Outlines are painted by containing self painting fragment. - Outlines are computed as: traverse fragment's descendants combine outlines for fragments with common layout objects paint combined outlines, using first fragment as DisplayItem There are many problems: - All descendant fragments are traversed for each outline paint, even if there are no outlines to be painted. Fix: detect outline existence while descendants are being painted, and only call this code if there are outlines. There are 119 tests in our test suite that trigger inline outline paint code. With this patch, we get 4 regressions: fast/history/visited-link-hover-outline-color.html paint/invalidation/overflow/inline-block-overflow-repaint.html paint/invalidation/overflow/inline-box-overflow-repaint.html cause: improper invalidation fast/inline/nested-text-descendants.html cause: inline text position 15 additional tests pass. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icccd225abac7e38fd9a871ee2914ff8d235474e3 Reviewed-on: https://chromium-review.googlesource.com/887633 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#532270}
-
Christopher Cameron authored
Plumb the flag --disable-mac-overlays. Update CALayer parameters to make the IOSurfaces CAContextID mutually exclusive (otherwise we get warned that the IOSurface mach port is invalid, when it is expected to be invalid). R=dcheng, fsamuel TBR=avi (content/) Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iaa2f2fdfb6dbb4135bd989f4c2af1ab6be892a1a Reviewed-on: https://chromium-review.googlesource.com/882316 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532269}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/aba14ff52bea..e76240044631 $ git log aba14ff52..e76240044 --date=short --no-merges --format='%ad %ae %s' 2018-01-27 ynovikov Fix Android build 2018-01-26 jmadill Entry Points: Expose glTexStorage3DEXT. 2018-01-25 ynovikov Print more logs when using default Platform 2017-12-25 jiawei.shao ES31: Refactor link mismatch error log 2018-01-25 oetuaho Use ImmutableString for HLSL texture references 2018-01-23 jmadill Vulkan: Implement the Pipeline cache. 2018-01-24 oetuaho Add a simple compiler perf test 2018-01-24 jmadill Vulkan: Add draw call perf test with a state change. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I66388a897a0c48bb7f770cfbb52d36d6bed587a0 Reviewed-on: https://chromium-review.googlesource.com/889696 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532268}
-
Yuzhu Shen authored
This CL changes: - RenderFrame::GetURLLoaderFactory() - ResourceFetcher::Start() Bug: 796425 TBR=jam@chromium.org (for fairly mechanical change of callsites in chrome/renderer/net/net_error_helper.cc). Change-Id: I65a99bd416a8a2ea1e1ca34870242868be11b8d0 Reviewed-on: https://chromium-review.googlesource.com/887645 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
-
Aleks Totic authored
Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2fd589b4db0fbeba4b142d130fb95f9cb804bc49 Reviewed-on: https://chromium-review.googlesource.com/889681Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#532266}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ibab61c12c168fe6777fe0a087cc33a8bc887e581 Reviewed-on: https://chromium-review.googlesource.com/889955Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#532265}
-
Mitsuru Oshima authored
Old remote shell drag used to capture the surface during drag because motion events have to be sent to android. And cursor update logic was depending on this behavior. This is no longer true in chrome driven drag&resize and the capture is now on the remote shell's widget (same as xdg). This CL makes the update logic independent of focus surface, and updates the cursor if the cursor created by this when moves to different display. BUG=804471 TEST=manual Change-Id: I8dc7a6fdc6f87c7b3872e54d7a61f43e2904b263 Reviewed-on: https://chromium-review.googlesource.com/882191 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
They were inconsistently sent from different places, which led to this bug because DragResizer isn't used in multi window resizer. They should be sent from single soruce. BUG=b/72402303 TEST=Covered by unit tests. Also tested manually. See bug for repro step. Change-Id: If9e24b7b62d879a83607ee99634c2670645c7bb6 Reviewed-on: https://chromium-review.googlesource.com/885081 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#532263}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d3c1b84a6e26..fbe6620284a5 $ git log d3c1b84a6..fbe662028 --date=short --no-merges --format='%ad %ae %s' 2018-01-26 mtklein add SkPicture::MakePlaceholder() Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ic47a357d13b3e18403d32de8bbd1e6b21baa2acb Reviewed-on: https://chromium-review.googlesource.com/890618 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=ericwilligers@chromium.org Bug: 177475 Change-Id: I452c8970b61ae8a2e610fe1c9698583960c7a005 Reviewed-on: https://chromium-review.googlesource.com/890061 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#532261}
-
Francois Doray authored
Replace usage with ScopedTaskEnvironment. TBR=glider@chromium.org Bug: 667892 Change-Id: I93d25b143a39f8966d425d98954bec28c710857a Reviewed-on: https://chromium-review.googlesource.com/881532Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532260}
-
Tom Anderson authored
The buildtools roll includes these revisions: https://chromium.googlesource.com/chromium/buildtools/+log/437a616be5b2056336ed3ca5c33c41f7788ede09..a2cbf26d9ed33836bc3e412b4dc0df259e4a1525 BUG=803679 R=thakis@chromium.org Change-Id: Ie398be7d8ef52d6a733f52043300449b3d35e947 Reviewed-on: https://chromium-review.googlesource.com/875330 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532259}
-
Robert Liao authored
This performs a task flush similar to TaskScheduler::FlushForTesting() except it is async. It calls the callback if TaskScheduler::Flush() would have returned. BUG=804930 Change-Id: I533ab5a2fbaccd79a220aad3a535fa37ed7df823 Reviewed-on: https://chromium-review.googlesource.com/883607 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Miguel Casas authored
This reverts commit 62633a07. Reason for revert: Broke chromium.gpu.fyi Mac Experimental Retina Release (NVIDIA) https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Experimental%20Retina%20Release%20%28NVIDIA%29/3232 Original change's description: > Mac gl_unittests: enable GLImageBindTest BGRX_1010102 > > This CL adds gl_unittests to chromium.gpu.fyi, hence making it > run, among others, on the Mac nVidia bot that caused the original > CL to be reverted. > > There's more information on the bug but, in a nutshell, the > original CL was reverted due to a specific nVidia bug that > manifested itself on the chromium.gpu.fyi mac bot; however, > it doesn't show up in the mac_optional_gpu_rel. So, this CL > has no specific nVidia provisions, just reenables the test, > and we'll see what happens in the chromium.gpu.fyi waterfall :-) > > > Bug: 803473 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I71c0451d2e3b53baa3bd24bafdf1f7a5f1210363 > Reviewed-on: https://chromium-review.googlesource.com/886543 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532136} TBR=kbr@chromium.org,mcasas@chromium.org Change-Id: I5988cab9dcb3fe2da1f22750ec76c1ffb0cf4555 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/889771Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532257}
-
Daniele Castagna authored
On intel, we want to be able to use SCANOUT_CPU_READ_WRITE with GMBs videoframes (cfr ). This CL adds YUV_420_BIPLANAR and other supported formats to SCANOUT_CPU_READ_WRITE. Bug: b/71837407 Change-Id: I1fcb5148ce71c2eeb90feb8ccc0b7378e9f1b0b8 Reviewed-on: https://chromium-review.googlesource.com/889846Reviewed-by:
-
- 27 Jan, 2018 15 commits
-
-
Nico Weber authored
This CL was uploaded by git cl split. R=eae@chromium.org Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3a861bf5eb39da51b628eafae99d0bff3ebfab39 Reviewed-on: https://chromium-review.googlesource.com/889728Reviewed-by:
-
Vaclav Brozek authored
The user needs to reauthenticate both to view/copy and to export passwords. Once reauthenticated, the authentication is skipped for the next 60 seconds. Through authentication, the user grants an easy access to anybody holding their device in the next 60 seconds to the passwords on their device. The explanation message of the reauth prompt includes the scope of the approval (e.g., "to view your passwords" or "to export your passwords") of the _first_ reason to reauthenticate. To protect the privacy of the user, if they grant the access for a one-at-a-time access (e.g., viewing passwords) but then a bulk access (e.g., export of all passwords) is requested within the grace period of 60 seconds, Chrome ignores the grace period and requests the reauth again. Bug: 800686 Change-Id: Icc96bf490b13ba7ba172bc88fdef0ffdefaf97f2 Reviewed-on: https://chromium-review.googlesource.com/883525 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532254}
-
Scott Violet authored
Specifically this converts back to setting the ConfigurationPolicyProviders *before* the PolicyService is created. There is a subtle difference between this code and the way the code was before my patch. Specifically previously the code did the following: 1. ChromeBrowserPolicyConnector created, which added a bunch of providers from constructor. 2. BrowserPolicyConnectorBase::GetPolicyService is called, which creates the service and pushes the providers to the PolicyServiceImpl 3. local state/field-trials created. 4. BrowserPolicyConnector::InitInternal was called, which in turn called Init() on the providers. With this patch, order is now: 1. ChromeBrowserPolicyConnector constructor does very little 2. ChromeBrowserPolicyConnector::InitPolicyProviders is called, which creates the providers. 3. BrowserPolicyConnectorBase::SetPolicyProviders is called, which creates the PolicyService and calls Init() on all the providers and sets is_initialized_. 4. BrowserPolicyConnectorBase::GetPolicyService is called, creating the PolicyService. 5. local state/field-trials created. 6. BrowserPolicyConnector::InitInternal is called. Key differences: . ConfigurationPolicyProvider::Init() is called earlier. . Had to remove DCHECK in BrowserPolicyConnector::InitInternal() because SetProviders sets is_initialized_. BUG=806538 TEST=none Change-Id: I0981419cb1734208789639cc1713e49ac8e901c7 Reviewed-on: https://chromium-review.googlesource.com/889500 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#532253}
-
John Chen authored
This is a reland of aa7860c7, with the change to enable the ChromeDriver tests on release bot only. The original commit was reverted due to flakiness of the tests on debug build. The reason for the flakiness is debug build of Chrome takes a long time to start, usually between 20 to 40 seconds. The timeout for the test is 30 seconds, thus it can either succeed or fail depending on whether Chrome started quick enough or not. While it is possible to increase the timeout, spending over 30 seconds per test appears to be too much overhead in the long run. Also, the purpose of running these tests is to catch incompatibilities that can develop between Chrome and ChromeDriver, and running these tests on release builds should suffice for that purpose. Original change's description: > [ChromeDriver] Add ChromeDriver tests to Commit Queue > > This is the initial check-in of the feature to add ChromeDriver tests > to commit queue. It includes the following: > > * A new test target chromedriver_py_tests, to encapsulate dependencies > needed to run the Python-based ChromeDriver tests. This target is > currently enabled on Linux only. Other platforms will be added later. > > * Only a single test case is enabled. Enabling additional test cases > will be done later. > > Bug: 793370 > Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47 > Reviewed-on: https://chromium-review.googlesource.com/874816 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531234} Bug: 793370 Change-Id: Ic8873c326dfcd676552083d6f90aba29cc046e67 Reviewed-on: https://chromium-review.googlesource.com/885082Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532252}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fc20008819f3..d3c1b84a6e26 $ git log fc2000881..d3c1b84a6 --date=short --no-merges --format='%ad %ae %s' 2018-01-27 fmalita [skottie] Render DM frames out-of-order 2018-01-27 mtklein Revert "hide picture virtuals (no public callers)" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I02b187e0d3afe1434aeb43bff6e54f8785c0d303 Reviewed-on: https://chromium-review.googlesource.com/890460 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 712abc66. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11096 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: I7e040b7dabbfa5217aa0d5240f4d71ad1464d4e7 Reviewed-on: https://chromium-review.googlesource.com/889952 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=806340 TBR=hamelphi@chromium.org Change-Id: Ib4e5091212d874d9ad88f3e9a1fdfee3ed7e0d5e Reviewed-on: https://chromium-review.googlesource.com/890059Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532249}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3ebeca61c483721c96b597c406910637d920fcb Reviewed-on: https://chromium-review.googlesource.com/887558Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#532248}
-
Thomas Anderson authored
This reverts commit 93f7aa87. Reason for revert: Causes failure in WebContentsVideoCaptureDeviceBrowserTest on Linux Tests (dbg)(1)(32): https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/47651 Original change's description: > FrameSinkVideoCapturer: Fix refresh logic for damaged sources. > > Fixes a couple of issues where frame capture becomes frozen or choppy, > with the following changes: > > 1. Move the "source dirty" logic out of VideoCaptureOracle and into > FrameSinkVideoCapturerImpl. > > 2. More-agressive response to frame refresh requests (needed for > improved mouse cursor update response). > > 3. Remove the distinction between passive and active refreshes from > VideoCaptureOracle. FrameSinkVideoCapturer now tracks source damage, and > can execute any refresh passively when there is no damage. > > 4. Add logic to ensure that FrameSinkVideoCapturerImpl provides > consumers with a refresh frame whenever key events occur; such as params > changes, capture target changes, etc.; that are known to require a full > update. > > 5. Re-enable the content_browsertests that were disabled due to > flakiness. > > Bug: 785072, 754872 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I402f3f928de61e6754e04014327421e4f6917d5f > Reviewed-on: https://chromium-review.googlesource.com/884996 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532161} TBR=miu@chromium.org,kylechar@chromium.org,xjz@chromium.org Change-Id: I32fd2fb0bf1e1dc32c026198809d12ff2ecc69f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785072, 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/890380Reviewed-by:
-
dpapad authored
Bug: 800773 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I546e25b3748e455449ee3c0a541c5a6658ee2504 Reviewed-on: https://chromium-review.googlesource.com/884847 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532246}
-
Scott Violet authored
the viz::FrameSinkId is not used when mus is hosting viz (the current code DCHECKs in mus as we end up supplying an invalid FrameSinkId, which triggers a DCHECK). To address this address a struct with param traits to ensure the FrameSinkId is set when appropriate. BUG=804508 TEST=covered by tests Change-Id: I1949d546d7aa7db39dc0ad2116694b614b3b875f Reviewed-on: https://chromium-review.googlesource.com/887619 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Yi Gu authored
The current cc/animations logic assumes a single animation has a single keyframe effect and can only affect a single layer. To enable animations with multiple keyframe effects, cc::AnimationPlayer need to support multiple AnimationTickers each corresponding to one keyframe effect. Currently there is a 1:1 relationship between AnimationPlayer and AnimationTicker. This patch is to extend it to 1:n. Here is a summary of changes: - Introduce a sub-class of AnimationPlayer, a.k.a SingleTickerAnimationPlayer, to handle the existing logic (single effect). SingleTickerAnimationPlayer owns only one AnimationTicker as the AnimationPlayer does today. - Currently a AnimationTicker is created upon creating AnimationPlayer. In this patch, tickers are created separately and added to the player afterwards. Tickers that the player owns may belong to different targets therefore the player needs to coordinate with AnimationHost regarding this situation. - Adjust existing unit tests according to the changes above. Bug: 767043 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibd2ed2f396effec9fbc206ff52c7b94474342d39 Reviewed-on: https://chromium-review.googlesource.com/742162 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#532244}
-
Alexei Filippov authored
BUG=803276 Change-Id: I1722ef6d2a9b529919189d7babb767bfc7cbbf83 Reviewed-on: https://chromium-review.googlesource.com/888328 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532243}
-
Alexei Filippov authored
The profile type is put behind a hidden experiment. BUG=803276 Change-Id: Ieb16c0eda7653ac90ef5ce8fc2008b724b2af4e8 Reviewed-on: https://chromium-review.googlesource.com/884574 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL makes sure that Blink code that needs to consult the current input event considers events going either through WebViewImpl or through a WebFrameWidgetImpl. The CL removes separately maintained |current_input_event_| fields from WebViewImpl and WebFrameWidgetImpl (the latter was never read anyway) and consolidates them into a new class - CurrentInputEvent. Bug: 804838 Change-Id: I89430f3a73f38ef5842c57635602fb079c1a34ef Reviewed-on: https://chromium-review.googlesource.com/887346Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#532241}
-
