- 19 Dec, 2019 40 commits
-
-
sczs authored
-This CL is part of the history_ui_egtest migration, in which resetBrowsingDataPrefs used to live. -Cleans up un-used imports and DEPS from history_ui_egtest. Change-Id: Ie3683213564d22659a9118761206582f71ee502f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976154Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726512}
-
Nick Harper authored
Removal was requested via email after a change of ownership of the domain. Removal request was verified via a DNS challenge. Change-Id: Ia528bcd2d6107eb827f431b4e944004930986bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976286 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726511}
-
Chris Lu authored
This situation can be triggered by the Translate Infobar being shown and the page is translated when the user taps on the Translate button in the Overflow menu. In this situation, the new step (AFTER_TRANSLATE) matches the current state. Bug: 1033888 Change-Id: I4f330e8b32d75931551273218017019baacac21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975691 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#726510}
-
Adithya Srinivasan authored
It seems that unlike EvalJs, ExecJs doesn't wait for promises to resolve before returning. This fixes existing portal browsertests to use EvalJs when waiting for a promise. Change-Id: Ib1cdb50e79b19fd8296f6b29fd8fbf9931c92ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976193Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726509}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic9f85b749810bdfb685a71ce5163eb4d4335887f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976295Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#726508}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers all of components/sync/ and the minimal set of necessary updates to client code elsewhere in the tree. Fixed: 1007739 Change-Id: I423028ab7b6f1b277b0a2e42a89a5a0ea09361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975452 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726507}
-
George Steel authored
Make target() return the originating element if target_ is a PseudoElement (EventTarget still returns the layout object). Add pseudoElement() property which returns the target pseudo-selector if the target is a pseudo-element (null otherwise). Invalid and unsupported pseudo-elements will still return a selector and the originating element (from target()) but will not animated (EventTarget returns null). Add pseudoElement option to KeyframeEffect constructor. Change-Id: Id7d16ea6966c533e56d1170462ff60a79b277fd5 Bug: 981894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921343 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#726506}
-
David Munro authored
* Capture every call to RestartCrostini so we can detect when we fail to reach the end (hang, crash, etc). * Move result logging to the destructor to close some gaps where we wouldn't log result * Default is_initial_install_ to false instead of true. When multiple restarts are queued only the first gets is_initial_install set correctly so we'd miss emitting metrics in that case. Now we rely on the installer to dedupe multiple installation requests and otherwise emit result for every run. Bug: chromium:1031925 Test: Unit tests. Change-Id: If348669a1e1e95f5bf24b148d2d6fd341078278e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965741Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#726505}
-
Koji Ishii authored
This patch fixes `text-overflow: ellipsis` to take the space occupied by `text-indent` into the account. Bug: 1006395 Change-Id: I417176efbc8f10fa3c073efa7695458fb2d302a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975372Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#726504}
-
Natalie Chouinard authored
Create separate Settings module, and build SettingsUtils.java in this new target. Bug: 1035928 Change-Id: I906b860d7486569305757acac0a56ec4a545d5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976153Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726503}
-
Caleb Rouleau authored
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8893636477245975664/+/steps/dawn_perf_tests_on_ATI_GPU_on_Mac_on_Mac-10.13.3/0/logs/Merge_script_log/0 Traceback (most recent call last): File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 361, in process_perf_results configuration_name, build_properties, extra_links, output_results_dir) File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 548, in _handle_perf_results is_reference, upload_failure=not upload_succeed) File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 580, in _write_perf_data_to_logfile json.dump(results, output_json_file, UnboundLocalError: local variable 'results' referenced before assignment Bug: 1035590 Change-Id: I6d0fd9373f94d6484ce42cf867a50e302ef428d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976294 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726502}
-
nancy authored
TBR=joelhockey@chromium.org BUG=1011235 Change-Id: Ia48be8b3e6b5d03bcb1c505ab405c536786cae7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975381Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726501}
-
Mario Sanchez Prada authored
This file contains references to old mojo types and so removing it will both reduce dead code in the repository and remove instances to old mojo types, so let's delete it. Bug: 955171 Change-Id: I04682b47cae9bc676c4da301b4e4337c12594a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975914Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#726500}
-
Tom Anderson authored
There were 32 linux documents in docs. It's getting out of hand, so lets move them to a subdirectory. R=sky,jorgelo CC=thestig BUG=None Change-Id: Ib7de415c72fe6ec3c51dc2b28f06b34487b5b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974901 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726499}
-
Mark Schillaci authored
Updated BrowserAccessibilityAndroid::IsClickable() to default to whether a node is a control on Android, rather than if a node is focusable. Added a test case to DumpAccessibilityTreeTests for non-focusable nodes (e.g. tabIndex=-1) with expected output. Bug: 1023229 Change-Id: I588df1f438f5391445c9ded514c526a06f3a65d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953646Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#726498}
-
Caleb Rouleau authored
Bug: 1035696 Change-Id: Ifb123b04337f3a899422ee0337dfde8ecf4f57d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975158 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#726497}
-
Caleb Rouleau authored
The upload for these is hanging on mac. My guess is that the root cause is the same as for windows where it hits a 403. However, the result is much worse for mac because it waits for over an hour before it hits the overall timeout. The longterm solution is to convert dawn_perf_tests to histograms. Bug: 1035590 Change-Id: I9070d04e527cc4387ba793963de78fa73141a0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976020 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#726496}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e020cf38f429..addc9bfc6cd1 git log e020cf38f429..addc9bfc6cd1 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 thestig@chromium.org Expose MakeTag() as CFX_FontMapper::MakeTag(). 2019-12-19 thestig@chromium.org Switch testing/image_diff/ code to use uint8_t instead of unsigned char. 2019-12-19 thestig@chromium.org Add core/fxcrt/byteorder.h. 2019-12-19 thestig@chromium.org Do less work in XFATestEnvironment::SetUp(). 2019-12-19 thestig@chromium.org Remove some references to fxcrt namespace. 2019-12-19 thestig@chromium.org Avoid using std::function to improve performance. 2019-12-19 nigi@chromium.org Remove parsing decimal numbers in StringToCode(). Created with: gclient setdep -r src/third_party/pdfium@addc9bfc6cd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7b4b7ff062b46de17934f76ac304d66a44d4355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726495}
-
Domenic Denicola authored
This updates the parsing of the feature policy parts of the origin policy manifest to mostly match the latest spec draft at https://wicg.github.io/origin-policy/, in particular https://wicg.github.io/origin-policy/#parsing. That is, it moves away from "feature-policy": ["... FP string"] to "features": { "policy": "... FP string" }. This changes the data model from a list of FP strings to an optional FP string. Additionally, it removes the failure on parsing errors, as those are no longer in the spec. This does not yet properly parse the FP string as a FP directive; instead it still treats it as a header (so, commas are allowed inside). A failing test is added for that case, which will be addressed in a followup CL. Bug: 751996 Change-Id: I51711ee9381ecfc705683ba0eb870e461fed434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965905 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#726494}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/04d5ba90fb16..f0ff36f6b2cb git log 04d5ba90fb16..f0ff36f6b2cb --date=short --first-parent --format='%ad %ae %s' 2019-12-19 brcui@microsoft.com Improve What's New Tool Accessibility 2019-12-19 brcui@microsoft.com Always show Show More buttons in data grid 2019-12-19 comoody@microsoft.com Normalize excluded file paths in check_gn.js to fix presubmit checks on Windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@f0ff36f6b2cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I981a0cf3e4a3339a4a7038e95c6bc17f3c4c5ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726493}
-
Sergey Ulanov authored
Previously FuchsiaAudioRenderer was expecting timeline update with stream_delta > 0 after Start(). That doesn't work correctly when playback is started with playbackRate=0.0 . Presence of presentation_timeline attribute in AudioConsumerStatus indicates that playback has started, i.e. Start() call has been handled, so it's not necessary to check stream_delta > 0. Bug: 1027048 Change-Id: Ie4de38c34a2ce6cb57faf567b784275b3a2d5a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976285 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726492}
-
Tricia Crichton authored
Added tests to check sameSite handling for creating Cookies. Bug: chromedriver:3265 Change-Id: I1591d2ec08287a0edc48fdeb628146165b08fc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956363 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726491}
-
Chase Phillips authored
Bug: 1033703 Change-Id: Ia1d978f58d04124f044e69055096af6ef4538067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869122 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#726490}
-
Brandon Goddard authored
This CL re-enables and rebaselines 2 tests that were disabled to land an accessibility change to devtools treeoutlines. It additionally adds an aXe test to prevent regressions. This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/1962600 Related devtools change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960952 Bug: 1033213 Change-Id: Ieaefa3b18b294073af1a16cf63f9d0014f6f5bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976495Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726489}
-
Connie Wan authored
Change-Id: I3de52c062deeb2f82488713f2776568be0485943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976197Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#726488}
-
Joshua Pawlicki authored
Bug: 1035895 Change-Id: I1c317e15e711de8df3ee94cdc6cb042cf8282c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976195 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726487}
-
Henrique Nakashima authored
Remove "PREFS" and "KEY" from the constant names since they are already referenced as "ChromePreferenceKeys.FOO". Prepend some prefixes bundling together related prefs. This is a preparation to alpha sort these names. Change-Id: I7bdc559d2c7de6ab723a4753a8ae30cfc2959d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974854 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#726486}
-
Sebastien authored
Removed the Chrome Branding check from registering the prefs since: - In reality the code is there and prefs may be checked on non-Chrome branded builds. The pref, however, will only be set by the update of a Chrome Omaha component downloaded from our servers. Since that is gated by Chrome Branding, I believe it's safe to remove the check here. - It also allows us to write more realistic test coverage and get the tests to run on more bots. Wrote the tests as PlatformBrowserTests and added them to the android_browsertests target. We can easily add other platforms in the future by adding them to the browser_tests target. We cannot add them now since, for example, we're only registering the Game pref on Android. Bug: 1018201 Change-Id: I99af5bd6e4eba601fab09b77e23de92d073c90c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959938 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#726485}
-
kylechar authored
VizDisplayCompositor has launched so the non_viz_* tests are no longer relevant. Bug: 732805, 936425 Change-Id: Ifd1ee9179766366e33c20c551dfb770f4818839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972789Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726484}
-
Eric Stevenson authored
* Remove static_library_proguard_disabled and instead separate static_library_provider and static_library_synchronized_proguard into separate flags. * Only enable synchronized proguard for the most basic Trichrome targets (can enable for others when we want to ship). * Add a real dep on static library provider APKs (so that they don't both need to be compiled explicitly). * Clean up stale GN variables. Bug: 921284, 901465 Change-Id: I346fe3e824ece041cd1df064e81b2939e64c6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955802 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726483}
-
Guillaume Jenkins authored
========== RELAND NOTE: I forgot to add an OS version check in one of the new tests, which caused it to fail on Windows 7. Patchset 1 is the reverted CL as-is. Patchset 2 contains the version check in the failing test. Initial CL: https://chromium-review.googlesource.com/c/chromium/src/+/1972573 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1975370 ========== Adds tests for the Hunspell fallback logic (Windows hybrid spell checking) submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/1918277 - Adds browser tests for SpellCheckHostChromeImpl - Adds component tests for the new SpellcheckHostMetrics - Adds component test coverage for the new SpellcheckPlatform methods in the Windows platform test - Created a bug to track splitting the single test into multiple ones - Adds component tests for SpellcheckProvider - Creates a new FakeSpellCheck class to fake the count of enabled spell check locales, which is needed to control when to call into the browser spell checker Bug: 463364, 1035450 Change-Id: Ia13d1f976079f08a5ca48036d0fa7327c558a9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972573 Auto-Submit: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#726150} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976491 Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#726482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2627d4d90fac..a509bcf2af35 Created with: gclient setdep -r src-internal@a509bcf2af35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icc2e8420a131fadc3fbf9b74b99e9f551e52b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976741Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726481}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/navigation_interception/ - components/net_log/ - components/offline_pages/ Fixed: 1007710, 1007705, 1007704 Change-Id: Ifdab534c0dce4d1b484540b6c770a0f3d8e6e7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976493Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726480}
-
Eric Stevenson authored
Change-Id: Iaa03a4edd1bdc1657e388930ac675655795b1bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976563Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726479}
-
Stephen Nusko authored
This reverts commit e9af78d1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable failing blink_perf.canvas tests. > > blink_perf.canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF > everywhere and others on android, mac, and win. > > NOTRY=true > TBR=crouleau@chromium.org > BUG=1035865,978500 > CC=aaronhk@chromium.org,fserb@chromium.org > > Change-Id: I747fb7924f9632edd3bf5f6582e99f028e4fb65e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975923 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726395} TBR=crouleau@chromium.org,nuskos@chromium.org Change-Id: Idba3ad4cc6838dbcc12b7783e4dc8e57ad301ac1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035865, 978500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976824Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726478}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b70d915..0340c945 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I330e3d51362344115c5861b6ab395b0136f78429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976220Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726477}
-
Steven Bennetts authored
When we switched to using an unmanaged enum for vpn.type (which is an intrinsic / immutable property of a configured VPN), it broke the policy indicator for the type selector, which assumes that the 'property' property will be a managed type (e.g. ManagedString). Since the provider type can not be changed, it is not useful to show the policy indicator for policy managed networks (the provider type must be provided by the policy). Therefore we should just leave 'property' undefined for that network-config-select element. Bug: 1035581 Change-Id: I47704adff49fa1063eab5e93a8654645a2ec1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976492Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726476}
-
meacer authored
This CL adds a list of characters that look like Latin characters. A domain consisting only of these characters and not having the .il ccTLD will be converted to punycode, as is done for Cyrillic Latin-lookalikes. The impact of this change is minimal on existing domains with <5 domains being affected. Bug: 722167 Change-Id: I0fd9c13331b10845958612f58fb6353d5fdb6c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975054Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726475}
-
Sammie Quon authored
Prior to this patch, the drop target would: - show an extra background for windows with backdrop or maximized windows with top insets - shift when dragging a maximized window with top insets Test: manual Bug: 1035526 Change-Id: Iac2ae0ec35268417d8cf369c76d9890b49583587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976312Reviewed-by:
Avery Musbach <amusbach@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#726474}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a9153faa00d..bd7e3bec93be git log 7a9153faa00d..bd7e3bec93be --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com trace_processor: add a fast path for zero/one row filtered tables 2019-12-19 lalitm@google.com perfetto: fix amalgamated build Created with: gclient setdep -r src/third_party/perfetto@bd7e3bec93be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Ib41fb9fc77a5d237c12ae9a9a51c45843d35f282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726473}
-