- 22 Mar, 2018 40 commits
-
-
Patrick Monette authored
A previous CL was meant to whitelist modules whose cert's subject matches the cert's subject of the executable, but the code was added in the wrong file. Move the check from ModuleListFilter where it doesn't belong and move it to the ProblematicProgramsUpdater class. Also added a unit test to make sure the issue is really fixed. Bug: 819793 Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 Reviewed-on: https://chromium-review.googlesource.com/969601 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#545128}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7b5a57449ba0..1f82e0612293 $ git log 7b5a57449..1f82e0612 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 jianj VP9 SVC: Add control to disable inter layer prediction. 2018-03-18 marpan vp9-svc: Improve frame dropper for spatial layers. 2018-03-19 johannkoenig visual studio: add yasm instructions 2018-03-19 johannkoenig build: remove stale .git files 2018-03-14 johannkoenig reland "use intrinsics for 'emms'" 2018-03-16 jzern CopyFrameTest: reduce max size for 32-bit targets 2018-02-21 jianj VP8: Fix out of range index for mvcost. 2018-03-16 jzern vpx_scale_test: reduce max size for 32-bit targets 2018-03-14 marpan vp9-svc: Frame dropper for SVC. 2018-03-15 jzern Revert "vp9_loopfilter.c: zero lfl_uv" 2017-06-26 jzern libs.mk,vcxproj generation: split srcs in invocation 2018-03-14 marpan vp9-svc: Bugfix to dyanmic enabling/disabling of layers. 2018-03-14 johannkoenig vp9_resize.c: assert vp9_highbd_resize_plane conditions 2018-03-12 johannkoenig remove spatial svc experiment 2018-03-14 johannkoenig vp9_loopfilter.c: zero lfl_uv 2018-03-14 johannkoenig vp8 rdopt.c: zero rd.[rate_uv|distortion_uv] 2018-03-14 johannkoenig vp8 mfqe: zero map[] 2018-03-14 johannkoenig temporal svc: zero layer_target_bitrate 2018-03-14 johannkoenig Revert "use intrinsics for 'emms'" 2018-03-13 johannkoenig spatial svc: set window_size to 15 (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Iff8288bbb3d1e8d0e36d469b5cb7f1ee8b38962e Reviewed-on: https://chromium-review.googlesource.com/973744Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#545127}
-
Alexander Timin authored
Measure the amount of work done in background when keep-active signal is present. This is to allow us to test the theory that we stopped stopping timers in background after 5 minutes on Android due to widespread keep-active signal. R=panicker@chromium.org,rkaplow@chromium.org BUG=823482 Change-Id: I653016d795a1903ea9d943e3c2b962ab9c1ba088 Reviewed-on: https://chromium-review.googlesource.com/973225Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545126}
-
Matt Wolenetz authored
Mark as flaky in Win TBR=hbos@chromium.org,hta@chromium.org BUG=824830,823003 NO-TRY=True Change-Id: Iabd4ddc714220082b332754c093652178ce91c27 Reviewed-on: https://chromium-review.googlesource.com/976048Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545125}
-
Kristian H. Kristensen authored
With CL:801974 we started using RGBA for primary framebuffers so that the alpha channel will be well-defined. Boards without atomic modesetting should not use overlays and scanout the primary framebuffer as RGB, but this didn't quite work. We tried to modeset and pageflip to RGBA buffers on boards with RGB-only overlays (peppy). This commit makes sure that we always pick the opaque framebuffer for the lowest plane. Bug: 821944, b/74997524 Change-Id: I79929d59bc8a568d7a6090a3ab5a4b31fad658b6 Reviewed-on: https://chromium-review.googlesource.com/964984 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#545124}
-
Roger Tawa authored
To create a "binary" std::string with embedded nulls from a C string, use the 2 argument constructor so that std::string does not use embedded nulls to determine the full length of the string. Bug: None Change-Id: I6003984b6179d03753fef402134329523fe4c31a Reviewed-on: https://chromium-review.googlesource.com/973692 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Mohsen Izadi authored
OverscrollControllerDelegate::OnOverscrollBehaviorUpdate() is always called before OverscrollControllerDelegate::OnOverscrollModeChange(). This CL merges the former into the latter by passing overscroll-behavior value directly to OnOverscrollModeChange(). BUG=800047 TEST=none Change-Id: I97f6b33b46fd9e5815e3a26fc36d04ded21c6864 Reviewed-on: https://chromium-review.googlesource.com/969611Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545122}
-
Sigurdur Asgeirsson authored
Bug: 749785 Change-Id: Ib52b3dd62b5b5386353cdc031d57c4ac74b13410 Reviewed-on: https://chromium-review.googlesource.com/975633Reviewed-by:
lpy <lpy@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545121}
-
Sadrul Habib Chowdhury authored
Validate that the |changed_button_flags_| field is allowed only the set of flags that makes sense. BUG=779372, 824629 Change-Id: I5e4d8b8f07fbf6d881d8510f45414814d074278d Reviewed-on: https://chromium-review.googlesource.com/974078 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This can be removed since https://crbug.com/823493 has been fixed by r544591. Bug: 638375 Change-Id: Ia07a35fa7725b7b38eeda495b05db35ad6fa6c13 Reviewed-on: https://chromium-review.googlesource.com/974473Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545119}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d4815d9..61c909d6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifd2157dee74405d6b4637a8ad4b6a911495725cb Reviewed-on: https://chromium-review.googlesource.com/975662Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545118}
-
Ryan Hansberry authored
Also add a test double for BackgroundEidGenerator. Bug: 819279 Change-Id: I24e2352d72deb00632a4d955f17cc508f7d4cbb5 Reviewed-on: https://chromium-review.googlesource.com/952462Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545117}
-
Xiaoqian Dai authored
When an overview window item is tapped, it's enlarged slightly first to indicate it's selected. We should enlarge it directly without any animation. Otherwise, we might not get the correct event location. Bug: 824505 Change-Id: I7829edf1cab09eddf0335f5812fcb033f101915b Reviewed-on: https://chromium-review.googlesource.com/974292Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545116}
-
Pete Williamson authored
Sometimes offline pages are displayed from a content URI instead of opening a file from our offline page store. The user might then press the "share" menu. When they do, we should use the content URI to share the page by instead of using a file path (since we have no file path). This change will pass back the content URI instead of just disabling sharing. Unit tests are included. Bug: 817608 Change-Id: I1d788a83de3aafe978b37374ec22d77ad328b59d Reviewed-on: https://chromium-review.googlesource.com/962990 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545115}
-
Quinten Yearsley authored
Bug: 790123 Change-Id: I683c66efb496f1c9569eddc23db34b03fbf1cca5 Reviewed-on: https://chromium-review.googlesource.com/974446Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#545114}
-
Evan Stade authored
This is a reland of 8ce1863f MSan fix was landed as 522e7d29 Original change's description: > Turn on native notifications by default for Chrome OS. > > They're already on by default for Mash. This makes Chrome use the mojo > ("native") interface for notifications even in non-Mash. > > Bug: 578868 > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b > Reviewed-on: https://chromium-review.googlesource.com/963518 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544395} Bug: 578868 Change-Id: Idac45274aaea709ef910d4bcb20b14f9a05a952c Reviewed-on: https://chromium-review.googlesource.com/974201Reviewed-by:
-
Sammie Quon authored
Bug: 824121 Change-Id: Ifb96edf110667d3e74584e3a3103602b02891b07 Reviewed-on: https://chromium-review.googlesource.com/974658Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#545112}
-
Gabriel Charette authored
R=fdoray@chromium.org Bug: 824770 Change-Id: Ib2e8cb5ae6c3aece489d7e27c256b18c52e89cb1 Reviewed-on: https://chromium-review.googlesource.com/975781 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#545111}
-
Justin Cohen authored
Introduces IsExpectingVoiceSearch to VoiceSearchNavigationTabHelper. Bug: 821360 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee8bcf8e04d0f28673ee59a5635c6e84eae24535 Reviewed-on: https://chromium-review.googlesource.com/971861Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545110}
-
Andrey Kosyakov authored
This fixes http/tests/inspector-protocol/network-data-length.js Bug: 721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I77cda55f1e129f13f162910340f2853f3fb66d07 Reviewed-on: https://chromium-review.googlesource.com/974464 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#545109}
-
Emily Hanley authored
Bug: 757933 Change-Id: I006f9695379c5a270d58c8f0bafe33a3195c7a44 Reviewed-on: https://chromium-review.googlesource.com/975622Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545108}
-
Lei Zhang authored
Check for enable_java_templates first. Files in build/ are available to other projects where enable_java_templates can be set to false with overrides. Change-Id: Ieb39e3aa825214ddbb06f4397c5d2b97af20d995 Reviewed-on: https://chromium-review.googlesource.com/974906Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545107}
-
Lei Zhang authored
Change-Id: I269b9b0249500cee9ea4c123951d89c347f791e3 Reviewed-on: https://chromium-review.googlesource.com/974319Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545106}
-
Ovidio Henriquez authored
Allows FakeBluetoothChooser to set the test scan duration to never timeout. BUG=719827 Change-Id: I38c74a1bbb0de026edb7d578b98258941d0c3349 Reviewed-on: https://chromium-review.googlesource.com/961544Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#545105}
-
Owen Min authored
When Chrome clean up ephemeral profiles during launch, create a new profile if all profiles are deleted and last used profile is guest profile. Bug: 823890 Change-Id: I64ff6b6230d73df9b97839b0d896fa56710b41e5 Reviewed-on: https://chromium-review.googlesource.com/974123 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545104}
-
Andrii Shyshkalov authored
It has been offline for 24 hours until machenbach@ pinged me https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder R=machenbach@chromium.org, nodir@chromium.org No-Try: True Change-Id: I29096b6a932dd215ed34600674c4785df83a338f Reviewed-on: https://chromium-review.googlesource.com/975925Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545103}
-
Mohamed Heikal authored
In (crrev.com/952097), a runtime check was added to Resource arrays such that only resource ids that start with "0x7f" ie. application resources (vs "0x01" which are system resources) are to have their package id transformed. This lead to startup performance degradation. This CL changes this check to a compile time check and unrolls the arrays at compile time (when packaging resources and creating the R.java file we have all the resource ids already). Bug: 821425 Change-Id: Id977901d7ecaf24df76806ce9c39a38f40a57061 Reviewed-on: https://chromium-review.googlesource.com/974079 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Wez authored
Adds some missing dependencies in //third_party/webrtc_overrides, and enables GN checks on that directory. Bug: 812058 Change-Id: I23fc0f45887a2c9ab50c6d217c9fb2c327ec4e7e Reviewed-on: https://chromium-review.googlesource.com/974755Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#545101}
-
Patrik Höglund authored
This should get WebRTC H264 perf tests running again. Bug: webrtc:8675 Change-Id: Ife68ff289b9caa02dab94e93f2b255d31f56215f Reviewed-on: https://chromium-review.googlesource.com/975021Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#545100}
-
Gabriel Charette authored
And introduce TestBrowserThreadBundle::RunIOThreadUntilIdle() to replace the only method that didn't have an immediate replacement. Bug: 824431 Change-Id: I2137660a745491d6096ef7f2e3d76818d2a9fa8e Reviewed-on: https://chromium-review.googlesource.com/974166Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Eugene But authored
On iOS 10, where Files app does not exist it is possible for UIDocumentInteractionController to not present Open In... menu. In this case Download Manager should show the prompt to install Google Drive app. Bug: 823702 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I393c8724186deaefd3dc192a61759c24799dd1d5 Reviewed-on: https://chromium-review.googlesource.com/974748 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#545098}
-
Jose Dapena Paz authored
On GCC builds with optimizations 3 VectorBuffer unit tests are failing: DeleteMoveOnly, MovableMove and CopyableMove. This is because the tests assume the original VectorBuffer items destructor will be invoked. In the case of MoveOnlyInt and CopyOnlyInt, the destructor will set the member int to 0. On GCC, in the test cases, those count as storage after destruction, and optimized away by dead store elimination. But setting the int as volatile will avoid the code being optimized away, and fix the unit tests. Change-Id: Ibad460d4f75b91cbcbaf935c32a6b9f8d1fd186a Reviewed-on: https://chromium-review.googlesource.com/968844Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#545097}
-
Joe Downing authored
This change completes the KeybaoardLockServiceImpl class and hooks it into the RenderWidgetHostImpl class. RenderWidgetHostImpl is responsible for tracking the keys requested to be locked, forwarding the request to WebContentsImpl, handling the response from WebContentsImpl once the UX is fullscreen, and then calling into the RenderWidgetHostView impl to actually request KeyboardLock. WebContentsImpl tracks the RenderWidgetHostImpl instance which has an active KeyboardLock request. It also calls back into that instance once tab-initiated fullscreen is entered/exited. Note that there are two other approaches I could have taken here: I could have used a WebContentsObserver class or I could have pushed this logic up into the chrome layer (ExclusiveAccessManager related class). I chose the current approach as the logic needed for calling down to the RenderWidgetHostImpl class is simple and only needed in a few places. RenderWidgetHostView is the class which will handle platform specialization for the KeyboardLock request. I've implemented this logic for Aura in this CL, macOS will be completed in a follow-up. My next CL will integrate KeyboardLock into the chrome layer and implement ESC key handling and UX string display. Also to be added are some browser tests for this functionality. These will be required before we enable this functionality by default. BUG=680809 Change-Id: I703d1ba27592943fff80432303583499d789a2ec Reviewed-on: https://chromium-review.googlesource.com/939535 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545096}
-
Jamie Madill authored
It seems new drivers have a regression with 3D textures. A few 3D texture tests were missed in the last CL. Bug: angleproject:2424 Tbr: kbr@chromium.org No-try: True Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I464924ae2a409d7fd1941e0ee4c9497cfa053e52 Reviewed-on: https://chromium-review.googlesource.com/975922Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#545095}
-
https://skia.googlesource.com/skia.git/+log/4259797efdf3..dab15f7a02dd $ git log 4259797ef..dab15f7a0 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 djsollen Revert "Remove legacy precision boundary" 2018-03-22 caryclark update SkIRect centerx centery docs 2018-03-22 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 3395c8b96..8b92c53b8 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idb474902ff53ae80a0bf94b54afd04d55a252132 Reviewed-on: https://chromium-review.googlesource.com/975582 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545094}
-
Christos Froussios authored
virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering.html is flaky Mark as flaky on Win and Mac TBR=aberent@chromium.org Bug: 824775 No-Try: True Change-Id: I89a71e962a531812105a5f659d187672b11c4357 Reviewed-on: https://chromium-review.googlesource.com/975552 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545093}
-
Mitsuru Oshima authored
A client may set custom WindowStateDelegate, so the code should be in the CustomFrameViewAsh. BUG=33693796 TEST=covered by unit tests. Change-Id: Iccacddf8a0bce01ed1a3819c959e73d591a8d8ef Reviewed-on: https://chromium-review.googlesource.com/972677 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545092}
-
Marc Treib authored
instead of hand-rolling its own version of it. As a convenience for callers, GetUploadToGoogleState now also handles a null SyncService (which maps to NOT_ACTIVE). Bug: 824723 Change-Id: Ie81ddc0350ef128ab065c944ecb493f1b1a899ae Reviewed-on: https://chromium-review.googlesource.com/975132 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#545091}
-
Balazs Engedy authored
Bug: 780078 Change-Id: I8f538a29306f1f94a2b5b5c307d743d485f33336 Reviewed-on: https://chromium-review.googlesource.com/975542 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#545090}
-
Elly Fong-Jones authored
These tests don't work when using a Mac printing dialog with MacViews, because the modal closure animation makes window closure very asynchronous. Disable it altogether in this set of tests. Bug: 817408 Change-Id: Idb1bd814e9248e0cbd8d07e3426084c72db06d65 Reviewed-on: https://chromium-review.googlesource.com/975521Reviewed-by:
-
