- 27 Sep, 2018 40 commits
-
-
François Beaufort authored
This CL makes sure DetectedFace interface is serializable so that DetectedFace can easily be transfered from workers. Change-Id: I7477a6882775d576677ce955c987667c7a663341 Reviewed-on: https://chromium-review.googlesource.com/1246522Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#594640}
-
Daniel Bratell authored
Noticed because RemoteTestServer refers to BaseServer which is not included in ios builds. Change-Id: I006a32ca751dd8d9e3c3d6be6ece93f30e0bc992 Reviewed-on: https://chromium-review.googlesource.com/1244841 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#594639}
-
Miguel Casas-Sanchez authored
This CL removes the class DecompressDestroyer in favour of a unique_ptr<> with specific Deleter. Less lines of code. Functionality covered by gfx_unittest, also under asan bot. Bug: 868400 Change-Id: I7ac2d254d6f5771a81620b14db7e610ff3b7e4b9 Reviewed-on: https://chromium-review.googlesource.com/1245467 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594638}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/10eb5745824a..d8f3c17e8da2 git log 10eb5745824a..d8f3c17e8da2 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 phoglund@webrtc.org Added test dependency factory. Created with: gclient setdep -r src/third_party/webrtc@d8f3c17e8da2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/113654555 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a522176c32238863744c166a7f29309b9ab79a2 Reviewed-on: https://chromium-review.googlesource.com/1248174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594637}
-
Yoshifumi Inoue authored
This patch adds |DCHECK()| to narrow down the case of returning null from |Position::ComputeContainerNode()| for helping to search the root cause of the bug[1] caused by |ComputeContainerNode()| returning null for non-null position. This patch also changes tests using before/after position of shadow root. Node: document and document fragment, including shadow root, can not be an anchor node of before/after position, since these position can not be represent by RangeBoundaryPoint == container node with offset of child. [1] https://crbug.com/882592 SelectionEditor should not call Node::ContainsIncludingHostElements() with null Bug: 882592, 889737 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9c7b0c8ad1c97d20a9080aa9baddea69faf805c5 Reviewed-on: https://chromium-review.googlesource.com/1248361Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594636}
-
Andreas Haas authored
Bug: v8:7294 v8:8015 Change-Id: I698f6fd6312dad6d27924d8c000375f4bcd0455f Reviewed-on: https://chromium-review.googlesource.com/1238538Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#594635}
-
Mathias Carlen authored
Before this patch, server and client protos were not in sync with respect to the required/optional qualifiers. This lead to obscure failures when serializing/deserializing messages from and to the backend. This patch changes the remaining required fields to optional. After this patch, we are closer to having wire identical protos. To completely guarantee this going forward we will introduce more tooling and sync them on a regular basis. The fields that changed are all ElementReferenceProtos which reduce to an empty selector when not set, which is acceptable. R=rouslan@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: If855ad1b882712917e3d883c9f4f607d479fc103 Reviewed-on: https://chromium-review.googlesource.com/1244677Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594634}
-
François Beaufort authored
This CL makes sure DetectedBarcode interface is serializable so that DetectedBarcode can easily be transfered from workers. Change-Id: I539dfa2dcba7873ccad4df76b8531c797d88072c Reviewed-on: https://chromium-review.googlesource.com/1246452Reviewed-by:
-
Yuki Yamada authored
This is a follow-up for I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a . ListenerType::kJSEventHandlerType is added in previous CL and used instead of ListenerType::kJSEventListenerType. EventTarget::ReportBlockedEvent() checks the ListenerType, so we have to make it check in accord with new condition. Bug: 872138 Change-Id: I092f97929a6aea5a6dfb6d7c842b913d8d652a6f Reviewed-on: https://chromium-review.googlesource.com/1248062Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#594632}
-
Jordan Demeulenaere authored
This avoids problems when replacing values that have special characters (like ' and \) in the script. Bug: 806868 Change-Id: I68ef1b3d549b0d17b6d6bb638d07cd086ae64400 Reviewed-on: https://chromium-review.googlesource.com/1244679 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. Bug: 864939, 812536 Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a Reviewed-on: https://chromium-review.googlesource.com/1246082 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594630}
-
Nicholas Verne authored
Only if the response proto status is "STARTING" do we wait for the TremplinStartedSignal before continuing. Bug: 884576 Change-Id: Id02a5863c2971329991d47bf156639fdc7f281bd Reviewed-on: https://chromium-review.googlesource.com/1248065 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88e4a9395a45..b3e48afc936d git log 88e4a9395a45..b3e48afc936d --date=short --no-merges --format='%ad %ae %s' 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 af8b73c9e632..115e8a2625f5 (1 commits) Created with: gclient setdep -r src/third_party/skia@b3e48afc936d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: If7e8670aeec8c246c062dde054d9ad3ca61bf79f Reviewed-on: https://chromium-review.googlesource.com/1248172Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ComputePositionForChildrenRemoval()| for |SelectionEditor| not to call |Node::ContainsIncludingHostElements()| with null to avoid crash. This is temporary patch until we find the root cause. Once we know the root cause, we should fix it instead of checking null pointer in |ComputePositionForChildrenRemoval()|. See also the patch[1] which narrows the condition. [1] http://crrev.com/c/1248361 Add DCHECK for Before/After position Bug: 882592 Change-Id: I7b284f480f1a151b666ad05caac73f7c4ea156b8 Reviewed-on: https://chromium-review.googlesource.com/1248363Reviewed-by:
-
Yuta Kitamura authored
This function returns a mutable pointer, thus it does not make sense to have this function const-qualified. Bug: 826203 Change-Id: I7ea049c9a86b79db7bab5e26bf16b0499d71a08d Reviewed-on: https://chromium-review.googlesource.com/1247643Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#594626}
-
Yutaka Hirano authored
network::ResourceRequest::request_initiator is set based on blink::ResourceRequest::RequestorOrigin. The former is a url::Origin the latter is a scoped_refptr<const blink::SecurityOrigin>. A file: origin is handled in a special manner in blink. Without --allow-file-access-from-files, it is NOT opaque but it is serialized as "null". Currently conversion from blink::SecurityOrigin to url::Origin relies on opacity (i.e., blink::SecurityOrigin::IsOpaque) but that is not good for CORS. This CL changes that. With this CL, A SecurityOrigin serializes as "null" is converted to a unique url::Origin. Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7b5ec4894c52499d85165689fd114e28bbd8bb97 Reviewed-on: https://chromium-review.googlesource.com/1131021Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#594625}
-
Hayato Ito authored
The comment is no longer true, and we can remove TODO here. Change-Id: I0b2e4735a543d915c6bc45fcc51fbce6207e4052 Reviewed-on: https://chromium-review.googlesource.com/1248341 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: None Change-Id: I3daee8d38c9793a75e3506d8c16588e83506cc66 Reviewed-on: https://chromium-review.googlesource.com/1244181Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/91957c1540f4..10eb5745824a git log 91957c1540f4..10eb5745824a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 buildbot@webrtc.org Roll chromium_revision 1574cf43..65b8a51a (594482:594582) Created with: gclient setdep -r src/third_party/webrtc@10eb5745824a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I489c3ff2ff8df9cfe3a24bbef9a06cbec54d33dc Reviewed-on: https://chromium-review.googlesource.com/1248170Reviewed-by:
-
Anand K. Mistry authored
As a result, also use std::unique_ptr<char[]> instead of char[] class members. This makes zip archiver more closely follow chromium style. BUG=889703 Change-Id: I551557958beff280e344134f15be20a406fb5ea8 Reviewed-on: https://chromium-review.googlesource.com/1242643Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594621}
-
Luciano Pacheco authored
In Video Player polymer_config.js was writing to console.error: polymer_config.js:15 Polymer is already defined. This was caused by <paper-slider.html> being included before any of WebUI or Files app Polymer element had a chance to initialize with the right config (polymer.html), which in turn was causing Polymer elements to render without shadowRoot. Change <files_icon_button> to include before <paper-slider> so it loads the right config/polymer.html. Test: --gtest_filter='VideoPlayerBrowserTest.CheckInitialElements' also manually checked for no error message and play button has shadowRoot. Bug: 875525 Change-Id: I9888992cce762cd6eae8c31a8042119506fd5590 Reviewed-on: https://chromium-review.googlesource.com/1248342 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#594620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fb2f561368c..ca716904bcfb Created with: gclient setdep -r src-internal@ca716904bcfb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I32870b3232e546b264c4a9f42ec2355434cc8c3b Reviewed-on: https://chromium-review.googlesource.com/1248167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594619}
-
Adam Rice authored
Modify BodyStreamBuffer::CloseAndLockAndDisturb to test new hypotheses about what is causing the crashes in this function. 1. Test whether IsContextDestroyed() is ever true by adding a CHECK if it is. 2. Test whether stream_ can be empty if stream_broken_ is false. Tests with a busy loop have indicated that this function is sometimes called with stream_broken_ set to true. This raises the question if failures still happen when it is false. This CL will cause it to CHECK if stream_broken_ is false and stream_ is empty. This CL causes intentional crashes and should not be left in the beta version as-is. BUG=882599 Change-Id: Id71b66c51fcab0e821a411a2a97866c992b3f36d Reviewed-on: https://chromium-review.googlesource.com/1245040Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5ea41fc89b26..88e4a9395a45 git log 5ea41fc89b26..88e4a9395a45 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3d27f2e721ed..4241ad731a8a (1 commits) 2018-09-27 herb@google.com Redo GrTextBlob path flush 2018-09-26 senorblanco@chromium.org GrTessellator: two fixes for boundary simplification artifacts. Created with: gclient setdep -r src/third_party/skia@88e4a9395a45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:884166,chromium:887103 TBR=bsalomon@chromium.org Change-Id: I66c8a37d44f3c2578145afc6b71624c8eef833e4 Reviewed-on: https://chromium-review.googlesource.com/1248166Reviewed-by:
-
Morten Stenshorne authored
Use LayoutText::LinesBoundingBox() (which knows how to deal with both NG and legacy layout), rather than reading out from the legacy line box tree manually. Added a crash unit test that would have crashed with this CL, had it not been for https://chromium-review.googlesource.com/1193868 - we used to stumble into dead layout objects. This CL also fixes one existing unit test. Bug: 889449 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icb3f75038e1504968badaedd992565c8c1cc8419 Reviewed-on: https://chromium-review.googlesource.com/1158688Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#594616}
-
Hayato Ito authored
Remove the TODO comment for HTML Imports, which are being deprecated and will be removed. Change-Id: I36f80d0e90adc06d53c05e3bcb24bd5f766b610e Reviewed-on: https://chromium-review.googlesource.com/1248382Reviewed-by:
-
Rakina Zata Amni authored
This CL removes WebFindOptions in favor of FindOptions defined in find_in_page.mojom. This also removes WebLocalFrame::Find and WebLocalFrame::StopFindingForTesting, combining both into just one function WebLocalFrame::FindForTesting. Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie904a02b3e197f1012c6d5b4c9f50fdb6ce8d14f Reviewed-on: https://chromium-review.googlesource.com/1184808 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594614}
-
Jan Krcal authored
These histograms were declared manually for all data types. As a result, many of them (for newer data types) were missing. This CL uses histogram suffixes instead. This CL also puts the related suffix SyncModelType up-to-date. Bug: 883252 Change-Id: Ia594f068919bee4ed233b7c1477460a7f04ab797 Reviewed-on: https://chromium-review.googlesource.com/1245117Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#594613}
-
Tommy Steimel authored
This CL adds the volume slider back into the modern media controls. The slider opens when the mute button is hovered/focused and closes when hover/focus is lost. Bug: 883540 Change-Id: I09df097c996f53a2c35ce15a161b4d8fc41ec49d Reviewed-on: https://chromium-review.googlesource.com/1246828Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594612}
-
Yuta Kitamura authored
This CL moves the ownership of the compositor thread from RenderThread- Impl to Platform in order to reduce //content's dependency to WebThread. Now Platform::CompositorThread() is a concrete member function, and the compositor thread is initialized by Platform::Initialize- CompositorThread(). Some components of //content require the task runner of the compositor thread, so RenderThreadImpl:: compositor_task_runner() is still available. Bug: 826203 Change-Id: I6fe71835d7b7671d8781744ec62561242c6be29f Reviewed-on: https://chromium-review.googlesource.com/1245039 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Katie D authored
Bug: 885326 Change-Id: I19764f67b871577d2b8e206800526508bc784fd8 Reviewed-on: https://chromium-review.googlesource.com/1245118Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
On Kiosk mode, we shouldn't show volume slider bubble. The check was missing in UnifiedSystemTray. It caused UI regression in Kiosk devices. (See the bug for detail). TEST=manual(confirmed on a Kiosk device that the slider is not shown) BUG=888890 Change-Id: I00359892b6bfc624b95c5f2a57fc7802b38a4dca Reviewed-on: https://chromium-review.googlesource.com/1247841Reviewed-by:
-
Keishi Hattori authored
This reverts commit ea613981. Reason for revert: Broke Google Chrome Win build https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/37835 Original change's description: > NUX: Move NUX backend code to chrome/browser/ui/webui/welcome > > Move NUX backend handlers and string resources to a chrome/ directory. There > will be a follow-up CL to move the frontend resources to the same directory. > > This is to make it possible to reuse chrome/ code for NUX handlers. > > Bug: 874122 > Change-Id: Id9a5fdd0a1ea88c4027139b66aaade0b120b4904 > Reviewed-on: https://chromium-review.googlesource.com/1232399 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594599} TBR=sky@chromium.org,dpapad@chromium.org,hcarmona@chromium.org,scottchen@chromium.org Change-Id: Ic7744af7c6de8a4508b45441cac030679e04cf26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874122 Reviewed-on: https://chromium-review.googlesource.com/1248142Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594608}
-
Hayato Ito authored
Element::GetShadowRoot() doesn't have to be inlined. That would cause element.h to depend on element_rare_data.h, which we wouldn't want. Change-Id: Ib20c6c5b2e3b13510c7eb142704df53439bfcc9d Reviewed-on: https://chromium-review.googlesource.com/1248344 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
In event capturing phase, when the event is dispatched on window, the related target was not set properly (it uses the state of the event at the target, which means related target is the same as when it was at the target). This might cause leaks when the event's relatedTarget is inside a shadow tree. This change makes it so at window context, the relatedTarget used is the relatedTarget of the last NodeEventContext. Bug: 817222 Change-Id: I1edea3977202b0a05e3e8ea46a5b8c1edb4b834d Reviewed-on: https://chromium-review.googlesource.com/1248244Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c38c4ec0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25372 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ia721d8beacad9408f4d3a7a100d011a58e0eba2e Reviewed-on: https://chromium-review.googlesource.com/1248123 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594605}
-
Luciano Pacheco authored
Change directory tree to the first item's section instead of static TOP section to determine if the first section divider should appear. Change the value of section-start attribute to be the current section which is the correct value, instead of previous section. While here modernized this function to use const/let instead of var. Bug: 878531 Test: browsertest --gtest_filter='FileManagerJsTest.DirectoryTree*' Change-Id: If8db170594608fef04913f3f6fe8235764eb03f7 Reviewed-on: https://chromium-review.googlesource.com/1248066 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594604}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a6b6bda177a..91957c1540f4 git log 3a6b6bda177a..91957c1540f4 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 kwiberg@webrtc.org AudioCodingModuleTest.TwoWayCommunication: Don't let the ACM create encoders Created with: gclient setdep -r src/third_party/webrtc@91957c1540f4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If629e05fe1c8bc68f2576c745dd3694434f2fbab Reviewed-on: https://chromium-review.googlesource.com/1248164Reviewed-by:
-
Xiaohan Wang authored
- Add ENABLE_WIDEVINE buildflag - Check BUILDFLAG(ENABLE_WIDEVINE) instead of defined(WIDEVINE_CDM_AVAILABLE) - Since WIDEVINE_CDM_AVAILABLE is not needed, remove a lot of dependencies on widevine_cdm_version.h - widevine_cdm_version.h is still needed to get WIDEVINE_CDM_VERSION_STRING and WIDEVINE_CDM_MIN_GLIBC_VERSION. - Some BUILD.gn cleanup to use "enable_widevine". Previously this wasn't possible since WIDEVINE_CDM_AVAILABLE is a define. - Remove third_party/widevine/cdm/stub/, whose sole purpose was to define WIDEVINE_CDM_AVAILABLE when "enable_widevine" is enabled. Bug: 349182 Test: No functionality change Change-Id: I864963033c4ae3a61b4ebde14c6bb68ed18e88f0 Reviewed-on: https://chromium-review.googlesource.com/1239873Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594602}
-
Patrik Höglund authored
Bug: 877018 Change-Id: I3502e8ce9c8410f3af1c52581adbc0d708806a7f Reviewed-on: https://chromium-review.googlesource.com/1245365Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#594601}
-
