GitLab

BUG=

Review URL: https://codereview.chromium.org/1079613003

Cr-Commit-Position: refs/heads/master@{#325457}

BUG=

Review URL: https://codereview.chromium.org/1086213004

Cr-Commit-Position: refs/heads/master@{#325456}

BUG=

Review URL: https://codereview.chromium.org/1051253006

Cr-Commit-Position: refs/heads/master@{#325455}

BUG=477148
TEST=Load webview browser sample (https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa), use the browser sample app to navigate to a website that embeds a plugin (flash or pdf). Verify that the browser doesn't crash.

Review URL: https://codereview.chromium.org/1088323002

Cr-Commit-Position: refs/heads/master@{#325454}

Add original author of the code and original reviewer as OWNERS and
sdefresne@ for componentization work of //chrome/browser/undo.

BUG=476919
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1088513005

Cr-Commit-Position: refs/heads/master@{#325453}

Required in order to reland CL 1056763002. The only difference in the test output is that on the Mac the textual contents of the contenteditable are also present in the AXValue property on the AXGroup representing the contenteditable. I prefer to reland the contenteditable CL in order to investigate this more easily on my Mac.
BUG=347859
R=dmazzoni

Review URL: https://codereview.chromium.org/1080533004

Cr-Commit-Position: refs/heads/master@{#325452}

In the process of investigation of empty username occurences in the password manager, we suspect re-authentication forms to be a frequent cause. This metric will show us in how many cases this is not the cause.

We interpret occurences of an empty and nonempty username pair on the same signon realm as a presence of both a first-time authentication and re-authentication form.

We report the number of password forms with an empty username in the login database, for which there isn't another password form with a nonempty username on the same signon realm.

Out of several possible approaches:
a) SELECT ... WHERE NOT EXISTS
b) SELECT DISTINCT ... FROM ... JOIN ... ON a.signon_realm=b.signon_realm
c) SELECT DISTINCT ... FROM ... WHERE ... AND a.signon_realm=b.signon_realm
d) SELECT, put into std::set<>, SELECT, iterate and search the set

we implemented a), as manual testing on 1000 random samples seemed to be the fastest.

BUG=456728

Review URL: https://codereview.chromium.org/1087233002

Cr-Commit-Position: refs/heads/master@{#325451}

Now that all blink threads have schedulers it makes sense to get
hold the corresponding WebScheduler via WebThread.  This patch
is the chromium side of doing that.

Patch 2: https://codereview.chromium.org/1087203002
Patch 3: https://codereview.chromium.org/1084173002

BUG=463143

Review URL: https://codereview.chromium.org/1088053003

Cr-Commit-Position: refs/heads/master@{#325450}

Fix KeychainItemForForm so that it understands not to specify a path when looking for Keychain items corresponding to Android credentials.

While other code in PasswordStoreMac omitted the path before storing the Keychain item, KeychainItemForForm derived an erroneous path for an Android credential as well, and insisted to retrieve only Keychain items having that path -- yielding no matches. This has led to deleting and updating existing passwords not working.

BUG=476851

Review URL: https://codereview.chromium.org/1089233002

Cr-Commit-Position: refs/heads/master@{#325449}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0b71278..f7aaadb

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1094643002

Cr-Commit-Position: refs/heads/master@{#325448}

BUG=477697
NOTRY=true
NOTREECHECKS=true
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/1096473002

Cr-Commit-Position: refs/heads/master@{#325447}

R=derekjchow@chromium.org,byungchul@chromium.org,lcwu@chromium.org
BUG=476713

Review URL: https://codereview.chromium.org/1058143004

Cr-Commit-Position: refs/heads/master@{#325446}

This group was only intended to be ran on early channels to show that we are tracking the right stats and ensure that the latest background mode experiment isn't bringing back the regressions that mode had previously brought (see issue 381820 and issue 398103).

The analysis is complete and support for it in the client is no longer required (already ramped down server-side).

(this is essentially a partial revert of https://codereview.chromium.org/926663002)

BUG=459600

Review URL: https://codereview.chromium.org/1089873002

Cr-Commit-Position: refs/heads/master@{#325445}

BUG=477696
NOTRY=true
NOTREECHECKS=true
TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/1084403003

Cr-Commit-Position: refs/heads/master@{#325444}

BUG=477691
NOTRY=true
NOTREECHECKS=true
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/1059963005

Cr-Commit-Position: refs/heads/master@{#325443}

A "custom_clang_lib_path" argument is added to specify a custom path of
blink_gc_plugin for distributed builds such as distcc.

R=hans@chromium.org

Review URL: https://codereview.chromium.org/1052033006

Cr-Commit-Position: refs/heads/master@{#325442}

An intricate entangling of libsigchain, sigaction() chaining and
user-space SIGSEGV handling by binary translator cause persistent
crashes when a SIGSEGV handler is installed by a x86 library on
a hybrid application which uses both Arm and x86 libraries.
Backing out the crash handler as a temporary workaround.
More context in the related bug.

BUG=477444

Review URL: https://codereview.chromium.org/1059543003

Cr-Commit-Position: refs/heads/master@{#325441}

When profiles are deleted, new profiles are created in the directory
Profile X. These directories are stored in last active profile. In metro
mode, on initialization rather than last active profile, default profile
corresponding to the directory Default is used resulting in problems
on profile deletion. This CL makes ProfileManager::GetActiveUserProfile
return last active profile instead of default profile for windows build
to solve the problem.

BUG=450192

Review URL: https://codereview.chromium.org/1051843002

Cr-Commit-Position: refs/heads/master@{#325440}

original CL:  https://codereview.chromium.org/1088793002/

BUG=267773

Review URL: https://codereview.chromium.org/1083403002

Cr-Commit-Position: refs/heads/master@{#325439}

An intricate entangling of libsigchain, sigaction() chaining and
user-space SIGSEGV handling by binary translator cause persistent
crashes when a SIGSEGV handler is installed by a x86 library on
a hybrid application which uses both Arm and x86 libraries.
Backing out the crash handler as a temporary workaround.
More context in the related bug.

BUG=477444

Review URL: https://codereview.chromium.org/1089303002

Cr-Commit-Position: refs/heads/master@{#325438}

The unittest ensure that DeleteAll(CookieMonster*) does flush and that the
flush_count is valid after DeleteAll() calls.

BUG=None

Review URL: https://codereview.chromium.org/1083883002

Cr-Commit-Position: refs/heads/master@{#325437}

Do this by making sure that we don't unregister the Service Worker for
each notification that's being shown, which actually closes the existing
ones on the platform.

BUG=472926

Review URL: https://codereview.chromium.org/1082273003

Cr-Commit-Position: refs/heads/master@{#325436}

Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1085073002/)

Reason for revert:
Still very flaky on Win Nvidia:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view

Original issue's description:
> Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/)
>
> Reason for revert:
> kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues.  I'll try reverting it, and keep an eye on it.
>
> Original issue's description:
> > Disable WebGL conformance test on Win8/NVIDIA
> >
> > The test:
> > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view
> >
> > Has been timing out on and off for as long as we have records.
> >
> > BUG=459265
> > NOPRESUBMIT=True
> >
> > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d
> > Cr-Commit-Position: refs/heads/master@{#316872}
>
> TBR=zmo@chromium.org,ccameron@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459265
>
> Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702
> Cr-Commit-Position: refs/heads/master@{#325142}

TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459265

Review URL: https://codereview.chromium.org/1082203004

Cr-Commit-Position: refs/heads/master@{#325435}

Added new attribute prompt step to enrollment screen.

BUG=464184

Review URL: https://codereview.chromium.org/975353002

Cr-Commit-Position: refs/heads/master@{#325434}

BUG=463143

Review URL: https://codereview.chromium.org/1089833002

Cr-Commit-Position: refs/heads/master@{#325433}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9d75ce..d352e4a

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089423002

Cr-Commit-Position: refs/heads/master@{#325432}

This patch adds xml RAPPOR entries for measuring the Device Motion and
Device Orientation APIs usage.
Corresponding blink-side patch: crrev.com/1017433002.
This patch replaces the chromium patch: crrev.com/1021823005.

BUG=467648

Review URL: https://codereview.chromium.org/1052013004

Cr-Commit-Position: refs/heads/master@{#325431}

BUG=475654

Review URL: https://codereview.chromium.org/1089853002

Cr-Commit-Position: refs/heads/master@{#325430}

Cr-Commit-Position: refs/heads/master@{#325429}

Initial implementation of chrome.launcherSearchProvider.setSearchResults.
iconUrl is not supported with this CL. It will be implemented with another CL.

BUG=440649

Review URL: https://codereview.chromium.org/1071093002

Cr-Commit-Position: refs/heads/master@{#325428}

This CL modifies OverscrollNavigationOverlayTests so that they use
TestRenderFrameHost::PrepareForCommit and TestRenderFrameHost::SendNavigate
instead of TestWebContents::CommitPendingNavigation. This allows values for
CrossNavigationPending to be properly set with browser-side navigation.

BUG=439423

Review URL: https://codereview.chromium.org/1088933003

Cr-Commit-Position: refs/heads/master@{#325427}

When we select enter key then open item is getting called and it opens last focused item.
This is due to 2 reasons:
1) getSelectedBookmarkNodes() returns bmm.list.selectedItems even when document.activeElement
is 'Folders' or 'Organize' button.
2) openItem() is for opening the item in the list, for that bmm.list should be currently active

Check have been added so that when we have bmm.list is active then only e.canExecute will become true.

BUG=452853

Review URL: https://codereview.chromium.org/1058533006

Cr-Commit-Position: refs/heads/master@{#325426}

This CL enables showing error pages when browser-side navigation is enabled. It
introduces a new IPC FrameMsg_FailedNavigation used by the browser to ask a
renderer to display an appropriate error page for a navigation that just
failed.

BUG=459033

Review URL: https://codereview.chromium.org/958083002

Cr-Commit-Position: refs/heads/master@{#325425}

BUG=477554
TEST=manually tested as described in the issue.

Review URL: https://codereview.chromium.org/1086353002

Cr-Commit-Position: refs/heads/master@{#325424}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/30421b4..d9d75ce

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1094483002

Cr-Commit-Position: refs/heads/master@{#325423}

This is follow up for issue 462861. As we have separate handle for 'undo-command' for search box, so canExecute should be set to true unconditionally.

BUG=477597

Review URL: https://codereview.chromium.org/1094513003

Cr-Commit-Position: refs/heads/master@{#325422}

While working on some other issue, I have noticed that `AwTestBase.loadUrl`
doesn't call the same overload of `AwContents.loadUrl` that WebView API
does, which can lead to different behaviour of tests vs. real apps.

Also, fixed some stuff in `AwContentsTest.testJavaBridge`, and figured
out that this test works despite what our documentation says about
availability of injected objects, filed http://crbug.com/476880.

Review URL: https://codereview.chromium.org/1083023002

Cr-Commit-Position: refs/heads/master@{#325421}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/67b98f43..a9250269

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1094543002

Cr-Commit-Position: refs/heads/master@{#325420}

Looks like instagram has removed iframe.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1088423003

Cr-Commit-Position: refs/heads/master@{#325419}

Yahoo had wrong username and password field ids and click button action.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1090853002

Cr-Commit-Position: refs/heads/master@{#325418}