- 14 Feb, 2020 40 commits
-
-
John Delaney authored
The match command documentation currently asks for "document-origin" but actually uses "document_origin", which is hard to recognize. This CL fixes the documentation and also adds a more verbose error for when the required arguments are not supplied. Change-Id: Idd5f82a61f0628677f8f69633d3e783538a0c253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055690Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741459}
-
Wez authored
Change-Id: I7d356012e6acb40b6305a43ed537796c313c1dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050476 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741458}
-
John Chen authored
This reverts commit 1cd142b4. Reason for revert: Causing build failures on Android x86 Builder (dbg) Original change's description: > Allow build ChromeDriver during Android build > > While build for android, ChromeDriver can be built using host toolchain. > > Bug: 1050709 > Change-Id: Ifc7b97f4474e73e3025ec33450bdfd29559ba087 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050872 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741146} TBR=johnchen@chromium.org,jbudorick@chromium.org Change-Id: I343851d232030913b08730c478f07dbeb6657792 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050709, 1052318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057109Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741457}
-
Darin Fisher authored
This eliminates Blink public WebPrerender and WebPrerenderingSupport interfaces in favor of having core/loader talk directly via mojo to the browser-side PrerenderProcessor. This deletes a bunch of code :) Move corresponding interfaces to blink/public/mojom/prerender/. PrerenderCanceler remains defined in chrome/common/ as it is used by the renderer process that is created to load a prerendered / prefetched web page. Onion soup of this part could be a future CL. Change-Id: If7ec0f417930f1a72a515a7fb7ae288a2ba843cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042139 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741456}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eaff904e7260..3a3e7d4dd2bc git log eaff904e7260..3a3e7d4dd2bc --date=short --first-parent --format='%ad %ae %s' 2020-02-14 aleino@nvidia.com Don't skip functional.layout_binding.ubo.vertex_binding_max on NV/D3D11 Created with: gclient setdep -r src/third_party/angle@3a3e7d4dd2bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ieefd9831592c37d949e3896b8447fd013479d608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741455}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02808dc0a181..46b98e70c127 git log 02808dc0a181..46b98e70c127 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 lalitm@google.com Merge "tp: only create tid/pid 0 <-> utid/upid 0 mappings for traces with ftrace" 2020-02-14 taylori@google.com Merge "perfetto-ui: Add args" 2020-02-13 primiano@google.com TraceProcessor: fix trace_bounds computation 2020-02-13 primiano@google.com Minor cleanup to string conversions. Expose TraceProcessor EOF 2020-02-13 treehugger-gerrit@google.com Merge "perf sampling: minimal UI for stacks as slice columns" 2020-02-13 hjd@google.com Merge "Fix Mac compile of api_integrationtest.cc" 2020-02-13 fmayer@google.com Merge "Remove stale comment." 2020-02-13 lalitm@google.com Merge "tp: make diff testing script run all tests by default" 2020-02-13 lalitm@google.com Merge "tp: cleanup diff test script in preperation for unified execution" 2020-02-13 ddrone@google.com Add frame_tree_node_id to LatencyInfo.Flow event 2020-02-12 treehugger-gerrit@google.com Merge "processor: Override/extend args correctly when merging" 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Register available categories with service" 2020-02-12 treehugger-gerrit@google.com Merge "UI: update logo and sidebar animation" Created with: gclient setdep -r src/third_party/perfetto@46b98e70c127 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148777631,chromium:149483774 Tbr: perfetto-bugs@google.com Change-Id: I4c50e46625876e6bbe9f14063e785660fc539836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057048Reviewed-by:
-
Mugdha Lakhani authored
This change moves three accessibility strings from chrome:// to components:// so they can be set for the security status icon in the WebLayer URL bar. Bug: 1025607 Change-Id: I7298a14efbaa663315438c2a1675e0e248cc5ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047025Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#741453}
-
Tina Wang authored
Some dependencies haven't been removed when removed unused imports. Change-Id: Ic31d2bfae3249e285ca6d2aa1405681a031af5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055023 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#741452}
-
Dong Hwi Lee authored
Add a test with a realistic sitemap.xml. Change-Id: I5ca40acab728553593da41491a52c11902bcb5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051875Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Dong-Hwi Lee <leedh@google.com> Cr-Commit-Position: refs/heads/master@{#741451}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ddad4c60aec3..f46f19b98c0d git log ddad4c60aec3..f46f19b98c0d --date=short --first-parent --format='%ad %ae %s' 2020-02-14 bsalomon@google.com Add support for implementing ShaderMode::kRepeat with MIPs in GrTextureEffect. Created with: gclient setdep -r src/third_party/skia@f46f19b98c0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Ib69b460dabeae487293f3ecb6178f8eac749f8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056487Reviewed-by:
-
Emre Kanlikilicer authored
Bug: 1051082: Remove startup sentinel during gcpw uninstall. Change-Id: I4d2db7eda7778abf791a1bada4a533562a284195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050621Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Emre Kanlikilicer <emreknlk@google.com> Cr-Commit-Position: refs/heads/master@{#741449}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e245d1a20821..65862c545fec git log e245d1a20821..65862c545fec --date=short --first-parent --format='%ad %ae %s' 2020-02-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-14 aerotwist@chromium.org Updates node_modules to remove resemblejs 2020-02-14 aerotwist@chromium.org Move screenshot helper Created with: gclient setdep -r src/third_party/devtools-frontend/src@65862c545fec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I93059a99e3b86f75347549c447b05ecdceef98c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056486Reviewed-by:
-
jonross authored
Originally we were having each callsite to PeakGpuMemoryTracker provide a callback to perform UMA reporting. However we had wished to bring the UMA work directly into the class. Upcoming plans with allocation source metrics would lead to too much boilerplate code being duplicated in all the callsites. This change refactors the UMA handling to be within PeakGpuMemoryTracker itself. With the callsites telling it which type of user interaction is being observed. Bug: 1001168 Change-Id: I4229025941c8d265af958015713502c63b19800b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026117Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#741447}
-
Oleg Davydov authored
Current implementation of FakeCWS doesn't support signed hashes for extensions' resources. Therefore content verification of extensions provided by FakeCWS may fail and extensions will be false-positively marked as corrupted. This commit disables content verification when FakeCWS is used, as we don't need it in corresponding tests. Also this commit removes condition when overriding WebStore URLs for ExtensionsClient, now they are always updated. That condition only added possible flakiness. In tests ExtensionsClient was initialized after command line changes, so it used overridden values anyway. Bug: 1051513 Change-Id: Ie74553f6f778efa0e82f17f64149d688e320f151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051931 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741446}
-
Stephen McGruer authored
As per https://crbug.com/1051944#c2 Bug: 1051944 Change-Id: I93e399580f1b4e4da6e7f3317602a9f2b591244a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057047Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741445}
-
Mugdha Lakhani authored
There was a naming conflict with url_bar.xml from chrome:// which caused some chrome smoke tests to fail. This CL fixes that and tries to reland the original change. Descrption from the original commit: UrlBarView is now a LinearLayout with its own resource XML. It contains a security icon (currently always the lock icon) and a TextView containing current display URL. Here's a recording of the UI after this change: https://drive.google.com/a/google.com/file/d/1q8IzYALoPYd8KLcln4cMEnRjIT6ox_so/view?usp=sharing TBR=dtrainor@chromium.org,tommycli@chromium.org Bug: 1025607 Change-Id: I47f94905de9a220f02a589814a7eada550e1b303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049980 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
When using imported input buffers, it is very possible that the system will give us buffers of a coded size larger than the one we specified when negotiating the input format with the encoder. In this case, we have to call S_FMT again in order to set the actual input buffer format. However doing so also has the effect of resetting the crop rectangle to the new resolution. Make sure to set the crop right after, otherwise we may end up with an invalid resolution in the encoded stream. BUG=b:149451052 BUG=b:147851828 TEST=android.media.cts.EncodeDecodeTest passing. Change-Id: I64a5f56a71b469b32d809419ff901516d1032328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056403Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#741443}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/142ac8d3..d249a8cf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I858fa9c9b1fa268c8a45f1c527cbc27447678db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056644Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741442}
-
Ian Clelland authored
Change-Id: Ida8184de82d7ed7c695a89ec7142f08485f002a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055669 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741441}
-
Sky Malice authored
Bug: 1050094 Change-Id: I3abcd08318fd6a0f8e6fccc95664da59f37f168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051737 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#741440}
-
Finnur Thorarinsson authored
A recent refactoring of SelectableItemView[Base] introduced a regression where a white selection circle would show on top of all images in the Photo Picker. The fix is to switch inheritance from SelectableItemView to SelectableItemViewBase, which doesn't inflate any extra xml. Bug: 1051523, 656015 Change-Id: Ie938b31ba79152d1573363cc567c937aa9d430e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056806 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chrome://autofill-internalsChristoph Schwering authored
Also changed testChromeAutofillInternalsSite to verify that chrome://autofill-internals/ is a substring of the omnibox URL, not identical to it, the reason being that autofill-internals dynamically changes the fragment identifier of the URL. Change-Id: I1a0d7b57980be5e9c2c54340e7d9b44fb8f95c0a Bug: 1051504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035897 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#741438}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/b2cdc6cc701d..e18eab01d2d4 $ git log b2cdc6cc7..e18eab01d --date=short --no-merges --format='%ad %ae %s' 2020-02-11 dverkamp system_api: vm_concierge: add disk type to ListVmDisks 2020-02-04 dverkamp system_api: vm_concierge: add min disk size field 2020-01-28 acostinas system_api: Add D-Bus constants for System-proxy Created with: roll-dep src/third_party/cros_system_api Bug: chromium:1042624 Change-Id: I27126f1e599e10aba375a87cd824ac53d2ab8555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054104Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#741437}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e7c4f9065168..bd710dbacd8f git log e7c4f9065168..bd710dbacd8f --date=short --first-parent --format='%ad %ae %s' 2020-02-14 xalep@google.com Removing dead code 2020-02-14 jakobi@webrtc.org Update transport overhead the first time the network connects. Created with: gclient setdep -r src/third_party/webrtc@bd710dbacd8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ebc810bd6557daf196d997ee59cbd96920ac91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056988Reviewed-by:
-
Stephen McGruer authored
This reverts commit 223a600d. Reason for revert: Strong suspect for failures in Linux CFI bot; crbug.com/1052348 Original change's description: > Desktop PWAs and shortcut windows use WebAppBrowserController > > We enable the flag DesktopPWAsUnifiedUiController > > Web apps (PWAs and shortcuts) now use WebAppBrowserController > instead of HostedAppBrowserController. > > Bug: 966290 > Change-Id: I2cdf4bc8161e263838d22fc84ba793174eef0db4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056163 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741324} TBR=ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I311b06dc8862281434ff9d85ad4189e57195348f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966290 Bug: 1052348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057105Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741435}
-
Antonio Gomes authored
... throughout the source base. Today both enum classes exist (see [1] and [2]) [1] //third_party/blink/public/common/frame/sandbox_flags.h [2] //third_party/blink/public/mojom/feature_policy/feature_policy.mojom ... and clearly duplicate each other. There are also typemap and trait files that translate between the two when doing mojo calls [3]. [3] third_party/blink/common/feature_policy/feature_policy.typemap This CL is a follows up of [4], and merges blink::WebSandboxFlags and blink::mojom::WebSandboxFlags, in favor of the later. The respective typemap declarations and trait files were also removed. [4] https://crrev.com/c/2050140 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org TBR=reillyg@chromium.org Bug: 1047273 Change-Id: I058db724b309657ca157aca4c05ea069c87912db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054664Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#741434}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/6c109e908aa4..b0a41e52137a $ git log 6c109e908..b0a41e521 --date=short --no-merges --format='%ad %ae %s' 2020-02-13 junyer MSVC also doesn't like casting lambdas with `+'. Sigh. 2020-02-13 junyer Only the latest MSVC allows designated initalisers. 2020-02-13 junyer Provide instrumentation points called "hooks". 2020-02-11 junyer Tidy up some GCC-only guards. 2020-02-04 junyer Tidy up the SWIG guard around LazyRE2. 2020-02-03 junyer Tweak some of the comments about FilteredRE2. 2020-01-31 junyer Avoid using the forward DFA in "ANCHOR_END" cases. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I3cbdc7e574b22907aebd6c31bc7220c7bbb6b8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055505Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741433}
-
Brian White authored
A change to histograms.xml was needed to validate the presubmit so <obsolete> messages had "deprecated" changed to "removed". "Deprecated" means it still exists (but is in disfavor) when in fact the histograms have been completely removed. Removal of an expires_after triggered the presubmit error but the file was otherwise okay. Bug: 1030096 Change-Id: I07422aabc6b1fdcf9e65ce1abc792239c865e64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052623 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#741432}
-
Xida Chen authored
Right now we report throughput to UMA whenever the number of expected frames are >= 100. This CL added a condition to prevent underflow. That is, the frames expected could be decremented to be < 0, but given that the type of frames_expected is uint64_t, we will get a very large number instead of < 0. Bug: 1021963 Change-Id: I2ec718545fa4913e941d2492c622df8144477512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010183Reviewed-by:
-
Peng Huang authored
PageFlipComplete() is not trivial, so call FinishSwapBuffers() before it to kick off next frame in viz thread earlier, and compositor will have more time budget to render the next frame. Bug: None Change-Id: Ie6e0f87d75d81b405447757585ec291887ca0063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057043 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741430}
-
Yuki Shiino authored
Makes union's component "core" if the union is used in "core". Bug: 839389 Change-Id: Ic097aec9eb8c7dd6c176714421f7a61bbe0c7de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056524 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741429}
-
Luca Hunkeler authored
At the moment when the keyoboard is showing tapping the continue button will make autobot proceed to the next step, which is a unintuitive behaviour. With this change we hide all the chip except for cancel when the keyboard is showing. Bug: b/146551893 Change-Id: I36d70f841fd45ea9192cbf4fd0491c6ac8f4d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051927 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#741428}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab2696d1. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/encoding external/wpt/resources rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iefca917a09b26573f1bd81abcbc17d14db70f36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057003Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741427}
-
Ioana Pandele authored
There are 2 pieces of information that are stored: 1. Whether the origin was blacklisted when the cache was populated (upon navigating to the page). 2. Whether the origin is currently blacklisted. The difference between the two is that the user can unblacklist the origin while being on the page. Thus, the first will be used to determine whether a toggle to re-enable saving for the origin should be shown to the user, while the second will be used to determine whether the toggle is on or off and whether Chrome should show the save password infobar. Bug: 1044930 Change-Id: Ic5de843ab843337c52502ec718916d39fd42186f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043841 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15d4c9308d6b..e245d1a20821 git log 15d4c9308d6b..e245d1a20821 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jacktfranklin@chromium.org Include `test/e2e` in ESLint checks. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e245d1a20821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1bd57ed6d148fe1d991612375edccdf7ac9bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056987Reviewed-by:
-
Maks Orlovich authored
This avoids code dupes and properly handles the case where experimental web platform features are turned on but the particular feature is disabled. Change-Id: Ic2d5394d1380d129b04f2c5f0dda059c2570a510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053127Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#741424}
-
Tom Anderson authored
The preference native_notifications.disabled has been renamed to native_notifications.allowed (and is not logically negated) since policies cannot have "Disabled" appearing in their name. This fixes a presubmit check of the form: Error: Boolean policy NativeNotificationsDisabled uses negative polarity, please make new boolean policies follow the XYZEnabled pattern. See also http://crbug.com/85687 The new policy maps to the native_notifications.allowed preference. R=thestig Bug: b/72535204 Change-Id: Ib57a6f5c95e89213f507f496e3ca1904694ad965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055391 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741423}
-
Stephen Nusko authored
We also change to using HeapBuffered to prevent forgetting to finalize the message which caused msan errors. git log f440b92c2422..02808dc0a181 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Add configuration for TrackEvent" 2020-02-12 fmayer@google.com Merge "Roll trace_to_text to pick up aosp/1232924" 2020-02-12 skyostil@google.com Merge "TrackEvent: Implement dynamic categories" Created with: gclient setdep -r src/third_party/perfetto@02808dc0a181 Bug: 1052142 Change-Id: I9c646c586ff6ea86426d88d383219e23f80239eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056725 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741422}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4adc7359f66e..379d0c30470e Created with: gclient setdep -r src-internal@379d0c30470e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I759f90d6b64332ca92c814e83aa3f7908ba48689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741421}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e9b53763fee..eaff904e7260 git log 2e9b53763fee..eaff904e7260 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits) 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits) Created with: gclient setdep -r src/third_party/angle@eaff904e7260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ib140dfa76e2afe8cc26e2a5b7a565805af3706e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056984Reviewed-by:
-
